Changes in style

Changes in style http://nxr.netbsd.org/rss/src/share/misc/style en Copyright 2005 Java fix typo /src/share/misc/style - 1.79 Sat Jan 03 21:42:19 UTC 2026 wiz share/misc/style: Note SET_ERROR(EMUMBLEFROTZ) for errno origination. I expect this to be entirely uncontroversial, but feel free to back this out and suggest it be proposed on tech-kern@ first if you think otherwise. PR kern/58378: Kernel error code origination lacks dtrace probes /src/share/misc/style - 1.78 Sat Jan 03 21:13:07 UTC 2026 riastradh style: One more typo, NFC /src/share/misc/style - 1.77 Mon Jan 29 05:42:41 UTC 2024 rin style: Fix typo, NFC "it it" --> "it is" (across a newline) /src/share/misc/style - 1.76 Wed Jan 24 04:00:43 UTC 2024 rin style(5): Advise against new struct typedefs and explain why. Proposed on tech-kern: https://mail-index.netbsd.org/tech-kern/2023/07/11/msg028950.html Positive feedback to general concept, negative feedback to specifics and phrasing of the first iteration but no objections to latest iteration after several weeks at: https://mail-index.netbsd.org/tech-kern/2023/07/16/msg028994.html /src/share/misc/style - 1.75 Mon Aug 07 18:01:42 UTC 2023 riastradh style: remove mentions of ANSI C The distinction between traditional C and ISO C90 or later is no longer needed in the style guide. Any old-style code is caught by the compilers. https://mail-index.netbsd.org/tech-userlevel/2023/04/15/msg013768.html https://mail-index.netbsd.org/tech-userlevel/2023/04/17/msg013776.html /src/share/misc/style - 1.74 Fri Apr 21 16:12:53 UTC 2023 rillig share/misc/style: Don't prescribe using "extern.h" for all prototypes. That's very 80s. No objection (or even response, amazingly enough) on tech-userlevel in two weeks. /src/share/misc/style - 1.73 Mon Apr 17 00:37:04 UTC 2023 dholland style: fix spelling of plural parentheses /src/share/misc/style - 1.72 Sat Apr 15 00:22:37 UTC 2023 rillig style: don't require sorting variables in functions Sorting the variables by size would be platform-dependent and thus is not possible. Sorting the variables alphabetically may or may not make the code easier to read, and the example given below that rule doesn't follow it, otherwise the correct order would be 'eight, eleven, nine, ten, thirteen, twelve'. https://mail-index.netbsd.org/tech-userlevel/2023/04/11/msg013749.html /src/share/misc/style - 1.71 Fri Apr 14 16:53:13 UTC 2023 rillig style(5): Omit redundant proscription against .c externs in previous. /src/share/misc/style - 1.70 Tue Apr 11 14:22:10 UTC 2023 riastradh style(5): Forbid extern in .c files. Discussed on tech-userlevel (bcc tech-kern): https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html /src/share/misc/style - 1.69 Thu Mar 30 10:39:30 UTC 2023 riastradh exit with EXIT_FAILURE, not 1, as elsewhere /src/share/misc/style - 1.68 Tue Feb 14 18:56:10 UTC 2023 jschauma Move a style recommendation closer to the syntax that it describes. /src/share/misc/style - 1.67 Fri Dec 30 21:12:44 UTC 2022 jkoshy C99: Suggest using narrow scopes for loop indices. /src/share/misc/style - 1.66 Fri Dec 30 17:02:31 UTC 2022 jkoshy Terminate a sentence with a full stop. /src/share/misc/style - 1.65 Thu Dec 29 18:23:37 UTC 2022 jkoshy share/misc/style: lint no longer needs CONSTCOND in do-while-loops Since usr.bin/xlint/lint1/tree.c 1.202 from 2021-01-31, lint recognizes the common idiom 'do { ... } while (0)' and no longer complains about its constant condition; see tests/usr.bin/xlint/lint1/msg_161.c. /src/share/misc/style - 1.64 Thu Mar 10 23:39:12 UTC 2022 rillig share/misc/style: clarify enum example code The only purpose of the enum example is to show that enum constants are written in uppercase. The previous code could be mistakenly interpreted as requiring each definition of an enum type to also define a global variable of that type, and to make the variable name the abbreviated type name. Even if the enum type were prefixed with 'typedef', choosing different names for the tag and the typedef would not be necessary. To avoid these possible misinterpretations above, remove the variable name from the declaration. /src/share/misc/style - 1.63 Thu Mar 10 22:45:23 UTC 2022 rillig Clarify and explain the rationale for parentheses in sizeof and return as discussed. /src/share/misc/style - 1.62 Sun Mar 28 14:28:56 UTC 2021 christos - EXIT_FAILURE instead of 1 - %j instead of PRI for *intmax_t - != -1 instead of < 0 for syscalls /src/share/misc/style - 1.61 Sun Mar 28 14:16:16 UTC 2021 christos style: fix typo /src/share/misc/style - 1.60 Sun Nov 29 09:15:33 UTC 2020 rillig