branches: 1.16.4;
convert HAVE_GCC handling to modern GCC release numbering:
- HAVE_GCC=5 is now the default (vs. HAVE_GCC=53 we've been using for
GCC 5.4 and GCC 5.5.)
- remove some more GCC 4.8 code. we don't support GCC 4 here.
- adjust set lists to gcc=5 from gcc=53.

add some basic HAVE_GCC=6 handling (totally unused so far.)

for GCC 5.3 pass -fwrapv as this relies upon well-defined integer overflow.

reimplement expr using lexical parser generated by yacc
highlights:
* / is treated correctly depending upon context (addresses PR # 10995)
* use 64 bit arithmetic, so expr is able to process integer values from
-(2**63) to (2**63 - 1)
* checks for integer over- & underflows added
* error messages improved, more error checking added

add AUTHOR section to manpage
add BUGS section, and mention possible drawbacks with other expr implementations

XXX the old expr treated empty string in arithmetic expressions as if it was 0
XXX this behaviour has been retained

Remove WARNS=1 from all the subdirectory Makefiles, and add it to Makefile.inc
now that all /bin has been cleaned.

Fix compiler warnings; add WARNS=1

convert to new RCS id conventions.

Re-implemented with a recursive descent parser.
Fixed subtle bug wrt. comparing integers when either one hasn't been
coersed from a string --- while avoiding an even subtler bug found in
GNU expr.

Use new POSIX.2 compatible regex routines in C library instead of -lgnuregex.

Oops. This one does need a single-entry SRCS, because it's generated at
compile time. Lose.

Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Add a manual page.

Use POSIX regular expression routines.
Remove TODO file, as I've allready done everything that there was to do.

changed "Id" to "Header" for rcsids

added rcs ids to all files

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

Clean up deleted files.

initial import of 386bsd-0.1 sources

expr.1: delete misleading example

The result of the example expression would be 0 even if the operator
precedence were inverted.

Fixes PR bin/57670.

expr: improve portability, fix typo

Suggested by Robert Elz.

expr.1: sync with latest changes, improve wording

branches: 1.38.4;
Change back various occurrences of \*[Le], \*[Ge] (less/greater equal)
and \*(ua (upwards arrow) to literal "<=", ">=" and "^" whenever
appropriate (e.g., in code examples).

branches: 1.37.6;
Remove workaround for ancient HTML generation code.

Mark email addresses as mailto links, heads up by Sascha Wildner.
Move email addresses to same line as author name.
Do not split the third author entry on to a new line.
Public domain is not licensed by definition, heads up by Robert Elz.

Instruction to not split the line needs to be stated separately.

Add HISTORY section
Credit author of initial implementation in AUTHORS section
Bump date
Remove contraction highlighted by textproc/igor

Improvements: wording, punctuation, macro usage.

From patch by Bug Hunting.

Remove an unnecessary space in the manpage. Patch provided by Bug Hunting.

branches: 1.31.4;
minor usage nit

Explicitly quote | and : meant as separate operator. Kill trailing
whitespace. Don't use \Z' with obscure character entity. Reorder sections
to canonical order.

Convert TNF licenses to new 2 clause variant

branches: 1.28.24;
Grammar improvement by Patrick Welche.

Add some articles; use No instead of Li in one place
(more correct, see e.g. PostScript output); bump date for previous.

add support for 'length' keyword, for compatibility with GNU expr

Add some articles.

add a note explaining empty string matching via :
this adresses bin/23810 by VaX#n8

bump date and update copyright

spelling errors, some from Igor Sobrado in PR 19670

'NetBSD.org'

New policy: New sentences start on a new line.
Patches by Robert Elz <kre at munnari oz au>, with minimal changes by me.

rewritten in NetBSD 1.6 -> rewritten for NetBSD 1.6

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Use standard headers, sort sections.

Quote `:' correctly.

Fix the operator precedence list to match reality. Operators were incorrectly
grouped there.

list parenthesis usage similar way as other operators
document operator precedence
rename section BUGS to COMPATIBILITY, add paragraph about -- handling

reimplement expr using lexical parser generated by yacc
highlights:
* / is treated correctly depending upon context (addresses PR # 10995)
* use 64 bit arithmetic, so expr is able to process integer values from
-(2**63) to (2**63 - 1)
* checks for integer over- & underflows added
* error messages improved, more error checking added

add AUTHOR section to manpage
add BUGS section, and mention possible drawbacks with other expr implementations

XXX the old expr treated empty string in arithmetic expressions as if it was 0
XXX this behaviour has been retained

For commands and utilities, use EXIT STATUS rather than RETURN VALUES as
appropriate (and documented in mdoc(7)).

Add 'RETURN VALUE' section header.

branches: 1.11.4;
On memory allocation failure, return 3 as per POSIX. (from OpenBSD)

Fix .Nm usage.

Winning Strategies has placed this code into the Public Domain

convert to new RCS id conventions.

Fix spelling error in Copyright notice

Fix spelling errors.

Document the new, less restrictive, behavior of the matching operator.

Document the fact that expr is POSIX.2 compliant.

Document that string comparisons are done using the locale specific
collation sequence.

Makefile

Add a manual page.

reimplement expr using lexical parser generated by yacc
highlights:
* / is treated correctly depending upon context (addresses PR # 10995)
* use 64 bit arithmetic, so expr is able to process integer values from
-(2**63) to (2**63 - 1)
* checks for integer over- & underflows added
* error messages improved, more error checking added

add AUTHOR section to manpage
add BUGS section, and mention possible drawbacks with other expr implementations

XXX the old expr treated empty string in arithmetic expressions as if it was 0
XXX this behaviour has been retained

On memory allocation failure, return 3 as per POSIX. (from OpenBSD)

Since our gcc doesn't warn about NULL format strings anymore, we can
fix the incorrect err(1, "%s", "") et al.
Closes PR bin/7592 by cgd.

branches: 1.10.6;
cast is*() to unsigned char

Be more retentive about use of NOTREACHED and noreturn.

Delint.

Slight code reduction.

__AUDIT__ cleanup.

Fix compiler warnings; add WARNS=1

don't spew an error message if setlocale(LC_ALL, ""); fails. This is for
consistency with other programs, and because currently it can never
actually succeeed if LANG is set to something other than "C". Sent
in by me in PR 2486, approved by jtc).

branches: 1.3.6;
Winning Strategies has placed this code into the Public Domain

convert to new RCS id conventions.

Re-implemented with a recursive descent parser.
Fixed subtle bug wrt. comparing integers when either one hasn't been
coersed from a string --- while avoiding an even subtler bug found in
GNU expr.

expr: use characters instead of bytes for ":" and "length"

Required by POSIX.

expr: sort grammar rules by operator precedence

For easier reading; no functional change intended.

expr: ensure that the result of '|' is never empty

Required by POSIX since at least 2004.

expr: only skip '--' once

expr: clean up

expr: don't evaluate irrelevant conditions

expr: clean up grammar and code

expr: extract expression evaluation functions from the grammar

expr: fix out-of-bounds memory read for empty command line argument

branches: 1.46.8;
Fix typo

branches: 1.45.2;
Add a missing check to handle correctly 0 * 0 in expr(1)

Improve the * operator handling in expr(1)

Fixes overflow detection in expressions INT * -UINT.

Detected with libFuzzer & UBSan.

remove notreached

return to caller instead of exit(2)

Detect properly overflow in expr(1) for 0 + INT

Rework perform_arith_op() in expr(1) to omit Undefined Behavior

The current implementation of operations - + * / % could cause Undefined
Behavior and in narrow cases (INT64_MIN / -1 and INT64_MIN % -1) SIGFPE
and crash duping core.

Detected with MKSANITIZER enabled for the Undefined Behavior variation:
# eval expr '4611686018427387904 + 4611686018427387904'
/public/src.git/bin/expr/expr.y:315:12: runtime error: signed integer overflow: 4611686018427387904 + 4611686018427387904 cannot be represented in type 'long'

All bin/t_expr ATF tests pass now in a sanitized userland.

Sponsored by <The NetBSD Foundation>

branches: 1.39.12;
Drop main() prototype.

Add __printflike attribution to use vprintf and friends with an argument
as format string.

branches: 1.37.2;
Mark yyerror as dead.

Revert for now, pending discussion of how expr should behave in the case
of pre-POSIX expressions.

SUS says that expr must support "--" to prevent interpretation of
negative numbers as options.

Normalize TNF license, move to 2 clause.

branches: 1.33.18;
Handle asprintf failing to allocate.

appease gcc -Wuninitialized

add support for 'length' keyword, for compatibility with GNU expr

explicitly use REG_BASIC when calling regcomp(3), instead of 0

'NetBSD.org'

Use {g,s}etprogname, and some other KNF stuff. Patch by Petri Koistinen.

Various cleanups/fixes.
Change the add/subtract overflow checks to use an unsigned to do the op
and then cast back into the signed var to check the signs.

Make multiply shortcut on either right or left being 0.
Make multiply's overflow test not fail on simple cases like 1 * -1
Make the multiple overflow test pass all the regress tests.

Various changes to fix bugs in PR bin/12838.

Make sure all precendence is spelled out correctly (comparison does not
have the same level as the arithmetic operators..)
Break the arithemtic operators into 2 classes (+- are lower than */%)
Restructure the arithmetic code into a function either class above can call.
Finally, add a whole suite of regression tests (checked in separately) which
the previous code failed on 3 of them.

Spell occurred correctly.

remove redundant declaration of yyparse

add a hack to properly handle '--' as first argument -
it's ignored if it would cause syntax error, otherwise treated as common
string; this is so that both 'expr -- : .' and 'expr -- foo : .' works
This addresses standards/11230 by Ben Harris.

while here, make all global variables but main() static, use const more

The "&" operator has a higer precedence than "|".

also credit J.T. Conklin in copyright message

fix operator precedence - | or & have lower priority than
arithmetic operations, compare, or :
This should fix bin/11318 by Love <lha@stacken.kth.se>

in regexp handling code, fix the format passed to asprintf() to be
actually in intended form - use "%.*s" and not incorrect "%*s"

Bug found by Launey Thomas <ljt@alum.mit.edu> and reported in private e-mail.

Fix bug in regexp handling, caused not quite complete conversion
from old expr.c. This fixes PR # 11060.

While here, convert the code to use asprintf() instead of strdup()
followed by truncating of new string and move definition of errstr
to block where it's used.

reimplement expr using lexical parser generated by yacc
highlights:
* / is treated correctly depending upon context (addresses PR # 10995)
* use 64 bit arithmetic, so expr is able to process integer values from
-(2**63) to (2**63 - 1)
* checks for integer over- & underflows added
* error messages improved, more error checking added

add AUTHOR section to manpage
add BUGS section, and mention possible drawbacks with other expr implementations

XXX the old expr treated empty string in arithmetic expressions as if it was 0
XXX this behaviour has been retained

Clean up deleted files.

don't forget a cast, and thereby fix the regexp problems on big-endian machines

branches: 1.14.2;
Fix insignificant memory leak.

Allow expressions like "expr 'ABC' : '^.*$' to work as is done in other
expr implementations.

Fix grammar to eliminate support for unary minus expressions -- they
weren't supported, they aren't standard, and they caused expr to dump
core.

Use err() routine for error messages.
If string does not match \( \) subexpression, return a null string.

expr is supposed to do string comparisons using the locale specific
collation sequence, so use strcoll instead of strcmp.

Now truely POSIX 1003.2 (D11.2) compliant.

Don't coerce strings to int in comparisons.

integer arguments were not coerced to strings for the `:' operator.
bad things: core dumps, etc. will happen if integer values make it
up the parse tree.

Updated to POSIX regular expression routines.
(Previous checkin was aborted by stray ^C)

update for latest version of patches from jtconklin@kaleida.com

added J.T. Conklin's changes to get parens working fine, etc.

changed "Id" to "Header" for rcsids

added rcs ids to all files

branches: 1.1.1;
Initial revision