PR lib/58461 PR lib/58453 portability fixes

Revert previous (1.4) and make the changes properly.

If base is invalid, what gets left in *endptr by strtoimax()
is unspecified (it is not guaranteed to be either nptr or unaltered)
and so cannot (in that case) be used in any way at all.

Since it is hard to determine from some implementations of
strtoimax() whether this happened or not, simply duplicate
the validity test for base here, so we know that error (EINVAL
because base is invalid) cannot occur from strtoimax(). In that
case, if we get an EINVAL from strtoimax we can simply ignore it,
as all it can mean is the (optional in POSIX) case where no
conversion occurred (where strtoi() sets the status to ECANCELED).

Since NetBSD never did that, this all changes nothing here, but
makes strtoi() portable to other environments using a different
version of strtoimax().

NFCI.

No pullups required, nothing has really changed, there never was
a NetBSD bug to fix.

POSIX allows systems that report EINVAL when no digits are found. On
such systems the only way to differentiate EINVAL and ECANCELED is to
initialized the end pointer to NULL before the call. On EINVAL cases,
strto*max(3) will leave the pointer unmodified, so we'll read back the
original NULL. On ECANCELED cases, strto*max(3) will set it to nptr.
This also prevents UB read of endptr on an unsupported base argument.
(Alejandro Colomar)

branches: 1.3.2;
PR/57828: Alejandro Colomar: Prioritize test for ERANGE before testing for
fully consuming the string. Adjust strtonum(3) to behave as before. Document
the order of the tests and sync the man pages (I should really autogenerate
one of the two man pages...)

branches: 1.2.2; 1.2.18; 1.2.20; 1.2.32;
match variable names with man page (Kamil Rytarowski)

add strto{i,u} from Kamil Rytarowski as discussed in tech-userlevel.

branches: 1.11.6;
Fix ISO C compliance: strtol of "0xX" should give the largest valid
numeric prefix, which is 0.

branches: 1.10.8;
comment out 0{b,B} handling.

Fix capitalization

Recognize 0[bB] as binary (base 2)

branches: 1.7.6;
Provide explicit LC_C_LOCALE accessor and drop the various NULL checks.
Provide LC_GLOBAL_LOCALE in a way that works with all locale functions.
Merge constant data used by the initial global locale and the C locale.
Drop function call layer for _current_locale() and directly return the
locale reference, not a pointer to it. Use protected access for global
variables, so that libc references can avoid the GOT overhead.

Restore standalone strtol/strtoul for citrus for now.

Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
strtol_l unless in tools mode. Add note to retire the BCS code on the
next libc major bump.

Do not use isalpha here, since we explicitly only support the Portable
Character Set as base and in theory a locale could define a ASCII
control character as letter, resulting in negations. Also avoid isdigit
here to give the compiler a better chance of deciding whether an
unsigned compare or a jump table is a better option, both are very
likely better choices than the memory indirection.

branches: 1.3.2;
Casts and type changes to fix portability issues.
- int -> size_t
- adjust width of RHS of shift
- adjust widths of types

branches: 1.2.6; 1.2.8;
Set endptr if the base is not supported. The opengroup spec does not special
case this condition. Note: glibc has the same problem.

branches: 1.1.2; 1.1.8;
Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

branches: 1.11.6;
Fix ISO C compliance: strtol of "0xX" should give the largest valid
numeric prefix, which is 0.

branches: 1.10.6;
Set *endptr in all paths out of strtoul and family.

XXX pullup-6
XXX pullup-7

branches: 1.9.2;
comment out 0{b,B} handling.

Recognize 0[bB] as binary (base 2)

branches: 1.7.6; 1.7.8; 1.7.10;
Provide explicit LC_C_LOCALE accessor and drop the various NULL checks.
Provide LC_GLOBAL_LOCALE in a way that works with all locale functions.
Merge constant data used by the initial global locale and the C locale.
Drop function call layer for _current_locale() and directly return the
locale reference, not a pointer to it. Use protected access for global
variables, so that libc references can avoid the GOT overhead.

Restore standalone strtol/strtoul for citrus for now.

Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
strtol_l unless in tools mode. Add note to retire the BCS code on the
next libc major bump.

Do not use isalpha here, since we explicitly only support the Portable
Character Set as base and in theory a locale could define a ASCII
control character as letter, resulting in negations. Also avoid isdigit
here to give the compiler a better chance of deciding whether an
unsigned compare or a jump table is a better option, both are very
likely better choices than the memory indirection.

branches: 1.3.2;
bring the casts to the operands, not the operation results.

Casts and type changes to fix portability issues.
- int -> size_t
- adjust width of RHS of shift
- adjust widths of types

branches: 1.1.2; 1.1.4; 1.1.22; 1.1.26; 1.1.30;
Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

getopt(): Make this built for _KERNEL || _STANDALONE

NFC as a libc routine.

getopt.c: Migrate from lib/libc/stdlib to common/lib/libc/stdlib

libc: New _r variants of heapsort, mergesort, qsort.

Also kheapsort_r for kernel/standalone use.

These variants allow the caller to pass a cookie through to the
comparison function, e.g. if you want to sort an array of indices
into a buffer.

qsort_r is new in POSIX.1-2024; the others are obvious analogues of
our nonstandard extensions for heapsort and mergesort.

PR lib/58931: qsort_r() missing

branches: 1.3.50; 1.3.70;
oops, converted some #ifndef into #if defined...

Convert all #ifdef _KERNEL to #if defined (_KERNEL) || defined(_STANDALONE)
from Bernd Ernesti on source-changes@. This fixes a build breakage
with i386/amd64 bootblocks.

Our qsort() is inappropriate for kernel use because it makes recursive
calls. Replace it with a kheapsort() function in kernel. Pointed out
by tron@.

branches: 1.1.4; 1.1.8; 1.1.30;
Allow kernel code to access constant databases by moving cdbr(3) and the
required mi_vector_hash(3) into src/common.

Our qsort() is inappropriate for kernel use because it makes recursive
calls. Replace it with a kheapsort() function in kernel. Pointed out
by tron@.

Make qsort() available in libkern.

fix various typos in comments.

common/lib/libc/stdlib: Fix possible signed integer overflow.

common/lib/libc/stdlib/random.c:482:6 can result in signed integer overflow.

This bug was reported by UBSan runs.

The change has been tested using the following program to generate random numbers
in both the old and the new library and can be used to verify the correctness of the
library after the change.

#include <stdio.h>
#include <stdlib.h>

#define COUNT 1000 * 1000

int
main(void)
{
int i;
FILE *fp = fopen("numbers.txt", "w");

srandom(0xdeadbeef);

for(i = 0; i < COUNT; i++) {
fprintf(fp, "%ld\n", random());
}

fclose(fp);

return 0;
}

Reviewed by: riastradh@ , kamil@

branches: 1.5.16; 1.5.20;
whitespace

update for the new function signatures of initstate/srandom

branches: 1.3.56; 1.3.70;
Add the old small random from the libkern and use it for now.

Make this compile for the kernel again.

Merge libkern + libc common files. As requested by core.

Make it easier to use strtoi and strtou in downsteam applications
without the need to define HAVE_NBTOOL_CONFIG_H and yet allow -Wundef
not to log any warnings.

branches: 1.2.16;
- new test for strtoi
- namespace protection for strto{i,u}
- separate manpages for strto{i,u} from the ones for strto{u,}l
From: Kamil Rytarowski

branches: 1.1.2;
add strto{i,u} from Kamil Rytarowski as discussed in tech-userlevel.

branches: 1.2.4; 1.2.8; 1.2.30;
Fix aliases.

changed lua_Number to int64_t

branches: 1.7.30;
Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
strtol_l unless in tools mode. Add note to retire the BCS code on the
next libc major bump.

branches: 1.6.2; 1.6.24;
Properly deal with LIBC namespace issues.

Unbork cross-builds in tools/compat/

Fix build breakage by adding appropriate #includes.
Patch from joerg@

Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

branches: 1.2.18;
remove bogus (void)&var; from Anon Ymous

branches: 1.1.2;
- Move strtoll.c and strtoull.c from libc/stdlib to common/libc/stdlib.
- Add strtoll.c and strtoull.c to libkern.

Make it easier to use strtoi and strtou in downsteam applications
without the need to define HAVE_NBTOOL_CONFIG_H and yet allow -Wundef
not to log any warnings.

branches: 1.2.16;
- new test for strtoi
- namespace protection for strto{i,u}
- separate manpages for strto{i,u} from the ones for strto{u,}l
From: Kamil Rytarowski

branches: 1.1.2;
add strto{i,u} from Kamil Rytarowski as discussed in tech-userlevel.

branches: 1.3.62;
Fix build breakage by adding appropriate #includes.
Patch from joerg@

Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

branches: 1.1.28;
Merge libkern + libc common files. As requested by core.

branches: 1.6.30;
Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
strtol_l unless in tools mode. Add note to retire the BCS code on the
next libc major bump.

branches: 1.5.2; 1.5.24;
Prepare use of strtoull, strtoumax and strtoimax in tools/compat by
including nbtool_config.h.

Properly deal with LIBC namespace issues.

Fix build breakage by adding appropriate #includes.
Patch from joerg@

Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

branches: 1.1.2; 1.1.26;
- Move strtoll.c and strtoull.c from libc/stdlib to common/libc/stdlib.
- Add strtoll.c and strtoull.c to libkern.

branches: 1.6.30;
Add strtol_l and friends. Switch _citrus_bcs_strtol to use plain
strtol_l unless in tools mode. Add note to retire the BCS code on the
next libc major bump.

branches: 1.5.2; 1.5.24;
Prepare use of strtoull, strtoumax and strtoimax in tools/compat by
including nbtool_config.h.

Properly deal with LIBC namespace issues.

Fix build breakage by adding appropriate #includes.
Patch from joerg@

Unify the implementation of strto{l,ul,ll,ull,imax,umax,q,uq} into one
version for signed and one version for unsigned data types.

Add a check for supported bases and set errno (userland) or panic
(kernel, libsa) otherwise.

Make strto{ll,ull,imax,umax} normal symbols and just keep the underscore
versions as strong alias.

Obtained from DragonFly, based on the wide char version from Citrus.
Reviewed by christos@

branches: 1.1.28;
Move strtoumax.c from libc/stdlib to common/libc/stdlib and include it
in libkern. Required for new code coming soon.