Workaround a toolchain issue by renaming the 'setup' host tool to 'mkdata' to make UAC happy when building with Cygwin. As described here -- http://msdn.microsoft.com/en-us/library/windows/desktop/bb756960.aspx -- 32-bit executables whose filenames include the strings 'install', 'setup', 'update', 'patch', etc. by default will request admin privileges unless an application manifest is provided.

branches: 1.13.54; 1.13.60;
Improve how various "simple" host tools are built and invoked.

Rework how MAKEVERBOSE operates:

* Don't bother prefixing commands with a line of ${_MKCMD}\
and instead rely upon "make -s". This is less intrusive on
all the Makefiles than the former. Idea from David Laight.

* Rename the variables use to print messages. The scheme now is:
_MKMSG_FOO Run _MKMSG 'foo'
_MKTARGET_FOO Run _MKMSG_FOO ${.TARGET}
From discussion with Alistair Crooks.

rework to use the newer _MKMSGCREATE (et al) macros

Support MAKEVERBOSE. (Some host tools still generate verbose runtime messages)

No need to reference .OBJDIR here.

HOST_CC -> HOST_LINK.c

Find setup-program even w/ obj dirs.

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

Allow this to be cross-compiled.

clean up RCS ids

specify man pages the new way.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

deprecate register, fixup .Nm usage

clean up RCS ids

branches: 1.1.1;
Initial revision

Oops, I forgot to actually implement the checksumming code for the new
savefile format, so any savefiles generated yesterday can be tampered
with. Oh well. While here, tidy up the crc code.

Make this not crash on machines that are (a) 64 bit, or (b) have signed
chars by default (i.e., almost all machines). Makes it possible to save
the game. This has been broken since 4.4 and probably ever since the
FORTRAN -> C translation.

Crash reported by Petri Laakso in private mail.

branches: 1.11.6;
ANSIfy a leftover function.
Also note some unportable code with a comment. Can't change it because
it'd break save files, though.

sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

The patch below does some minor cleanup of adventure(6): an additional
use of const I missed in bin/6041; avoiding a signed/unsigned warning;
marking an unused parameter as such; revoking setgid privileges
(including the saved gid) rather than setuid ones; includes and
function prototypes in setup.c; the string passed to err() should not
end with a `.'. Together with the patch sent concerning adventure's
EOF handling, this synchronises adventure(6) in NetBSD with the Linux
port of the NetBSD games.

Via PR 6557 by Joseph Myers <jsm28@cam.ac.uk>

constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

More include additions for exit, abs, strcmp, etc.

remove unused function return values (PR#6079 by Joseph Myers <jsm28@cam.ac.uk>)

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

grumble.

Oops, I forgot to actually implement the checksumming code for the new
savefile format, so any savefiles generated yesterday can be tampered
with. Oh well. While here, tidy up the crc code.

branches: 1.14.6;
Remove 3rd and 4th clauses in christos' license. OK christos.

Use __dead.

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

Remove uses of __P.

remove unused function return values (PR#6079 by Joseph Myers <jsm28@cam.ac.uk>)

constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>

remove main() prototype, as per PR 6867

Remove unused function and unnecessary prototypes, as per PR 6050 by
Joseph Myers <jsm28@cam.ac.uk>

Replace some homegrown string-functions with standard-<string.h>-macros.
Reported by Joseph Myers <jsm28@cam.ac.uk> in PR 6028.

Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.

KNFify again

KNFify

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

Fix capitalisation of compass directions.

branches: 1.1.1;
Initial revision

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

eliminate redundant decls

This patch fixes adventure(6) to use `extern' on declarations of
objects in its header file, and to add corresponding definitions to
init.c accordingly. (See the C standard - relying on linker commons
where there are multiple uninitialised declarations of an object in
the program traditionally works on Unix, but is not standard C.)

The patch also removes a bit-rotten code fragment under #ifdef
OLDSTUFF.

Patch submitted in PR 8105 by Joseph Myers <jsm28@cam.ac.uk>

This patch cleans up the handling of the variable `saved' in
adventure(6). The handling of this variable is somewhat confusing,
since it is used for two different purposes (controlling the time
required before a saved game can be restored, and controlling various
aspects of dwarf behaviour); in fact, it is also declared twice in
hdr.h. Except possibly when saving a game fails, these uses can never
interfere; when used for controlling dwarf behaviour, we always have
saved == -1. This can be better understood with reference to the
original PDP-10 FORTRAN source (URL in patch, since hdr.h references
the comments of the FORTRAN as still relevant to this version) of
which the C version is a direct translation: the wrong value for
`saved' meant that someone was cheating and had bypassed normal
initialisation. Saving was done by halting and telling the user to
save their core image, so the question of carrying on after saving
failed to open the output file did not arise.

This patch separates the uses of `saved' into uses of two separate
variables.

Closes PR 8005 by Joseph Myers <jsm28@cam.ac.uk>

The game adventure(6) handles EOF on standard input rather
ungracefully. The patch, derived from OpenBSD, improves this
handling.

Sent in in PR 6556 by Joseph Myers <jsm28@cam.ac.uk>.

Improved signal handling as per PR 6051 by
Joseph Myers <jsm@octomino.demon.co.uk>

KNFify

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

tag decl() __noinline, as inlining it would defeat its purpose
(which is to not have interesting string literals appear in the
compiled binary)

branches: 1.20.2; 1.20.8;
NULL does not need a cast

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

convert __attribute__s to applicable cdefs.h macros

branches: 1.16.10;
don't access out of bounds element of static alloc array.
found by Coverity, CID 1519 / Run 5

XXX possible that intention was to start with i = 0.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

eliminate redundant decls

This patch fixes adventure(6) to use `extern' on declarations of
objects in its header file, and to add corresponding definitions to
init.c accordingly. (See the C standard - relying on linker commons
where there are multiple uninitialised declarations of an object in
the program traditionally works on Unix, but is not standard C.)

The patch also removes a bit-rotten code fragment under #ifdef
OLDSTUFF.

Patch submitted in PR 8105 by Joseph Myers <jsm28@cam.ac.uk>

Add __attribute__() to a variable. From PR 6557, after discussion with
Joseph S. Myers <jsm28@cam.ac.uk>

Improved signal handling as per PR 6051 by
Joseph Myers <jsm@octomino.demon.co.uk>

Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.

change includes to fix compiler warning

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

oops, use <signal.h> not <sys/signal.h> (tholo@sigmasoft.com)

give up setuid-ness. we don't need it. while i'm here, include
<sys/signal.h> and use SIGINT rather than 2.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

don't try to switch a char and have a case of EOF - use an int.

Coverity CID 2737: Handle linked-lists properly. Use calloc instead of malloc
so that we don't end up storing garbage accidentally and the next pointer is
initialized. If there is an inconsistency in the file abort instead
of dereferencing NULL.

Coverity CID 1195: Check for possible negative index.

Coverity CID 777: Fix NULL pointer deref and de-obfuscate code.

KNF and WARNS=3

off-by-one. aaron@openbsd

off-by-one. aaron@openbsd

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Use err(1, NULL) and warn(NULL) for `out of memory' error messages.

The game adventure(6) handles EOF on standard input rather
ungracefully. The patch, derived from OpenBSD, improves this
handling.

Sent in in PR 6556 by Joseph Myers <jsm28@cam.ac.uk>.

return error on errors (PR#6147 by Joseph Myers <jsm28@cam.ac.uk>)

check for malloc failures (PR#6136 by Joseph Myers <jsm28@cam.ac.uk>)

constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>

Remove unused function and unnecessary prototypes, as per PR 6050 by
Joseph Myers <jsm28@cam.ac.uk>

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.19.20;
KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

More include additions for exit, abs, strcmp, etc.

Use setgid(), not setregid().

This patch cleans up the handling of the variable `saved' in
adventure(6). The handling of this variable is somewhat confusing,
since it is used for two different purposes (controlling the time
required before a saved game can be restored, and controlling various
aspects of dwarf behaviour); in fact, it is also declared twice in
hdr.h. Except possibly when saving a game fails, these uses can never
interfere; when used for controlling dwarf behaviour, we always have
saved == -1. This can be better understood with reference to the
original PDP-10 FORTRAN source (URL in patch, since hdr.h references
the comments of the FORTRAN as still relevant to this version) of
which the C version is a direct translation: the wrong value for
`saved' meant that someone was cheating and had bypassed normal
initialisation. Saving was done by halting and telling the user to
save their core image, so the question of carrying on after saving
failed to open the output file did not arise.

This patch separates the uses of `saved' into uses of two separate
variables.

Closes PR 8005 by Joseph Myers <jsm28@cam.ac.uk>

The patch below does some minor cleanup of adventure(6): an additional
use of const I missed in bin/6041; avoiding a signed/unsigned warning;
marking an unused parameter as such; revoking setgid privileges
(including the saved gid) rather than setuid ones; includes and
function prototypes in setup.c; the string passed to err() should not
end with a `.'. Together with the patch sent concerning adventure's
EOF handling, this synchronises adventure(6) in NetBSD with the Linux
port of the NetBSD games.

Via PR 6557 by Joseph Myers <jsm28@cam.ac.uk>

return error on errors (PR#6147 by Joseph Myers <jsm28@cam.ac.uk>)

remove unused function return values (PR#6079 by Joseph Myers <jsm28@cam.ac.uk>)

add main() prototype

Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

oops, use <signal.h> not <sys/signal.h> (tholo@sigmasoft.com)

give up setuid-ness. we don't need it. while i'm here, include
<sys/signal.h> and use SIGINT rather than 2.

Removed "extern int errno"; Added #include <errno.h> if not already present.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: Do not assume <sys/endian.h> is transcluded from <sys/types.h>

prompted by PR pkg/59839

avoid leaving off the trailing nul in a literal string.

Minor tidyup.

branches: 1.13.6;
Oops, I forgot to actually implement the checksumming code for the new
savefile format, so any savefiles generated yesterday can be tampered
with. Oh well. While here, tidy up the crc code.

Redo save file handling. The old save files were unportable, had no
magic number or versioning, relied on random(3) never changing to a
different implementation, and were also saving pointers to disk and
reading them back again. It *looks* as if the pointers thus loaded
were reset before being used, but it's not particularly clear as the
main loop of this thing is goto-based FORTRAN translated lightly to C.
I've changed the logic to null these pointers instead of saving and
loading them, and things seem to still work.

The new save files have a header, support versioning, write only sized
types in network byte order, and for the toy encryption to discourage
cheating do something self-contained instead of using random(3) as a
stream cipher.

Because between the original import from 4.4 until earlier today
trying to save would result in SIGSEGV on most platforms, it's
unlikely anyone has a save file, but just in case (since the pointer
issue appears to be nonlethal) I've kept compat code for old save
files.

branches: 1.11.6;
Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Adventure(6) should check for errors (e.g. disk full or quota
exceeded) when writing out saved games. Do so!

Patch supplied by Joseph Myers <jsm28@cam.ac.uk> in PR 8016

This patch cleans up the handling of the variable `saved' in
adventure(6). The handling of this variable is somewhat confusing,
since it is used for two different purposes (controlling the time
required before a saved game can be restored, and controlling various
aspects of dwarf behaviour); in fact, it is also declared twice in
hdr.h. Except possibly when saving a game fails, these uses can never
interfere; when used for controlling dwarf behaviour, we always have
saved == -1. This can be better understood with reference to the
original PDP-10 FORTRAN source (URL in patch, since hdr.h references
the comments of the FORTRAN as still relevant to this version) of
which the C version is a direct translation: the wrong value for
`saved' meant that someone was cheating and had bypassed normal
initialisation. Saving was done by halting and telling the user to
save their core image, so the question of carrying on after saving
failed to open the output file did not arise.

This patch separates the uses of `saved' into uses of two separate
variables.

Closes PR 8005 by Joseph Myers <jsm28@cam.ac.uk>

constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>

KNFify

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Ensure trailing newline is present on error and warning messages (lost
in previous conversion from <err.h> functions to ISO C ones).

Don't use <sys/cdefs.h> __COPYRIGHT/__RCSID macros or <err.h> err/errx
functions for host programs - use portable ANSI constructs instead.

Patches from Chris Demetriou.

From PR 7985 by Joseph Myers <jsm28@cam.ac.uk>:

games/adventure/setup.c fails to check for errors when writing its
output. This means that, if the disk fills up at this point during a
build, it would nevertheless fail to return an error status.

The patch below does some minor cleanup of adventure(6): an additional
use of const I missed in bin/6041; avoiding a signed/unsigned warning;
marking an unused parameter as such; revoking setgid privileges
(including the saved gid) rather than setuid ones; includes and
function prototypes in setup.c; the string passed to err() should not
end with a `.'. Together with the patch sent concerning adventure's
EOF handling, this synchronises adventure(6) in NetBSD with the Linux
port of the NetBSD games.

Via PR 6557 by Joseph Myers <jsm28@cam.ac.uk>

some cleanups as per PR#6082 by Joseph Myers <jsm28@cam.ac.uk>

KNFify again

KNFify

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

More include additions for exit, abs, strcmp, etc.

return error on errors (PR#6147 by Joseph Myers <jsm28@cam.ac.uk>)

remove unused function return values (PR#6079 by Joseph Myers <jsm28@cam.ac.uk>)

Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

Coverity CID 570: Remove impossible check.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Use err(1, NULL) and warn(NULL) for `out of memory' error messages.

return error on errors (PR#6147 by Joseph Myers <jsm28@cam.ac.uk>)

check for malloc failures (PR#6136 by Joseph Myers <jsm28@cam.ac.uk>)

constify, per PR 6041 by Joseph Myers <jsm28@cam.ac.uk>

Replace some homegrown string-functions with standard-<string.h>-macros.
Reported by Joseph Myers <jsm28@cam.ac.uk> in PR 6028.

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

clean up RCS ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

fix previous, thanks asau@

Pass -Wstrict-overflow.

branches: 1.14.6; 1.14.12;
Whn ths cd ws wrttn, thr ws bt shrtg nd vwls wr xtrml xpnsv. Nowadays,
however, we have an ample vowel budget, and bit shortages are a thing
of the past (even in a down economy) so spend a bit to improve
readability.

sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

This patch cleans up the handling of the variable `saved' in
adventure(6). The handling of this variable is somewhat confusing,
since it is used for two different purposes (controlling the time
required before a saved game can be restored, and controlling various
aspects of dwarf behaviour); in fact, it is also declared twice in
hdr.h. Except possibly when saving a game fails, these uses can never
interfere; when used for controlling dwarf behaviour, we always have
saved == -1. This can be better understood with reference to the
original PDP-10 FORTRAN source (URL in patch, since hdr.h references
the comments of the FORTRAN as still relevant to this version) of
which the C version is a direct translation: the wrong value for
`saved' meant that someone was cheating and had bypassed normal
initialisation. Saving was done by halting and telling the user to
save their core image, so the question of carrying on after saving
failed to open the output file did not arise.

This patch separates the uses of `saved' into uses of two separate
variables.

Closes PR 8005 by Joseph Myers <jsm28@cam.ac.uk>

The game adventure(6) handles EOF on standard input rather
ungracefully. The patch, derived from OpenBSD, improves this
handling.

Sent in in PR 6556 by Joseph Myers <jsm28@cam.ac.uk>.

Kill unused parameters, per PR 6023 by Joseph Myers <jsm28@cam.ac.uk>.

Consider leap years, as per PR 5830 by Joseph Myers <jsm28@cam.ac.uk>

KNFify

deprecate register, fixup .Nm usage

PR/3964: Eric Fischer: Remove dependencies to traditional cpp...
While I was there add WARNS?= too.

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up RCS ids

branches: 1.1.1;
Initial revision