Gcc-8 bug confusion with restrict on sh3

branches: 1.10.46;
When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Simply include -lcurses instead of -lcurses -ltermcap

Use -ltermcap instead of -ltermlib

install games that need it setgid.

branches: 1.5.4;
clean up import

specify man pages the new way.

Add RCS identifiers.

got rid of unnecessary -lcompat and associated dependency

branches: 1.1.1;
Initial revision

Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Grammar fixes, from jmc@openbsd.

Lots of minor fixes resulting from reading these man pages in detail.

New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace and/or punctuation fixes.

Manpage improvements based on OpenBSD.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

Fix typo, closes pr 6137 by Joseph Myers.

WARNSify

clean up import

update to -mandoc macros

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.15.20;
KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Make code clearer; add a macro ROOMDESC for the number of times a room
should be visited for the short description only to be used, and don't
increment beenthere[position] beyond this value. From OpenBSD.

Use setgid(), not setregid().

Give sensible error message in a shouldn't happen case.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

Drop setgid privileges early. Derived from OpenBSD and sent in as PR 5970
by Joseph Myers <jsm28@cam.ac.uk>.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Prevent CUMBER from going negative; avoid division by zero if it is
zero.

Clean up formatting; partly from OpenBSD.

Spelling and punctuation corrections or improvements from OpenBSD.

Rename move() to moveplayer() to avoid clashing with libcurses.

branches: 1.9.8;
Fix -Wsign-compare warnings.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

don't deref -1.

In cypher(), don't attempt to make sense of words other than VERBs or
KNIFE when a verb is required. Add AUXVERB for "make", "move",
"climb" (as in "make love", "climb up") and ignore AUXVERB as a verb,
going on to the next word, instead of treating these words as
adjectives. When creating new verbs from "put on", "put down", "take
off", mark them as type VERB. Mostly from Paul Janzen
<pjanzen@foatdi.harvard.edu>.

Add OBJ_AN flag to objflags so as to use "a" or "an" appropriately in
messages; avoids "a amulet", "a Elf". Define and use macros to use
"a", "an", "the", "is", "are" appropriately. Partly based on OpenBSD.

Fix logic error in use of n and wordnumber in murder() when using
laser. From OpenBSD.

Add explicit no-ops to empty loops following the NetBSD style guide.

Correct spelling "dont" to "don't". From OpenBSD.

Allow for the bathing goddess in ravage(). From OpenBSD.

Use a lookup table to identify whether objects are plural or singular,
instead of testing the final character against 's' in each place.
Avoids oddities about "pot of jewels" and "compass".

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Give an appropriate error on "kill all" rather than a crash or
nonsense message. From OpenBSD.

Don't try to wear anything that isn't OBJECT or NOUNS. Don't try to
wear DOOR or anything without a short description. Fixes crashes on
"wear knfo" (bug reported by Peter Maydell
<pmaydell@chiark.greenend.org.uk>), "wear wear", "wear kick", "wear
door" and "wear goddess". Partly from OpenBSD.

If no hand-to-hand weapons are available, try using the laser to kill
in murder(). From OpenBSD.

Clean up formatting; partly from OpenBSD.

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Propperly note place-change, as reported in PR 6008 by Joseph Samuel Myers
<jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Use defined constant FINAL instead of hardcoded 275. From OpenBSD.

Add explicit no-ops to empty loops following the NetBSD style guide.

Correct spelling "dont" to "don't". From OpenBSD.

Use a lookup table to identify whether objects are plural or singular,
instead of testing the final character against 's' in each place.
Avoids oddities about "pot of jewels" and "compass".

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Initialize return-value correctly as pointed out in PR 6007 by
Joseph Myers <jsm@octomino.demon.co.uk>.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

In cypher(), don't attempt to make sense of words other than VERBs or
KNIFE when a verb is required. Add AUXVERB for "make", "move",
"climb" (as in "make love", "climb up") and ignore AUXVERB as a verb,
going on to the next word, instead of treating these words as
adjectives. When creating new verbs from "put on", "put down", "take
off", mark them as type VERB. Mostly from Paul Janzen
<pjanzen@foatdi.harvard.edu>.

Add OBJ_AN flag to objflags so as to use "a" or "an" appropriately in
messages; avoids "a amulet", "a Elf". Define and use macros to use
"a", "an", "the", "is", "are" appropriately. Partly based on OpenBSD.

Correct spelling "dont" to "don't". From OpenBSD.

Give a better message for trying to eat things it doesn't make sense
to eat. For something eatable, check first whether you're holding it,
then whether you have a knife, then whether you're stuffed (gives
better message for "eat coconuts" when you don't have any). From
OpenBSD.

Attempt to disambiguate BODY for kicking. Avoid crashing or nonsense
messages on "kick door" and "kick man". From OpenBSD.

Use a lookup table to identify whether objects are plural or singular,
instead of testing the final character against 's' in each place.
Avoids oddities about "pot of jewels" and "compass".

Don't say "Kicked." of an object not present; give sensible messages.
From OpenBSD.

Check for an object being taken not being there before checking for
whether it is too heavy or too bulky; gives a better message for "take
viper" with the viper not present.

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Clean up formatting; partly from OpenBSD.

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Fix -Wsign-compare warnings.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Fix loving already loved goddess; avoid fallthrough after loving
goddess; give error on "love amulet". From OpenBSD.

Add explicit no-ops to empty loops following the NetBSD style guide.

Allow for bathing goddess in love(); give better message for a lover
that isn't present and for certain choices of lover. From OpenBSD.

From OpenBSD: in kiss(), "take" the bathing goddess if required, and
give a better error message if the person to kiss is not present.

Clean up formatting; partly from OpenBSD.

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Spelling and punctuation corrections or improvements from OpenBSD.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Add braces to make the new egcs happy.

DTRT if "give" is invoked without arguments. Fix contributed by Joseph S.
Myers <jsm28@cam.ac.uk>, closeds PR 6049.

Don't allow empty "give" command (without arguments).
Fixes PR 6049 by Joseph Myers <jsm@octomino.demon.co.uk>.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Add explicit no-ops to empty loops following the NetBSD style guide.

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Clean up formatting; partly from OpenBSD.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Use time() instead of gettimeofday().

Fix uses of names of library functions for other purposes.

A couple more checks for file descriptor < 3 missed earlier.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

Drop setgid privileges early. Derived from OpenBSD and sent in as PR 5970
by Joseph Myers <jsm28@cam.ac.uk>.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

time_t != long; fix minor type problem.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

Use POSIX signal and tty semantics.

KERNEL -> _KERNEL

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

Clean up formatting; partly from OpenBSD.

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Rename move() to moveplayer() to avoid clashing with libcurses.

branches: 1.6.12;
KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

WARNS=5, and make WARNS=5 the default for src/games.

branches: 1.4.6;
sprinkle static

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.3.84;
KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.4.4;
fix issues found by GCC 6.4:

battlestar was missing some {} in its insane printf()+puts() usage.
this is a literal code sequence i found:

printf("The blast catches ");
printf("the goddess in the ");
printf("stomach, knocking ");
puts("her to the ground.");
printf("She writhes in the ");
printf("dirt as the agony of ");
puts("death taunts her.");
puts("She has stopped moving.");

no lines inserted or removed.

tetris' checkscores() had wrong and missing {} usage.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

avoid unnecessary floating point ops

branches: 1.4.2;
WARNS=5, and make WARNS=5 the default for src/games.

branches: 1.3.42;
KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

fflush the score file while signals are blocked to decrease the chance of
it getting corrupted.

fix typo.

handle ctime returning NULL.

sprinkle static

convert __attribute__s to applicable cdefs.h macros

branches: 1.3.10;
KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

fix issues found by GCC 6.4:

battlestar was missing some {} in its insane printf()+puts() usage.
this is a literal code sequence i found:

printf("The blast catches ");
printf("the goddess in the ");
printf("stomach, knocking ");
puts("her to the ground.");
printf("She writhes in the ");
printf("dirt as the agony of ");
puts("death taunts her.");
puts("She has stopped moving.");

no lines inserted or removed.

tetris' checkscores() had wrong and missing {} usage.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rename com#.c to command#.c to avoid conflicts with those file basenames
on certain Microsoft host OS's.

games: remove trailing whitespace in *.c and *.h

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

In cypher(), don't attempt to make sense of words other than VERBs or
KNIFE when a verb is required. Add AUXVERB for "make", "move",
"climb" (as in "make love", "climb up") and ignore AUXVERB as a verb,
going on to the next word, instead of treating these words as
adjectives. When creating new verbs from "put on", "put down", "take
off", mark them as type VERB. Mostly from Paul Janzen
<pjanzen@foatdi.harvard.edu>.

Remove excess blank lines. From OpenBSD.

Give less cryptic messages than "-1%" when WEIGHT or CUMBER are zero.

Prevent CUMBER from going negative; avoid division by zero if it is
zero.

Give appropriate messages (rather than saying nothing) if an verb is
used with "all" and nothing relevant is present. From OpenBSD.

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Wording, punctuation and line length improvements. Also adjust test
for killing nonsensical things to fix crash with "kill door". From
OpenBSD.

Spelling and punctuation corrections or improvements from OpenBSD.

Rename move() to moveplayer() to avoid clashing with libcurses.

branches: 1.10.8;
Add FALLTHROUGH comment.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

Fix object recognition, per PR 6048 by Joseph S. Myers <jsm28@cam.ac.uk>.

Untakable objects are marked with NULL pointers, not empty strings,
resulting in core dumps. Fixed as per PR 6006 by Joseph Myers
<jsm28@cam.ac.uk>.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add missing initialisers (avoid gcc -W warnings) and comments giving
room numbers.

Based on OpenBSD: spelling, punctuation, grammar and line length
adjustments, and support for '=' in room descriptions meaning a
literal '-'.

Spelling and punctuation corrections or improvements from OpenBSD.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Fix some spelling errors reported by Joseph Myers <jsm28@cam.ac.uk>
in PR 5842.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add missing initialisers.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use random(), not rand().

avoid signed left-shift

Use CHAR_BIT, not 8.

branches: 1.33.2; 1.33.8;
Use __dead and __printflike instead of __attribute__.

sprinkle static

KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

In cypher(), don't attempt to make sense of words other than VERBs or
KNIFE when a verb is required. Add AUXVERB for "make", "move",
"climb" (as in "make love", "climb up") and ignore AUXVERB as a verb,
going on to the next word, instead of treating these words as
adjectives. When creating new verbs from "put on", "put down", "take
off", mark them as type VERB. Mostly from Paul Janzen
<pjanzen@foatdi.harvard.edu>.

Add new flags OBJ_PERSON and OBJ_NONOBJ to the objflags array.

Add OBJ_AN flag to objflags so as to use "a" or "an" appropriately in
messages; avoids "a amulet", "a Elf". Define and use macros to use
"a", "an", "the", "is", "are" appropriately. Partly based on OpenBSD.

Make hash table static in parse.c.

Make functions local to parse.c static.

Clean up fly.c by making local variables and functions static and
removing abs() macro.

Use a lookup table to identify whether objects are plural or singular,
instead of testing the final character against 's' in each place.
Avoids oddities about "pot of jewels" and "compass".

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Store copy of username with strdup rather than using a fixed length
buffer. Also make initialization functions and arrays static.

Put prototypes in alphabetical order.

Make code clearer; add a macro ROOMDESC for the number of times a room
should be visited for the short description only to be used, and don't
increment beenthere[position] beyond this value. From OpenBSD.

Rename move() to moveplayer() to avoid clashing with libcurses.

branches: 1.15.8;
Declare variables in extern.h as extern, and add non-extern
declarations to globals.c.

Use time() instead of gettimeofday().

Fix uses of names of library functions for other purposes.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

Drop setgid privileges early. Derived from OpenBSD and sent in as PR 5970
by Joseph Myers <jsm28@cam.ac.uk>.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

- really make extern char's extern.

change includes to fix compiler warning

KNFify (with indent)

WARNSify

sigh, fix RCS ID again

RCS ID Police

Sync to 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

Sync to 4.4BSD-Lite2

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import

change <sys/signal.h> to <signal.h>

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Pass -Wstrict-overflow.

branches: 1.14.26; 1.14.32;
convert __attribute__s to applicable cdefs.h macros

branches: 1.13.10;
KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Convert old deprecated curses call to new equivalent.

Clean up fly.c by making local variables and functions static and
removing abs() macro.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

initscr() returns a pointer, compare return value with NULL and not
an int.
Compatible with other versions of curses.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

PR/45842: Henning Petersen: compare fgets with NULL not 0

branches: 1.13.42;
KNF and WARNS=3

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Discard any part of a line of input that goes beyond our buffer rather
than treating it as our next line of input. From OpenBSD.

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

die() on EOF; based on OpenBSD.

Clean up formatting; partly from OpenBSD.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

speed limit 80

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add new flags OBJ_PERSON and OBJ_NONOBJ to the objflags array.

Add OBJ_AN flag to objflags so as to use "a" or "an" appropriately in
messages; avoids "a amulet", "a Elf". Define and use macros to use
"a", "an", "the", "is", "are" appropriately. Partly based on OpenBSD.

Make hash table static in parse.c.

Use NULL instead of 0 (from OpenBSD). Also add or adjust comments.

Use a lookup table to identify whether objects are plural or singular,
instead of testing the final character against 's' in each place.
Avoids oddities about "pot of jewels" and "compass".

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Store copy of username with strdup rather than using a fixed length
buffer. Also make initialization functions and arrays static.

Spelling and punctuation corrections or improvements from OpenBSD.

Declare variables in extern.h as extern, and add non-extern
declarations to globals.c.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use random(), not rand().

branches: 1.15.42; 1.15.48;
KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Store copy of username with strdup rather than using a fixed length
buffer. Also make initialization functions and arrays static.

Use strncpy() rather than strcpy() with fixed size buffer.

Fix uses of names of library functions for other purposes.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

Initialize locations before checking wizard mode.

branches: 1.1.1;
Initial revision

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add missing initialisers (avoid gcc -W warnings) and comments giving
room numbers.

Based on OpenBSD: spelling, punctuation, grammar and line length
adjustments, and support for '=' in room descriptions meaning a
literal '-'.

Spelling and punctuation corrections or improvements from OpenBSD.

From PR 7987 by Joseph Myers <jsm28@cam.ac.uk>:
More battlestar(6) spelling and punctuation fixes for battlestar(6).
These ones come from OpenBSD.

Fix some spelling errors reported by Joseph Myers <jsm28@cam.ac.uk>
in PR 5842.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add missing initialisers.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

games/battlestar: Replace snprintf(3) with strlcpy(3) for better performance.

Reviewed by: kamil@

games/battlestar: Fix the -Werror=restrict warning.

Replace strcpy(1) with the safer snprintf(3) which guarantees NULL
termination of strings.

Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.

Reviewed by: kamil@

branches: 1.15.84;
KNF and WARNS=3

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

`existent', not `existant'

Make hash table static in parse.c.

Make functions local to parse.c static.

Remove all adjectives in parse(), since they are nowhere used. Fixes
crash on "carry old all" shown up by fuzz testing. Patch from Paul
Janzen <pjanzen@foatdi.harvard.edu>.

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

expand the internal consistency checks in truedirec() to avoid
fallthrough cases. now if direction turns up wrong (it should
not, but this code can't tell that, and convert it to an enum
that would also fix this, is more effort than this is worth.

branches: 1.13.44;
Don't use return value of a function as format string.

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Based on OpenBSD: spelling, punctuation, grammar and line length
adjustments, and support for '=' in room descriptions meaning a
literal '-'.

Make code clearer; add a macro ROOMDESC for the number of times a room
should be visited for the short description only to be used, and don't
increment beenthere[position] beyond this value. From OpenBSD.

Const poisoning, per PR 6660 by Joseph Myers <jsm28@cam.ac.uk>

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

KNF and WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Use err(1, NULL) and warn(NULL) for `out of memory' error messages.

This patch improves the handling of save files in battlestar(6), by
allowing the user to choose the name of the save file and specify it
on the command line when restoring. It also eliminates a buffer
overrun in determining the path to the save file, and any particular
arbitrary limit on the name length. In the name of a tidier home
directory, the default name is changed from "Bstar" to ".Bstar".

Patch supplied in PR 8085 by Joseph Myers <jsm28@cam.ac.uk>
Minor modification (s/startup/filename/ in initialize()) by me.

add sanity checks when saving/restoring games (PR#6138 by Joseph Myers <jsm28@cam.ac.uk>)

missed a couple of clock->ourclock and time->ourtime variable renames

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

In cypher(), don't attempt to make sense of words other than VERBs or
KNIFE when a verb is required. Add AUXVERB for "make", "move",
"climb" (as in "make love", "climb up") and ignore AUXVERB as a verb,
going on to the next word, instead of treating these words as
adjectives. When creating new verbs from "put on", "put down", "take
off", mark them as type VERB. Mostly from Paul Janzen
<pjanzen@foatdi.harvard.edu>.

Various improvements to parsing in battlestar, mostly from OpenBSD.

Define a constant WORDLEN. Always use this constant and NWORD where
appropriate.

Use NWORD - 1 in battlestar.c to avoid off-by-one error.

Increment wordnumber after the INVEN verb to allow it to be followed
by a comma and other actions.

Avoid overflowing elements of the words array if input words are too
long.

Parse "," as AND except when followed by a verb, to allow such
constructions as "take foo, bar, and baz". Trim AND AND which may
occur from the ", and" in such a list.

Avoid crashes from EVERYTHING in the wrong place by moving it to the
start of OBJECT AND EVERYTHING and NOUNS AND EVERYTHING sequences, and
trimming EVERYTHING AND EVERYTHING.

Patches from OpenBSD: add verbs "open"/"unlock" (essentially a no-op),
and "verbose"/"brief" (in verbose mode, always show long room
descriptions), and synonyms "papaya" for "papayas" and "coconut" for
"coconuts".

Make spacing nicer and add explicit NULL initializers.

KNFify (with indent)

WARNSify

Sync to 4.4BSD-Lite2

clean up import

Add RCS identifiers.

branches: 1.1.1;
Initial revision