Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

merge with Lite, new RCS id conventions, etc.

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

llvm does not know -Wno-error=restrict, check for what gcc is worried about.

introduce a couple of new turn-off-gcc-warning variables and use them.

GCC 14 has a new annoying calloc() checker that we turn off in a bunch
of places, and there are a few more dangling-pointer issuse that come up,
but seem bogus.

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

games/hack: Suppress -Werror=stringop-truncation error.

Add GCC_NO_STRINGOP_TRUNCATION to hack.end.c to prevent build failure.

Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.

Reviewed by: kamil@

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.45.42;
-Wno-shadow is no longer needed for HAVE_PCC, here

- document non-literal format strings
- avoid strict aliasing violations, but adding an intermediate function.

apply some -Wno-error and/or -fno-strict-aliasing.


all of this should be looked at closer, but some of them are not
very trivial.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.

branches: 1.40.20;
Change DPADD from LIBTERM (which doesn't exist) and LIBCOMPAT (which it
doesn't use) to LIBTERMCAP (which it does use).

Improve how various "simple" host tools are built and invoked.

Rework how MAKEVERBOSE operates:

* Don't bother prefixing commands with a line of ${_MKCMD}\
and instead rely upon "make -s". This is less intrusive on
all the Makefiles than the former. Idea from David Laight.

* Rename the variables use to print messages. The scheme now is:
_MKMSG_FOO Run _MKMSG 'foo'
_MKTARGET_FOO Run _MKMSG_FOO ${.TARGET}
From discussion with Alistair Crooks.

rework to use the newer _MKMSGCREATE (et al) macros

Support MAKEVERBOSE. (Some host tools still generate verbose runtime messages)

Rework how dependency generation is performed:

* DPSRCS contains extra dependencies, but is _NOT_ added to CLEANFILES.
This is a change of behaviour. If a Makefile wants the clean semantics
it must specifically append to CLEANFILES.
Resolves PR toolchain/5204.

* To recap: .d (depend) files are generated for all files in SRCS and DPSRCS
that have a suffix of: .c .m .s .S .C .cc .cpp .cxx

* If YHEADER is set, automatically add the .y->.h to DPSRCS & CLEANFILES

* Ensure that ${OBJS} ${POBJS} ${LOBJS} ${SOBJS} *.d depend upon ${DPSRCS}

* Deprecate the (short lived) DEPENDSRCS


Update the various Makefiles to these new semantics; generally either
adding to CLEANFILES (because DPSRCS doesn't do that anymore), or replacing
specific .o dependencies with DPSRCS entries.

Tested with "make -j 8 distribution" and "make distribution".

simplify and use ${DEPENDSRCS} as a target as appropriate

No need to reference .OBJDIR here.

use ${INSTALL_FILE} as appropriate

Use ${COPY} instead of -c for ${INSTALL} commands.

Use ${INSTPRIV} with ${INSTALL}.

tweaks to pass DESTDIR to subprograms when it is defined in /etc/mk.conf
but is not in the environment.

Make the helper programs compile right in a cross-compiling environment.

install games files with the correct permissions.

install games that need it setgid.

use CPPFLAGS instead of CFLAGS, fix dependancies for parallel compile

branches: 1.24.2;
WARNsify...

enable WARNS?=1 by default, & temporarily disable for the few unclean programs

Use afterinstall, not proginstall, to run post-installation crap.

Allow this to be cross-compiled.

Install the help file again.

- Makefile cleanups

Sync to 4.4BSD-Lite2

Use ${INSTALL}.

merge with Lite, new RCS id conventions, etc.

specify man pages the new way.

need -lcompat

kiil bogus install -d's

Use .OBJDIR for auxiliary programs.

From: Havard Eidnes <Havard.Eidnes@runit.sintef.no>
Fix various permissions problems in /var/games/hackdir, and use `install -d'.

use LDSTATIC

Make hack.onames.h be built first.

Add -I. to deal with hack.onames.h, and tweak for cross-compilation.

Remove makedefs when cleaning.

Use `./makedefs'.

Add hack.onames.h to CLEANFILES so it gets removed when cleaning, and to SRCS
so it gets build for depending.

Add RCS identifiers.

make sure directory to install stuff exists before installing

got rid of unnecessary -lcompat and associated dependency

branches: 1.1.1;
Initial revision

merge with Lite, new RCS id conventions, etc.

branches: 1.1.1;
Initial revision

initial import of 386bsd-0.1 sources

s/independant/independent/, from Zafer.

merge with Lite, new RCS id conventions, etc.

branches: 1.1.1;
Initial revision

merge with Lite, new RCS id conventions, etc.

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Simplify alloc() to avoid ifdef(LINT) workaround.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

<sys/wait.h> is standard, so just use it instead of fiddling about with
ifdefs for long-dead systems. While here, remove union wait.

abolish references to index/rindex

Remove the PYRAMID_BUG code. I don't think Pyramids are coming back, nor
do we care if their compiler vomits trying to decrement a bitfield.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

comment or delete text after CPP directives.

WARNsify...

Make these compile on the PowerPC (an unsigned char system).

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

s/venomenous/venomous/

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

sprinkle static

Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

- document non-literal format strings
- avoid strict aliasing violations, but adding an intermediate function.

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

comment or delete text after CPP directives.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Don't refer to index() in comments; use strchr().

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

comment or delete text after CPP directives.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Mark error() as dead, so that validation for setclipped works correctly.

Use __dead and __printflike instead of __attribute__.

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Remove silly casts.

Use consistent sign in compare, the function is only called with
constants as third argument anyway.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

sprinkle static

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

Change getdate() to getdatestr() since the former maybe present on systems
supporting X/Open System Interfaces Extension (XSI) getdate() in <time.h>.
This prevents a function prototype conflict.

branches: 1.9.2;
fix -Wsign-compare issues

branches: 1.8.6; 1.8.8;
Remove clause 3 and 4 from TNF licenses

branches: 1.7.4;
Make hack build with WARNS=4.

branches: 1.6.16; 1.6.22; 1.6.26;
Remove uses of __P.

__STDC__ is always defined on NetBSD.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

fix redundant decls and nested externs. while I am here change my copyright
to TNF.

update after change to return value of tputs() third argument

branches: 1.1.6;
WARNsify...

Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.

Grammar fix, from ray at raylai org via jmc@openbsd.

Quote question mark.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

Lots of minor fixes resulting from reading these man pages in detail.

New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace and/or punctuation fixes.

remove unnecessary command name after .Nm

fix path of mail reader

merge with Lite, new RCS id conventions, etc.

update to -mandoc macros

alloc.c

branches: 1.1.1;
Initial revision

a bit more const

sprinkle some more const

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

Fix up still more casts; use NULL instead of (char *)0.

Correctly print variables as strings, not as format string.

ANSIfy function declarations. All object file diffs inspected.

convert __attribute__s to applicable cdefs.h macros

branches: 1.8.22;
Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

Include system headers before private headers. Avoids various possible
symbol conflicts.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Fix up some lint.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

fix spelling of accommodate; from Zapher.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up still more casts; use NULL instead of (char *)0.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Make hack build with WARNS=4.

branches: 1.7.22;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

comment or delete text after CPP directives.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Remove more silly casts.

Include system headers before private headers. Avoids various possible
symbol conflicts.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

Remove more silly casts.

sprinkle static

Fix two serious string-handling bugs (one exploitable, one probably
exploitable) and also add proper checking/paranoia in several other
places.

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.7.10; 1.7.14;
Make hack build with WARNS=4.

branches: 1.6.16; 1.6.22; 1.6.26;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Make hack build with WARNS=4.

branches: 1.8.10;
Bah! Compare, don't assign!

Coverity CID 1326: check for error return

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

- done() can return in wizard mode. don't NOTREACHED'd it
but break instead.

branches: 1.12.42;
Fix up some lint.

Fix up still more casts; use NULL instead of (char *)0.

Correctly print variables as strings, not as format string.

sprinkle static

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.6.16; 1.6.26; 1.6.38; 1.6.42;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

games/hack: Revert the strlcpy(1) change since this changes expected behavior from strncpy(3).

Reviewed by: kamil@

games/hack: Fix -Wstringop-truncation warning.

Replace strncpy(3) with strlcpy(3).

Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.

Reviewed by: kamil@

Fix up still more casts; use NULL instead of (char *)0.

Remove more silly casts.

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

sprinkle static

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

Change getdate() to getdatestr() since the former maybe present on systems
supporting X/Open System Interfaces Extension (XSI) getdate() in <time.h>.
This prevents a function prototype conflict.

branches: 1.9.10; 1.9.12; 1.9.14;
Make hack build with WARNS=4.

convert __attribute__s to applicable cdefs.h macros

branches: 1.7.4; 1.7.10; 1.7.14;
Coverity CID 3382: Fix memory leak.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

Fix up still more casts; use NULL instead of (char *)0.

Remove more silly casts.

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Remove silly casts.

sprinkle static

remove unnecessary casts

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

sprinkle static

sprinkle some more const

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.8.10; 1.8.14;
Make hack build with WARNS=4.

branches: 1.7.4; 1.7.10; 1.7.14;
Fix Coverity issue 2584 -- USE_AFTER_FREE and issue 889 -- FORWARD_NULL.
Approved by christos@.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Spell 'occurred' with two 'r's.

merge with Lite, new RCS id conventions, etc.

branches: 1.1.1;
Initial revision

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

abolish references to index/rindex

include sys/time.h earlier (rather than implicitly via fcntl.h) so that
the "u" variable doesn't shadow stuff, found later in time.h inlines.

kind of a hack, but i don't want to modify time.h either.

XXX: seems kind of annoying

Fix two serious string-handling bugs (one exploitable, one probably
exploitable) and also add proper checking/paranoia in several other
places.

a bit more const

sprinkle some more const

branches: 1.10.16; 1.10.26; 1.10.38; 1.10.42;
Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

fix redundant decls and nested externs. while I am here change my copyright
to TNF.

comment or delete text after CPP directives.

More include additions for exit, abs, strcmp, etc.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

Fix up still more casts; use NULL instead of (char *)0.

Remove more silly casts.

Correctly print variables as strings, not as format string.

sprinkle static

Fix two serious string-handling bugs (one exploitable, one probably
exploitable) and also add proper checking/paranoia in several other
places.

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.10.4; 1.10.14; 1.10.26; 1.10.30;
Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
Approved by Christos@.

Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

Initialize pointers to NULL to avoid gcc/sparc compiler error
hack.invent.c: In function `dolook':
hack.invent.c:800: warning: `otmp0' might be used uninitialized in this function
hack.invent.c:801: warning: `gold' might be used uninitialized in this function
(this is awfully tiresome - can't we fix gcc?)

branches: 1.5.2;
WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

Fix up still more casts; use NULL instead of (char *)0.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

Use POSIX tty semantics.

merge with Lite, new RCS id conventions, etc.

Don't #include inside a function definition.

alloc.c

branches: 1.1.1;
Initial revision

Remove *another* set of useless casts. sheesh

Remove more silly casts.

Remove silly casts.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

use %zu to print size_t

fix -Wsign-compare issues

Make hack build with WARNS=4.

branches: 1.6.22;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up still more casts; use NULL instead of (char *)0.

Correctly print variables as strings, not as format string.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

sprinkle static

Fix two serious string-handling bugs (one exploitable, one probably
exploitable) and also add proper checking/paranoia in several other
places.

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.10.10; 1.10.14;
Make hack build with WARNS=4.

branches: 1.9.16; 1.9.22; 1.9.26;
Remove uses of __P.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

__STDC__ is always defined on NetBSD.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

POSIX.2: Ignore a null PAGER as well.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Make hack build with WARNS=4.

branches: 1.6.22;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up still more casts; use NULL instead of (char *)0.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

shops are only supposed to have 1 door (as per standard hack 1.0.3).
for some reason, the version of 1.0.3 that was in the 4.4 lite tree
was modified to allow shops with two doors -- this violates the spirit
of the game. with this diff, we revert back to classic 1.0.3 behavior.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

Fix up some lint.

Remove more silly casts.

drop private (and wrong) definition of NULL

Use consistent sign in compare, the function is only called with
constants as third argument anyway.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

Make hack build with WARNS=4.

branches: 1.7.10;
Coverity CID 1328: check for error return

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

- document non-literal format strings
- avoid strict aliasing violations, but adding an intermediate function.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

hack(6): Fix a segfault that occurs when ASLR is enabled

Prior to this change, savenames() would store "objects" in save files as a
blob, and restnames() would load it and overwrite "objects". But since
objclass::oc_name and oc_descr are pointers to string constants, they would
be invalid when the next time the process is spawned, and opening the
inventory would crash by dereferencing invalid pointers.

Fix up still more casts; use NULL instead of (char *)0.

Remove *another* set of useless casts. sheesh

Use the right type for the malloc wrapper function, and don't cast the
return value.

(XXX: Except for a pile of allocation macros that produce typed pointer
results; there the typechecking of the result assignment is more valuable
than the warning if the alloc function isn't declared properly. These
macros should go away.)

Remove silly casts.

sprinkle static

ANSIfy function declarations. All object file diffs inspected.

fix -Wsign-compare issues

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Fix up some lint.

sprinkle static

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.7.10; 1.7.14;
Make hack build with WARNS=4.

branches: 1.6.16; 1.6.22; 1.6.26;
Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

Make mostly gcc -W clean, and other cleanup:
Use const.
Add __noreturn__ attributes.
Add a __format__ attribute.
Add __unused__ attributes.
Use symbolic constants for open() and lseek().
Declare types of all function parameters; convert some function
definitions to ISO C form.
Ensure standard file descriptors are open on startup.
Check for errors writing output of makedefs.
Avoid duplicate definitions of variables.

WARNsify...

merge with Lite, new RCS id conventions, etc.

alloc.c

branches: 1.1.1;
Initial revision

Clean up deleted files.

alloc.c

branches: 1.1.1;
Initial revision

Correctly print variables as strings, not as format string.

sprinkle static

sprintf -> snprintf, plus some use of strlcpy/strlcat where appropriate
XXX: there's still one sprintf left which will take some hacking to expunge.

ANSIfy function declarations. All object file diffs inspected.

branches: 1.7.16; 1.7.26; 1.7.38; 1.7.42;
Refer to 'O' rather than 'o' as command to set options. Bug reported
by Christian Garbs <debian@cgarbs.de> in Debian bug 191452.

Hack is now BSD-licensed. Thanks to Andries Brouwer, Jay Fenlason and
CWI <http://www.cwi.nl/~aeb/games/hack/hack.html>. Via OpenBSD.
Addresses part of PR bin/5850.

fix redundant decls and nested externs. while I am here change my copyright
to TNF.

WARNsify...

merge with Lite, new RCS id conventions, etc.

Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

branches: 1.1.1;
Initial revision

reinstate NULL cast by request, where the NULL was being passed as a vararg

NULL does not need a cast