branches: 1.1.1;
build hunt.

handle compiled-in pathnames the customary way

branches: 1.11.6; 1.11.12;
Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Remove references to config #defines for the thoroughly obsolete
4.2BSD syslog API.

Sync with v20030416 of Makefile.

Minor rearrangement.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

Curses works - define USE_CURSES for BSD44 and don't try to do our own
thing (using curses internal data structures anyway!).

use CPPFLAGS instead of CFLAGS

branches: 1.2.2;
Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

build hunt.

hunt version 1993-07-17

Notes on the protocol used by hunt, from OpenBSD.

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.9.26;
split off a bunch of the nastier network code into its own file

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

branches: 1.7.6; 1.7.12;
When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Simply include -lcurses instead of -lcurses -ltermcap

move hunt under dm(6)

Must have the correct library link order to be able to link
the binaries static.

use CPPFLAGS instead of CFLAGS

branches: 1.1.2;
build hunt.

Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

branches: 1.8.6; 1.8.12;
Whitespace.

ANSIfy function declarations.

Remove bogus casts. Two object file diffs inspected and found to be harmless.

Merge with v20030416.

Make this work on 64 bit big endian platforms.

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

Various minor fixes, mostly from OpenBSD.

Fix markup

branches: 1.12.28;
Drop trailing whitespace.

Merge with v20030416.

setup -> set up.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

.Nm still needs "".

Lots of minor fixes resulting from reading these man pages in detail.

New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

mdoc'ify.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

note that huntd lives in /usr/games.

branches: 1.1.1;
Initial revision

Remove unused.

curses has printw, use it.

don't use the preprocessor to rename curses functions, just call them

Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)

I wish the socket API didn't require casts. Easy to mess them up.

fix obvious mistake (seems to have been there since 4.4)

Clean up the handling of the list of hunt daemons.

use fewer globals

unexpose some globals that server.c previously required

split off a bunch of the nastier network code into its own file

be consistent about whether functions are static

handle compiled-in pathnames the customary way

make some globals static

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

Remove unsafe and unnecessary pointer casts.

catch up to huntd changes.
XXX: this needs to stop promiscuously sharing .h files.

branches: 1.41.2; 1.41.8;
reinstate NULL cast by request, where the NULL was being passed as a vararg

NULL does not need a cast

Don't use variables as format string.

avoid unnecessary cast (hi wiz)

Fix realloc error. Found by cppcheck.

sprinkle static and prune some dead code

Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Whitespace.

ANSIfy function declarations.

Remove two more bogus casts. These *do* create object diffs on amd64,
for no clear reason, but it looks like the diffs are harmless.

Remove bogus casts. Two object file diffs inspected and found to be harmless.

sprintf -> snprintf

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.26.6;
clean for WARNS=4

convert __attribute__s to applicable cdefs.h macros

branches: 1.24.10;
change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Add (unsigned char) cast to ctype functions

Mark unused parameters, nonreturning functions and format functions in
the few cases not already marked.

Remove uses of __P.

Make build.

Merge with v20030416.

don't print error messages using warn, because we clear the screen immediately
afterwards and they vanish.

Rewrite broken broadcast interface detection code using getifaddrs(3).
"hunt -q" works now.

Avoid strict alias warning.

Remove an unused declaration.

If we're searching for a huntd, probe local_address along with broadcast
addresses.

select() -> poll()

eliminate nested externs

Don't declare 'extern opt*' getopt variables.

Include <sys/param.h> for MAXHOSTNAMELEN.

Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

branches: 1.8.2;
mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

Add braces to make the new egcs happy.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

change static to static int

FD_ZERO select mask before FD_SET-ing it

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

branches: 1.9.4; 1.9.8;
Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)

Clean up the handling of the list of hunt daemons.

use fewer globals

unexpose some globals that server.c previously required

split off a bunch of the nastier network code into its own file

group external functions by where they come from

make some globals static

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

catch up to huntd changes.
XXX: this needs to stop promiscuously sharing .h files.

branches: 1.15.6; 1.15.12;
Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Whitespace.

ANSIfy function declarations.

convert __attribute__s to applicable cdefs.h macros

branches: 1.10.10;
Coverity CID 1443: Prevent static overrun.

add more "ifdef notdef" around unused sections - addresses Coverity CID 564

Add (unsigned char) cast to ctype functions

Mark unused parameters, nonreturning functions and format functions in
the few cases not already marked.

Remove uses of __P.

Merge with v20030416.

eliminate nested externs

Don't frob the interals of a WINDOW*, use the mvinch() macro.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

Use the curses beep function instead of writing a beep to stdout.

don't use the preprocessor to rename curses functions, just call them

fix off-by-one

Instead of #define STDIN 0, use STDIN_FILENO.

Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)

When indexing an array with a char, cast it to unsigned char, not int,
to not only silence the compiler warning but also get the correct
behavior.

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

catch up to huntd changes.
XXX: this needs to stop promiscuously sharing .h files.

branches: 1.16.6; 1.16.12;
u_int32_t -> uint32_t

sprinkle static and prune some dead code

Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)

Whitespace.

ANSIfy function declarations.

Remove bogus casts. Two object file diffs inspected and found to be harmless.

clean for WARNS=4

branches: 1.8.22;
Remove uses of __P.

Merge with v20030416.

Make this work on sparc64 (don't use long and assume sizeof(long) = 4).
Tested against a LE32 system (arm).

select() -> poll()

FD_ZERO select mask before FD_SET-ing it

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

huntd(6): convert malloc(x * y) and realloc(x * y) to reallocarr

branches: 1.8.4; 1.8.8;
I wish the socket API didn't require casts. Easy to mess them up.

Tidy up list of broadcast addresses.

Clean up the handling of the list of hunt daemons.

more cleanup

unexpose some globals that server.c previously required

name reform, fewer file statics

goto considered harmful

split off a bunch of the nastier network code into its own file

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

one port complains about string overflow here that i can't see.

add some new uses of existing GCC_NO_* variables for warning issues.
remove an no longer relevant for gcc7 workaround (works fine in both
gcc9 and gcc 10.)

convert HAVE_GCC == 7 to HAVE_GCC >= 7.

apply -Wno-error=implicit-fallthrough on files that have fallthru
comments but are missed by the current checker.

branches: 1.6.26;
Reduce ifdefs by making a common function to talk to either syslogd or
stderr.

Flush unwanted file.

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

remove stubbed-out function

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

branches: 1.1.68; 1.1.74;
build hunt.

games: remove trailing whitespace in *.c and *.h

Use bool (not int) for a boolean return type.

Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.

Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...

fix non-INTERNET build

Reduce ifdefs by making a common function to talk to either syslogd or
stderr.

don't declare own boolean type

branches: 1.16.6; 1.16.12;
u_int32_t -> uint32_t

sprinkle static and prune some dead code

Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

sprintf -> snprintf

Fix possible remote DoS of a running hunt game, and prevent a possible
theoretical attack involving >= 1 billion ammo.

branches: 1.9.10; 1.9.14;
clean for WARNS=4

branches: 1.8.4; 1.8.10; 1.8.14;
change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Add (unsigned char) cast to ctype functions

Merge with v20030416.

Make this work on sparc64 (don't use long and assume sizeof(long) = 4).
Tested against a LE32 system (arm).

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

fix compiler warnings on the alpha.

branches: 1.1.1;
Initial revision

Remove empty header file.

branches: 1.7.6; 1.7.12;
Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove references to config #defines for the thoroughly obsolete
4.2BSD syslog API.

Whitespace.

Merge with v20030416.

Minor rearrangement.

RCS Id Police.

branches: 1.1.1;
Initial revision

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

Remove empty header file.

Make the code for issuing talk requests to find players actually build.

branches: 1.5.6; 1.5.12;
Whitespace.

ANSIfy function declarations.

Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

Remove empty header file.

Make the code for issuing talk requests to find players actually build.

branches: 1.9.6; 1.9.12;
Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

Merge with v20030416.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

receive, not recieve

FD_ZERO select mask before FD_SET-ing it

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

don't declare own boolean type

branches: 1.8.6; 1.8.12;
sprinkle static and prune some dead code

Whitespace.

ANSIfy function declarations.

sprintf -> snprintf

clean for WARNS=4

branches: 1.3.22;
Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.

Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...

fix non-INTERNET build

Reduce ifdefs by making a common function to talk to either syslogd or
stderr.

handle compiled-in pathnames the customary way

Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.

sprinkle static

Move definitions to the file they're used in.

remove stubbed-out function

Use setproctitle() instead of handrolled version.

Make the code for issuing talk requests to find players actually build.

don't declare own boolean type

use random(), not a handrolled 16-bit generator

fix unused variable warnings

branches: 1.21.2; 1.21.8;
NULL does not need a cast

sprinkle static and prune some dead code

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Remove references to config #defines for the thoroughly obsolete
4.2BSD syslog API.

Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

sprintf -> snprintf

clean for WARNS=4

branches: 1.12.8;
PR/18906: roskens at elfin dot net: misc. select() to poll() updates.

Adapted to -current by myself, thanks for the patch!

change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Remove uses of __P.

Merge with v20030416.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

- openlog "huntd" instead of "HUNT"
- consistently log non-critical errors at LOG_WARNING not LOG_ERR
- consistently use positive numbers for exit() and _exit()
- one warning was using printf() instead of syslog()

Don't declare 'extern opt*' getopt variables.

FD_ZERO select mask before FD_SET-ing it

drop core in /var/tmp (from linux).

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

be consistent about whether functions are static

don't declare own boolean type

branches: 1.10.2; 1.10.8;
NULL does not need a cast

Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

sprintf -> snprintf

clean for WARNS=4

branches: 1.4.22;
Remove uses of __P.

Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

sprinkle static

branches: 1.7.6; 1.7.12;
Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

Remove uses of __P.

Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...

Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.

sprinkle static

don't declare own boolean type

branches: 1.6.6; 1.6.12;
sprinkle static and prune some dead code

Whitespace.

Merge with v20030416.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

remove stubbed-out function

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

Remove empty header file.

Use setproctitle() instead of handrolled version.

Make the code for issuing talk requests to find players actually build.

don't declare own boolean type

typo in error message

branches: 1.18.6; 1.18.12;
u_int32_t -> uint32_t

Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

sprintf -> snprintf

convert __attribute__s to applicable cdefs.h macros

branches: 1.10.22;
Mark unused parameters, nonreturning functions and format functions in
the few cases not already marked.

Remove uses of __P.

Merge with v20030416.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

remove redundant decls

- openlog "huntd" instead of "HUNT"
- consistently log non-critical errors at LOG_WARNING not LOG_ERR
- consistently use positive numbers for exit() and _exit()
- one warning was using printf() instead of syslog()

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

fix compiler warnings on the alpha.

branches: 1.1.1;
Initial revision

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

Remove empty header file.

Make the code for issuing talk requests to find players actually build.

Use getaddrinfo() instead of gethostbyname().

const

simplify silly logic

If you are going to use memcpy instead of struct assignment, then at
least use sizeof(the correct variable). The use of memcmp to test
two pointers for equality, one line earlier, is also weird but may be
correct.

branches: 1.10.6; 1.10.12;
Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

Merge with v20030416.

remove redundant decls

- openlog "huntd" instead of "HUNT"
- consistently log non-critical errors at LOG_WARNING not LOG_ERR
- consistently use positive numbers for exit() and _exit()
- one warning was using printf() instead of syslog()

More include additions for exit, abs, strcmp, etc.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Use bool (not int) for a boolean return type.

Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.

Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...

Reduce ifdefs by making a common function to talk to either syslogd or
stderr.

Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.

Group function declarations by which source file they come from, and
delete several that don't actually exist.

sprinkle static

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

Remove empty header file.

Make the code for issuing talk requests to find players actually build.

don't declare own boolean type

branches: 1.19.6; 1.19.12;
sprinkle static and prune some dead code

Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.

Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)

Remove config for the return type of signal handlers, which is also a
long-dead issue.

Whitespace.

Sigh, more of the same (missed two)

__attribute__((__noreturn__)) -> __dead

clean for WARNS=4

branches: 1.11.22;
Mark unused parameters, nonreturning functions and format functions in
the few cases not already marked.

Remove uses of __P.

Make build.

Merge with v20030416.

select() -> poll()
Also, turn off talk announcements; it's a wretched hack.

Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

branches: 1.5.2;
mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

remove unneeded typedef for TTYB, as per PR#5867

RCS Id Police.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

Fix sendmail section (8 -> 1) in xrefs.

branches: 1.9.6; 1.9.12;
Fix preamble

branches: 1.8.28;
Drop trailing whitespace.

Merge with v20030416.

Lots of minor fixes resulting from reading these man pages in detail.

Ispell.

mdoc'ify.

RCS Id Police.

note that huntd lives in /usr/games.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

tsort contents of file

const in unused code

don't declare own boolean type

branches: 1.8.4; 1.8.10;
#if 0 some unused code.

sprinkle static and prune some dead code

Whitespace.

ANSIfy function declarations.

Remove uses of __P.

Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

Flush unwanted file.

Move definitions to the file they're used in.

move a comment that should have gone with its symbol

Remove tautological #if DEBUG.

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

branches: 1.5.6; 1.5.12;
Whitespace.

clean for WARNS=4

branches: 1.3.22;
Merge with v20030416.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

adjust a fallthru comment and add a missing break.

branches: 1.14.26;
be consistent about whether functions are static

don't declare own boolean type

branches: 1.12.2; 1.12.8;
NULL does not need a cast

more whitespace

Whitespace.

ANSIfy function declarations.

Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.

sprintf -> snprintf

Add a missing bp->b_score not null check - addresses Coverity CID 1003

Remove uses of __P.

Merge with v20030416.

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

branches: 1.2.4; 1.2.8;
Er oops, fix previous.

Reduce ifdefs by making a common function to talk to either syslogd or
stderr.

Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.

branches: 1.7.6; 1.7.12;
Whitespace.

Remove uses of __P.

Merge with v20030416.

RCS Id Police.

use err/warn instead of perror

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

Whitespace.

ANSIfy function declarations.

clean for WARNS=4

branches: 1.4.22;
Merge with v20030416.

__STDC__ is always defined on NetBSD.

Yet Another Monster Commit:
- WARNSify
- getopt returns -1 not EOF
- select() uses an fd_set, not int/long; modify code to use FD_* et al
instead of direct bitwise operations
- in otto.c::look (renamed to ottolook() to prevent name clash), the
case WEST section had a 'goto cont_east', instead of 'goto cont_west'.
(picked up by WARNS=1, because cont_west was an unused label because
of this typo). probably meant that otto got lost in the maze :-/
- deprecate register, convert bcmp() -> memcmp()

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

branches: 1.4.4; 1.4.8;
Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.

Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.

move a comment that should have gone with its symbol

Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.

games: remove trailing whitespace in *.c and *.h

branches: 1.1.4; 1.1.8;
handle compiled-in pathnames the customary way