fix various typos in comments, messages and documentation.

Fix doubled 'the'.

clean up import, NetBSD RCS Ids

branches: 1.1.1;
Initial revision

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.20.2;
Restore the MKGROFF=bo MKCXX=yes build

Mark the documentation in dc(1), gprof(1), rogue(6) and fsck_ffs(8) with
the .roff flag in SUBDIR.

Sponsored by <The NetBSD Foundation>

branches: 1.19.22;
Rework /usr/share/doc.

Update the <bsd.doc.mk> infrastructure, and update the docs to match
the new infrastructure.

- Build and install text, ps, pdf, and/or html, not roff sources.

- Don't wire the chapter numbers into the build system, or use them in
the installed pathnames. This didn't matter much when the docs were a
museum, but now that we're theoretically going to start maintaining
them again, we're going to add and remove documents periodically and
having the chapter numbers baked in creates a lot of thrashing for no
purpose.

- Specify the document name explicitly, rather than implicitly in a
path. Use this name (instead of other random strings) as the name
of the installed files.

- Specify the document section, which is the subdirectory of
/usr/share/doc to install into.

- Allow multiple subdocuments. (That is, multiple documents in one
output directory.)

- Enumerate the .png files groff emits along with html so they can be
installed.

- Remove assorted hand-rolled rules for running roff and roff widgetry
and add enough variable settings to make these unnecessary. This
includes support for
- explicit use of soelim
- refer
- tbl
- pic
- eqn

- Forcibly apply at least minimal amounts of sanity to certain
autogenerated roff files.

- Don't exclude USD.doc, SMM.doc, and PSD.doc directories from the
build, as they now actually do stuff.

Note: currently we can't generate pdf. This turns out to be a
nontrivial problem with no immediate solution forthcoming. So for now,
as a workaround, install compressed .ps as the printable form.

branches: 1.18.2;
WARNS=5

branches: 1.17.6; 1.17.12;
When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.

Don't use -fwritable-strings. Add one more const.

Make "rogue" build with "WARNS=2". The necessary patches were supplied
by David A. Holland in PR bin/17498.

Remove rogue's old and bit-rotten cut-down version of curses.

s/SETUIDGAME/SETGIDGAME/ - catch up with the rest of the world.

branches: 1.12.2;
Simply include -lcurses instead of -lcurses -ltermcap

Remove -lcompat; not needed

install games that need it setgid.

use CPPFLAGS instead of CFLAGS

branches: 1.8.2;
Use bsd.subdir.mk as appropriate.

don't forget to install the docs.

clean up import, NetBSD RCS Ids

specify man pages the new way.

don't -g by default

new curses update

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove rogue's old and bit-rotten cut-down version of curses.

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.7.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Make "rogue" build with "WARNS=2". The necessary patches were supplied
by David A. Holland in PR bin/17498.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.17.6;
ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

convert __attribute__s to applicable cdefs.h macros

branches: 1.13.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Change deprecated curses call to new equivalent.

More include additions for exit, abs, strcmp, etc.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

Check for failure of malloc() and calloc() at various places in the games.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

constify, per PR 6148

const poisoning.

WARNSify (not an insignificant task...)

Use POSIX tty semantics.

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead and __printflike instead of __attribute__.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.10.10;
XXX: GCC uninitialized

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

- use correctly bounded strings when reloading a saved game. in particular,
do not let the save game file "string length" exceed the amount of space
supplied. as noted by <stanojr@iserver.sk> on bugtraq.
- minor KNF.

tested by simonb.

Make "rogue" build with "WARNS=2". The necessary patches were supplied
by David A. Holland in PR bin/17498.

branches: 1.6.10; 1.6.12;
constify, per PR 6148

WARNSify (not an insignificant task...)

NULL => 0 (Arne Juul; PR#3629)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.7.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

The Double-Semi-Colon Police.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix misspelling of acceptible (it's only acceptable with an 'a', not an 'i').

branches: 1.19.2; 1.19.8;
reinstate NULL cast by request, where the NULL was being passed as a vararg

NULL does not need a cast

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.14.10;
It's "its."

Cast last argument of execl to (char *).

Reviewed by <hubertf>.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Remove rogue's old and bit-rotten cut-down version of curses.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

constify, per PR 6148

const poisoning.

As per PR bin/5806 by Joseph Myers <jsm28@cam.ac.uk>/lash@tellabs.com:
- Init Random by time, not by pid
- Fix lossage with fire-spitting, monster-killing dragons

WARNSify (not an insignificant task...)

Use POSIX tty semantics.

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.8.6;
ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

branches: 1.6.22;
Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

fix new GCC 12 warning that can't happen by forcing unsigned context for
values that are always positive by this point.

games: remove trailing whitespace in *.c and *.h

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.10.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

- use correctly bounded strings when reloading a saved game. in particular,
do not let the save game file "string length" exceed the amount of space
supplied. as noted by <stanojr@iserver.sk> on bugtraq.
- minor KNF.

tested by simonb.

branches: 1.8.2;
printf() pedant - do not pass variable alone, use %s.
idea from openbsd. after looking at freebsd commit msgs from kris@freebsd.

branches: 1.7.10;
constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

new curses update

Rewrite special character handling.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix loading save files

Both monster and weapon damage are represented as strings like "1d1", and
internally the game keeps track of them as pointers to static strings
in memory. When saving, the game saves these pointers and when loading
them the pointers end up being identical to before - which now points to
undefined memory.

So when loading a save game, reset the damage strings based on the type
of monster or weapon.

Pointed out and fix suggested by Anthony C Howe <achowe@snert.com>
(committed with a small modification of said patch).

branches: 1.17.36; 1.17.38;
WARNS=5

branches: 1.16.6; 1.16.12;
Fix '=' for '==' in a test. From NAKAJIMA Yoshihiro in PR 42177.

sprinkle static

branches: 1.14.10; 1.14.16;
ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.11.10;
Coverity CID 1287: not checking for error return

Change marker from "pmppc" to "powerpc" because a NetBSD-macppc build
is also affected.

Add an initialization to placate -Wuninitialized.
Marked with XXXGCC for pmppc (found while compiling for it).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

fix prototype of mon_sees(), per PR#5867

As per PR bin/5806 by Joseph Myers <jsm28@cam.ac.uk>/lash@tellabs.com:
- Init Random by time, not by pid
- Fix lossage with fire-spitting, monster-killing dragons

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Kill some pointer indirections. Don't use variables as format strings.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.8.10;
XXX: GCC uninitialized

Coverity CID 1293: not checking for an error return

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix loading save files

Both monster and weapon damage are represented as strings like "1d1", and
internally the game keeps track of them as pointers to static strings
in memory. When saving, the game saves these pointers and when loading
them the pointers end up being identical to before - which now points to
undefined memory.

So when loading a save game, reset the damage strings based on the type
of monster or weapon.

Pointed out and fix suggested by Anthony C Howe <achowe@snert.com>
(committed with a small modification of said patch).

branches: 1.14.56; 1.14.58;
sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.10.10;
Coverity CID 993: dereference of NULL pointer

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

fix prototypes, per PR#5867

Better fix for the previous.

make gcc happy on Sparc

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Kill some pointer indirections. Don't use variables as format strings.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.7.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

fix prototypes, per PR#5867

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

branches: 1.4.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix segfault when canceling "Quit" operation

When pressing 'Q' followed by anything other than 'y', make sure not to
end up calling __unreachable().

Pointed out by Anthony C Howe <achowe@snert.com>

branches: 1.10.10; 1.10.12;
- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.9.68;
ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.6.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

branches: 1.5.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.6.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Drop a trailing dot. From jmc@openbsd.

Lots of minor fixes resulting from reading these man pages in detail.

New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Rogue stores scores in /var/games/rogue.scores, not .../rogue_roll.

Convert to -mandoc macros.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Fix loading save files

Both monster and weapon damage are represented as strings like "1d1", and
internally the game keeps track of them as pointers to static strings
in memory. When saving, the game saves these pointers and when loading
them the pointers end up being identical to before - which now points to
undefined memory.

So when loading a save game, reset the damage strings based on the type
of monster or weapon.

Pointed out and fix suggested by Anthony C Howe <achowe@snert.com>
(committed with a small modification of said patch).

branches: 1.24.36; 1.24.38;
WARNS=5

typo in comment

branches: 1.22.2; 1.22.8;
Use __dead and __printflike instead of __attribute__.

Kill some pointer indirections. Don't use variables as format strings.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.17.16;
Avoid arrays of incomplete types (required to build with GCC 4).

Reviewed by <hubertf>.

Remove uses of __P.

Don't use -fwritable-strings. Add one more const.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

- use correctly bounded strings when reloading a saved game. in particular,
do not let the save game file "string length" exceed the amount of space
supplied. as noted by <stanojr@iserver.sk> on bugtraq.
- minor KNF.

tested by simonb.

branches: 1.12.2;
remove duplicate decls

branches: 1.11.8;
Remove rogue's old and bit-rotten cut-down version of curses.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

constify, per PR 6148

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

const poisoning.

WARNSify (not an insignificant task...)

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.13.46;
sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.9.10;
Coverity CID 2788: If no room gets returned, don't try to place a monster.

Coverity CID 1288: possible negative array index

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

fix prototype, per PR#5867

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix loading save files

Both monster and weapon damage are represented as strings like "1d1", and
internally the game keeps track of them as pointers to static strings
in memory. When saving, the game saves these pointers and when loading
them the pointers end up being identical to before - which now points to
undefined memory.

So when loading a save game, reset the damage strings based on the type
of monster or weapon.

Pointed out and fix suggested by Anthony C Howe <achowe@snert.com>
(committed with a small modification of said patch).

branches: 1.14.6; 1.14.8;
games: remove trailing whitespace in *.c and *.h

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.10.10;
Call fclose() appropriately if there is a problem with the save file.
Coverty CID 2063

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

- use correctly bounded strings when reloading a saved game. in particular,
do not let the save game file "string length" exceed the amount of space
supplied. as noted by <stanojr@iserver.sk> on bugtraq.
- minor KNF.

tested by simonb.

branches: 1.7.8; 1.7.10;
Fix -Wsign-compare warnings.

Fix buffer overrun in rogue.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead and __printflike instead of __attribute__.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.11.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Make "rogue" build with "WARNS=2". The necessary patches were supplied
by David A. Holland in PR bin/17498.

Fix for FreeBSD/13278, from FreeBSD:
When a game ends that makes the top 10, the function insert_score in
score.c is called to make the new score file. But the case for KFIRE
(killed by fire) incorrectly uses strcpy instead of strcat (all the
other cases use strcat). This puts the string in the wrong place and
corrupts the score file.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

new curses update

Use `r+' rather than `a+' when opening score file.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Kill some pointer indirections. Don't use variables as format strings.

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.5.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Kill some pointer indirections. Don't use variables as format strings.

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.7.10;
Coverity CID 2452: possible negative array index; CID 1518 and CID 1517: possible overrun of static array

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.6.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

sprinkle static

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.6.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ANSIfy. Remove unnecessary casts. Clean up for -Wsign-compare. Make more
things file-static. Other minor tidyups, and fix a couple minor bugs found
along the way.

Whitespace/KNF nits.

Comprehensive (or at least extensive) string handling cleanup for rogue.

This patch dates (mostly) back to 2002; the critical parts of it were
handled back then by security-officer. As far as I know, there's
nothing exploitable fixed herein.

A slightly earlier version of this patch was reviewed by Christian Biere
when I filed it as PR 34750.

branches: 1.6.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

constify, per PR 6148

WARNSify (not an insignificant task...)

clean up import, NetBSD RCS Ids

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Reorg docs, part 1:
Move all the reference manuals to subdirs of /usr/share/doc/reference.
We have subdirs ref1-ref9, corresponding to man page sections 1-9.

Everything that's the reference manual for a program (sections 1, 6,
8), C interface (sections 2, 3), driver or file system (section 4),
format or configuration (section 5), or kernel internal interface
(section 9) belongs in here.

Section 7 is a little less clear: some things that might go in section
7 if they were a man page aren't really reference manuals. So I'm only
putting things in reference section 7 that are (to me) clearly
reference material, rather than e.g. tutorials, guides, FAQs, etc.
This obviously leaves some room for debate, especially without first
editing the docs with this distinction in mind, but if people hate
what I've done things can always be moved again.

Note also that while roff macro man pages traditionally go in section
7, I have put all the roff documentation (macros, tools, etc.) in one
place in reference/ref1/roff. This will make it easier to find and
also easier to edit it into some kind of coherent form.

Rework /usr/share/doc.

Update the <bsd.doc.mk> infrastructure, and update the docs to match
the new infrastructure.

- Build and install text, ps, pdf, and/or html, not roff sources.

- Don't wire the chapter numbers into the build system, or use them in
the installed pathnames. This didn't matter much when the docs were a
museum, but now that we're theoretically going to start maintaining
them again, we're going to add and remove documents periodically and
having the chapter numbers baked in creates a lot of thrashing for no
purpose.

- Specify the document name explicitly, rather than implicitly in a
path. Use this name (instead of other random strings) as the name
of the installed files.

- Specify the document section, which is the subdirectory of
/usr/share/doc to install into.

- Allow multiple subdocuments. (That is, multiple documents in one
output directory.)

- Enumerate the .png files groff emits along with html so they can be
installed.

- Remove assorted hand-rolled rules for running roff and roff widgetry
and add enough variable settings to make these unnecessary. This
includes support for
- explicit use of soelim
- refer
- tbl
- pic
- eqn

- Forcibly apply at least minimal amounts of sanity to certain
autogenerated roff files.

- Don't exclude USD.doc, SMM.doc, and PSD.doc directories from the
build, as they now actually do stuff.

Note: currently we can't generate pdf. This turns out to be a
nontrivial problem with no immediate solution forthcoming. So for now,
as a workaround, install compressed .ps as the printable form.

branches: 1.5.6;
rename target paper.${PRINTER} to paper.ps -- PRINTER isnt defined anywhere!

branches: 1.4.54; 1.4.60;
Rename a large chunk of the make(1) variables which refer to a
program/tool from "FOO" to "TOOL_FOO". The new variables are:
TOOL_ASN1_COMPILE TOOL_CAP_MKDB TOOL_CAT TOOL_CKSUM TOOL_COMPILE_ET
TOOL_CONFIG TOOL_CRUNCHGEN TOOL_CTAGS TOOL_DB TOOL_EQN TOOL_FGEN
TOOL_GENCAT TOOL_GROFF TOOL_HEXDUMP TOOL_INDXBIB TOOL_INSTALLBOOT
TOOL_INSTALL_INFO TOOL_M4 TOOL_MAKEFS TOOL_MAKEINFO TOOL_MAKEWHATIS
TOOL_MDSETIMAGE TOOL_MENUC TOOL_MKCSMAPPER TOOL_MKESDB
TOOL_MKLOCALE TOOL_MKMAGIC TOOL_MKTEMP TOOL_MSGC TOOL_MTREE
TOOL_PAX TOOL_PIC TOOL_PREPMKBOOTIMAGE TOOL_PWD_MKDB TOOL_REFER
TOOL_ROFF_ASCII TOOL_ROFF_DVI TOOL_ROFF_HTML TOOL_ROFF_PS
TOOL_ROFF_RAW TOOL_RPCGEN TOOL_SOELIM TOOL_SUNLABEL TOOL_TBL
TOOL_UUDECODE TOOL_VGRIND TOOL_ZIC

For each, provide default in <bsd.sys.mk> of the form:
TOOL_FOO?= foo
and for the ${USETOOLS}=="yes" case in <bsd.own.mk>, provide override:
TOOL_FOO= ${TOOLDIR}/bin/${_TOOL_PREFIX}foo

Document all of these in bsd.README.

This cleans up a chunk of potential (and actual) namespace collision
within our build infrastructure, as well as improves consistency in
the share/mk documentation and provision of appropriate defaults for
each of these variables.

Add ${MACROS} to ${ROFF} usage to make output readable

from jbernard@mines.edu in misc/19685

clean up import, NetBSD RCS Ids

branches: 1.1.1;
Initial revision

Uppercase CPU, plural is CPUs.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix pasto. From FreeBSD.

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS Ids

branches: 1.1.1;
Initial revision