remove unused files (PR#6083 by Joseph Myers <jsm28@cam.ac.uk>)

branches: 1.1.1;
Initial revision

remove unused files (PR#6083 by Joseph Myers <jsm28@cam.ac.uk>)

branches: 1.1.1;
Initial revision

remove unused files (PR#6083 by Joseph Myers <jsm28@cam.ac.uk>)

branches: 1.1.1;
Initial revision

remove unused files (PR#6083 by Joseph Myers <jsm28@cam.ac.uk>)

branches: 1.1.1;
Initial revision

Uses non-literal format strings

When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

branches: 1.15.12;
Make the default WARNS for games 4. The only game that needs to set WARNS
to anything else now is rogue, so clear WARNS from the other makefiles.

Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

Don't make /var/games/sail here.

avoid failure on "make install" when /var/games/sail already exists.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

Simply include -lcurses instead of -lcurses -ltermcap

Use -ltermcap instead of -ltermlib.

install games that need it setgid.

branches: 1.7.2;
Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

enable WARNS?=1 by default, & temporarily disable for the few unclean programs

clean up import, NetBSD RCS IDs

specify man pages the new way.

Add RCS identifiers.

got rid of unnecessary -lcompat and associated dependency

branches: 1.1.1;
Initial revision

sail(6): convert realloc(x * y) to reallocarr

branches: 1.1.2;
Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

games: remove trailing whitespace in *.c and *.h

Use __c99inline from sys/cdefs.h

branches: 1.1.2;
Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

avoid non-literal format string

Don't use variables as format string.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.15.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Move newturn() from pl_7 to pl_2.
pl_7 was mostly curses/display stuff, is going to be all display stuff.
pl_2 is where the main loop lives.

Move all curses bits to pl_7.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.3.8;
Remove clause 3 and 4 from TNF licenses

branches: 1.2.32;
Use License templates from localsrc for license on new files.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Prune a comment referring to objects that (AFAICT) didn't even exist in -r1.1.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

sprintf -> snprintf

branches: 1.23.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.22.10;
Coverity CID 980: Prevent an impossible NULL point deref.

Add (unsigned char) cast to ctype functions

Replaced strncpy with strlcpy. Thanks to Peter Postma who
pointed them our in PR #25762. Approved by christos@NetBSD.org.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Various stylistic nits.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Fix uses of namespaces reserved by ISO C or POSIX.1.

branches: 1.9.2;
Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Add braces to make the new egcs happy.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

- enlarge buffer to avoid snprintf() truncation

branches: 1.26.26;
temp is a pointer, and tempmax, not sizeof(temp), is the length of
the buffer that it points to. Adjust a strlcat() call to suit.

branches: 1.25.6; 1.25.12;
Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

String buffer cleanup. sprintf bad.

Don't use char for random state variables; use int or bool.

Braces around a nested if, for clarity; suggested by diffing against OpenBSD.

branches: 1.19.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Fix uses of namespaces reserved by ISO C or POSIX.1.

branches: 1.10.2;
Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

fix prototype, per PR#5867

Rename internal move() to move_ship(), as per PR 5841 by
Joseph Myers <jsm@octomino.demon.co.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

String buffer cleanup. sprintf bad.

branches: 1.15.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Fix uses of namespaces reserved by ISO C or POSIX.1.

branches: 1.6.4;
The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.13.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

fix simple mis-matched function prototype and definitions.

most of these are like, eg

void foo(int[2]);

with either of these

void foo(int*) { ... }
void foo(int[]) { ... }

in some cases (such as stat or utimes* calls found in our header files),
we now match standard definition from opengroup.

found by GCC 12.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.12.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

Don't cast the return value of calloc().

Use err(3) and errx(3), not perror and fprintf to stderr. From OpenBSD.

branches: 1.12.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

setuid rather than setruid

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

add missing extern to several variables.

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead

Use __dead and __printflike instead of __attribute__.

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

sprinkle static

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Turns out the W_FILE message wasn't ever used.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

String buffer cleanup. sprintf bad.

branches: 1.28.28;
If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up

Use standard C abs function rather than local macro.

Include <sys/types.h>.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Various stylistic nits.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Second half of static-ization of local funcs.

G/C undocumented and unimplemented `-D' (debug) option.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Use random() instead of rand(), and seed from time(3) instead of from getpid().

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

ANSIfy in preparation for changes.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

branches: 1.13.2;
Use separate definitions and extern declarations of variables rather
than linker commons.

Fix uses of namespaces reserved by ISO C or POSIX.1.

branches: 1.11.2;
Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

Rename internal move() to move_ship(), as per PR 5841 by
Joseph Myers <jsm@octomino.demon.co.uk>.

add missing extern to several variables.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Change the riggings to ints, so that comparisons against negative
values works as expected on systems with unsigned chars.

Sync to 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

Sync to 4.4BSD-Lite2

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.11.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

First half of static-ization of local funcs.

ANSIfy in preparation for further work.

Fix some uses of NULL as non-pointer and 0 for null pointer.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

sprinkle static

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.13.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Various stylistic nits.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

G/C undocumented and unimplemented `-D' (debug) option.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

Use separate definitions and extern declarations of variables rather
than linker commons.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

fixed spelling of Napoleon

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __c99inline from sys/cdefs.h

branches: 1.1.2;
Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

Close file when finished with it. Found by cppcheck.

sprinkle static

Don't use perror()

Remove some unnecessary casts.

String buffer cleanup. sprintf bad.

branches: 1.13.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.12.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

include stdlib.h for prototypes (typically for exit()).

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

ANSIfy in preparation for further work.

More include additions for exit, abs, strcmp, etc.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.5.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Use POSIX signal and tty semantics.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

Fix usage message

chdir to /var/games/sail while running, to simplify name handling.

Use errx/warnx instead of printing to stderr. From OpenBSD.

branches: 1.22.6;
Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.21.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Include <time.h> for declarations the Single Unix Specification says
are there but not in <sys/time.h>.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

G/C undocumented and unimplemented `-D' (debug) option.

Fix getopt usage (again) in case where user does not choose a scenario on
the command line.

Fix getopt() usage.

ANSIfy in preparation for further work.

Fix warning.

Use random() instead of rand(), and seed from time(3) instead of from getpid().

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Use getopt(3) for flag processing.

Fix style nit.

ANSIfy in preparation for other changes.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

Remove some unnecessary casts.

branches: 1.16.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.15.16;
Add (unsigned char) cast to ctype functions

Use standard C abs function rather than local macro.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

need string.h for prototype (checked with alpha)

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

branches: 1.11.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

chdir to /var/games/sail while running, to simplify name handling.

branches: 1.5.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Don't use perror()

branches: 1.19.12;
convert __attribute__s to applicable cdefs.h macros

branches: 1.18.22;
Use int for wait status.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

include stdlib.h for prototypes (typically for exit()).

Various stylistic nits.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

More include additions for exit, abs, strcmp, etc.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Move newturn() from pl_7 to pl_2.
pl_7 was mostly curses/display stuff, is going to be all display stuff.
pl_2 is where the main loop lives.

branches: 1.11.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Various stylistic nits.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.17.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

Change the macro to roll a six-sided die from die() to dieroll() (for
obvious reasons of convention).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Add braces to make the new egcs happy.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

branches: 1.15.34;
Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.25.46;
Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Move all curses bits to pl_7.c.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

String buffer cleanup. sprintf bad.

branches: 1.19.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.18.10;
If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

need string.h for prototype (checked with alpha)

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.11.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead and __printflike instead of __attribute__.

add printf attributes.

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

Don't define esc-[ as a custom key sequence because it steps on vt
function keys.

sprinkle static

Simplify previous; suggested by Paul Goyette

Fix sign-compare problem that crept in due to working from an old tree.
Whoops. won't happen again...

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Move newturn() from pl_7 to pl_2.
pl_7 was mostly curses/display stuff, is going to be all display stuff.
pl_2 is where the main loop lives.

Move all curses bits to pl_7.c.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Use \a instead of \7 for BEL.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

Use errx() to send fatal error messages. From OpenBSD.

branches: 1.28.12;
convert __attribute__s to applicable cdefs.h macros

branches: 1.27.22;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Changed deprecated curses call to new equivalent.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

remove redundant decls.

include stdlib.h for prototypes (typically for exit()).

need string.h for prototype (checked with alpha)

Various stylistic nits.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

More include additions for exit, abs, strcmp, etc.

Don't initialise curses until after the initial non-curses setup (the
choice of scenario uses puts() rather than curses functions).

branches: 1.13.2;
Use separate definitions and extern declarations of variables rather
than linker commons.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Add braces to make the new egcs happy.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

clean up import, NetBSD RCS IDs

new curses

Use '\a', not CTRL('g').

Pass the signal number to tstp().

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rework the game startup so it uses curses nicely. There are now menus
and stuff for picking scenarios and ships and all that.

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Don't use perror()

Don't cast the return value of calloc().

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

Remove some unnecessary casts.

String buffer cleanup. sprintf bad.

More fixes from OpenBSD: use err instead of perror, don't hork on EOF
during the initial setup questions.

Check for failure of fgets when reading the captain's name, and don't
allow it to be empty. From OpenBSD.

branches: 1.17.28;
fix buffer overflow (CVE-2006-1744), from Debian

branches: 1.16.2; 1.16.4; 1.16.6; 1.16.8; 1.16.10;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

De-`register'

Missed commit -- ANSIfy in preparation for further work.

Don't initialise curses until after the initial non-curses setup (the
choice of scenario uses puts() rather than curses functions).

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

fixed to use fgets()

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sprinkle static

constify the version string

branches: 1.11.40;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Various stylistic nits.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

Use separate definitions and extern declarations of variables rather
than linker commons.

initscr() returns a pointer, compare return value with NULL and not
an int.
Compatible with other versions of curses.

add missing extern to several variables.

Sync to 4.4BSD-Lite2

clean up import, NetBSD RCS IDs

Add RCS identifiers.

BADSIG --> SIG_ERR

branches: 1.1.1;
Initial revision

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

branches: 1.3.8;
Remove clause 3 and 4 from TNF licenses

branches: 1.2.32;
Use License templates from localsrc for license on new files.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Move HISTORY to proper place.

Edit. Sync with reality, at least partway. Bump date.

Sort options. End sentence with a dot.

mdocify. Partly merged from OpenBSD. Not by any means perfect yet.

branches: 1.14.28;
Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

PDP-11 instead of PDP 11. Igor Sobrado in PR 19678.

Mdoc nits -- unneeded ".

Ispell.

New sentences begin on new lines.
Patch from Richard Elz, slightly improved by yours truly.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace and/or punctuation fixes.

Sync to 4.4BSD-Lite2

nuke 'the the' typo

clean up import, NetBSD RCS IDs

fixed spelling of Napoleon

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

fix unused variable warnings

branches: 1.33.6; 1.33.12;
chdir to /var/games/sail while running, to simplify name handling.

Don't crosswire the two kinds of path names, and don't croak on
scenario numbers > 99.

Turns out the W_FILE message wasn't ever used.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Use \a instead of \7 for BEL.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

Remove some unnecessary casts.

String buffer cleanup. sprintf bad.

branches: 1.25.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.24.10;
don't try to switch a char and have a case of EOF - use an int.

Replaced strncpy with strlcpy. Thanks to Peter Postma who
pointed them our in PR #25762. Approved by christos@NetBSD.org.

Include <sys/stat.h>.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

Various stylistic nits.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

Fix insecure /tmp usage in sail.

Essentially concludes the merge into NetBSD of those changes in the
Linux port of the NetBSD games which it is fairly clear to me should
be so merged.

Include <time.h> in various places in the games where time() or time_t
are used.

Use the symbolic names `SEEK_SET' and `O_RDONLY' where appropriate in
the games.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

fix prototype, per PR#5867