bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

apply ${GCC_NO_FORMAT_TRUNCATION} to scores.c

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.7.46;
Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Make the default WARNS for games 4. The only game that needs to set WARNS
to anything else now is rogue, so clear WARNS from the other makefiles.

Build with WARNS=4. (All fixes are cosmetic, except that it's definitely
bad karma to shadow a local variable with another of the same name in a
nested block...)

install games that need it setgid.

branches: 1.3.4;
NetBSD RCS Ids

specify man pages the new way.

branches: 1.1.1;
Initial revision

ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

Coverity CID 868: Fix possible NULL deref (after INFTIM passes :-)

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Correct some comments and error messages that still talked about "select".

Solves the last part of PR 18905.

Fix a bug in rwait() introduced during the select() to poll() conversion
that caused tetris to crash when pausing the game. Approved by tron.

select() -> poll()

de-register

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

Removed "extern int errno"; Added #include <errno.h> if not already present.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

games: Do not assume <sys/endian.h> is transcluded from <sys/types.h>

prompted by PR pkg/59839

games: remove trailing whitespace in *.c and *.h

avoid uninit memory and use memmove vs strncpy for a will be
truncated on purpose string.

fix the previous. the code was right, just badly formatted before.

should fix infinite loops reported in some cases.

branches: 1.23.2;
fix issues found by GCC 6.4:

battlestar was missing some {} in its insane printf()+puts() usage.
this is a literal code sequence i found:

printf("The blast catches ");
printf("the goddess in the ");
printf("stomach, knocking ");
puts("her to the ground.");
printf("She writhes in the ");
printf("dirt as the agony of ");
puts("death taunts her.");
puts("She has stopped moving.");

no lines inserted or removed.

tetris' checkscores() had wrong and missing {} usage.

Revert part of previous -r1.21 and fix the errno-handling bug instead.

fix unused variable warnings

branches: 1.20.6; 1.20.12;
Fix fd leak in error cases. Found by cppcheck.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Disable writing scores when built for /rescue. PR 42009

Don't use a variable-size array here. There's not really that much point.

Clean up scorefile handling.

This was writing time_t to disk. Worse, the time_t member was at an
unaligned offset in the structure in question, so after the time_t
change the structure layout depended on compiler-inserted structure
padding. This gives three legacy formats: one with 32-bit time, one
with 64-bit time, and one with 64-bit time and 4 bytes of structure
padding.

And of course the file didn't have a header or version coding or
anything.

The new code writes a structure of well-defined size that should not
receive unexpected padding, and gives the file a header and version
number. It reads that format and any of the three legacy formats,
figuring out which one it's dealing with by inspecting the file
contents. For good measure, it also now handles opposite-endian files,
doesn't bail out unceremoniously unless necessary, and won't croak if
the file is corrupt and e.g. contains unterminated strings.

(Was it worth going to this length? Maybe not. But it didn't seem
right to just leave it, and it's not clear where to stop halfway.)

ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

Better check data read from tetris.scores before use as array indices etc.
This is CVE-2006-1539, files against Gentoo Linux, the patch is from
Gentoo.
A standard NetBSD installation is not as much risk because tetris is
sgid "games", and users shouldn't be in that group.

branches: 1.13.2; 1.13.4; 1.13.6; 1.13.8; 1.13.10;
Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

de-register

Clean up error reporting in tetris.

Fix high score table formatting bug.

Bug report and fix from Malcolm Parsons <malcolm@bits.bris.ac.uk>.

Fix -Wsign-compare warnings.

Convert tetris to use <err.h> functions.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

use <termcap.h>

bfunctions -> memfunctions

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

Clean up scorefile handling.

This was writing time_t to disk. Worse, the time_t member was at an
unaligned offset in the structure in question, so after the time_t
change the structure layout depended on compiler-inserted structure
padding. This gives three legacy formats: one with 32-bit time, one
with 64-bit time, and one with 64-bit time and 4 bytes of structure
padding.

And of course the file didn't have a header or version coding or
anything.

The new code writes a structure of well-defined size that should not
receive unexpected padding, and gives the file a header and version
number. It reads that format and any of the three legacy formats,
figuring out which one it's dealing with by inspecting the file
contents. For good measure, it also now handles opposite-endian files,
doesn't bail out unceremoniously unless necessary, and won't croak if
the file is corrupt and e.g. contains unterminated strings.

(Was it worth going to this length? Maybe not. But it didn't seem
right to just leave it, and it's not clear where to stop halfway.)

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

games: remove trailing whitespace in *.c and *.h

elide compiler stupidity.

branches: 1.32.2; 1.32.4;
Center game board on screen. OK from christos@.

PR/50411: Rin Okuyama: fix two bugs:
- clear blocks in the 0 row, otherwise the pile up forever.
- black (white) blocks are not shown as "next shape":

Fixes color scheme white on black and black on white.

This commit was approved by christos@

branches: 1.29.2;
Provide an option to restore traditional black-and-white mode.

Add a little color. In order to minimize logic differences, keep 0 as the
empty board value, and since 7 is white, turn white into black (0) when
painting.

branches: 1.27.8; 1.27.18;
Use tiparm instead of vtparm.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Hide the cursor during the game.

sprinkle static

ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

Build with WARNS=4. (All fixes are cosmetic, except that it's definitely
bad karma to shadow a local variable with another of the same name in a
nested block...)

convert __attribute__s to applicable cdefs.h macros

include sys/cdefs.h so that __attribute__ can be fixed later

branches: 1.19.22;
Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

de-register

Update to the new t_agetstr() API.

Fix core dump.

Converted games to use the new termcap interface.

update after change to return value of tputs() third argument

branches: 1.12.2;
Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

Adapt to change of "termcap.h".

only show preview if the -p option is given

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

bzero->memset

use <termcap.h>

minor WARNSify

Fix usages of ospeed.

Use POSIX signal and tty semantics.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

sprinkle static

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Converted games to use the new termcap interface.

Declare variables as extern in headers rather than using linker commons.

update after change to return value of tputs() third argument

branches: 1.3.6;
use <termcap.h>

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

Add a little color. In order to minimize logic differences, keep 0 as the
empty board value, and since 7 is white, turn white into black (0) when
painting.

branches: 1.8.12; 1.8.22;
ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

don't discard const. GCC 4.1-20061021 doesn't like that...

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

de-register

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

minor WARNSify

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

tetris(6): Support the informal standard of allowing setting NO_COLOR
in the environment to disable the use of color. (no-color.org)

tetris(6) is not limited to CRT displays. noted by tnn

Use Pp (mdoc) instead of sp (roff).
Use An in AUTHORS section.

add a 'down' key to tetris, defaulting to 'n'. it move the block down
a line, if it fits. like most other tetris games have.

minor clean up of magic number usage while here.

branches: 1.14.2;
Bump date for -c (exactly one year after previous bump)

At suggestion of christos@, use -b for b&w rather than -c

Provide an option to restore traditional black-and-white mode.

branches: 1.11.48; 1.11.60;
Use standard AUTHORS section header. From YOMURA Masanori in private mail
Sort sections if necessary. Use more/better markup.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Lots of minor fixes resulting from reading these man pages in detail.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace and/or punctuation fixes.

only show preview if the -p option is given

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

fix typo; from Hubert Feyrer in PR bin/4070

Fix broken uses of Dd. Both the mdoc and mdoc.samples pages agree:
.Dd is supposed to be invoked like:
.Dd month day, year
e.g. ".Dd January 25, 1989", rather than:
.Dd "month day, year"
which is what these pages did.

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

tetris(6): Support the informal standard of allowing setting NO_COLOR
in the environment to disable the use of color. (no-color.org)

tetris: Use arc4random_uniform instead of modulo for better randomness

Center game board on screen. OK from christos@.

PR/50411: Rin Okuyama: fix two bugs:
- clear blocks in the 0 row, otherwise the pile up forever.
- black (white) blocks are not shown as "next shape":

add -b to usage, from leot

Fix the list of keys across the bottom so it fits on an 80-column screen
again. Fixes PR 49937.

HI MRG

add a 'down' key to tetris, defaulting to 'n'. it move the block down
a line, if it fits. like most other tetris games have.

minor clean up of magic number usage while here.

branches: 1.27.2;
At suggestion of christos@, use -b for b&w rather than -c

Provide an option to restore traditional black-and-white mode.

Add a little color. In order to minimize logic differences, keep 0 as the
empty board value, and since 7 is white, turn white into black (0) when
painting.

branches: 1.24.8; 1.24.18;
NULL does not need a cast

Fix a few of the games to use getprogname() in their usage() functions.

Suggested by Joerg.

XXX There are probably many more that have their progname hard-coded, but
XXX I'm not up for a wholesale roto-till at the moment.

sprinkle static

ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

sprintf -> snprintf

Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.18.6;
convert __attribute__s to applicable cdefs.h macros

branches: 1.17.22;
Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

de-register

Clean up error reporting in tetris.

Declare variables as extern in headers rather than using linker commons.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

Add `__noreturn__' and `__unused__' attributes where appropriate to
the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Most noreturn attributes were previously added in bin/6144, with some
others that were missed then in bin/8082. Previous `unused'
attributes were covered in bin/6557, bin/8058 and other PRs (all these
PRs have already been handled and closed).

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

Newline and usage cosmetics from Soren S. Jorvang <soren@t.dk> PR7205

Remove unneeded "mips compiler bug" workaround from original code imported
in 1994.

only show preview if the -p option is given

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

bzero->memset

minor WARNSify

NetBSD RCS Ids

branches: 1.1.1;
Initial revision

tetris: Use arc4random_uniform instead of modulo for better randomness

Center game board on screen. OK from christos@.

Provide an option to restore traditional black-and-white mode.

Add a little color. In order to minimize logic differences, keep 0 as the
empty board value, and since 7 is white, turn white into black (0) when
painting.

branches: 1.12.12; 1.12.22;
sprinkle static

ANSIfy function declarations.

Some object file diffs, but they are harmless. (Mostly they seem to
come from internal counters in gcc... and in one case the order of two
instructions was harmlessly swapped, which is odd and annoying.)

Remove uses of __P.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Declare variables as extern in headers rather than using linker commons.

Security improvements for games (largely from or inspired by OpenBSD).

Games which run setgid from dm, but don't need to, should drop their
privileges at startup.

Games which have a scorefile should open it at startup, then drop all
privileges leaving just the open writable file descriptor. If the
game can invoke subprocesses, this should be made close-on-exec.

Games with scorefiles should make sure they do not get a file
descriptor < 3. (Otherwise, they could get confused and corrupt the
scorefile when using stdin, stdout or stderr.)

Some old setuid revokes from the days of setuid games change into gid
revokes.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

only show preview if the -p option is given

Add previewing of next shape. Old (previous) behaviour can be
restored by compiling with NO_PREVIEW defined.

mark non-returning functions (PR#6144 by Joseph Myers <jsm28@cam.ac.uk>)

NetBSD RCS Ids

branches: 1.1.1;
Initial revision