bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

More cases to disable gcc-8 warnings only when we're using gcc>=8

Add -Wno-error for gcc-8 warnings

branches: 1.5.26;
"soon" is "now". Remove all __indr_reference crap.

branches: 1.4.36; 1.4.42;
we don't need <irs.h>

merge in resolver portion of bind-9.4.0-rc2

branches: 1.2.10; 1.2.12;
Jump through taller hoops to provide binary compatibility with programs
compiled with the older and shorter _res. We now use _nres internally
which is the new and bigger one. We define a _res which is the old
size one if COMPAT__RES is set, and then we consult selected values from
this old _res in res_init(), to emulate the old behavior.

Add glue files.

"soon" is "now". Remove all __indr_reference crap.

branches: 1.5.36; 1.5.42;
- Function no longer matched prototype after
move to ansi prototype in last commit; restore.
- Not noticed as weak aliases are used so the
code is not compiled in.

branches: 1.4.4; 1.4.6;
compat core reorg.

- Fix the remaining indr_references so that they define lint symbols.
- Add an internal symbol for strerror_r (thanks klaus for noticing)
- Remove internal __strerror

Add missing __RCSID()

Add glue files.

"soon" is "now". Remove all __indr_reference crap.

branches: 1.4.44; 1.4.50;
compat core reorg.

- Fix the remaining indr_references so that they define lint symbols.
- Add an internal symbol for strerror_r (thanks klaus for noticing)
- Remove internal __strerror

Add missing __RCSID()

Add glue files.

"soon" is "now". Remove all __indr_reference crap.

branches: 1.4.44; 1.4.50;
compat core reorg.

- Fix the remaining indr_references so that they define lint symbols.
- Add an internal symbol for strerror_r (thanks klaus for noticing)
- Remove internal __strerror

Add missing __RCSID()

Add glue files.

branches: 1.3.6;
updates from bind-9-5-0

branches: 1.2.2;
Remove clause 3 and 4 from TNF licenses

branches: 1.1.24;
provide __h_errno_set()

belated removal of the advertising clause.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.8.6;
merge libbind and bump.

branches: 1.7.4; 1.7.6; 1.7.8; 1.7.10; 1.7.14;
updates from bind-9-5-0

branches: 1.6.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.4.10; 1.4.12;
one more missing weak_alias

netbsd rcsid.

- don't use irs.
- h_errno is not going to be per-thread in our implementation.

branches: 1.1.1;
Initial revision

branches: 1.4.2; 1.4.4;
Re-add missing file (removed by cvs import because it was added manually by
christos).

Hi Veego!

Resolve conflicts.

we don't need <irs.h>

branches: 1.1.1;
Initial revision

s/begining/beginning/ in comments and messages.

belated removal of the advertising clause.

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.11.2;
fix the rest of libc mi gcc-4.5 hacks. portmasters should fix the md ones.

merge libbind and bump.

branches: 1.9.4; 1.9.6; 1.9.8; 1.9.10; 1.9.14;
updates from bind-9-5-0

branches: 1.8.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.6.10; 1.6.12;
Provide access to the 8 symbols the bind8 resolver did, through weak aliases.
3 of them [res_send_*, and res_querydomain], were done incorrectly before...

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

more lint fixes.

branches: 1.1.1;
Initial revision

the doo doo doo, the daa daa daa...

branches: 1.2.8;
Remove clause 3 and 4 from TNF licenses

branches: 1.1.24;
Jump through taller hoops to provide binary compatibility with programs
compiled with the older and shorter _res. We now use _nres internally
which is the new and bigger one. We define a _res which is the old
size one if COMPAT__RES is set, and then we consult selected values from
this old _res in res_init(), to emulate the old behavior.

fix nested extern warnings

Add a knote to keep track when resolv.conf gets changed and re-initialize.
While here fix a memory leak when calling res_vinit with an already inited
res_state.

fix lint issues and actual bugs lint found (missing break statements)

merge libbind and bump.

branches: 1.11.4; 1.11.6; 1.11.8; 1.11.10; 1.11.14;
updates from bind-9-5-0

branches: 1.10.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.8.10; 1.8.12;
Jump through taller hoops to provide binary compatibility with programs
compiled with the older and shorter _res. We now use _nres internally
which is the new and bigger one. We define a _res which is the old
size one if COMPAT__RES is set, and then we consult selected values from
this old _res in res_init(), to emulate the old behavior.

Provide access to the 8 symbols the bind8 resolver did, through weak aliases.
3 of them [res_send_*, and res_querydomain], were done incorrectly before...

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

more lint fixes.

- res_ourserver_p prototype was inconsistent (thanks lint)
- protect update functions with _LIBRESOLV
- add res_opt() to mirror res_nopt

branches: 1.1.1;
Initial revision

libc/resolv/res_debug.c: Minor whitespace fixes.

convert explicit length check before unchecked snprintf() with just a
overflow checked snprintf(). for res_debug.c and res_query.c, convert
from sprintf() to snprintf().

tested scp and rcp fail properly with too-long paths.
tested getaddrinfo fails as expected for too-long domains.
tested dig and ping for similar (res_debug.c/res_query.c).
created a temporary fs with quotas to test edquota with a long EDITOR.
did not test ypserv directly, but it's the same pattern.

avoids GCC 12 snprintf() warnings, and reduces total code size.

fix various typos, mainly in comments.

Remove unused macro

branches: 1.14.14; 1.14.16;
belated removal of the advertising clause.

Update old-style definitions to ANSI, remove a couple of register
definitions along the way. Fixed gcc 4.1 build (thank you vax)

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.11.6;
merge libbind and bump.

branches: 1.10.4; 1.10.6; 1.10.8; 1.10.10; 1.10.14;
updates from bind-9-5-0

branches: 1.9.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.7.10; 1.7.12;
resolve conflicts.

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

more lint fixes.

- add casts to silence lint
- add missing prototype
- rename variables to avoid hiding globals

branches: 1.1.1;
Initial revision

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.1.1;
Initial revision

kqueue(2) file descriptors are not inherited across fork(2). A
process that that calls getaddrinfo(3) will end up cacheing the
kqueue(2) file descriptor in its res_state structure. If that
process fork(2)s and calls getaddrinfo(3) again might end up closing
that cached file descriptor which can end up pointing to a different
file object than the kqueue(2) original one. To fix this, associate
the kqueue(2) file descriptor with the process id that created it,
and don't close(2) it if it is being closed from a different process.
An alternative fix would be to attach the resolver to a fork(2) hook
to cleanup the res_state, but handling it internally in the resolver
is less intrusive. This was discovered by Dima Veselov when using
the FreeRADIUS package.

branches: 1.31.14;
F_DUPFD* needs an argument (minfd) found by jmcneill

branches: 1.30.2; 1.30.4;
belated removal of the advertising clause.

Mark the dup of the resolv fd for close on exec.

provide a patchable __res_conf_name for testing purposes.

Fix typo ("then" instead of "than")

branches: 1.26.2;
add a check-names option, now that the default is no-check-names

Use C89 Prototypes.
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.23.2;
close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

expose res_check.

Add a knote to keep track when resolv.conf gets changed and re-initialize.
While here fix a memory leak when calling res_vinit with an already inited
res_state.

Bring back binary compatibility with the previous version of the resolver.
There was no room to allocate 16 bytes for _rnd in the struct in the _LP64
case, so we dynamically allocate now. Also put the _rnd field last, so that
we are bitwise compatible too. Now of course we've run out of space, so
next time will need to perform more evil tricks to fit.

we are not guaranteed that the ext pointer is going to be null at this point
so don't attempt to free.

fix lint issues and actual bugs lint found (missing break statements)

merge libbind and bump.

branches: 1.16.2;
merge christos-time_t

branches: 1.15.4; 1.15.6; 1.15.8; 1.15.12;
- protect DEBUG again because we should be able to set it from the Makefile
- add a missing cast to pacify lint.

updates from bind-9-5-0

branches: 1.13.12;
Resolve conflicts.

Only try free-ing a version of res if it is not supposed to be pre-inited
like before. Fixes issues with programs passing random uninitialized data
as res_state.

Don't check for ext being NULL to destroy the res_state. Instead check
the option bits like we did before.

Fix minor compilation issues.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.8.4; 1.8.6;
Coverity CID 618: Comment out dead code.

don't re-define DEBUG

Rest of fix for PR#31184: getaddrinfo() now honors resolv.conf sortlist
directive for dns answers.

Also, unifdef the RESLVSORT (non-)option sillyness.

Reviewed by christos.

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

add casts to silence lint.

branches: 1.1.1;
Initial revision

s/psuedo/pseudo/ in comments.

PR/52578: Benjamin M. Schwartz Set the AD bit when DNSSEC is enabled
(RFC 6840 Section 5.7).

branches: 1.15.8;
belated removal of the advertising clause.

PR/48475: YAMAGUCHI Takanori: EDNS option broken with unbound. struct
querybuf in net/gethnamaddr.c defines MAXPACKET to 64K. This in turn
gets passed down until it reached res_nopt(..., answer, anslen), where
the size of the buffer must fit in 16 bits. Unfortunately we end up
being one more than the max so we end up sending a 0 as the size and
unbound does not like that. Instead we clip now to 64K - 1, and everyone
is happy.
XXX: Pullup to 7.

branches: 1.13.10;
PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.12.6; 1.12.8;
fix lint issues and actual bugs lint found (missing break statements)

merge libbind and bump.

branches: 1.10.4; 1.10.6; 1.10.8; 1.10.10; 1.10.14;
- protect DEBUG again because we should be able to set it from the Makefile
- add a missing cast to pacify lint.

updates from bind-9-5-0

branches: 1.8.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.6.4; 1.6.6;
don't re-define DEBUG

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

silence lint.

branches: 1.1.1;
Initial revision

fix nested extern warnings

kqueue(2) file descriptors are not inherited across fork(2). A
process that that calls getaddrinfo(3) will end up cacheing the
kqueue(2) file descriptor in its res_state structure. If that
process fork(2)s and calls getaddrinfo(3) again might end up closing
that cached file descriptor which can end up pointing to a different
file object than the kqueue(2) original one. To fix this, associate
the kqueue(2) file descriptor with the process id that created it,
and don't close(2) it if it is being closed from a different process.
An alternative fix would be to attach the resolver to a fork(2) hook
to cleanup the res_state, but handling it internally in the resolver
is less intrusive. This was discovered by Dima Veselov when using
the FreeRADIUS package.

branches: 1.3.48;
expose res_check.

Add a knote to keep track when resolv.conf gets changed and re-initialize.
While here fix a memory leak when calling res_vinit with an already inited
res_state.

branches: 1.1.1;
Initial revision

Not a bug, but avoid using a possibly negative index anyway (CID-603941)

branches: 1.17.2;
convert explicit length check before unchecked snprintf() with just a
overflow checked snprintf(). for res_debug.c and res_query.c, convert
from sprintf() to snprintf().

tested scp and rcp fail properly with too-long paths.
tested getaddrinfo fails as expected for too-long domains.
tested dig and ping for similar (res_debug.c/res_query.c).
created a temporary fs with quotas to test edquota with a long EDITOR.
did not test ypserv directly, but it's the same pattern.

avoids GCC 12 snprintf() warnings, and reduces total code size.

belated removal of the advertising clause.

close on exec hostaliases

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.13.6;
don't read hostaliases using unbuffered reads. there is no security benefit.

merge libbind and bump.

branches: 1.11.4; 1.11.6; 1.11.8; 1.11.10; 1.11.14;
- protect DEBUG again because we should be able to set it from the Makefile
- add a missing cast to pacify lint.

updates from bind-9-5-0

branches: 1.9.12;
Resolve conflicts.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.7.4; 1.7.6;
don't re-define DEBUG

Put back issetugid() check for hostaliases.
XXX: this is suboptimal, It would be better if we propelry checked
for access.

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

add casts to silence lint.

branches: 1.1.1;
Initial revision

belated removal of the advertising clause.

two more type casts after type changes

more type changes

using the proper types eliminate a whole bunch of casts

- make all filedescriptors close-on-exec
- use SOCK_NOSIGPIPE.
- add kqueue handling (not enabled by default, from FreeBSD)
- add RES_INSECURE1 handling (from FreeBSD)

branches: 1.25.2;
time_t casts

Use C89 Prototypes.
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.22.4;
Remove self-assignment of an argument that is later used.

Don't do highestFD check with USE_POLL. It provides no benefit
but causes a dependency between RLIMIT_NOFILE and rumphijack FDOFF.

christos ok

branches: 1.20.2;
expose res_check.

Add a knote to keep track when resolv.conf gets changed and re-initialize.
While here fix a memory leak when calling res_vinit with an already inited
res_state.

merge libbind and bump.

branches: 1.17.2;
fix a very old resolver bug:

when looping over the current list of sockets we're connected to,
use getpeername() not getsockname() to find out who the remote
end is. avoid spurious close()s and (rare) failure.

apparently known as ISC bug #18625, and fixed in libbind 6.0

merge christos-time_t

branches: 1.15.4; 1.15.6; 1.15.8; 1.15.12;
- protect DEBUG again because we should be able to set it from the Makefile
- add a missing cast to pacify lint.

updates from bind-9-5-0

branches: 1.13.12;
Resolve conflicts.

Although we don't have a kqueue implementation yet, there is no point in
limiting the max fd in the poll case. Pointed out by Jan Schaumann, original
patch from FreeBSD/John Baldwin.

Fix minor compilation issues.

merge in resolver portion of bind-9.4.0-rc2

branches: 1.9.4; 1.9.6;
don't re-define DEBUG

A little libc namespace housekeeping exercise:
* Make vfprintf_unlocked() an internal function, c.f. __svfscanf_unlocked().
* Add internal names for arc4random(), endnetpath(), fhstatvfs(),
fstatvfs(), mkstemp(), shquote(), statvfs(), taddr2uaddr(), uaddr2taddr(),
uuid_create_nil(), uuid_is_nil(), and wcwidth().
* Include namespace.h where supposed to.

resolve conflicts.

disable weak aliases for now; the resolver header file adds __ to all the
names.

namespace protection for resolver routines.

netbsd rcsid.

more lint fixes.

- add casts to appease lint
- fix unreachable condition pointed out by lint.

branches: 1.1.1;
Initial revision

merge christos-time_t

branches: 1.7.8;
Remove clause 3 and 4 from TNF licenses

branches: 1.6.10;
merge in resolver portion of bind-9.4.0-rc2

branches: 1.5.10; 1.5.12;
Jump through taller hoops to provide binary compatibility with programs
compiled with the older and shorter _res. We now use _nres internally
which is the new and bigger one. We define a _res which is the old
size one if COMPAT__RES is set, and then we consult selected values from
this old _res in res_init(), to emulate the old behavior.

Do all the _res initialization in __res_get_state()

Provide access to _res in the non-threaded case, and abort in the threaded
case.

#ifdef protect __weak_alias

Add glue files.