Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.2.70; 1.2.72; 1.2.76;
RCS Id Police.

move the rpc code into libc

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

Add set_rpc_maxgrouplist

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

More cases to disable gcc-8 warnings only when we're using gcc>=8

Add -Wno-error for gcc-8 warnings

branches: 1.23.16;
- Provide multi-threaded fdset's for everyone not just rump if requested.
- Abstract fd_set access, and don't limit the fd_set size.
- Maintain binary compatibility by keeping the old global variables around.

remove various HAVE_GCC=45 fragments.

Don't depend on HAVE_GCC being always defined.

branches: 1.20.2;
Add documentation link xdr_sizeof(3) -> xdr(3)

Import xdr_sizeof() from FreeBSD

apply some -Wno-error and/or -fno-strict-aliasing.


all of this should be looked at closer, but some of them are not
very trivial.

branches: 1.17.4;
remove an unncessary .PATH element that doesn't exist (and never did?)

document svcudp_create

have __rpc_getxid.c

Move rpcb_prot.x to include/rpc instead.

Fix rpcb_prot.h target.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.11.2;
implement bindresvport_sa(), which is necessary for IPv6 support in certain
programs (like rshd or rlogind).

bindresvport() and bindresvport_sa() exhibits exactly the same functionality,
with different function prototype (sockaddr_in * and sockaddr *).

The behavior and prototype was discussed and agreed among shin@kame.net
(who is doing freebsd-current kame merge), deraadt@openbsd.org, and
Jean-Luc.Richier@imag.fr (INRIA IPv6/IPv6 RPC support). so it will be
portable across *bsd.

regsterrpc.3 -> registerrpc.3

add missing .Nm entries. from spz@serpens.swb.de.

branches: 1.8.10;
save my sanity; stop using Id.

specify man pages the new way.

fixes from Thomas Eberhardt <thomas@mathematik.uni-Bremen.de> to:
(1) don't clobber the MLINKS variable in rpc
(2) install the rand48 man page in stdlib

Change ``MAN3 = ...'' to ``MAN3 += ...'', so other manpages are built.

move the rpc code into libc

Add RCS identifiers.

include xdr_float & xdr_double with all the other rpc/xdr code in libc.a

cruel hack to get librpc contents into libc (for yp)

RCS Id Police.

move the rpc code into libc

fix nested extern warnings

use internal names for randomid()

use randomid(3). actually generate random ID for DNS queries (previous
fix was incomplete)

have __rpc_getxid.c

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.15.2;
Use C89 definitions
Remove use of __P

branches: 1.14.60; 1.14.62;
rename MAX_MARSHEL_SIZE to MAX_MARSHAL_SIZE

Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

constify some tables.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

use u_int32_t instead of size_t...

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.3.4;
save my sanity; stop using Id.

be much more careful with types, and add prototype everything.

move the rpc code into libc

fix nested extern warnings

Add set_rpc_maxgrouplist

src is too big these days to tolerate superfluous apostrophes. It's
"its", people!

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

fix error messages and warnings.

branches: 1.23.2;
Use C89 definitions
Remove use of __P

branches: 1.22.8; 1.22.10;
merge christos-time_t

branches: 1.21.8;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.20.24;
White space nit- don't put a space before/after increment/decrement
operators.

Merge the nathanw_sa branch.

branches: 1.18.2;
remove unnecessary casts to NULL

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.16.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

int -> uid_t, gid_t

constify some tables.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

use u_int32_t instead of size_t...

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix incorrect arguments in authunix_validate
Add prototypes
Fix gcc warnings
Fix RCSID's

pull in unistd.h for prototypes

branches: 1.3.2;
Add explict function return types

save my sanity; stop using Id.

branches: 1.1.4;
move the rpc code into libc

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.15.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.13.44; 1.13.46;
xdr sucks. sprinkle some (void *) casts into it's functions taking void **,
and shut up GCC4.

Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

xdrproc_t casts.

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.2.4;
save my sanity; stop using Id.

move the rpc code into libc

Remove workaround for ancient HTML generation code.

* Don't use the term "anonymous"; this is confusing.
* Mention "reserved", that's what it's stands for after all.
* Mention getsockname() to determine the assigned port in any case.

Use
.In header.h
instead of
.Fd #include \*[Lt]header.h\*[Gt]
Much easier to read and write, and supported by groff for ages.
Okayed by ross.

Merge the nathanw_sa branch.

Generate <>& symbolically.

Boring whitespace fixes.

branches: 1.8.2;
remove extra period in SEE ALL section

implement bindresvport_sa(), which is necessary for IPv6 support in certain
programs (like rshd or rlogind).

bindresvport() and bindresvport_sa() exhibits exactly the same functionality,
with different function prototype (sockaddr_in * and sockaddr *).

The behavior and prototype was discussed and agreed among shin@kame.net
(who is doing freebsd-current kame merge), deraadt@openbsd.org, and
Jean-Luc.Richier@imag.fr (INRIA IPv6/IPv6 RPC support). so it will be
portable across *bsd.

fix include file. bindresvport() is declared in rpc/rpc.h, not netinet/in.h.

add LIBRARY section to man page

* use setsockopt(IP_PORTRANGE_LOW) instead of looping through the
address range (from freebsd).
* enhance the man page to be a bit more useful.

add missing #; noted by Todd Miller

save my sanity; stop using Id.

move the rpc code into libc

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

branches: 1.23.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.21.56; 1.21.58;
Merge the nathanw_sa branch.

fix WARNS=2 (-Wshadow) warnings

branches: 1.19.2;
elide non-portable casts

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.17.2;
implement bindresvport_sa(), which is necessary for IPv6 support in certain
programs (like rshd or rlogind).

bindresvport() and bindresvport_sa() exhibits exactly the same functionality,
with different function prototype (sockaddr_in * and sockaddr *).

The behavior and prototype was discussed and agreed among shin@kame.net
(who is doing freebsd-current kame merge), deraadt@openbsd.org, and
Jean-Luc.Richier@imag.fr (INRIA IPv6/IPv6 RPC support). so it will be
portable across *bsd.

Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

int -> socklen_t

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

delint

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

* use setsockopt(IP_PORTRANGE_LOW) instead of looping through the
address range (from freebsd).
* enhance the man page to be a bit more useful.

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.6.2;
Add explict function return types

Fill in sin_len.

Changed bzero to memset.
Changed bcmp to memcmp.
Added #include <string.h> to bring prototypes into scope.

save my sanity; stop using Id.

branches: 1.2.2;
be much more careful with types, and add prototype everything.

move the rpc code into libc

fix nested extern warnings

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

branches: 1.24.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.22.6; 1.22.8;
indentation/whitespace

remove stray semicolon

sign-compare fixes

branches: 1.19.8; 1.19.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.18.16;
nuke useless perror

Coverity CID 3651: Don't leak ifaddrs on getaddrinfo failure.

Coverity CID 2283: Don't leak sys_auth on error.

- constify and remove __UNCONST from caller of clnt_call().
- use __UNCONST where approproate.

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

appease gcc -Wuninitialized

__RCSID police

use niels provos' random sequence number generator to initialize RPC XID.

Merge the nathanw_sa branch.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

Make this work in the !INET6 case -- if we mismatch the AF, don't return a
bogus (uninitialized) structure.
Also, ignore v4 ifa's with no broadcast address (rather than core dumping).

branches: 1.7.2;
fix WARNS=2 (-Wshadow) warnings

check pmap_flag before sendto.

missing space in a warning

branches: 1.4.2;
sprinkle _DIAGASSERT() appropriately. minor other cleanups

get prototypes from rpc/nettype.h
avoid non-portable casts
add explicit casts

branches: 1.2.4;
include <string.h> for mem* prototypes.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

fix nested extern warnings

s/begining/beginning/ in comments and messages.

s/succesful/successful/ in comment.

fix mainly same typos as in my previous commit but outside sys/dev/dm.

- add __clnt_sigfillset() that does not blindly block all signals but excludes
the tty generated ones (int, quit, tstp), plus term and hup. This makes
command line clients behave on connect(2) where before they would need
to be killed from a different tty. Much easier than making the file
descriptor non-blocking for the duration of connect and then using
pselect/pollts to detect when actual connection or timeout occured using
a different sigmask.
- factor out some of the error paths.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

branches: 1.26.2;
Use C89 definitions
Remove use of __P

branches: 1.25.2; 1.25.4;
various build fixes for gcc 4.5. from chuq. XXX i'm not sure all of
these work properly wtf pointer aliasing, but there are no casts at
least...

the lib/libpuffs/puffs_priv.h is definately a real bug fix.

from chuq.

branches: 1.24.4;
Use __isthreaded from reentrant.h and don't redeclare it.

sign-compare fixes

branches: 1.22.8; 1.22.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.21.10;
switch from kqueue() back to pollts() so that signals will be unblocked
while we're sleeping. keep the new timeout logic, though.
as discussed on source-changes some 15 months ago.

branches: 1.20.4;
- constify and remove __UNCONST from caller of clnt_call().
- use __UNCONST where approproate.

remove _REENTRANT bogus signal mask code; pointed out by chuq.

Use the kqueue(2) framework instead of the poll(2) system call to wait
for replies and timeouts in the conectionless (UDP) RPC client
code. Based on similar changes from FreeBSD in rev 1.15.

Reviewed by Christos Zoulas.

Fix build: maskp should be a pointer to a sigset_t. Hi, christos@!

PR/31264: Mark Davies: rup not interruptable
The cause of this is that in the re-entrant case we block all signals until
we timeout. Convert this to use pollts and then grab the pending signals
and sigsuspend them.
XXX: We should really convert this to use kqueue, like FreeBSD did.

use malloc rather than mem_alloc (which is implemented using calloc)
for receive/send buffers to avoid unnecessarily anonymous memory bloat.

branches: 1.14.2;
cast to socklen_t/size_t

-don't update the RPC server address with the reply's sender address;
this breaks server failover under some circumstances, and Solaris doesn't
seem to do it either
-minor cleanup
approved by fvdl

__RCSID police

use niels provos' random sequence number generator to initialize RPC XID.

add a missing release_fd_lock.

Merge the nathanw_sa branch.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.7.2; 1.7.4;
sprinkle _DIAGASSERT() appropriately. minor other cleanups

oops fix previous typos.

appease lint casts

Use explicit int32 get/put macros. Needed for 64bit big-endian systems.

remove register
adjust types to match functions
elide non-portable casts
cast to proper types

branches: 1.2.2; 1.2.4;
Get <string.h> so this builds on LP64.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

CID 975113: Ignore __rpc_setnodelay error, it is not fatal

CID 975112: Ignore bindresvport() return. This is can only succeed for root

branches: 1.31.4;
- add __clnt_sigfillset() that does not blindly block all signals but excludes
the tty generated ones (int, quit, tstp), plus term and hup. This makes
command line clients behave on connect(2) where before they would need
to be killed from a different tty. Much easier than making the file
descriptor non-blocking for the duration of connect and then using
pselect/pollts to detect when actual connection or timeout occured using
a different sigmask.
- factor out some of the error paths.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

branches: 1.28.2;
Use C89 definitions
Remove use of __P

branches: 1.27.4; 1.27.8; 1.27.24;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.26.18;
Centralize the TCP_NODELAY handling as discussed in tech-net.

use __UNCONST rather than having a writable string.

WARNS=4

cast to size_t/socklen_t

__RCSID police

Merge the nathanw_sa branch.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.19.2; 1.19.4;
sprinkle _DIAGASSERT() appropriately. minor other cleanups

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

The two unchanged interfaces (svc_create and clnt_create) resulted
in sockets bound to reserved ports in the old code. Since old binaries
will still expect this, always try to bind to a reserved port in
clnt_cli_create and svc_tli_create, unless we're already bound.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.15.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

delint:
- memmove -> memcpy
- check that we don't get a bogus h->h_length

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.6.4;
Fill in sin_len.

Changed bzero to memset.
Changed bcmp to memcmp.
Added #include <string.h> to bring prototypes into scope.

save my sanity; stop using Id.

RPCSRC 4.0, which our RPC implementation is derrived from, erroneously
sets a default timeout of 25 seconds in clnt_create(). This bug causes
timeouts specified as the last argument to clnt_call to be ignored.
With this fix, timeouts will be taken from clnt_call() unless the
program sets its own default timeout with clnt_control().

should bzero automatic sockaddr's before use

move the rpc code into libc

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.29.2;
Use C89 definitions
Remove use of __P

branches: 1.28.4; 1.28.8; 1.28.24;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.27.18;
rpc_errlist:
- add some missing error numbers.
- while i'm here, use c99 initializer.
clnt_sperrno:
- handle NULL in rpc_errlist as it's now sparse.

WARNS=4

change 'char *' args of clnt_pcreateerror, clnt_spcreateerror,
clnt_perror, and clnt_sperror to 'const char *' to follow manual
pages (!!).

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.23.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

fix use of uninitialized "buflen" (botched in 1.18), closes PR lib/9104
by bgrayson@ece.utexas.edu

Fix incorrectly initialized value from _DIAGASSERT() changes.

branches: 1.20.2;
back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

since clnt_p*error() are expected to print an error message, print one if they're called with dodgy args. ;)

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

int -> size_t

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

delint

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix printf format strings.
Fix RCSID's
Fix gcc warnings
Add missing prototypes

- convert unsafe strcpy(), strcat() and sprintf() to the `n' versions.
- some KNF.

branches: 1.8.2;
Changed clnt_{s,}p{errno,error,createerror} so that the functions that
output emit newlines and those that return a pointer to string do not
append them.

The existing behavior was inherited from RPC4.0, but this seems to have
been corrected sometime before SunOS 4.1.

The documentation has been updated to reflect the new behavior.

fix typo(?): rpc__errlist usage shouldn't have had two underscores.
Also, cast return types to (char *) to quiet compiler's complaints about
loss of 'const'-ness.

Changed auth_errmsg() and clnt_sperrno() to access error messages
directly instead of by linear search.

save my sanity; stop using Id.

Added \n to end of format strings used by all the perror-like functions.
Added const qualifier to array of error strings.

be much more careful with types, and add prototype everything.

Don't bother checking if errno is in range --- strerror() already does
that.

move the rpc code into libc

fix nested extern warnings

- Use -1 for the fake raw fd since we will be able to go beyond FD_SETSIZE.
- Poster boy for why it is bad to initialize in declarations :-)

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

fix error messages and warnings.

branches: 1.30.2;
Use C89 definitions
Remove use of __P

branches: 1.29.4; 1.29.8; 1.29.24;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.28.18;
- constify and remove __UNCONST from caller of clnt_call().
- use __UNCONST where approproate.

Fix typo reported in PR 30872.

use malloc rather than mem_alloc (which is implemented using calloc)
for receive/send buffers to avoid unnecessarily anonymous memory bloat.

branches: 1.25.2;
cast to size_t
remove unneeded casts.

Merge the nathanw_sa branch.

fix WARNS=2 (-Wshadow) warnings

branches: 1.22.2;
oops fix previous typos.

appease lint casts

remove dedundant declaration of _svc_getreq_common; declared in <rpc/svc.h>

Use explicit int32 get/put macros. Needed for 64bit big-endian systems.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.17.2;
Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.16.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

avoid potential buffer overflow and alignment problem that was caused
by casting a char[24] array to struct rpc_msg (sizeof(struct rpc_msg) == 48)
on i386. Use a union instead.

constify some tables.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

use u_int32_t instead of size_t...

use u_int instead of size_t in clntraw_control (oops!)

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

a memory leak can occur when xdr_replymesg() fails, so XDR_FREE in
this case. originally fixed in freebsd in clnt_udp.c, and similar
change to clnt_raw.c made by openbsd.

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.3.4;
save my sanity; stop using Id.

be much more careful with types, and add prototype everything.

move the rpc code into libc

Fix non _REENTRANT build.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.31.2;
Use C89 definitions
Remove use of __P

branches: 1.30.6; 1.30.8;
Use __isthreaded from reentrant.h and don't redeclare it.

fix typo.

use FD_CLOEXEC instead of 1.

- constify and remove __UNCONST from caller of clnt_call().
- use __UNCONST where approproate.

WARNS=4

Don't use NULL to compare against a character.

__RCSID police

Merge the nathanw_sa branch.

branches: 1.22.2;
sprinkle _DIAGASSERT() appropriately. minor other cleanups

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.19.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it, or they didn't use CLNT_DESTROY()

fixes a couple of unnecessary closing of already-closed sockets.
noted by: Matthias Drochner <M.Drochner@fz-juelich.de>

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

delint:
- memmove -> memcpy
- check that we don't get a bogus h->h_length

KNF.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

- convert unsafe strcpy(), strcat() and sprintf() to the `n' versions.
- some KNF.

branches: 1.6.2;
Add explict function return types

Fill in sin_len.

Changed bzero to memset.
Changed bcmp to memcmp.
Added #include <string.h> to bring prototypes into scope.

save my sanity; stop using Id.

branches: 1.2.4;
should bzero automatic sockaddr's before use

move the rpc code into libc

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.21.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it, or they didn't use CLNT_DESTROY()

fixes a couple of unnecessary closing of already-closed sockets.
noted by: Matthias Drochner <M.Drochner@fz-juelich.de>

xdrproc_t casts.

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

Use a union again to make sure that we are aligned; this is not necessary
in this case, but makes the code easier to read, and avoids lint warnings.

constify some tables.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

use u_int32_t instead of size_t...

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix uninitialized variable free on error.
Add prototypes
Fix RCSID's
Fix gcc warnings.

It's not necessary to initialize the `revents' field of struct pollfd.

unistd.h for prototypes

use poll() instead of select()

branches: 1.4.4;
save my sanity; stop using Id.

branches: 1.3.2;
be much more careful with types, and add prototype everything.

branches: 1.2.2;
rpc library no longer uses _rpc_dtablesize() internally -- keeps track
of highest active file descriptor. limit fd usage to FD_SETSIZE, until
a better solution is found. remove non-FD_SETSIZE code.

move the rpc code into libc

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.21.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

int -> socklen_t

* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it, or they didn't use CLNT_DESTROY()

fixes a couple of unnecessary closing of already-closed sockets.
noted by: Matthias Drochner <M.Drochner@fz-juelich.de>

* ensure memory is released if operations fail (in authunix_create(),
xdr_callmsg(), xprt_register(), svc_tcp(), svc_udp(), etc)
* don't attempt to close a socket filedescriptor if it's -1 (some from
freebsd, some i found)
* make the initial xid a little more random (from freebsd)
* fix some spelos and tyops in comments (some from freebsd)
* use warn() instead of warnx() for many errors; the user probably
wants to know what the error code was.
* knf & whitespace nitpicks

Restructure the send and recv buffers slightly to avoid lint warnings and
make their treatment symmetric.

constify some tables.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

use u_int32_t instead of size_t...

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

a memory leak can occur when xdr_replymesg() fails, so XDR_FREE in
this case. originally fixed in freebsd in clnt_udp.c, and similar
change to clnt_raw.c made by openbsd.

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

It's not necessary to initialize the `revents' field of struct pollfd.

use poll() instead of select()

branches: 1.4.4;
save my sanity; stop using Id.

branches: 1.3.2;
be much more careful with types, and add prototype everything.

branches: 1.2.2;
rpc library no longer uses _rpc_dtablesize() internally -- keeps track
of highest active file descriptor. limit fd usage to FD_SETSIZE, until
a better solution is found. remove non-FD_SETSIZE code.

move the rpc code into libc

fix nested extern warnings

s/begining/beginning/ in comments and messages.

fix mainly same typos as in my previous commit but outside sys/dev/dm.

Fix non _REENTRANT build.

Increment to the value, not the pointer. (Thorsten Brehm)

Avoid casting gymnastics that lead to pointer aliasing by introducing an
inline function.

- add __clnt_sigfillset() that does not blindly block all signals but excludes
the tty generated ones (int, quit, tstp), plus term and hup. This makes
command line clients behave on connect(2) where before they would need
to be killed from a different tty. Much easier than making the file
descriptor non-blocking for the duration of connect and then using
pselect/pollts to detect when actual connection or timeout occured using
a different sigmask.
- factor out some of the error paths.

PR/47747: Thorsten Brehm: TCP-based RPC client calls no longer terminate when
connections break. Return proper error code.
XXX: pullup 6

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

PR/13082: Thorsten Brehm: Fix wrong memcpy that caused possible memory
corruption. XXX: pullup to 6.

branches: 1.18.2;
PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.17.6; 1.17.8; 1.17.12;
Use __isthreaded from reentrant.h and don't redeclare it.

Enable assertions only when _DIAGNOSTICS is defined, as other libc parts do.

branches: 1.15.8; 1.15.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.14.18;
fix some unpaired sigblocks which possibly leave the process with all
signals blocked,
this might some problems with the Gnome GUI which uses RPC to communicate
with "fam" (file access monitor), in particular it might fix PR pkg/22483
by jmmv

- constify and remove __UNCONST from caller of clnt_call().
- use __UNCONST where approproate.

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

branches: 1.11.2; 1.11.4;
add size_t casts.

use niels provos' random sequence number generator to initialize RPC XID.

Merge the nathanw_sa branch.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.7.2; 1.7.4;
sprinkle _DIAGASSERT() appropriately. minor other cleanups

oops fix previous typos.

appease lint casts

Use explicit int32 get/put macros. Needed for 64bit big-endian systems.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.2.2; 1.2.4;
Get <string.h> so this builds on LP64.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.11.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

branches: 1.3.2;
1) Agree with kernel on format of SIOCGIFCONF results.
2) Return non-zero on error, so RPC clients do not die unexpectedly.

save my sanity; stop using Id.

branches: 1.1.4;
move the rpc code into libc

Use
.In header.h
instead of
.Fd #include \*[Lt]header.h\*[Gt]
Much easier to read and write, and supported by groff for ages.
Okayed by ross.

Merge the nathanw_sa branch.

Fn arguments do not need (empty) braces.

Add description of struct netconfig.
This adresses PR lib/18501 by Benedikt Meurer

While here, finish mdocifying of the manpage. There is no .B, .I, .SB
in mdoc, and some items were missing in output due to that.

Generate <>& symbolically.

netconfig(5), not (4), and whitespace fixes.

branches: 1.1.2; 1.1.4; 1.1.6;
Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

Revert previous since it causes a double free (p->nc_netid == tmp == tmp2).
From Xin Li @ FreeBSD.
XXX: pullup 7

PR/51578: Henning Petersen: Fix leak on error.

KNF, no real change (except malloc(x * y) -> calloc(x, y))

branches: 1.22.2;
make more descriptors that we open as close-on-exec

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.20.2;
Use C89 definitions
Remove use of __P

branches: 1.19.2; 1.19.4;
close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

Use __isthreaded from reentrant.h and don't redeclare it.

branches: 1.17.8;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.16.10;
Remove more duplicate #includes, and a few spurious whitespaces at EOL
From Slava Semushin <slava.semushin@gmail.com>

Coverity CID 2275: Avoid memory leak on error.

WARNS=4

Make the arg to getnetconfigent const char * to match the man page (and
likely calling code).

__RCSID police

The second parameter of strchr() is an integer, not a pointer.
So use '\0' instead of NULL.

Merge the nathanw_sa branch.

Fix signed/unsigned comparison warnings.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.7.2;
Various typos in comments (neccessary, sceme, choise, ...).

branches: 1.6.2;
make local constant arrays const

whitespace consistency fixups

sprinkle _DIAGASSERT() appropriately. minor other cleanups

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

PR/10499: IWAMOTO Toshihiro: getnetconfig uses strtok. Applied suggested patch
to use strtok_r

branches: 1.1.2; 1.1.4;
Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

getnetpath(3): Sprinkle some markup

Use
.In header.h
instead of
.Fd #include \*[Lt]header.h\*[Gt]
Much easier to read and write, and supported by groff for ages.
Okayed by ross.

Merge the nathanw_sa branch.

New sentence, new line. From Robert Elz.

Generate <>& symbolically.

netconfig(5), not (4); environ(7), not (5); whitespace, and use
.Dq instead of ``xx.''

branches: 1.1.2; 1.1.4; 1.1.6;
Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

s/compnent/component/

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.16.2;
Update old-style definitions to ANSI, remove a couple of register
definitions along the way. Fixed gcc 4.1 build (thank you vax)

Use C89 definitions
Remove use of __P

branches: 1.14.2; 1.14.6; 1.14.22;
Coverity CID 5028: Fix memory leak.

branches: 1.13.2;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.12.10;
Compile with DIAGNOSTIC

Remove more duplicate #includes, and a few spurious whitespaces at EOL
From Slava Semushin <slava.semushin@gmail.com>

Coverity CID 2276: Don't leak memory on error.

A little libc namespace housekeeping exercise:
* Make vfprintf_unlocked() an internal function, c.f. __svfscanf_unlocked().
* Add internal names for arc4random(), endnetpath(), fhstatvfs(),
fstatvfs(), mkstemp(), shquote(), statvfs(), taddr2uaddr(), uaddr2taddr(),
uuid_create_nil(), uuid_is_nil(), and wcwidth().
* Include namespace.h where supposed to.

__RCSID police

Merge the nathanw_sa branch.

Make sure we don't look before the beginning of the string.
from xs@kittenz.org

branches: 1.5.2;
whitespace consistency fixups

sprinkle _DIAGASSERT() appropriately. minor other cleanups

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.2.2; 1.2.4;
syslog an error if /etc/netconfig is not found. fixes lib/10275

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

Sections 2 and 3 have RETURN VALUES, not DIAGNOSTICS

Bump date for const change.

* add const qualifier making getrpcbyname() and getrpcbyname_r()
prototypes match those used in latest Sun RPC code (TI-RPC 2.3)
* modify function getrpcbyname() definition as appropriate

Use
.In header.h
instead of
.Fd #include \*[Lt]header.h\*[Gt]
Much easier to read and write, and supported by groff for ages.
Okayed by ross.

Merge the nathanw_sa branch.

New sentence, new line. From Robert Elz.

Generate <>& symbolically.

Sort sections.

Boring whitespace fixes.

branches: 1.6.12;
add LIBRARY section to man page

<netdb.h> -> <rpc/rpc.h>

fix pasto (s/getpwent/getrpcent/); from Tobias Weingartner

alternate -> alternative, per PR 2643

save my sanity; stop using Id.

move the rpc code into libc

pass dest buffer size to strncpy() and ensure nul termination.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.22.2; 1.22.4; 1.22.8;
close on exec fixes:
- open + fcntl -> open O_CLOEXEC
- configuration database file descriptors that can stay open are now opened
fopen(db, "re")

* add const qualifier making getrpcbyname() and getrpcbyname_r()
prototypes match those used in latest Sun RPC code (TI-RPC 2.3)
* modify function getrpcbyname() definition as appropriate

Use ANSI function decls.

Fix getrpcbyname() alias lookups. Closes PR lib/23294; reviewed by <christos>.

branches: 1.18.6;
whitespace consistency fixups

Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

Declare more local items static.

delint

const poisoning.

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

Make sure /etc/rpc is *closed* when we're done.

pull in netdb.h and arpa/inet.h, kill local decls. add interpret() proto

branches: 1.4.4;
save my sanity; stop using Id.

be much more careful with types, and add prototype everything.

Kill the YP code.

branches: 1.1.2;
move the rpc code into libc

Merge the nathanw_sa branch.

New sentence, new line. From Robert Elz.

branches: 1.3.12;
add LIBRARY section to man page

save my sanity; stop using Id.

move the rpc code into libc

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.17.2;
Use C89 definitions
Remove use of __P

branches: 1.16.64; 1.16.66;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

delint:
- memmove -> memcpy
- check that we don't get a bogus h->h_length

* in get_myaddress(); always return sockaddr_in containing localhost:PMAP_PORT.
(as recommended in Weiste Venema's portmap5_beta distribution)
* deprecate register
* use memmove instead of bcopy
* KNF includes
* use err/warn() instead of perror/fprintf(stderr,)
* fix some typos

revert; we can't break the existing ABI and API

major cleanup (to sync with changes made in include/rpc/*.h):
* use int32_t, size_t, in_port_t instead of long, u_int, u_short as appropriate
* use uid_t and gid_t instead of int
* KNF, fix typos and spellos
* use const as appropriate
* deprecate register
* use memmove instead of bcopy
* use err/warn()

If port provides __weak_alias(), provide an Standard C and POSIX pure
identifier namespace by renaming non standard functions and variables
such that they have a leading underscore. The library will use those
names internally. Weak aliases are used to provide the original names
to the API.

This is only the first part of this change. It is most of the functions
which are implemented in C for all NetBSD ports. Subsequent changes are
to add the same support to the remaining C files, to assembly files, and
to the automagically generated assembly source used for system calls.
When all of the above is done, ports with weak alias support should add
a definition for __weak_alias to <sys/cdefs.h>.

Fix RCSID's
Fix gcc warnings.
Add missing prototypes

pull in rpc/pmap_clnt.h for protos

branches: 1.6.2;
Add explict function return types

Fill in sin_len.

Changed bzero to memset.
Changed bcmp to memcmp.
Added #include <string.h> to bring prototypes into scope.

save my sanity; stop using Id.

should bzero automatic sockaddr's before use

move the rpc code into libc

Use C89 definitions
Remove use of __P

branches: 1.8.6;
Use __isthreaded from reentrant.h and don't redeclare it.

branches: 1.7.8;
Remove clause 3 and 4 from TNF licenses

- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.5.18;
Need to give the various rpc locks private names (prefixing them with
__rpc_). Rather than scattering changes around the 3rd-party RPC
code, place them in namespace.h.

branches: 1.4.2;
PR/25003: John Kohl: File is missing a copyright.

__RCSID police

Merge the nathanw_sa branch.

branches: 1.1.4; 1.1.6;
Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

fix nested extern warnings

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

branches: 1.18.56; 1.18.58; 1.18.62;
Merge the nathanw_sa branch.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.16.2; 1.16.4;
add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

branches: 1.14.2;
Delint.
Remove trailing ; from uses of __weak_alias(). The macro inserts this if
needed.

Use TCP to register RPC services with the portmapper.
This has the advantage that we get an immediate error in case of
network problems (loopback, actually) instead of a nasty timeout.

* don't close the socket unless it was opened by the function
* note (in the comments) that the client is responsible for closing
the socket if they opened it, or they didn't use CLNT_DESTROY()

fixes a couple of unnecessary closing of already-closed sockets.
noted by: Matthias Drochner <M.Drochner@fz-juelich.de>