Home | History | Annotate | Download | only in libtelnet
History log of /src/lib/libtelnet/encrypt.c
RevisionDateAuthorComments
 1.20  29-Oct-2024  kre PR bin/58787 libtelnet - avoid using a global variable

From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
 1.19  23-Feb-2022  andvar branches: 1.19.2; 1.19.4;
fix various typos in comments, mainly immediatly/immediately/,
as well shared and recently fixed typos in OpenBSD code by Jonathan Grey.
 1.18  05-Jan-2019  maya branches: 1.18.2;
Match the function prototype of encrypthandler instead of casting to it.
Make GCC 9 snapshot happier with the code

While here, remove unnecessary braces around return (KNF).
 1.17  21-Mar-2012  matt branches: 1.17.30; 1.17.32;
Use C89 functions definitions.
Remove use of __P
 1.16  09-Jan-2012  christos PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- minimal fixes to compile with WARNS=4
- separate kerberos (USE_KERBEROS) from encryption (MKCRYPTO)
 1.15  23-Dec-2011  christos Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.14  17-Jan-2007  hubertf branches: 1.14.18; 1.14.22; 1.14.26; 1.14.34;
Remove more duplicate #includes, and a few spurious whitespaces at EOL
From Slava Semushin <slava.semushin@gmail.com>
 1.13  06-Feb-2005  perry branches: 1.13.10; 1.13.14;
de-__P (really de-P)
 1.12  07-Aug-2003  agc Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.
 1.11  15-Jul-2003  itojun use bounded string op
 1.10  20-Jan-2003  simonb The Double-Semi-Colon Police.
 1.9  26-May-2002  wiz __STDC__ is always defined on NetBSD.
 1.8  06-Jan-2001  christos eliminate redundant decls.
 1.7  22-Jun-2000  thorpej Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.
 1.6  27-Feb-1998  christos branches: 1.6.10;
WARNSify and RCSID cleanups
 1.5  09-Oct-1997  lukem WARNSify
 1.4  24-Feb-1996  jtk update libtelnet with changes through 95.10.23 version
 1.3  25-Feb-1994  cgd new libtelnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...
 1.2  01-Aug-1993  mycroft Add RCS identifiers.
 1.1  21-Mar-1993  cgd branches: 1.1.1;
Initial revision
 1.1.1.1  21-Mar-1993  cgd initial import of 386bsd-0.1 sources
 1.6.10.2  05-Apr-2001  he Pull up revision 1.8 (requested by assar):
Upgrade Heimdal to version 0.3e.
 1.6.10.1  22-Jun-2000  thorpej Update from trunk:
Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.
 1.13.14.1  31-Dec-2011  snj Pull up following revision(s) (requested by christos in ticket #1440):
lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.13.10.1  31-Dec-2011  snj Pull up following revision(s) (requested by christos in ticket #1440):
lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.14.34.1  17-Apr-2012  yamt sync with head
 1.14.26.1  31-Dec-2011  snj Pull up following revision(s) (requested by christos in ticket #1704):
lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.14.22.1  31-Dec-2011  snj Pull up following revision(s) (requested by christos in ticket #1704):
lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.14.18.1  31-Dec-2011  snj Pull up following revision(s) (requested by christos in ticket #1704):
lib/libtelnet/encrypt.c: revision 1.15
Avoid buffer overflow, reported by Colin Percival at FreeBSD
 1.17.32.1  10-Jun-2019  christos Sync with HEAD
 1.17.30.1  18-Jan-2019  pgoyette Synch with HEAD
 1.18.2.1  18-Nov-2024  martin Pull up following revision(s) (requested by riastradh in ticket #1927):

lib/libtelnet/encrypt.h: revision 1.10
libexec/telnetd/telnetd.c: revision 1.59
libexec/telnetd/sys_term.c: revision 1.50
lib/libtelnet/encrypt.c: revision 1.20
lib/libtelnet/enc_des.c: revision 1.18
lib/libtelnet/enc-proto.h: revision 1.11
libexec/telnetd/state.c: revision 1.33
libexec/telnetd/state.c: revision 1.35
libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787 libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787 telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet
 1.19.4.1  02-Aug-2025  perseant Sync with HEAD
 1.19.2.1  18-Nov-2024  martin Pull up following revision(s) (requested by riastradh in ticket #1013):

lib/libtelnet/encrypt.h: revision 1.10
libexec/telnetd/telnetd.c: revision 1.59
libexec/telnetd/sys_term.c: revision 1.50
lib/libtelnet/encrypt.c: revision 1.20
lib/libtelnet/enc_des.c: revision 1.18
lib/libtelnet/enc-proto.h: revision 1.11
libexec/telnetd/state.c: revision 1.33
libexec/telnetd/state.c: revision 1.35
libexec/telnetd/telnetd.c: revision 1.60

Fix memory leak - free resources allocated by getaddrinfo

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)
Thanks christos@ for the review
PR bin/58787 libtelnet - avoid using a global variable


From RVP -- make 'encrypt_debug_mode' be a static (file scope)
variable instead of extern, and convert the (had been recently
anyway) unused function encrypt_debug() into an accensor function
for it.

This is the minor (almost irrelevant) change from PR bin/58787
PR bin/58787 telnetd - handle auto authentication better
Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from

https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

RSS XML Feed