add LIBKRB5_LDADD/LIBKRB5_DPADD and their static counterparts
to bsd.prog.mk. use them instead of hard coding various lists
of libraries for krb5.

this fixes static builds.

We need authentication || encryption even when we are not building
kerberos. They are needed for telnet_net_write() which is used in libtelnet.

Remove MKCRYPTO option.

Originally, MKCRYPTO was introduced because the United States
classified cryptography as a munition and restricted its export. The
export controls were substantially relaxed fifteen years ago, and are
essentially irrelevant for software with published source code.

In the intervening time, nobody bothered to remove the option after
its motivation -- the US export restriction -- was eliminated. I'm
not aware of any other operating system that has a similar option; I
expect it is mainly out of apathy for churn that we still have it.
Today, cryptography is an essential part of modern computing -- you
can't use the internet responsibly without cryptography.

The position of the TNF board of directors is that TNF makes no
representation that MKCRYPTO=no satisfies any country's cryptography
regulations.

My personal position is that the availability of cryptography is a
basic human right; that any local laws restricting it to a privileged
few are fundamentally immoral; and that it is wrong for developers to
spend effort crippling cryptography to work around such laws.

As proposed on tech-crypto, tech-security, and tech-userlevel to no
objections:

https://mail-index.netbsd.org/tech-crypto/2017/05/06/msg000719.html
https://mail-index.netbsd.org/tech-security/2017/05/06/msg000928.html
https://mail-index.netbsd.org/tech-userlevel/2017/05/06/msg010547.html

P.S. Reviewing all the uses of MKCRYPTO in src revealed a lot of
*bad* crypto that was conditional on it, e.g. DES in telnet... That
should probably be removed too, but on the grounds that it is bad,
not on the grounds that it is (nominally) crypto.

kerberos needs sqlite3

branches: 1.49.2; 1.49.8; 1.49.14; 1.49.18; 1.49.20; 1.49.22; 1.49.26; 1.49.28;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

branches: 1.48.4;
We no longer need -I/usr/include/krb5.

Upgrade Heimdal to 1.5pre1 by switching the build from crypto/dist/heimdal
to crypto/external/bsd/heimdal. The latter was just imported as the head
of the Heimdal tree as of a few days ago.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Default to WARNS=4
Exceptions that need a lower level are:
getty ld.elf_so lfs_cleanerd makewhatis telnetd tftpd
hpropd ipropd-master ipropd-slave kadmind kpasswdd

branches: 1.44.28;
Goodbye KerberosIV

Add -lcrypt to link lines for applications using -lkrb5, so that they
link successfully when MKPIC=no, as is always the case for our ports
which do not support shared libraries.

Discussed with thorpej and christos.

Introduce PAM_STATIC_LDADD and PAM_STATIC_DPADD. When compiling
with MKPIC=no, possibly because the target does not support shared
libraries, these include libraries required to resolve all symbols
which end up referenced from PAM-using applications. The libraries
presently required are -lcrypt, -lrpcsvc and -lutil.

Add use of these variables which are currently set up to use PAM,
so that they compile when MKPIC=no.

Also, in the telnetd case, reorder the order of the libraries, so
that libtelnet.a comes before -ltermcap and -lutil, again to fix
link error when MKPIC=no.

Discussed with thorpej and christos.

Add pam glue.

Move linking with libdes to the common kerberos section since
libtelnet depends on the old des functions.

From Jukka Salmi in NetBSD pr misc/28727

rearrange lib stuff so that these link on non-shared-lib platforms.

Fix the checkflist for builds without Kerberos 4 (MKKERBEROS4=no)
and without Kerberos 4 & 5 (MKKERBEROS=no). Previously checkflist
complained of missing files.

* move kerberos- and kerberos 4-only files into new flists,
distrib/sets/lists/*/krb.*

* make the flist generators grok MKKERBEROS{,4} variables

* fix Makefiles which treat MKKERBEROS=no as MKKERBEROS5=no.
9 out of 10 experts agree that it is ludicrous to build w/
KERBEROS4 and w/o KERBEROS5.

* fix header files, also, which treat MKKERBEROS=no as MKKERBEROS5=no.

* omit some Kerberos-only subdirectories from the build as
MKKERBEROS{,4} indicate

(I acknowledge the sentiment that flists are the wrong way to go,
and that the makefiles should produce the metalog directly. That
sounds to me like the right way to go, but I am not prepared to do
revamp all the makefiles. While my approach is expedient, it fits
painlessly within the current build architecture until we are
delivered from flist purgatory, and it does not postpone our
delivery. Fair enough?)

libkrb depend on libdes
libkrb5 depends on libasn1 and libcrypto

split MKKERBEROS4 from MKKERBEROS. based on work by lha at stacken.kth.se
(build confirmed with both MKKERBEROS4=yes and MKKERBEROS4=no)

stop installing install libtelnet. build under lib/libtelnet and reference
it from usr.bin/telnet and libexec/telnetd.
(reason for separate build: compiler flags)

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

PR/17999: FUKAUMI Naoki: Support wtmpx entries.

Use ${NETBSDSRCDIR}/some/path instead of ${.CURDIR}/../../some/path

Split the notion of building Hesiod, Kerberos, S/key, and YP
infrastructure and using that infrastructure in programs.

* MKHESIOD, MKKERBEROS, MKSKEY, and MKYP control building
of the infratsructure (libraries, support programs, etc.)

* USE_HESIOD, USE_KERBEROS, USE_SKEY, and USE_YP control
building of support for using the corresponding API
in various libraries/programs that can use it.

As discussed on tech-toolchain.

${MAKE} print-objdir -> ${PRINTOBJDIR}

Remove direct calls to "make" and replace with ${MAKE}

forced: previous was really: remove libvers, it's not being used

link against the not-installed libvers

update build infrastructure for heimdal 0.3a

Add MK... variables to enable/disable various aspects of building
crypto support into the system. See share/mk/bsd.README for more
a full description.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.23.2;
Merge a bunch of things from crypto-us and crypto-intl into basesrc,
adding support for Heimdal/KTH Kerberos where easy to do so. Eliminate
bsd.crypto.mk.

There is still a bunch more work to do, but crypto is now more-or-less
fully merged into the base NetBSD distribution.

branches: 1.22.6;
optionally include CRYPTOPATH Makefile.frag files.

Use bsd.crypto.mk.

dual-stack telnetd.

Treat crypto-us like domestic.

Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
not SecurID

Descend on obj, as well as clean, cleandir, etc.

distclean is a synonym for cleandir

Fix for pr 5904 from Zdenek Salvet; we now use openpty() to get a pty.

Ack! I misunderstood a problem reported to me. We don't need to do
anything special to handle obj directories; bsd.man.mk does it for us
already. Back out that part of the previos commit.

Fix two problems with my previous change:

- We must include bsd.own.mk to get EXPORTABLE_SYSTEM from mk.conf.
Noted by Bernd Ernesti.
- If we're only generating man pages, we should deal with obj
directories as appropriate. Both Perry Metzger and I found this
independently.

This completes the tasks necessary to close PR 5519.

Unlike other domestic bits, telnet and telnetd are never built as a part
of the domestic build process. No domestic program actually builds its
own man pages but instead relies on those built in the exportable tree.
The result is missing telnet(1) and telnet(8) pages.

Fix this problem descending into the telnet and telnetd directories
regardless of whether we're doing an exportable build or not. Once there,
we generate only the man pages if we're building a non-exportable system.

use CPPFLAGS instead of CFLAGS

branches: 1.10.2;
add commented CFLAGS for AUTHENTICATION, remove list of crypto files

merge lite-2 Makefiles (rcsids), and turn on WARNS for all of libexec.

WARNS?=1. RCS ids.

- Makefile cleanups

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

specify man pages the new way.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.6.4;
(net_write): rename to telnet_net_write

kill old-style getenv() declaration

WARNS?=1. RCS ids.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

branches: 1.1.1;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Various typo fixes from Jonathon Gray via jmc@openbsd.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

select() -> poll()

__STDC__ is always defined on NetBSD.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Symmetric has one s and two m's.

Buffer overflow and environment passing fixes [originally inspired from
FreeBSD]. We really didn't need the environment fixes, but for the sake
of keeping the code as close as possible...

Need <time.h> for various definitions, so just include it in this one place.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add new uname() cookies like getty.
(I had thought telnetd spawned a getty. Sigh.)

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Don't play #define games with extern, just have a separate list to avoid commons

Use __dead

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

branches: 1.20.42;
Remove static local variable so its easier to correctly use strlcpy.

branches: 1.19.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.18.2; 1.18.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Add extern before terminaltype. (Definition is in global.c via
`#define extern' and `#include <ext.h>'.)
Last part of bin/13667 by Brian Ginsbach.

Move #endif so that inclusion of libtelnet/auth.h and
libtelnet/encrypt.h do not depend upon DEFAULT_IM being undefined.
From bin/13667 by Brian Ginsbach.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.10.4;
Make 'if' capability from gettytab work. *shudder*.

Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
not SecurID

startslave() prototype is independent of AUTHENTICATION

WARNS?=1. RCS ids.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add new uname() cookies like getty.
(I had thought telnetd spawned a getty. Sigh.)

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Don't play #define games with extern, just have a separate list to avoid commons

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

WARNS?=1. RCS ids.

RCS id cosmetics.

RCS Id Police

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

s/varaible/variable/ and s/varible/variable/ in comments.

fix spelling of accommodate; from Zapher.

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

use snprintf

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

Spell 'occurred' with two 'r's.

fix redundant declarations.

bzero->memset, bcopy->memcpy, bcmp->memcmp

kill some excess whitespace

WARNS?=1. RCS ids.

RCS id cosmetics.

RCS Id Police

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

PR bin/58787 telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

branches: 1.34.2;
fix various typos in comments and log messages.

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)

Thanks christos@ for the review

branches: 1.32.2;
s/fist/first/

branches: 1.31.2;
- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.30.14;
acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

branches: 1.29.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

Grammar and spelling fixes, mainly in comments. A few in documentation,
logging, test description, and SCSI ASC/ASCQ assignment descriptions.

PR bin/58787 telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

branches: 1.49.8; 1.49.10;
telnetd: Stop defining the same variables concurrently in bss and data

auth_level and require_secure_login were defined in two places:

- global.c that picked it from headers and removed 'extern'
- telnetd.c that initialized it to 0

line was defined twice: in global.c and sys_term.c with a non-zero value.
Remove the definition and initialization from sys_term.c and initialize
the variable early in main().

Detected during the build of telned with Address Sanitizer (MKSANITIZER).

Reviewed by <mrg>

branches: 1.48.2;
Remove unused macros.

branches: 1.47.26; 1.47.28;
fix wrong variable check, remove casts
http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html

Only include the headers we use and remove useless variable.

branches: 1.45.6;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

branches: 1.44.34;
Remove duplicated #includes and some trailing whitespace while here.
From Slava Semushin <slava.semushin@gmail.com>

use _PATH_DEV instead of "/dev/"

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Pass -a [srrvis'd struct sockaddr] to login, so that login can record the
address where we have logged in from.

realloc pedannt

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

more cleanups

remove unused function
XXX what's the difference between #ifdef UTMPX and #ifdef SUPPORT_UTMPX

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

use bounded string op (there still are remains)

use strlcpy. minor style fixes

add some more ifdefs, so that we don't define variables we don't use.

PR/17999: FUKAUMI Naoki: Support wtmpx entries.

Fix #ifdef indentation after recent removal of #ifdef NEWINIT-code.
Patch by Brian Ginsbach.

Remove code #ifdef'd on NEWINIT (never used on NetBSD).
Sync with Cray, patch by Brian Ginsbach in private mail.

Cray-only patch (sync with cray). Patch by Brian Ginsbach in private mail.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Rename variable to avoid shadowing.

Improve whitespace a bit, per bin/13667 by Brian Ginsbach.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Fix type of last execl argument, inspired by bin/13667.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

use LOG_ERR for fatal errors, LOG_WARNING for other errors
minor knf
deprecate LOG_ODELAY; it's the default

(scrub_env): change to only accept a listed set of variables,
including only non-filename contents for TERMCAP

Buffer overflow and environment passing fixes [originally inspired from
FreeBSD]. We really didn't need the environment fixes, but for the sake
of keeping the code as close as possible...

branches: 1.18.4;
Abort if memory for execv(2) argument array cannot be allocated instead
of passing an array with incomplete contents to login(1).
Fix provided by Jun-ichiro itojun Hagino in PR bin/9082.

Kerberos5 ticket forwarding works.

Added kerberos5_cleanup() to cleanup if KRB5 defined. This is to destroy
a forwarded ccache on cleanup.

branches: 1.15.2;
Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
not SecurID

Execute ttyaction on termination of rlogind/telnetd sessions.
Also, say a little bit about ttyaction in the getty and login manpages.

Fix for pr 5904 from Zdenek Salvet; we now use openpty() to get a pty.

No need to include <sys/tty.h>.

WARNS?=1. RCS ids.

Lseek(2) usage cleanup: the use of L_SET/L_INCR/L_XTND is deprecated,
use SEEK_SET/SEEK_CUR/SEEK_END instead.

apply Thorsten's patch to add gettytab support to telnetd.

RCS id cosmetics.

restore lost local change (be careful with 'long' vs. 'int'
distinctions)

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Make sure that the user name cannot ever be interpreted as an option to
login(8). Note: This does *not* fix any security holes.

be a bit more careful with types, casts, and and function declarations.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove mention of SPX.

branches: 1.31.44; 1.31.46;
Improve markup.

branches: 1.30.34;
Code is not using gethostbyaddr any longer, but getnameinfo.
Fix references. Addresses part of PR 26337 by Peter Postma.

Consistently use 'RFC 1234' instead of 'RFC1234' or 'RFC-1234'.
From jmc@openbsd.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

Bump date for -r removal.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

Begin new sentences on new lines.
Patch from Robert Elz (kre at munnari oz au).

Whitespace and punctuation nits, comment out an option that does not concern NetBSD.

Describe -S option, and remove mention of /etc/inittab in FILES section.
Patch by Brian Ginsbach.

Remove description of an option that only applies to UNICOS < 7.0.

dual-stack telnetd.

change:
.Sh "SEE ALSO"
to:
.Sh SEE ALSO
The doc macros check for the latter (actually just for 'SEE' as the first
argument to .Sh) to set the section header SEE ALSO flag, which modifies
some behaviour (e.g. references done with .Rs/.Re).

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

add missing .Bl.

sort SEE ALSO section by "sort |sort -n"

Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
not SecurID

delete .Sh ENVIRONMENT.
delete extra period.

Execute ttyaction on termination of rlogind/telnetd sessions.
Also, say a little bit about ttyaction in the getty and login manpages.

Change occurrences of "UNIX" to .Ux or .At as appropriate.

macroize BSD, NetBSD, FreeBSD and misc cleanup

Fix .Nm usage.

.Nm telnetd. -> .Nm telnetd .

apply Thorsten's patch to add gettytab support to telnetd.

Move the RCS id to the proper place in the file.

RCS Id Police

fix small documentation bug -- we have no bftp(1).

update to match 4.4-Lite

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Fix various typos, mainly in comments.

PR bin/58787 telnetd - handle auto authentication better

Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
more than 2 years ago, so I assume instead from
https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet

branches: 1.59.2;
Fix memory leak - free resources allocated by getaddrinfo

branches: 1.58.2;
telnetd: fix the crash that's been talked about the past couple days.

(Move initialization of the slc table earlier so it doesn't get
accessed before that happens.)

Calling the crash a DoS or security problem is a bit overwrought; it's
just a bug.

s/desireable/desirable/ in comments.

telnetd: Stop defining the same variables concurrently in bss and data

auth_level and require_secure_login were defined in two places:

- global.c that picked it from headers and removed 'extern'
- telnetd.c that initialized it to 0

line was defined twice: in global.c and sys_term.c with a non-zero value.
Remove the definition and initialization from sys_term.c and initialize
the variable early in main().

Detected during the build of telned with Address Sanitizer (MKSANITIZER).

Reviewed by <mrg>

branches: 1.55.18; 1.55.26; 1.55.28;
Global variable is never a null pointer.

branches: 1.54.6;
Use __dead

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

branches: 1.52.4;
#include <com_err.h> -> #include <krb5/com_err.h>.

Remove the \n and tabs from the __COPYRIGHT() strings.

branches: 1.50.20;
change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Make the debug variable static, to accomodate static linking with libssh.a.

Remove static local variable so its easier to correctly use strlcpy.

Ensure IF is initialized before trying to use it.
Found with -Wuninitialized.

branches: 1.46.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

PR/28473: Jed Davis: telnetd loses data and corrupts crypto state due to
typo in use of poll(). There was an && instead of an & (hi charles)

Pass -a [srrvis'd struct sockaddr] to login, so that login can record the
address where we have logged in from.

branches: 1.43.2; 1.43.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

Since telnetd has ignored the USER environment variable for logging in for
quite a bit of time, make telnetd ignore it completely now. This results
in the :if=: entry in the default gettytab entry to honored instead of
being ignored. The -h option to telnetd will continue to suppress the
inclusion of :if=:

use bounded string op. bump shlib major for libtelnet due to API change.

SIGINFO is defined

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

use bounded string op (there still are remains)

use strlcpy

PR/21233: Onno van der Linden: -U option does not work as advertised.

Remove dead code.

select() -> poll()

add some more ifdefs, so that we don't define variables we don't use.

implement -u <len>. PR 13676

-edebug should only be mentioned in the help #ifdef ENCRYPTION, not #ifdef
AUTHENTICATION. Noted (with patch) by Brian Ginsbach.

Remove code #ifdef'd on NEWINIT (never used on NetBSD).
Sync with Cray, patch by Brian Ginsbach in private mail.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Fix typo, and duplicate ';'. From bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

use LOG_ERR for fatal errors, LOG_WARNING for other errors
minor knf
deprecate LOG_ODELAY; it's the default

Buffer overflow and environment passing fixes [originally inspired from
FreeBSD]. We really didn't need the environment fixes, but for the sake
of keeping the code as close as possible...

make error case handling in -daemon case meet with other portion of the code.
(use fprintf-then-exit, not errx - costmetic)

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.20.4;
Make 'if' capability from gettytab work. *shudder*.

do not touch __ss_len directly, they are not supposed to be touched.

branches: 1.18.4;
Nuke some whitespace.

Put the RCS ID in the correct place.

dual-stack telnetd.

Fix for PR 5821
- s/SecurID/SECURELOGIN/g and define SECURELOGIN in Makefile
- update man page to reflect S/Key and Kerboros authentication used
not SecurID

Declare ints, too, don't default them.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

No need to declare optind and optarg.

don't include <sys/cdefs.h> twice, kill old-style getpty() declaration

use <termcap.h>

WARNS?=1. RCS ids.

Put a whitespace after the keyword `switch'.

Compare a return value of getopt() against -1 instead of EOF.

apply Thorsten's patch to add gettytab support to telnetd.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

branches: 1.6.4;
Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

branches: 1.5.6;
RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Add missing braces, per bin/13612 by Brian Ginsbach.

seperate -> separate

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.6.12;
WARNS?=1. RCS ids.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix CVE-2020-10188

branches: 1.33.2;
- bump buffer sizes to avoid potential truncation issues

branches: 1.32.32; 1.32.40;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

branches: 1.31.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Don't print uninitialized errno, from David A. Holland on #NetBSD-code

use a u_char[] when it is expected.

Handle printing ptyfs pty names

branches: 1.27.2;
Make this compile after the de-__Ping round.

de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

PR/21515: Onno van der Linden: Fix typo preventing %v from working.

Use the argument to stilloob() for the poll...

select() -> poll()

If the peer closes the connection in ttloop()
syslog(LOG_ERR, "ttloop: peer died: %m");
is a little console spammingly excessive. Switch to LOG_INFO.

branches: 1.18.2;
bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

use LOG_ERR for fatal errors, LOG_WARNING for other errors
minor knf
deprecate LOG_ODELAY; it's the default

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.13.4;
Make 'if' capability from gettytab work. *shudder*.

branches: 1.12.4;
kill old-style declaration of strchr()
add back variable needed for -DAUTHENTICATION

WARNS?=1. RCS ids.

Don't truncate long host names.
From SAITOH Masanobu <msaitoh@spa.is.uec.ac.jp>, PR #2676.

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

version number update

add uname % format stuff back in

new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Excuse me while I be braindead for a minute.

Add new uname() cookies like getty.
(I had thought telnetd spawned a getty. Sigh.)

Add RCS identifiers.

branches: 1.1.1;
Initial revision