Add -x option which allows to run `fsck_msdos -n' on a snapshot of
a live file system.

While here modify snap_open() to accept a character device as its
first arg and remove now unneeded get_snap_device().

Reviewed by: Manuel Bouyer <bouyer@netbsd.org>

Programs that use efun.

WARNS=2 is the default defined in sbin/Makefile.inc. (thanks wiz)

Use ${NETBSDSRCDIR}/some/path instead of ${.CURDIR}/../../some/path

Make WARNS=2 safe, and set WARNS to 2.

CFLAGS->CPPFLAGS

Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

Fix handling of clusters marked bad
Noted by Rafal Boni

util -> fsutil

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Add fsck utility for msdosfs

fix 32bit builds

Fix writing of corrected fsinfo.
Continue when fsinfo has been rewritten.

Cast read()/write() result to size_t to make this compile again.

Support large disk sectors.

Avoid unportable shift construct

boot.c:150:29, left shift of 255 by 24 places cannot be represented in type 'int'
boot.c:153:29, left shift of 255 by 24 places cannot be represented in type 'int'

Don't add the 2 reserved clusters before we determine if we using fat16/fat32.
From FreeBSD: https://reviews.freebsd.org/D23082:

Correct off-by-two issue when determining FAT type.

In the code we used NumClusters as the upper (non-inclusive) boundary
of valid cluster number, so the actual value was 2 (CLUST_FIRST) more
than the real number of clusters. This causes a FAT16 media with
65524 clusters be treated as FAT32 and might affect FAT12 media with
4084 clusters as well.

To fix this, we increment NumClusters by CLUST_FIRST after the type
determination.

branches: 1.21.4;
Typos.

The on-disk FAT array does not include anything before CLUST_FIRST,
compensate in size check.

This was tickled by my SanDisk Sansa Clip 4GB, which exactly filled the FAT array.

Avoid mixing cluster numbers and sector numbers. Makes code more readable.

Add #include <inttypes.h> for intmax_t to fix compile error.

ClusterOffset actually needs to be able to be negative.

branches: 1.16.2;
From: http://marc.info/?l=openbsd-tech&m=140354518512871&w=2
more consistency checks

branches: 1.15.12; 1.15.22;
fix sign-compare issues

branches: 1.14.4;
Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.13.12; 1.13.14; 1.13.16;
Change mismatch of bytes 11 to 90 to be a warning, not an error, and
print out the values of the bytes that do not match.
Add comment explaining that there is no documented rationale for the
check.

fsck_msdos checks that several bytes are equal in the primary and
backup bootblock. There is no documented rationale. The kernel does
not enforce this when mounting a filesystem. I have a FAT32
filesystem on my disk (mounted as /share) which fails this check, but
is accepted by both Windows XP and NetBSD. My volume differs in bytes
71-81. The primary contains "SHARE " and the backup NUL bytes.

Further, fsck_msdos does not have code to repair the mismatch. As a
result such filesystems can be used not checked.

- removes unused ctype.h header
- correct comment in mount_nfs/getnfsargs.c: s/Nead/Need/

From: Slava Semushin <php-coder@altlinux.ru>

- don't leak memory on allocation failure.
- s/perror/perr and print how much we were trying to allocate.

Kill __P(), ANSIfy, remove main() prototype.

Only compare the interesting part of the bootblock with its backup.

Allow check to proceed with bad backup boot block if we're doing a readonly
check.

Various typos in comments (neccessary, sceme, choise, ...).

Since M$ doesn't maintain the FSINFO block correctly,
don't treat errors there as modifications.

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

util -> fsutil

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Add fsck utility for msdosfs

Fix writing of corrected fsinfo.
Continue when fsinfo has been rewritten.

Well, if you set FSFIXFAT, better do it... Try running fsck on:

$ newfs_msdos -C 1M ./poc.fs
$ dd if=/dev/zero of=poc.fs conv=notrunc bs=1 count=1 seek=512

multiple times and see that it does not get fixed.

branches: 1.18.12; 1.18.22;
fix sign-compare issues

branches: 1.17.4;
Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.16.2; 1.16.4;
Make sure that the exit values are always sane, and use symbolic instead
of magic constants. Reviewed by go@

branches: 1.15.4; 1.15.10; 1.15.12;
- removes unused ctype.h header
- correct comment in mount_nfs/getnfsargs.c: s/Nead/Need/

From: Slava Semushin <php-coder@altlinux.ru>

- don't leak memory on allocation failure.
- s/perror/perr and print how much we were trying to allocate.

Kill __P(), ANSIfy, remove main() prototype.

Make WARNS=2 safe, and set WARNS to 2.

if readboot() calls pfatal(), we need to print a \n before exiting

branches: 1.10.4;
Recognize "dirty" signature on FAT as set by Windows 95 OSR2+ and don't report
it just as "odd byte sequence". Handle the dirty flag similar way
it's treated on e.g. FFS - e.g. clear it separately from rest of FAT.
Changing of FAT is now postponed until after all checks are done,
check.c:checkfilesys() was cleaned considerably and several messages
has been adjusted to be more accurate.

If file system was modified and no error has occured, just return 0
instead of 4 - there is no need for forcing a reboot in this case.

This addresses bin/5638 by Christos Zoulas.

from Erik Bertelsen <erik@mediator.uni-c.dk>
{ put } { in } { lots } { of } { these } { to } { shut } { up } { egcs }

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

Fix handling of clusters marked bad
Noted by Rafal Boni

util -> fsutil

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files

branches: 1.1.4;
Add fsck utility for msdosfs

Prevent SEGV on corrupted msdos directories (Veo Zhang)

branches: 1.28.6;
PR/50908: David Binderman: Optimize memset's

Avoid mixing cluster numbers and sector numbers. Makes code more readable.

From: http://marc.info/?t=140304310700005&r=1&w=2
When truncating cluster chains fix the length of the cluster head.

branches: 1.25.10; 1.25.20;
undo part of the previous patch, which I suspect is bad.

PR/44529: Martin Danielsson: fsck_msdos crashes when verifying corrupt file
system. Avoid using the long name index when it is 0. Refactor the code to
avoid duplication.

branches: 1.23.2;
fix sign-compare issues

branches: 1.22.4;
Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.21.12; 1.21.14; 1.21.16;
Remove more duplicate #includes,
from Slava Semushin <slava.semushin@gmail.com>

- don't leak memory on allocation failure.
- s/perror/perr and print how much we were trying to allocate.

the root directory of non fat32 filesystems is stored in a special area.
a couple of corner cases can cause it to fail to write out that area
after it performs repairs.

Coverity CID 1078: Add assertion check for NULL pointer.

Kill __P(), ANSIfy, remove main() prototype.

use bounded string op

Recognize "dirty" signature on FAT as set by Windows 95 OSR2+ and don't report
it just as "odd byte sequence". Handle the dirty flag similar way
it's treated on e.g. FFS - e.g. clear it separately from rest of FAT.
Changing of FAT is now postponed until after all checks are done,
check.c:checkfilesys() was cleaned considerably and several messages
has been adjusted to be more accurate.

If file system was modified and no error has occured, just return 0
instead of 4 - there is no need for forcing a reboot in this case.

This addresses bin/5638 by Christos Zoulas.

from Erik Bertelsen <erik@mediator.uni-c.dk>
{ put } { in } { lots } { of } { these } { to } { shut } { up } { egcs }

__AUDIT__ cleanup.

Fix some bugs & annoyances when reparing defect disks

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

Fix a few bugs, especially when repairing disks:
Print correct pathname in error messages
Fix unterminating loop when trying to correct a bad fat
Require fat media byte to be the same as the one in the bpb
Fix unterminating loop when looking for free directory slot in LOST.DIR
(bad disk image provided by Christoph Badura)

util -> fsutil

Fix delete() call in dir.c differently than Christos' way.
Require at least one filesystem as program argument.
Update man page to reflect the latter.

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Fix null pointer derefernce
Fixes PR#2765. Thanks David.

Fix gcc warnings.

Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files

branches: 1.1.4;
Add fsck utility for msdosfs

Avoid mixing cluster numbers and sector numbers. Makes code more readable.

ClusterOffset actually needs to be able to be negative.

branches: 1.6.38;
Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.5.46; 1.5.48; 1.5.50;
Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

Fix handling of clusters marked bad
Noted by Rafal Boni

Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files

branches: 1.1.4;
Add fsck utility for msdosfs

ext.h: fix spelling and grammar in a comment

fix sign-compare issues

branches: 1.12.4;
Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.11.26; 1.11.28; 1.11.30;
Kill __P(), ANSIfy, remove main() prototype.

Spell 'occurred' with two 'r's.

Various typos in comments (neccessary, sceme, choise, ...).

Make WARNS=2 safe, and set WARNS to 2.

Format string cleanups by Bill Sommerfeld.

branches: 1.6.4;
Recognize "dirty" signature on FAT as set by Windows 95 OSR2+ and don't report
it just as "odd byte sequence". Handle the dirty flag similar way
it's treated on e.g. FFS - e.g. clear it separately from rest of FAT.
Changing of FAT is now postponed until after all checks are done,
check.c:checkfilesys() was cleaned considerably and several messages
has been adjusted to be more accurate.

If file system was modified and no error has occured, just return 0
instead of 4 - there is no need for forcing a reboot in this case.

This addresses bin/5638 by Christos Zoulas.

branches: 1.5.4;
Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files

branches: 1.1.4;
Add fsck utility for msdosfs

We already incremented cl; fix indexing. Noticed by Xin Li @FreeBSD.

branches: 1.29.24;
Another infinite loop fix from OpenBSD from Tobias Stoeckmann:

You can download a "proof of concept" from my website:
http://www.stoeckmann.org/openbsd/poc.iso.

Take FAT1 and it'll infinitely loop. This fix will complete
your previous commit.

Bring in a regression for the previous fix from OpenBSD

From: http://marc.info/?l=openbsd-tech&m=140234174104724&w=2
Avoid off-by-one on FAT12 filesystems.

From: http://marc.info/?l=openbsd-tech&m=140275150804337&w=2
Avoid infinite loops in cluster chain linked lists.

From: http://marc.info/?t=140304310700005&r=1&w=2
When truncating cluster chains fix the length of the cluster head.

branches: 1.24.6;
An uninitialized next-free-cluster value in the file system information
block is valid; do not consider it for correction.

branches: 1.23.2;
The free space value in the FSInfo block is merely unitialized when it is
0xffffffff. Fixes first part of bin/46743

branches: 1.22.6;
fix sign-compare issues

branches: 1.21.4;
Do not crash when boot->FSNext contains garbage (i.e. -1).

Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.19.20; 1.19.22; 1.19.24;
don't use uint32_t when you mean size_t.

- don't leak memory on allocation failure.
- s/perror/perr and print how much we were trying to allocate.

Coverity CID 2302: Free fat if fatal error to avoid leak.

Kill __P(), ANSIfy, remove main() prototype.

Eliminate a -Wshadow warning

Make WARNS=2 safe, and set WARNS to 2.

minor knf

Format string cleanups by Bill Sommerfeld.

branches: 1.11.4;
add a prototype for _readfat() added in last commit and make it static, so
that it's possible to compile this with -Wstrict-prototypes -Wmissing-prototypes

Breakage reported by Jeff Rizzo <riz@boogers.sf.ca.us> on current-users.

Recognize "dirty" signature on FAT as set by Windows 95 OSR2+ and don't report
it just as "odd byte sequence". Handle the dirty flag similar way
it's treated on e.g. FFS - e.g. clear it separately from rest of FAT.
Changing of FAT is now postponed until after all checks are done,
check.c:checkfilesys() was cleaned considerably and several messages
has been adjusted to be more accurate.

If file system was modified and no error has occured, just return 0
instead of 4 - there is no need for forcing a reboot in this case.

This addresses bin/5638 by Christos Zoulas.

branches: 1.9.2;
Fix some bugs & annoyances when reparing defect disks

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

Fix a few bugs, especially when repairing disks:
Print correct pathname in error messages
Fix unterminating loop when trying to correct a bad fat
Require fat media byte to be the same as the one in the bpb
Fix unterminating loop when looking for free directory slot in LOST.DIR
(bad disk image provided by Christoph Badura)

Fix handling of clusters marked bad
Noted by Rafal Boni

util -> fsutil

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

branches: 1.1.4;
Add fsck utility for msdosfs

Document the version fsck_msdos first appeared.
Bump date.

New sentence, new line. Sort SEE ALSO.
Improve formatting of option list.

Add -x option which allows to run `fsck_msdos -n' on a snapshot of
a live file system.

While here modify snap_open() to accept a character device as its
first arg and remove now unneeded get_snap_device().

Reviewed by: Manuel Bouyer <bouyer@netbsd.org>

Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.14.32; 1.14.34; 1.14.36;
.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

New sentence, new line. By Robert Elz with minimal fixes.

Drop an unnecessary .Pp.

Drop arguments of .Os.

Clean up SYNOPSIS formatting.

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

Use .Nm "" instead of .Nm fsck_msdos in SYNOPSIS.

all but the first .Nm in SYNOPSIS need to be spelt out. [bin/4256]

use .Nm correctly

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

clean up and add a fair bit of text. document -f (and the fact that it's
ignored).

Fix delete() call in dir.c differently than Christos' way.
Require at least one filesystem as program argument.
Update man page to reflect the latter.

Document -p (preen) option. If there are no filesystems specified on the
command line, get them from /etc/fstab when we are preening.

Add fsck utility for msdosfs

fix error messages containing \n

fix compilation.

branches: 1.22.4;
Add -x option which allows to run `fsck_msdos -n' on a snapshot of
a live file system.

While here modify snap_open() to accept a character device as its
first arg and remove now unneeded get_snap_device().

Reviewed by: Manuel Bouyer <bouyer@netbsd.org>

Move to 2 clause license, approved by Wolfgang Solfrank.

branches: 1.20.2; 1.20.4;
Catch signals and exit with the proper error code like all the other fsck
programs.

Make sure that the exit values are always sane, and use symbolic instead
of magic constants. Reviewed by go@

branches: 1.18.4; 1.18.10; 1.18.12;
- removes unused ctype.h header
- correct comment in mount_nfs/getnfsargs.c: s/Nead/Need/

From: Slava Semushin <php-coder@altlinux.ru>

Kill __P(), ANSIfy, remove main() prototype.

Add a progress meter to fsck_ffs based on the work by thorpej presented
to the mailing lists last January. This is optional.

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Add a -q (quiet) option to print nothing for clean filesystems.
Support in fsck_ffs and stub in fsck_xxx.
Push a few more messages through pwarn() instead of printf() to ensure
disk name is shown.

__STDC__ is always defined on NetBSD.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

Add support for FAT32
Support dropping lost cluster chains (on request by Christoph Badura)
While being here, fix some minor bugs, mostly with format strings

Don't declare optind.

* cleanup for WARNS=1
* getopt returns -1 not EOF
* cleanup manpage

include -f in usage, removed 'v' from getopt string since it's not handled

Accept -f flag, but do nothing with it.

util -> fsutil

Fix delete() call in dir.c differently than Christos' way.
Require at least one filesystem as program argument.
Update man page to reflect the latter.

- use error printing code from fsck(8)
- remove fstab walking code
- add missing prototypes
- add missing argument in dir.c near "Truncate", where delete() was being
called with fewer args. I think the missing argument should be a zero,
but Wolfgang should check...

Document -p (preen) option. If there are no filesystems specified on the
command line, get them from /etc/fstab when we are preening.

Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files

branches: 1.1.4;
Add fsck utility for msdosfs