user librumpres

Include several libc functions in rump.ping6

We need getaddrinfo, getifaddrs, if_indextoname and if_nametoindex
in addition to getnameinfo.

Introduce rump.ping6

We use ping6 frequently in ATF tests so let's have rump-ified one.

fix gcc warnings and eliminate duplicate code.

apply some -Wno-error and/or -fno-strict-aliasing.


all of this should be looked at closer, but some of them are not
very trivial.

Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Remove support support for RFC 2292.

Add support for RFC 3542 Adv. Socket API for IPv6 (which obsoletes 2292).
* RFC 3542 isn't binary compatible with RFC 2292.
* RFC 2292 support is on by default but can be disabled.
* update ping6, telnet and traceroute6 to the new API.

From the KAME project (www.kame.net).
Reviewed by core.

Move WARNS=3 to the Makefile.inc, and add a little const to the remaining
programs that did not compile before.

Kill __P(), use ANSI function declarations; WARNS=3.

no need for KAME_SCOPEID

repair fd_set size attack. from deraadt.
some of cleanups from kame (inet_ntop error check, unnecessary headers,
stddev computation like ping(8)).
$NetBSD$.

branches: 1.5.4;
provide -S for source address specifier.
enable KAME scopeid hack.
cleanups in node information query.
(sync with latest KAME)

branches: 1.4.4;
do not modify BINGRP as there's no reason for.

From: tsubai@netbsd.org

-D... belongs in CPPFLAGS

enable -DIPSEC.

ping for IPv6. try
ping6 ::1
on you node.

In ping6, there's no blank space in the ping packets by default.

- document that if you use -p to specify a fill pattern you need to
make the packets bigger with -s;

- warn if -p is used and there's not at least one byte of fill space.

PR 56057

Remove the "-R" option. It uses IPV6_REACHCONF, but we've never had
this.

Sort options. Sort option descriptions. Remove Tn.
Sync usage (more) with man page.

Remove the "hops" parameter, it uses RH0, which is deprecated by RFC5095,
and doesn't work on modern networks anymore.

branches: 1.30.14;
Add options -X for deadline and -x for reply maxwait (flag names matching
FreeBSD). Unline FreeBSD, currently -x doesn't count late packets to statistics.
After discussion with, and help from ozaki-r@
Should fix PR/49896

Add the once -o option like ping

Remove unnecessary Bk/Ek pairs from SYNOPSIS.
No effective change except where I used the opportunity to sort options
and/or option descriptions.

branches: 1.27.44;
There are no broadcast addresses in IPv6, so, kill a leftover from the
ping(8) man page.

Add support for RFC 3542 Adv. Socket API for IPv6 (which obsoletes 2292).
* RFC 3542 isn't binary compatible with RFC 2292.
* RFC 2292 support is on by default but can be disabled.
* update ping6, telnet and traceroute6 to the new API.

From the KAME project (www.kame.net).
Reviewed by core.

Consistently use 'RFC 1234' instead of 'RFC1234' or 'RFC-1234'.
From jmc@openbsd.

IPsec, not ipsec. From Igor Sobrado in PR 20722.

address has two ds, not three; from Adrian Mrva.

KNF. remove unused variable "signo". from deraadt

Xr ping6 8 -> Nm

Sort sections and a grammar fix.

sync with kame.
- use bind(2) to select source.
- KNF.
- -g option to specify intermediate gateway.

Add space before ..., lose a .Pp.

clarify -a. sync with kame

sync with latest kame.
- sync usage/manpage with reality.
- stop pinging on "-f -c N".

Xr icmp(6), inet(6), ip(6)

examples. suggested by deraadt. sync with kame

-Q is not there. some comsetic sync with kame. NetBSD PR 12384.

improve spec conformance of node information query (07).
sync with kame.

fix up various .Nm abuses:
- keep the case consistent between the actual name and what's referenced.
e.g, if it's `foo', don't use '.Nm Foo' at the start of a sentence.
- remove unnecessary `.Nm foo' after the first occurrence (except for
using `.Nm ""' if there's stuff following, or for the 2nd and so on
occurrences in a SYNOPSIS
- use Sx, Ic, Li, Em, Sq, and Xr as appropriate

For commands and utilities, use EXIT STATUS rather than RETURN VALUES as
appropriate (and documented in mdoc(7)).

DNS compression support.
be more picky about DNS label validation.
(sync with kame)

branches: 1.8.2;
better conformance to draft-ietf-ipngwg-icmp-name-lookups-05.
the old code was chimera of 03 and 05 draft.

-n by default, since IPv6 reverse lookup takes too much time.
use -H to enable reverse name lookup.

branches: 1.7.2;
remove incorrect mention to sysexits.h. this closes PR 9707.

support ping6 -a c
(request IPv4 mapped/compatible addrs from
draft-ietf-ipngwg-icmp-name-lookups-05.txt)

sync with latest libipsec and kernel.

add reference to RFC, and some more DESCRIPTION.
sync with latest KAME document.

provide -S for source address specifier.
enable KAME scopeid hack.
cleanups in node information query.
(sync with latest KAME)

branches: 1.2.4;
add NetBSD RCS ID.

ping for IPv6. try
ping6 ::1
on you node.

Fix various typos, mainly in comments and log/error messages.

branches: 1.107.4;
fix various typos, mainly in comments, but also log messages, docs, game text.

ping, ping6: fix comment about ID field

Since ping.c 1.76 and ping6.c 1.58 from 2004-04-22, the ID field
contains random bits instead of a process ID.

In ping6, there's no blank space in the ping packets by default.

- document that if you use -p to specify a fill pattern you need to
make the packets bigger with -s;

- warn if -p is used and there's not at least one byte of fill space.

PR 56057

Make sure the output packet buffer and the control message buffer
are aligned.

Fixes bin/56198.

branches: 1.103.8;
Add code 3 of paramprob, part of RFC7112: "IPv6 First Fragment has
incomplete IPv6 Header Chain". Handle this code in ping6.

Remove annoying (void) casts.

Remove double include and unused macros.

Remove the "-R" option. It uses IPV6_REACHCONF, but we've never had
this.

Fix usage(), A/E don't exist.

Simplify: remove #ifdefs for constants that are always defined, and
remove their #else's (some of which can't compile, since they use values
that since got removed).

Remove dead/broken code, we want to favor RFC3542 over RFC2292. No
functional change. traceroute6 and rtadvd did the same.

Sort options. Sort option descriptions. Remove Tn.
Sync usage (more) with man page.

Remove the "hops" parameter, it uses RH0, which is deprecated by RFC5095,
and doesn't work on modern networks anymore.

typo in comment

branches: 1.93.12;
Merge the PR 36997 fixes into ping6. It already didn't accept too
small or wildly too large intervals, but it did allow intervals that
failed at poll(). Since that's signed integer overflow and thus UB,
better not to.

branches: 1.92.2;
#ifdef forward declaration of setpolicy like definition.

Fix rump.ping6 -c N (N > 1) doesn't work

2nd packet and subsequent packets are sent based on SIGALRM and
it depends on poll(2) returns with EINTR by the signal. However,
currently poll is rump-ified while signals aren't so the signal
doesn't wake up poll and ping6 doesn't work expectedly.

Rump-ifying signals is unsure (nobody does it for now) and the
combination use of signals and poll makes the logic a bit complex.
So let's fix the defect by stopping using signals for packet
transmissions. The new logic is derived from ping(8).

Bonus: ping6 -i 0.01 works as we expect now while the original
didn't work enough fast.

Fix exit status when -c and -X is used

It exited with status 0 when at least one packet was received
and timed out. However, when we specify -c N (while N > 0),
we expect that it fails if it times out before all sent requests
are replied.

rump.ping6 supports "-S" option.

Introduce rump.ping6

We use ping6 frequently in ATF tests so let's have rump-ified one.

Add options -X for deadline and -x for reply maxwait (flag names matching
FreeBSD). Unline FreeBSD, currently -x doesn't count late packets to statistics.
After discussion with, and help from ozaki-r@
Should fix PR/49896

Add the once -o option like ping

Remove out-of-date comments

PR/49206: ping6 dies with SIGINT even when it just fails to ping
When reusing the same handler for SIGALRM, make don't pretend you
got SIGINT.

Rework to be avoid a conditional assignment which results in:
sbin/ping6/ping6.c:1879:8: error: 'cbit.skip' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cur += ntohs(cbit.skip) * 32;

branches: 1.82.4;
avoit type punning

branches: 1.81.2;
Accept "-s 0"

branches: 1.80.2;
include <netipsec/ipsec.h> rather than <netinet6/ipsec.h> from userland
where possible, for consistency and compatibility to FreeBSD
(exception: KAME specific statistics gathering in netstat(1) and systat(1))

-consistently use "char *" for the compiled policy buffer in the
ipsec_*_policy() functions, as it was documented and used by clients
-remove "ipsec_policy_t" which was undocumented and only present
in the KAME version of the ipsec.h header
-misc cleanup of historical artefacts, and to remove unnecessary
differences between KAME ans FAST_IPSEC

branches: 1.78.2;
NULL does not need a cast, here

put back the byte swapping code, and remove the double byte swapping.

Remove erroneous seq=ntohs(seq) introduced in rev. 1.74, which caused
icmp_seq numbers to increment by 256 instead of 1 on LE platforms.

static + __dead + G/C pathmtu

fix gcc warnings and eliminate duplicate code.

Avoid NaN when calculating std-dev, which fixes a crash on VAX.

fix sign-compare issues

branches: 1.71.4;
Fix reversed test in connection with combining -i and -l. If some
packets have already sent because of the preload count handling, we
shouldn't start off by sending another one right away. The reversed
test causes ping6 to wait one interval before sending anything at all
if you don't use -l. PR bin/39732.

branches: 1.70.2; 1.70.18;
PR/30226: Nino Dehne: ping6(8) and ping(8) are inconsistent in the output
of round-trip times.

okay rpaulo@

Replace the way we calculate the standard deviation with the unbiased form
for non-related samples. There are several websites that explain why we
should use this form instead of the normal formula to compute the std. dev.
(Wikipedia is one of them).
Also, ping(8) (where this "new" formula came from) already does it this way
so, I'm trying to score some extra points by making both utilities behave
the same way.

Thanks to wrtstuden@ for the initial clarification.

Remove support support for RFC 2292.

len should be socklen_t, not size_t. Spotted by
Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de>.

Add support for RFC 3542 Adv. Socket API for IPv6 (which obsoletes 2292).
* RFC 3542 isn't binary compatible with RFC 2292.
* RFC 2292 support is on by default but can be disabled.
* update ping6, telnet and traceroute6 to the new API.

From the KAME project (www.kame.net).
Reviewed by core.

Fix an off-by-one found by Coverity, CID 1456.

I haven't looked, but I suggest security-officer@ looks into it to see if
this may be exploited passively?

Add an initialization to appease -Wuninitialized.
Marked with XXXGCC for sun2 (found while building for it).

Reviewed by lukem.

appease gcc -Wuninitialized

Kill __P(), use ANSI function declarations; WARNS=3.

Add (unsigned char) cast to ctype function

correct mistake in usage(). Chris Pinnock

There's no point in bringing PRNG output to network byteorder prior to
transmission.

do not disclose endian. henning@openbsd

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22308, verified by myself.

fix packet loss rate computation

Fix typo. Noted by Sean Boudreau on tech-net.

do proper rounded packet loss calculations.
From Robert Elz in PR #20885
XXX This should be sent back to KAME

correct the use of sizeof() on memset(). sync w/kame

use strlcpy. sync w/kame

be more picky about numeric arg parsing. sync w/kame

reduce diff w/ kame

Touch up error/warning messages.

select() -> poll()

ansi pedantic. sync w/kame

clarify comment when nreceived > ntransmitted. from deraadt

typo, from openbsd

Fix Missing %s in format string.

KNF. remove unused variable "signo". from deraadt

s/IPSec/IPsec/

sync with kame.
- use bind(2) to select source.
- KNF.
- -g option to specify intermediate gateway.

branches: 1.40.2;
no \n to warnx(3). From: Mike Pechkin <mpech@prosoft.org.lv>

should be using htons() to convert from a host byte order into a network
byte order, not ntohs().

fix -Wshadow warning

use bind(2) to support -S. snprintf return value audit from deraadt

sync with latest kame.
- sync usage/manpage with reality.
- stop pinging on "-f -c N".

correct -n handling.

fix signal handling on ping6 -f <nonexisting peer>. from hash@iij.ad.jp.
sync with kame

getopt(3): EOF -> -1.

correct recvmsg() validation.

more simpler signal handling. be more friendly with 4.3BSD-ish socket API
(linux/USAGI folks are using the code). sync with kame.

avoid signal handler race. help from deraadt

correct use of howmany() for fd_set. commented by deraadt

indent and pedant. from deraadt. sync with kame

call seteuid(getuid) too

revoke root privilege earlierst possible.

sync with latest kame.
- validate strdup() error on argument parsing.
- use strlcat on complex string manipulation.

improve spec conformance of node information query (07).
sync with kame.

- fix -s with small number (like < 8). kame 1.97 -> 1.99
- add fflush. kame 1.96 -> 1.97
- alpha friendly (printf format - %ld and others) kame 1.93 -> 1.94
sync with kame

do not segv on too many args. sync with kame

Format string cleanups by Bill Sommerfeld.

fix truncated response handling; sync with kame

repair fd_set size attack. from deraadt.
some of cleanups from kame (inet_ntop error check, unnecessary headers,
stddev computation like ping(8)).
$NetBSD$.

- bugfix: truncated FQDN printing
- allow < 1 second interval on -i (root only). from openbsd

DNS compression support.
be more picky about DNS label validation.
(sync with kame)

warnx?/errx? audit. don't pass variable/function return value alone.
use with "%s". from openbsd.

branches: 1.15.2;
better conformance to draft-ietf-ipngwg-icmp-name-lookups-05.
the old code was chimera of 03 and 05 draft.

-n by default, since IPv6 reverse lookup takes too much time.
use -H to enable reverse name lookup.

make sure to clear ni_flags field on -w.

branches: 1.13.2;
support ping6 -a c
(request IPv4 mapped/compatible addrs from
draft-ietf-ipngwg-icmp-name-lookups-05.txt)

use getnameinfo(), instead inet_ntop(), as much as possible.
(sync with latest kame)

sync with latest libipsec and kernel.

Remove bogus declarations of "errno", "optind" and "optarg".

provide -S for source address specifier.
enable KAME scopeid hack.
cleanups in node information query.
(sync with latest KAME)

usage(): wrap lines so that they don't exceed 80 characters

rcsid police

branches: 1.6.4;
add NetBSD RCS ID.

be friendly with non-IPsec kernel.
don't exit even if ipsec policy config fails.

stop using __RCSID from UCB comment.
Hope this fixes PR 7892.

Fix some printf format problems.

Fix LP64 printf format problem.

ping for IPv6. try
ping6 ::1
on you node.

rump.ping6 supports "-S" option.

Introduce rump.ping6

We use ping6 frequently in ATF tests so let's have rump-ified one.

rump.ping6 supports "-S" option.

Introduce rump.ping6

We use ping6 frequently in ATF tests so let's have rump-ified one.

rump.ping6 supports "-S" option.

Introduce rump.ping6

We use ping6 frequently in ATF tests so let's have rump-ified one.