Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.2.22; 1.2.44; 1.2.52; 1.2.54;
Remove KDIR=, since SYS_INCLUDE=symlinks and KDIR are not supported any more.

branches: 1.1.2; 1.1.4;
Install ALTQ header files.

Fix various typos, mainly in comments.

altq, cbq: support 10 Gbps bandwidth

Mostly just s/u_int/uint64_t/ for bandwidth and rate variables.

branches: 1.4.178;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.3.22; 1.3.44; 1.3.52; 1.3.54;
/*CONTCOND*/ while (0)'ed macros

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

refac: remove parens from return statements

handle duplication: extract address family interface lookup

branches: 1.23.10;
altq(9): Fix missing IFNET_LOCK around if_ioctl.

sys: Use if_ioctl wrapper function.

Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

kill sprintf

branches: 1.19.16; 1.19.26; 1.19.30;
*** Summary ***

When a link-layer address changes (e.g., ifconfig ex0 link
02:de:ad:be:ef:02 active), send a gratuitous ARP and/or a Neighbor
Advertisement to update the network-/link-layer address bindings
on our LAN peers.

Refuse a change of ethernet address to the address 00:00:00:00:00:00
or to any multicast/broadcast address. (Thanks matt@.)

Reorder ifnet ioctl operations so that driver ioctls may inherit
the functions of their "class"---ether_ioctl(), fddi_ioctl(), et
cetera---and the class ioctls may inherit from the generic ioctl,
ifioctl_common(), but both driver- and class-ioctls may override
the generic behavior. Make network drivers share more code.

Distinguish a "factory" link-layer address from others for the
purposes of both protecting that address from deletion and computing
EUI64.

Return consistent, appropriate error codes from network drivers.

Improve readability. KNF.

*** Details ***

In if_attach(), always initialize the interface ioctl routine,
ifnet->if_ioctl, if the driver has not already initialized it.
Delete if_ioctl == NULL tests everywhere else, because it cannot
happen.

In the ioctl routines of network interfaces, inherit common ioctl
behaviors by calling either ifioctl_common() or whichever ioctl
routine is appropriate for the class of interface---e.g., ether_ioctl()
for ethernets.

Stop (ab)using SIOCSIFADDR and start to use SIOCINITIFADDR. In
the user->kernel interface, SIOCSIFADDR's argument was an ifreq,
but on the protocol->ifnet interface, SIOCSIFADDR's argument was
an ifaddr. That was confusing, and it would work against me as I
make it possible for a network interface to overload most ioctls.
On the protocol->ifnet interface, replace SIOCSIFADDR with
SIOCINITIFADDR. In ifioctl(), return EPERM if userland tries to
invoke SIOCINITIFADDR.

In ifioctl(), give the interface the first shot at handling most
interface ioctls, and give the protocol the second shot, instead
of the other way around. Finally, let compatibility code (COMPAT_OSOCK)
take a shot.

Pull device initialization out of switch statements under
SIOCINITIFADDR. For example, pull ..._init() out of any switch
statement that looks like this:

switch (...->sa_family) {
case ...:
..._init();
...
break;
...
default:
..._init();
...
break;
}

Rewrite many if-else clauses that handle all permutations of IFF_UP
and IFF_RUNNING to use a switch statement,

switch (x & (IFF_UP|IFF_RUNNING)) {
case 0:
...
break;
case IFF_RUNNING:
...
break;
case IFF_UP:
...
break;
case IFF_UP|IFF_RUNNING:
...
break;
}

unifdef lots of code containing #ifdef FreeBSD, #ifdef NetBSD, and
#ifdef SIOCSIFMTU, especially in fwip(4) and in ndis(4).

In ipw(4), remove an if_set_sadl() call that is out of place.

In nfe(4), reuse the jumbo MTU logic in ether_ioctl().

Let ethernets register a callback for setting h/w state such as
promiscuous mode and the multicast filter in accord with a change
in the if_flags: ether_set_ifflags_cb() registers a callback that
returns ENETRESET if the caller should reset the ethernet by calling
if_init(), 0 on success, != 0 on failure. Pull common code from
ex(4), gem(4), nfe(4), sip(4), tlp(4), vge(4) into ether_ioctl(),
and register if_flags callbacks for those drivers.

Return ENOTTY instead of EINVAL for inappropriate ioctls. In
zyd(4), use ENXIO instead of ENOTTY to indicate that the device is
not any longer attached.

Add to if_set_sadl() a boolean 'factory' argument that indicates
whether a link-layer address was assigned by the factory or some
other source. In a comment, recommend using the factory address
for generating an EUI64, and update in6_get_hw_ifid() to prefer a
factory address to any other link-layer address.

Add a routing message, RTM_LLINFO_UPD, that tells protocols to
update the binding of network-layer addresses to link-layer addresses.
Implement this message in IPv4 and IPv6 by sending a gratuitous
ARP or a neighbor advertisement, respectively. Generate RTM_LLINFO_UPD
messages on a change of an interface's link-layer address.

In ether_ioctl(), do not let SIOCALIFADDR set a link-layer address
that is broadcast/multicast or equal to 00:00:00:00:00:00.

Make ether_ioctl() call ifioctl_common() to handle ioctls that it
does not understand.

In gif(4), initialize if_softc and use it, instead of assuming that
the gif_softc and ifp overlap.

Let ifioctl_common() handle SIOCGIFADDR.

Sprinkle rtcache_invariants(), which checks on DIAGNOSTIC kernels
that certain invariants on a struct route are satisfied.

In agr(4), rewrite agr_ioctl_filter() to be a bit more explicit
about the ioctls that we do not allow on an agr(4) member interface.

bzero -> memset. Delete unnecessary casts to void *. Use
sockaddr_in_init() and sockaddr_in6_init(). Compare pointers with
NULL instead of "testing truth". Replace some instances of (type
*)0 with NULL. Change some K&R prototypes to ANSI C, and join
lines.

branches: 1.18.36; 1.18.40; 1.18.46; 1.18.50;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.17.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.13.4; 1.13.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.9.4; 1.9.6; 1.9.8; 1.9.10; 1.9.12;
merge ktrace-lwp.

branches: 1.8.4;
nuke trailing whitespace

branches: 1.7.4; 1.7.6;
kill sprintf, use snprintf

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.5.16;
don't need <sys/types.h> when including <sys/param.h>

add RCSIDs

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

handle duplication: extract address family interface lookup

branches: 1.3.178;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.2.2; 1.2.42; 1.2.64; 1.2.72; 1.2.74;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.26.6; 1.26.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

s/lenght/length/

branches: 1.24.18;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.23.8; 1.23.26;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

branches: 1.22.76;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.21.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.17.4; 1.17.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Complete the FREE -> free transition and add more NULL checks for malloc
returns. Although these cannot happen because M_WAITOK, the rest of the
code does them already, so this is good for consistency. From Mindaugas

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.12.4; 1.12.6; 1.12.8; 1.12.10; 1.12.12;
merge ktrace-lwp.

branches: 1.11.4;
nuke trailing whitespace

branches: 1.10.4; 1.10.6;
Fix URL to Wu-chang Feng's BLUE

branches: 1.9.2;
Spell length with h after t. Inspired by a commit by brad@openbsd.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

There is NO reason to use arc4random() here, and it needlessly slows down the
forwarding path, so goodbye.

use arc4random. sync w/ kame

branches: 1.5.14;
bring in latest ALTQ from kjc. ALTQify some of the drivers.

add RCSIDs

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.4.12; 1.4.20; 1.4.22;
merge ktrace-lwp.

branches: 1.3.4;
nuke trailing whitespace

branches: 1.2.2; 1.2.26; 1.2.34; 1.2.36;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

altq, cbq: fix default class assignment

Fix typo in v1.34.

Tested by me and manu@.

altq, cbq: fix NSEC_TO_PSEC

Pointed out by manu@, thanks.

branches: 1.39.4; 1.39.6; 1.39.8;
fix few typos in comments, mainly in word "parameter".

Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

fix multiplei repetitive typos in comments, messages and documentation. mainly because copy paste code big amount of files are affected.

altq: fix CBQ with RED and/or pf

altq, cbq: convert ns_per_byte to ps_per_byte

Also the type of variables of it is changed to u_long from int.

This change provides fine-grain resolution of bandwidth. For example
750 Mbps was treated as 800 Mbps internally because bandwidth was
represented as nanoseconds per byte. Converting the representation
to picoseconds per byte enables to treat 750 Mbps as-is.

PR kern/56319

altq, cbq: allow the root class to be default

altq, cbq: allow no control class

branches: 1.32.16;
Remove the 't' argument from m_tag_find().

branches: 1.31.2; 1.31.4;
Zero buffers copied to userland to avoid stack disclosure.

From Ilja Van Sprundel.

branches: 1.30.10;
apply if_start_lock() to L2 callers which call ifp->if_start() of device derivers

IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.28.2;
src is too big these days to tolerate superfluous apostrophes. It's
"its", people!

branches: 1.27.4; 1.27.6; 1.27.10;
kill sprintf

branches: 1.26.12; 1.26.18; 1.26.22; 1.26.24; 1.26.26; 1.26.32;
s/the the/the/

merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@. requested by core@

branches: 1.24.36; 1.24.38; 1.24.40; 1.24.42; 1.24.44;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.23.4;
__unused removal on arguments; approved by core.

Don't allow to initialize an interface with MTU smaller than one.
This prevents a divide by zero and fixes PR #21474.

ok tron@

Kill some KAUTH_GENERIC_ISSUSER.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.17.4; 1.17.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Complete the FREE -> free transition and add more NULL checks for malloc
returns. Although these cannot happen because M_WAITOK, the rest of the
code does them already, so this is good for consistency. From Mindaugas

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.12.4; 1.12.6; 1.12.8; 1.12.10; 1.12.12;
merge ktrace-lwp.

branches: 1.11.4;
nuke trailing whitespace

branches: 1.10.4; 1.10.6;
s/the the/the/ (only in sources that aren't regularly imported from
elsewhere).

parameter with two es. From Peter Postma.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

expose CBQ_MAXPRI to userland

branches: 1.6.6;
fix a bug in a cbq list chasing.
this bug turns up only when 3 or more cbq instances are
created at a time.

sync w/kame

add RCSIDs

Spell 'occurred' with two 'r's.

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

altq, cbq: change long to uint64_t for ILP32 archs

PR kern/56319

altq, cbq: treat time in nanoseconds

Time granularity in microseconds is sometimes not enough to provide
accurate bandwidth control; actual bandwidth on a capped class
can exceed its limit considerably in some cases.

Treating time in nanoseconds requires the following changes:
- Use timespec instead of timeval
- Use nanotime(9) instead of microtime(9)
- Change the type of some variables, especially *idle, to long

altq, cbq: convert ns_per_byte to ps_per_byte

Also the type of variables of it is changed to u_long from int.

This change provides fine-grain resolution of bandwidth. For example
750 Mbps was treated as 800 Mbps internally because bandwidth was
represented as nanoseconds per byte. Converting the representation
to picoseconds per byte enables to treat 750 Mbps as-is.

PR kern/56319

branches: 1.8.158;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.7.12; 1.7.20; 1.7.22;
merge ktrace-lwp.

branches: 1.6.4;
nuke trailing whitespace

branches: 1.5.8; 1.5.10;
expose CBQ_MAXPRI to userland

branches: 1.4.6;
Spell 'should' correctly.

branches: 1.3.2; 1.3.14;
HZ -> hz

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.22.6; 1.22.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

Avoid storing a pointer of an interface in a mbuf

Having a pointer of an interface in a mbuf isn't safe if we remove big
kernel locks; an interface object (ifnet) can be destroyed anytime in any
packet processing and accessing such object via a pointer is racy. Instead
we have to get an object from the interface collection (ifindex2ifnet) via
an interface index (if_index) that is stored to a mbuf instead of an
pointer.

The change provides two APIs: m_{get,put}_rcvif_psref that use psref(9)
for sleep-able critical sections and m_{get,put}_rcvif that use
pserialize(9) for other critical sections. The change also adds another
API called m_get_rcvif_NOMPSAFE, that is NOT MP-safe and for transition
moratorium, i.e., it is intended to be used for places where are not
planned to be MP-ified soon.

The change adds some overhead due to psref to performance sensitive paths,
however the overhead is not serious, 2% down at worst.

Proposed on tech-kern and tech-net.

branches: 1.20.8; 1.20.26;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

branches: 1.19.76;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.18.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.14.4; 1.14.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.10.4; 1.10.6; 1.10.8; 1.10.10; 1.10.12;
merge ktrace-lwp.

branches: 1.9.4;
nuke trailing whitespace

branches: 1.8.8; 1.8.10;
Uppercase CPU, plural is CPUs.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

There is NO reason to use arc4random() here, and it needlessly slows down the
forwarding path, so goodbye.

use arc4random. sync w/ kame

branches: 1.4.16;
add RCSIDs

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.4.12; 1.4.20; 1.4.22;
merge ktrace-lwp.

branches: 1.3.4;
nuke trailing whitespace

branches: 1.2.2; 1.2.26; 1.2.34; 1.2.36;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

remove redundant and dead #ifdef _KERNEL branches and use cprng directly

the entire code is in a _KERNEL block. move the header decl in in the original _KERNEL block.
redefining _KERNEL to use cprng is purely a dead branch and we should either use random or cprng.

Half revert the previous.

Only use cprng_fast32() for in kernel (ie: #ifdef _KERNEL) usages,
leave rump (and anything else userland) doing it the old way.

coverity scan: use a more secure random generator when randomly selecting a packet in queue

return: remove parenthesis from return statements

branches: 1.8.38;
s/static inline/static __inline/g for consistency.

branches: 1.7.140;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.6.12; 1.6.20; 1.6.22;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.4.4;
nuke trailing whitespace

branches: 1.3.22; 1.3.30; 1.3.32;
From KAME:

kjc 2001/02/09 16:20:40 JST

Modified files:
kame/sys/altq altq_classq.h altq_rmclass.c
Log:
clear m_nextpkt at dequeueing a packet.

this is not needed in the current code but
requested by Lars Eggert <larse@ISI.EDU> for
their experiment to use altq for inbound processing.

Revision Changes Path
1.4 +4 -1 kame/kame/sys/altq/altq_classq.h
1.10 +4 -1 kame/kame/sys/altq/altq_rmclass.c

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.22.6; 1.22.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.20.2;
Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

branches: 1.19.76; 1.19.86; 1.19.92;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.18.4;
Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.16.2; 1.16.4;
add missing initializer

- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

branches: 1.12.4; 1.12.6; 1.12.8; 1.12.10; 1.12.12;
merge ktrace-lwp.

branches: 1.11.4;
nuke trailing whitespace

branches: 1.10.6; 1.10.14; 1.10.16;
merge kqueue branch into -current

kqueue provides a stateful and efficient event notification framework
currently supported events include socket, file, directory, fifo,
pipe, tty and device changes, and monitoring of processes and signals

kqueue is supported by all writable filesystems in NetBSD tree
(with exception of Coda) and all device drivers supporting poll(2)

based on work done by Jonathan Lemon for FreeBSD
initial NetBSD port done by Luke Mewburn and Jason Thorpe

pull only "opt_altq_enabled.h" in if_altq.h, and include altqconf.h
explicitly in single file which implicitly needed it (altq_conf.c)

this avoids pulling in implicit dependency on <sys/conf.h> to every
file including <net/if.h> (which includes <altq/if_altq.h> to get altq
related structures)

make this compile.

Merge the gehenna-devsw branch into the trunk.

This merge changes the device switch tables from static array to
dynamically generated by config(8).

- All device switches is defined as a constant structure in device drivers.

- The new grammer ``device-major'' is introduced to ``files''.

device-major <prefix> char <num> [block <num>] [<rules>]

- All device major numbers must be listed up in port dependent majors.<arch>
by using this grammer.

- Added the new naming convention.
The name of the device switch must be <prefix>_[bc]devsw for auto-generation
of device switch tables.

- The backward compatibility of loading block/character device
switch by LKM framework is broken. This is necessary to convert
from block/character device major to device name in runtime and vice versa.

- The restriction to assign device major by LKM is completely removed.
We don't need to reserve LKM entries for dynamic loading of device switch.

- In compile time, device major numbers list is packed into the kernel and
the LKM framework will refer it to assign device major number dynamically.

branches: 1.6.6;
bring in latest ALTQ from kjc. ALTQify some of the drivers.

add RCSIDs

branches: 1.4.2; 1.4.4; 1.4.6; 1.4.8;
Saner glue into cdevsw.

No need to wrap these in #ifdef ALTQ -- they're not even included
if ALTQ is not configured into the kernel.

Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.9.4;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.8.12; 1.8.20; 1.8.22;
merge ktrace-lwp.

branches: 1.7.2;
add a missing const.

branches: 1.6.2;
Back out the lwp/ktrace changes. They contained a lot of colateral damage,
and need to be examined and discussed more.

Pass lwp pointers throughtout the kernel, as required, so that the lwpid can
be inserted into ktrace records. The general change has been to replace
"struct proc *" with "struct lwp *" in various function prototypes, pass
the lwp through and use l_proc to get the process pointer when needed.

Bump the kernel rev up to 1.6V

Merge the gehenna-devsw branch into the trunk.

This merge changes the device switch tables from static array to
dynamically generated by config(8).

- All device switches is defined as a constant structure in device drivers.

- The new grammer ``device-major'' is introduced to ``files''.

device-major <prefix> char <num> [block <num>] [<rules>]

- All device major numbers must be listed up in port dependent majors.<arch>
by using this grammer.

- Added the new naming convention.
The name of the device switch must be <prefix>_[bc]devsw for auto-generation
of device switch tables.

- The backward compatibility of loading block/character device
switch by LKM framework is broken. This is necessary to convert
from block/character device major to device name in runtime and vice versa.

- The restriction to assign device major by LKM is completely removed.
We don't need to reserve LKM entries for dynamic loading of device switch.

- In compile time, device major numbers list is packed into the kernel and
the LKM framework will refer it to assign device major number dynamically.

branches: 1.3.2; 1.3.4; 1.3.16;
remove variable names from prototype. sync with kame.

branches: 1.2.2;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.18.6; 1.18.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.16.86; 1.16.106;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.15.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.11.4; 1.11.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.7.4; 1.7.6; 1.7.8; 1.7.10; 1.7.12;
merge ktrace-lwp.

branches: 1.6.4;
nuke trailing whitespace

branches: 1.5.8; 1.5.10;
- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.4.16;
add RCSIDs

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.6.12; 1.6.20; 1.6.22;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.4; 1.4.6;
hide in-kernel structure by _KERNEL

Spell length with h after t. Inspired by a commit by brad@openbsd.

branches: 1.2.2; 1.2.26;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Need opt_inet.h for #ifdef INET, INET6.

branches: 1.3.142; 1.3.146;
Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.2.2; 1.2.42; 1.2.64; 1.2.72; 1.2.74;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.30.6; 1.30.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

sys/altq: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.

branches: 1.28.4;
Remove the 't' argument from m_tag_find().

branches: 1.27.2; 1.27.4;
Zero buffers copied to userland to avoid stack disclosure.

From Ilja Van Sprundel.

branches: 1.26.10;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

Prevent interface deletion from running into an infinite loop when altq closes.
$ cat /etc/altq.conf
interface ppp0 bandwidth 10M priq
class priq ppp0 high_class_ppp NULL priority 1
class priq ppp0 low_class_ppp NULL priority 0 default
filter ppp0 high_class_ppp 0 0 0 0 1
$ ifconfig ppp0 create
$ /etc/rc.d/altqd onestart
$ ifconfig ppp0 destroy
$ pkill altqd
XXX: pullup-7

branches: 1.24.36; 1.24.40; 1.24.42; 1.24.52; 1.24.58; 1.24.60; 1.24.62; 1.24.66;
merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@. requested by core@

branches: 1.23.36; 1.23.38; 1.23.40; 1.23.42; 1.23.44;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.22.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.17.4; 1.17.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Complete the FREE -> free transition and add more NULL checks for malloc
returns. Although these cannot happen because M_WAITOK, the rest of the
code does them already, so this is good for consistency. From Mindaugas

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.12.4; 1.12.6; 1.12.8; 1.12.10; 1.12.12;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.10.4;
nuke trailing whitespace

branches: 1.9.8; 1.9.10;
Uppercase CPU, plural is CPUs.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.7.2;
avoid name collision [class_stats]

sync with KAME.
- don't MALLOC() with M_WAITOK in the spl block.
move the allocation before splnet().
- when we reset vt of a class, reset the runtime service curve as well.
- don't use max() to compare 64 bit values.

branches: 1.5.8;
add RCSIDs

avoid divide-by-zero when the specified bandwidth is less than 8bps.
OpenBSD PR: kernel/2150

branches: 1.3.2; 1.3.4; 1.3.6;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.7.12; 1.7.20; 1.7.22;
merge ktrace-lwp.

branches: 1.6.4;
nuke trailing whitespace

branches: 1.5.2; 1.5.10; 1.5.12;
fix typo, from David Laight.

oops, forgot to rename two struct refs.

avoid name collision [class_stats]

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Fix various typos, mainly in comments:
s/invaid/invalid/
s/instad/instead/
s/wich/with/
s/tranform/transform/
s/tranmist/transmit/
s/tranceiver/transceiver/
s/Tranparent/Transparent/
s/tranlated/translated/
s/tranfer/transfer/
s/tranmissions/transmissions/
s/condtions/conditions/
s/Recient/Recent/

return: remove parenthesis from return statements

compile time: use right jobs interface and return value

branches: 1.12.6; 1.12.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

Zero buffers copied to userland to avoid stack disclosure.

From Ilja Van Sprundel.

branches: 1.10.8;
PR 51553 David Binderman: don't bother counting up backlogged classes
when not doing anything with the results.

branches: 1.9.2;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

Prevent interface deletion from running into an infinite loop when altq closes.
$ cat /etc/altq.conf
interface ppp0 bandwidth 10M priq
class priq ppp0 high_class_ppp NULL priority 1
class priq ppp0 low_class_ppp NULL priority 0 default
filter ppp0 high_class_ppp 0 0 0 0 1
$ ifconfig ppp0 create
$ /etc/rc.d/altqd onestart
$ ifconfig ppp0 destroy
$ pkill altqd
XXX: pullup-7

branches: 1.7.2;
Fix error branches to avoid leaks, noted by maxv@.

branches: 1.6.14; 1.6.18; 1.6.20; 1.6.28; 1.6.34;
rename the altq-defined INFINITY symbol to ALTQ_INFINITY

- it is not infinity
- it is exposed to userland
- it causes confusion when #include <math.h> follows
(I don't know why GCC does not object to redefining the symbol)

branches: 1.5.40; 1.5.62; 1.5.64;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.4.4; 1.4.6;
__unused removal on arguments; approved by core.

Kill another KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.1.2; 1.1.6; 1.1.8;
file altq_jobs.c was initially added on branch peter-altq.

whitespace: clear trailing whitespaces

branches: 1.5.96;
rename the altq-defined INFINITY symbol to ALTQ_INFINITY

- it is not infinity
- it is exposed to userland
- it causes confusion when #include <math.h> follows
(I don't know why GCC does not object to redefining the symbol)

branches: 1.4.14; 1.4.16;
Don't redefine INFINITY.

branches: 1.3.4; 1.3.50; 1.3.54; 1.3.56; 1.3.60;
Use another number for JOBS_CLEAR because it clashes with PRIQ_CLEAR.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.1.2; 1.1.6; 1.1.8;
file altq_jobs.h was initially added on branch peter-altq.

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.9.4;
__unused removal on arguments; approved by core.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.6.12; 1.6.20; 1.6.22;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.16; 1.4.24; 1.4.26;
add RCSIDs

branches: 1.3.2;
copyright clarification (the skeleton file is in public domain)

branches: 1.2.2; 1.2.4; 1.2.6;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.28.6; 1.28.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

sys/altq: Memset zero before copyout.

Just in case of uninitialized padding which would lead to kernel
stack disclosure. If the compiler can prove the memset redundant
then it can optimize it away; otherwise better safe than sorry.

branches: 1.26.4;
Remove the 't' argument from m_tag_find().

branches: 1.25.2;
simplify priq_class_create(): if the alloc for cl_q fails,
then only clean up required to to free cl. delete all the
code at err_ret that was probably used in the past, and move
the free + return upon failure earlier.

branches: 1.24.2;
Zero buffers copied to userland to avoid stack disclosure.

From Ilja Van Sprundel.

branches: 1.23.10;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

Prevent interface deletion from running into an infinite loop when altq closes.
$ cat /etc/altq.conf
interface ppp0 bandwidth 10M priq
class priq ppp0 high_class_ppp NULL priority 1
class priq ppp0 low_class_ppp NULL priority 0 default
filter ppp0 high_class_ppp 0 0 0 0 1
$ ifconfig ppp0 create
$ /etc/rc.d/altqd onestart
$ ifconfig ppp0 destroy
$ pkill altqd
XXX: pullup-7

branches: 1.21.18; 1.21.22; 1.21.24; 1.21.32; 1.21.38; 1.21.40; 1.21.42; 1.21.46;
Change about 4500 of the K&R function definitions to ANSI ones.
There are still about 1600 left, but they have ',' or /* ... */
in the actual variable definitions - which my awk script doesn't handle.
There are also many that need () -> (void).
(The script does handle misordered arguments.)

branches: 1.20.4; 1.20.10;
merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@. requested by core@

branches: 1.19.36; 1.19.38; 1.19.40; 1.19.42; 1.19.44;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.18.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.13.4; 1.13.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.9.4; 1.9.6; 1.9.8; 1.9.10; 1.9.12;
merge ktrace-lwp.

branches: 1.8.4;
nuke trailing whitespace

branches: 1.7.8; 1.7.10;
- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.6.2;
avoid name collision [class_stats]

add RCSIDs

avoid divide-by-zero when the specified bandwidth is less than 8bps.
OpenBSD PR: kernel/2150

branches: 1.3.2; 1.3.4; 1.3.6;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.6.12; 1.6.20; 1.6.22;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.2; 1.4.10; 1.4.12;
oops, forgot to rename two struct refs.

avoid name collision [class_stats]

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.35.6; 1.35.8;
s/failes/fails/ in comment.

Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

fix typos in comments, mainly s/extention/extension/ and s/sufficent/sufficient/

s/lenght/length/

Remove the 't' argument from m_tag_find().

branches: 1.30.16; 1.30.18;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.29.8; 1.29.26;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

branches: 1.28.30;
merge yamt-pf42 branch.
(import newer pf from OpenBSD 4.2)

ok'ed by peter@. requested by core@

branches: 1.27.6; 1.27.8; 1.27.10; 1.27.12; 1.27.14;
Now that __HAVE_TIMECOUNTER and __HAVE_GENERIC_TODR are invariants,
remove the conditionals and the code associated with the undef case.

branches: 1.26.10; 1.26.16; 1.26.22;
Remove duplicate #include <sys/kauth.h>
From: Slava Semushin <php-coder@altlinux.ru>

branches: 1.25.2; 1.25.4; 1.25.6;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.24.4;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.19.4; 1.19.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

fix timecounter fallout

branches: 1.17.2;
kauth fallout

integrate kauth.

Complete the FREE -> free transition and add more NULL checks for malloc
returns. Although these cannot happen because M_WAITOK, the rest of the
code does them already, so this is good for consistency. From Mindaugas

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.13.4; 1.13.6; 1.13.8; 1.13.10; 1.13.12;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.11.4;
nuke trailing whitespace

branches: 1.10.8; 1.10.10;
Spell length with h after t. Inspired by a commit by brad@openbsd.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

There is NO reason to use arc4random() here, and it needlessly slows down the
forwarding path, so goodbye.

use arc4random. sync w/ kame

branches: 1.6.14;
bring in latest ALTQ from kjc. ALTQify some of the drivers.

add RCSIDs

branches: 1.4.2; 1.4.4;
Fix typo. s/extention/extension/

Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.4.12; 1.4.20; 1.4.22;
merge ktrace-lwp.

branches: 1.3.4;
nuke trailing whitespace

branches: 1.2.2; 1.2.26; 1.2.34; 1.2.36;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.25.6; 1.25.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

s/lenght/length/

branches: 1.23.18;
Use M_GETCTX and M_SETCTX instead of open-coding rcvif

No functional change.

IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.21.22; 1.21.40;
Remove extra whitespace added by a stupid tool.
XXX: more in src/sys/arch

bcopy -> memcpy

branches: 1.19.40; 1.19.50; 1.19.56;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.18.2;
Remove duplicate #includes, patch contributed in private mail
by Slava Semushin <slava.semushin@gmail.com>.

To verify that no nasty side effects of duplicate includes (or their
removal) have an effect here, I've compiled an i386/ALL kernel with
and without the patch, and the only difference in the resulting .o
files was in shifted line numbers in some assert() calls.
The comparison of the .o files was based on the output of "objdump -D".

Thanks to martin@ for the input on testing.

__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.12.4; 1.12.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.8.4; 1.8.6; 1.8.8; 1.8.10; 1.8.12;
merge ktrace-lwp.

branches: 1.7.4;
nuke trailing whitespace

branches: 1.6.8; 1.6.10;
Spell length with h after t. Inspired by a commit by brad@openbsd.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.4.16;
add RCSIDs

branches: 1.3.2; 1.3.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.4.12; 1.4.20; 1.4.22;
merge ktrace-lwp.

branches: 1.3.4;
nuke trailing whitespace

branches: 1.2.2; 1.2.26; 1.2.34; 1.2.36;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

altq, cbq: take care of borrowed classes on sleeping

rmc_under_limit() determines if we can send a packet by checking
that a target class (or borrowing classes) is ready to send a
packet. cl->undertime_ indicates a time that the class can send
packets after the time. So if cl->undertime_ has passed
(i.e., now >= cl->undertime_), we can send packets through the class.

The treatment is important when a required delay period is shorten
than the minimum delay on the system (a tick), because in that case
the delay handler is too late to wake up to send a packet in time.
If there are traffic, rmc_under_limit() can save such a case.

Unfortunately, the old code didn't take care of bandwidth borrowing
on sleeping. So bandwidth borrowing didn't work well with high
bandwidths that require short delay actions.

branches: 1.30.2;
fix spelling mistakes, mainly in comments and log messages.

branches: 1.29.10;
altq: fix CBQ with RED and/or pf

altq, cbq: apply tweaks for PPP to only PPP interfaces

altq, cbq: change long to uint64_t for ILP32 archs

PR kern/56319

altq, cbq: treat time in nanoseconds

Time granularity in microseconds is sometimes not enough to provide
accurate bandwidth control; actual bandwidth on a capped class
can exceed its limit considerably in some cases.

Treating time in nanoseconds requires the following changes:
- Use timespec instead of timeval
- Use nanotime(9) instead of microtime(9)
- Change the type of some variables, especially *idle, to long

altq, cbq: convert ns_per_byte to ps_per_byte

Also the type of variables of it is changed to u_long from int.

This change provides fine-grain resolution of bandwidth. For example
750 Mbps was treated as 800 Mbps internally because bandwidth was
represented as nanoseconds per byte. Converting the representation
to picoseconds per byte enables to treat 750 Mbps as-is.

PR kern/56319

altq, cbq: calculate a delay period based on a borrowed class

A delay period was calculated based on a suspended class even if the
class can borrow bandwidth from another class. In that case a delay
period should be calculated based on a borrowed class. Otherwise
a borrowing class can't borrow bandwidth correctly.

altq, cbq: don't increment the xmit counter of the root class twice wrongly

branches: 1.22.66;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

branches: 1.21.28;
Use more timespecs internally. From Alexander Shishkin and me.
Welcome to 4.99.70, 30 more to go for 100.

branches: 1.20.36; 1.20.40; 1.20.42; 1.20.44; 1.20.46;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.19.2;
Comment out #ident.

__unused removal on arguments; approved by core.

Don't allow to initialize an interface with MTU smaller than one.
This prevents a divide by zero and fixes PR #21474.

ok tron@

avoid shadowing "delay"

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.13.8; 1.13.10;
Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.12.2; 1.12.4; 1.12.6;
Fix some typos.

branches: 1.11.2; 1.11.4; 1.11.6;
merge ktrace-lwp.

rename shadowing variable delay to nowdelay.

branches: 1.9.4;
nuke trailing whitespace

branches: 1.8.8; 1.8.10;
- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

There is NO reason to use arc4random() here, and it needlessly slows down the
forwarding path, so goodbye.

use arc4random. sync w/ kame

branches: 1.5.16;
add RCSIDs

branches: 1.4.2;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

From KAME:

kjc 2001/02/09 16:20:40 JST

Modified files:
kame/sys/altq altq_classq.h altq_rmclass.c
Log:
clear m_nextpkt at dequeueing a packet.

this is not needed in the current code but
requested by Lars Eggert <larse@ISI.EDU> for
their experiment to use altq for inbound processing.

Revision Changes Path
1.4 +4 -1 kame/kame/sys/altq/altq_classq.h
1.10 +4 -1 kame/kame/sys/altq/altq_rmclass.c

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

altq, cbq: fix TS_ADD_DELTA on ILP32

TS_ADD_DELTA adds a nanosecond value, delta, to a timespec value while
delta is int64_t and tv_nsec is long. delta is guaranteed as positive
in ALTQ/CBQ. However, the original code used delta after casting it
into long. So it could be negative on ILP32 systems. TS_ADD_DELTA
didn't assume that delta was negative and resulting tv_nsec could be
negative unexpectedly.

This issue was likely to occur when bandwidth borrowing was used where
the borrowing class had a absolutely small bandwidth (e.g., less than
10 Mbps) or a relatively small bandwidth (e.g., 10 Mbps when the parent
class had 200 Mbps).

KASSERT has been added to guarantee resulting tv_nsec is always not
negative. Additionally, another KASSERT has been added to make it clear
that delta is assumed to be non-negative.

branches: 1.13.4; 1.13.10;
fix various typos in comment, documentation and log messages.

altq, cbq: change long to uint64_t for ILP32 archs

PR kern/56319

altq, cbq: treat time in nanoseconds

Time granularity in microseconds is sometimes not enough to provide
accurate bandwidth control; actual bandwidth on a capped class
can exceed its limit considerably in some cases.

Treating time in nanoseconds requires the following changes:
- Use timespec instead of timeval
- Use nanotime(9) instead of microtime(9)
- Change the type of some variables, especially *idle, to long

altq, cbq: convert ns_per_byte to ps_per_byte

Also the type of variables of it is changed to u_long from int.

This change provides fine-grain resolution of bandwidth. For example
750 Mbps was treated as 800 Mbps internally because bandwidth was
represented as nanoseconds per byte. Converting the representation
to picoseconds per byte enables to treat 750 Mbps as-is.

PR kern/56319

altq, cbq: apply the do-while idiom to TV_* macros

branches: 1.8.158;
Don't allow to initialize an interface with MTU smaller than one.
This prevents a divide by zero and fixes PR #21474.

ok tron@

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.6.12; 1.6.20; 1.6.22;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.8; 1.4.10;
expose CBQ_MAXPRI to userland

branches: 1.3.14;
bring in latest ALTQ from kjc. ALTQify some of the drivers.

branches: 1.2.2; 1.2.4; 1.2.6;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.6.12; 1.6.20; 1.6.22;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.8; 1.4.10;
- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.3.22;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.2.2; 1.2.4;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.33.46; 1.33.48;
Use if_acquire and if_release instead of using psref API directly

- Provide if_release for consistency to if_acquire
- Use if_acquire and if_release for ifp iterations
- Make ifnet_psref_class static

branches: 1.32.2; 1.32.4;
apply if_start_lock() to L2 callers which call ifp->if_start() of device derivers

Protect ifnet list with psz and psref

The change ensures that ifnet objects in the ifnet list aren't freed during
list iterations by using pserialize(9) and psref(9).

Note that the change adds a pslist(9) for ifnet but doesn't remove the
original ifnet list (ifnet_list) to avoid breaking kvm(3) users. We
shouldn't use the original list in the kernel anymore.

IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.29.4;
- Move IFNET_*() macros under #ifdef _KERNEL.
- Replace TAILQ_FOREACH on ifnet with IFNET_FOREACH().

branches: 1.28.24; 1.28.28; 1.28.38;
add braces for symmetry

Use binuptime(9) and emulate 1GiHz (2^30) counter rather than
nanouptime(9) and 1GHz counter to avoid extra rescaling.
Suggested and reviewed by kardel@.

In machclk functions always emulate 1GHz counter using nanotime(9)
since it has enough resolution via timecounter(9).
Using machine dependent cpu_counter() is not MP safe
and it won't work even on UP with Speedstep etc.

No particular comment on tech-kern, and also closes PR kern/39835.

branches: 1.25.4; 1.25.6; 1.25.8;
Use MI cpu_counter() interface.

branches: 1.24.16; 1.24.18; 1.24.20; 1.24.22;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.23.4;
init tbr_callout in all cases (hi ad!)

branches: 1.22.2; 1.22.6; 1.22.8;
Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

branches: 1.21.2; 1.21.4;
Use mtod(m, char*) when doing pointer arithmetic on the result.
Patch from Andreas Wrede.

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.19.4;
__unused removal on arguments; approved by core.

Don't enable ALTQ in altq_pfattach. Enabling/disabling of ALTQ is already
done in the pf(4) code (pf_ioctl.c).

From OpenBSD.

Only compile in pf specific code when pf is configured.
Fixes kernel build when ALTQ is configured and pf not.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.14.8; 1.14.10;
Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.13.4; 1.13.6; 1.13.8; 1.13.10; 1.13.12;
merge ktrace-lwp.

branches: 1.12.4;
nuke trailing whitespace

branches: 1.11.8; 1.11.10;
Uppercase CPU, plural is CPUs.

- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.9.6;
replace cpu_tsc_freq with curcpu()->ci_tsc_freq

bring in latest ALTQ from kjc. ALTQify some of the drivers.

add RCSIDs

fix IPv4 fragment handling in the classifier.
report and fix by "Paul Koster" <list@kosteronline.net>
sync with kame

branches: 1.5.2; 1.5.4;
Remove the use of splimp() from the NetBSD kernel. splnet()
and only splnet() is allowed for the protection of data structures
used by network devices.

branches: 1.4.2; 1.4.4;
Don't need <vm/vm.h> (it doesn't exist in -current).

No need to wrap these in #ifdef ALTQ -- they're not even included
if ALTQ is not configured into the kernel.

Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

s/functiuon/function/ in comment.

branches: 1.12.104;
In machclk functions always emulate 1GHz counter using nanotime(9)
since it has enough resolution via timecounter(9).
Using machine dependent cpu_counter() is not MP safe
and it won't work even on UP with Speedstep etc.

No particular comment on tech-kern, and also closes PR kern/39835.

branches: 1.11.28; 1.11.32; 1.11.38; 1.11.42; 1.11.44;
Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

branches: 1.10.8; 1.10.10;
Don't enable ALTQ in altq_pfattach. Enabling/disabling of ALTQ is already
done in the pf(4) code (pf_ioctl.c).

From OpenBSD.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

branches: 1.8.6; 1.8.14; 1.8.16;
Change "inline" back to "__inline" in .h files -- C99 is still too
new, and some apps compile things in C89 mode. C89 keywords stay.

As per core@.

branches: 1.7.2; 1.7.4; 1.7.6;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.5.16;
- kill bzero/bcopy
- defopt stats and settings, removing their definitions from the files
- make code compile by eliminating multicharacter constants!?! and rearranging
variable declarations so they are defined before used!?!
- help gcc with uninitialized variables

branches: 1.4.6;
/*CONTCOND*/ while (0)'ed macros

define ALTQ_NOPCC if i386 and !I586_CPU and !I686_CPU.
otherwise, kernel fails to compile.
report by "Federico G. Schwindt" <fgsch@olimpo.com.br>

branches: 1.2.2; 1.2.4; 1.2.6; 1.2.18;
Add NetBSD RCS IDs.

branches: 1.1.1;
Initial revision

return: remove parenthesis from return statements

branches: 1.23.6; 1.23.8;
Remove FreeBSD blocks that did not compile anyway, and use l->l_cred
consistently.

Reject negative indices.

(Would be nice to change the types too, and it's *probably* safe to
replace int by u_int, but I'm reluctant to touch the ioctl
definitions without at least a modicum more thought. Also one of
them is a u_long, because why not?)

From Ilja Van Sprundel.

branches: 1.21.10;
IFQ_ENQUEUE refactor (2/3) : eliminate pktattr argument from altq implemantation

branches: 1.20.4; 1.20.6; 1.20.8; 1.20.12;
kill sprintf

branches: 1.19.28; 1.19.34; 1.19.38; 1.19.40; 1.19.44; 1.19.50;
Add support for source address hashhing in ALTQs WFQ. This allows to
easily distribute bandwidth for huge number of clients for incoming
traffic.

branches: 1.18.36; 1.18.40; 1.18.42; 1.18.46;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.17.2; 1.17.4; 1.17.8;
__unused removal on arguments; approved by core.

Kill some KAUTH_GENERIC_ISSUSER.

Merge the peter-altq branch.

(sync with KAME & add support for using ALTQ with pf(4)).

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.13.4; 1.13.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

kauth fallout

integrate kauth.

Use malloc/free instead of MALLOC/FREE and M_ZERO instead of memset.

branches: 1.9.4; 1.9.6; 1.9.8; 1.9.10; 1.9.12;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.7.4;
nuke trailing whitespace