Home | History | Annotate | Download | only in dev
History log of /src/sys/arch/sparc64/dev/ffb_mainbus.c
RevisionDateAuthorComments
 1.15  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.14  04-Nov-2016  macallan branches: 1.14.14; 1.14.16;
set BUS_SPACE_MAP_PREFETCHABLE when mapping the SFB32 range
now using alpha fonts is actually faster than using bitmap fonts
 1.13  22-Dec-2011  macallan branches: 1.13.6; 1.13.24; 1.13.28;
support anti-aliased fonts and let the hardware do the alpha blending
 1.12  31-Oct-2011  jdc branches: 1.12.2; 1.12.6;
Add support for the WSDISPLAYIO_GET_EDID ioctl (requires passing a device_t
to ffb_attach).
 1.11  01-Jul-2011  dyoung #include <sys/bus.h> instead of <machine/bus.h>.
 1.10  03-Jun-2011  christos CFATTACH_DECL_NEW
 1.9  21-Sep-2010  macallan branches: 1.9.2; 1.9.6;
* implement hw acceleration for putchar()
* use VCONS for copycols()
* don't map the framebuffer now that we don't access it anymore
* make a bunch of drawing engine syncs optional
 1.8  11-Dec-2005  christos branches: 1.8.78; 1.8.98; 1.8.100;
merge ktrace-lwp.
 1.7  04-May-2005  martin Make ffb take part in the /dev/fbN circus.
 1.6  04-May-2005  martin Ansify.
 1.5  01-Jul-2004  heas branches: 1.5.10;
The DAC registers do not need to be mapped linearly and thus should not.
 1.4  21-May-2004  heas Map the ffb's DAC register space and add support for video "blanking"
(aka WSDISPLAYIO_{S,G}VIDEO).
 1.3  19-Mar-2004  petrov More on fbnode to prom_stdout_node rename.
 1.2  15-Jul-2003  lukem __KERNEL_RCSID()
 1.1  23-May-2003  petrov branches: 1.1.2;
Port of OpenBSD ffb driver written by Jason L. Wright.
 1.1.2.4  10-Nov-2005  skrll Sync with HEAD. Here we go again...
 1.1.2.3  21-Sep-2004  skrll Fix the sync with head I botched.
 1.1.2.2  18-Sep-2004  skrll Sync with HEAD.
 1.1.2.1  03-Aug-2004  skrll Sync with HEAD
 1.5.10.2  07-Jun-2005  tron Pull up revision 1.7 (requested by martin in ticket #376):
Make ffb take part in the /dev/fbN circus.
 1.5.10.1  07-Jun-2005  tron Pull up revision 1.6 (requested by martin in ticket #376):
Ansify.
 1.8.100.2  12-Jun-2011  rmind sync with head
 1.8.100.1  05-Mar-2011  rmind sync with head
 1.8.98.1  22-Oct-2010  uebayasi Sync with HEAD (-D20101022).
 1.8.78.1  09-Oct-2010  yamt sync with head
 1.9.6.1  23-Jun-2011  cherry Catchup with rmind-uvmplock merge.
 1.9.2.1  06-Jun-2011  jruoho Sync with HEAD.
 1.12.6.1  18-Feb-2012  mrg merge to -current.
 1.12.2.1  17-Apr-2012  yamt sync with head
 1.13.28.1  07-Jan-2017  pgoyette Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
 1.13.24.1  05-Dec-2016  skrll Sync with HEAD
 1.13.6.1  03-Dec-2017  jdolecek update from HEAD
 1.14.16.1  10-Jun-2019  christos Sync with HEAD
 1.14.14.1  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)

RSS XML Feed