History log of /src/sys/dev/ieee1394/sbp.c |
Revision | | Date | Author | Comments |
1.43 |
| 11-Jul-2025 |
andvar | Fix various typos, mainly in comments and log/error messages.
|
1.42 |
| 12-Apr-2022 |
andvar | s/sould/should/ and s/shoud/should/
|
1.41 |
| 07-Aug-2021 |
thorpej | Merge thorpej-cfargs2.
|
1.40 |
| 24-Apr-2021 |
thorpej | branches: 1.40.8; Merge thorpej-cfargs branch:
Simplify and make extensible the config_search() / config_found() / config_attach() interfaces: rather than having different variants for which arguments you want pass along, just have a single call that takes a variadic list of tag-value arguments.
Adjust all call sites: - Simplify wherever possible; don't pass along arguments that aren't actually needed. - Don't be explicit about what interface attribute is attaching if the device only has one. (More simplification.) - Add a config_probe() function to be used in indirect configuiration situations, making is visibly easier to see when indirect config is in play, and allowing for future change in semantics. (As of now, this is just a wrapper around config_match(), but that is an implementation detail.)
Remove unnecessary or redundant interface attributes where they're not needed.
There are currently 5 "cfargs" defined: - CFARG_SUBMATCH (submatch function for direct config) - CFARG_SEARCH (search function for indirect config) - CFARG_IATTR (interface attribte) - CFARG_LOCATORS (locators array) - CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)
...and a sentinel value CFARG_EOL.
Add some extra sanity checking to ensure that interface attributes aren't ambiguous.
Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark ports to associate those device handles with device_t instance. This will trickle trough to more places over time (need back-end for pre-OFW Sun OBP; any others?).
|
1.39 |
| 10-Nov-2019 |
chs | branches: 1.39.10; in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT and remove code to handle failures that can no longer happen.
|
1.38 |
| 23-Sep-2019 |
maxv | Remove unused assignment. Found by the lgtm bot.
|
1.37 |
| 03-Sep-2018 |
riastradh | Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
|
1.36 |
| 25-Feb-2014 |
pooka | branches: 1.36.28; 1.36.30; Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before the sysctl link sets are processed, and remove redundancy.
Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate lines of code.
|
1.35 |
| 15-Sep-2013 |
martin | Remove unused variables
|
1.34 |
| 29-Apr-2012 |
dsl | branches: 1.34.2; 1.34.4; Remove everything to do with 'struct malloc_type' and the malloc link_set. To make code in 'external' (etc) still compile, MALLOC_DECLARE() still has to generate something of type 'struct malloc_type *', with normal optimisation gcc generates a compile-time 0. MALLOC_DEFINE() and friends have no effect. Fix one or two places where the code would no longer compile.
|
1.33 |
| 14-Aug-2010 |
cegger | branches: 1.33.8; 1.33.12; Fix sbp attach/detach. When plugging a firewire webcam, sbp attaches. sbpattach() calls sbp_alloc_target(). In sbp_alloc_target, crom_search_key() fails and sbp_alloc_target() returns NULL. Move mutex and list initializations up in sbpattach() and in sbp_alloc_target() so that destroyal of them through sbpdetach() does not cause LOCKDEBUG panics when unplugging the firewire webcam.
|
1.32 |
| 23-May-2010 |
christos | Revert all previous kmem_ commits. This needs to be done in a different way because we cannot call kmem_ from an interrupt context. I opened PR/43341 for it.
|
1.31 |
| 10-May-2010 |
kiyohara | Use kmem(9) instead of malloc(9).
|
1.30 |
| 29-Apr-2010 |
kiyohara | + Use structs scsipi_inquiry_data/scsi_sense_data instead of scsi3_inquiry_data/ scsi3_sense_data. + s/switch()/switch ()/. + Change args for printf(). ("FUNCNAME ...") -> ("%s ...\n", __func__, ...) + Indent. + Remove unnecessary cast.
|
1.29 |
| 29-Mar-2010 |
kiyohara | Bye-bye fw_port.h.
|
1.28 |
| 12-May-2009 |
cegger | branches: 1.28.2; 1.28.4; struct cfdata * -> cfdata_t, no functional changes intended.
|
1.27 |
| 18-Apr-2009 |
tsutsui | Remove extra whitespace added by a stupid tool. XXX: more in src/sys/arch
|
1.26 |
| 18-Mar-2009 |
cegger | bcopy -> memcpy
|
1.25 |
| 18-Mar-2009 |
cegger | bzero -> memset
|
1.24 |
| 11-Jan-2009 |
christos | branches: 1.24.2; merge christos-time_t
|
1.23 |
| 03-Jan-2009 |
yamt | branches: 1.23.2; remove extra semicolons.
|
1.22 |
| 12-Nov-2008 |
ad | Remove LKMs and switch to the module framework, pass 1.
Proposed on tech-kern@.
|
1.21 |
| 29-Mar-2008 |
kiyohara | branches: 1.21.4; 1.21.10; 1.21.12; Split device_t/softc. And cosmetic change.
|
1.20 |
| 11-Dec-2007 |
lukem | branches: 1.20.8; use __KERNEL_RCSID()
|
1.19 |
| 05-Nov-2007 |
kiyohara | branches: 1.19.4; 1.19.6; 1.19.8; + Sync to FreeBSD. firewire.c Rev.1.101 firewire.h Rev.1.21 firewirereg.h Rev.1.50 fwdev.c Rev.1.52 fwdma.c Rev.1.9 fwmem.c Rev.1.34 fwohci.c Rev.1.93 fwohcireg.h Rev.1.23 fwohcivar.h Rev.1.16 if_fwip.c Rev.1.16 if_fwipvar.h Rev.1.5 sbp.c Rev.1.92 + Cleanup macros in fw_port.h. + Fix the occurrence of the error at the resume. Don't set the buffer again.
|
1.18 |
| 19-Oct-2007 |
ad | machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h
|
1.17 |
| 09-Jul-2007 |
ad | branches: 1.17.6; 1.17.8; 1.17.12; Merge some of the less invasive changes from the vmlocking branch:
- kthread, callout, devsw API changes - select()/poll() improvements - miscellaneous MT safety improvements
|
1.16 |
| 21-Apr-2007 |
kiyohara | firewire.c sync to Rev.1.86 for FreeBSD. firewirereg.h sync to Rev.1.41 for FreeBSD. fwcrom.c sync to Rev.1.14 for FreeBSD. fwdev.c sync to Rev.1.49 for FreeBSD. fwmem.c sync to Rev.1.32 for FreeBSD. fwohci.c sync to Rev.1.86 for FreeBSD. fwohcivar.h sync to Rev.1.15 for FreeBSD. if_fwip.c sync to Rev.1.14 for FreeBSD. if_fwipvar.h sync to Rev.1.4 for FreeBSD. sbp.c sync to Rev.1.89 for FreeBSD.
|
1.15 |
| 04-Mar-2007 |
christos | branches: 1.15.2; 1.15.4; Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.
|
1.14 |
| 22-Dec-2006 |
kiyohara | branches: 1.14.2; Use macro FWBUSNOTREADY.
|
1.13 |
| 16-Nov-2006 |
christos | __unused removal on arguments; approved by core.
|
1.12 |
| 12-Oct-2006 |
christos | - sprinkle __unused on function decls. - fix a couple of unused bugs - no more -Wno-unused for i386
|
1.11 |
| 14-May-2006 |
elad | branches: 1.11.6; 1.11.10; 1.11.12; integrate kauth.
|
1.10 |
| 30-Apr-2006 |
kiyohara | Do microtime() before return.
|
1.9 |
| 30-Apr-2006 |
kiyohara | Coordination of macro fw_bus_dma_tag_create().
|
1.8 |
| 14-Apr-2006 |
christos | Coverity CID 1121: Avoid NULL deref.
|
1.7 |
| 11-Apr-2006 |
rpaulo | Coverity ID 2443: In sbp_scsipi_detach_sdev() check for sdev and target being NULL before dereferencing them.
|
1.6 |
| 28-Mar-2006 |
thorpej | Use device_unit().
|
1.5 |
| 25-Feb-2006 |
wiz | branches: 1.5.2; 1.5.4; 1.5.6; Fix some typos.
|
1.4 |
| 24-Dec-2005 |
perry | branches: 1.4.2; 1.4.4; 1.4.6; Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.
|
1.3 |
| 11-Dec-2005 |
christos | merge ktrace-lwp.
|
1.2 |
| 29-Aug-2005 |
kiyohara | branches: 1.2.6; Remove '#if defined(cobalt)'.
|
1.1 |
| 11-Jul-2005 |
kiyohara | ieee1394 import from FreeBSD.
|
1.2.6.2 |
| 10-Nov-2005 |
skrll | Sync with HEAD. Here we go again...
|
1.2.6.1 |
| 29-Aug-2005 |
skrll | file sbp.c was added on branch ktrace-lwp on 2005-11-10 14:05:22 +0000
|
1.4.6.2 |
| 01-Jun-2006 |
kardel | Sync with head.
|
1.4.6.1 |
| 22-Apr-2006 |
simonb | Sync with head.
|
1.4.4.1 |
| 09-Sep-2006 |
rpaulo | sync with head
|
1.4.2.1 |
| 01-Mar-2006 |
yamt | sync with head.
|
1.5.6.2 |
| 24-May-2006 |
tron | Merge 2006-05-24 NetBSD-current into the "peter-altq" branch.
|
1.5.6.1 |
| 31-Mar-2006 |
tron | Merge 2006-03-31 NetBSD-current into the "peter-altq" branch.
|
1.5.4.2 |
| 11-May-2006 |
elad | sync with head
|
1.5.4.1 |
| 19-Apr-2006 |
elad | sync with head.
|
1.5.2.2 |
| 24-May-2006 |
yamt | sync with head.
|
1.5.2.1 |
| 01-Apr-2006 |
yamt | sync with head.
|
1.11.12.2 |
| 10-Dec-2006 |
yamt | sync with head.
|
1.11.12.1 |
| 22-Oct-2006 |
yamt | sync with head
|
1.11.10.2 |
| 12-Jan-2007 |
ad | Sync with head.
|
1.11.10.1 |
| 18-Nov-2006 |
ad | Sync with head.
|
1.11.6.7 |
| 21-Jan-2008 |
yamt | sync with head
|
1.11.6.6 |
| 15-Nov-2007 |
yamt | sync with head.
|
1.11.6.5 |
| 27-Oct-2007 |
yamt | sync with head.
|
1.11.6.4 |
| 03-Sep-2007 |
yamt | sync with head.
|
1.11.6.3 |
| 30-Dec-2006 |
yamt | sync with head.
|
1.11.6.2 |
| 21-Jun-2006 |
yamt | sync with head.
|
1.11.6.1 |
| 14-May-2006 |
yamt | file sbp.c was added on branch yamt-lazymbuf on 2006-06-21 15:04:08 +0000
|
1.14.2.2 |
| 07-May-2007 |
yamt | sync with head.
|
1.14.2.1 |
| 12-Mar-2007 |
rmind | Sync with HEAD.
|
1.15.4.1 |
| 11-Jul-2007 |
mjf | Sync with head.
|
1.15.2.5 |
| 23-Oct-2007 |
ad | Sync with head.
|
1.15.2.4 |
| 27-May-2007 |
ad | Sync with head.
|
1.15.2.3 |
| 13-May-2007 |
ad | - Pass the error number and residual count to biodone(), and let it handle setting error indicators. Prepare to eliminate B_ERROR. - Add a flag argument to brelse() to be set into the buf's flags, instead of doing it directly. Typically used to set B_INVAL. - Add a "struct cpu_info *" argument to kthread_create(), to be used to create bound threads. Change "bool mpsafe" to "int flags". - Allow exit of LWPs in the IDL state when (l != curlwp). - More locking fixes & conversion to the new API.
|
1.15.2.2 |
| 10-Apr-2007 |
ad | Nuke the deferred kthread creation stuff, as it's no longer needed. Pointed out by thorpej@.
|
1.15.2.1 |
| 09-Apr-2007 |
ad | - Add two new arguments to kthread_create1: pri_t pri, bool mpsafe. - Fork kthreads off proc0 as new LWPs, not new processes.
|
1.17.12.2 |
| 13-Nov-2007 |
bouyer | Sync with HEAD
|
1.17.12.1 |
| 25-Oct-2007 |
bouyer | Sync with HEAD.
|
1.17.8.2 |
| 09-Jan-2008 |
matt | sync with HEAD
|
1.17.8.1 |
| 06-Nov-2007 |
matt | sync with HEAD
|
1.17.6.2 |
| 06-Nov-2007 |
joerg | Sync with HEAD.
|
1.17.6.1 |
| 26-Oct-2007 |
joerg | Sync with HEAD.
Follow the merge of pmap.c on i386 and amd64 and move pmap_init_tmp_pgtbl into arch/x86/x86/pmap.c. Modify the ACPI wakeup code to restore CR4 before jumping back into kernel space as the large page option might cover that.
|
1.19.8.1 |
| 13-Dec-2007 |
bouyer | Sync with HEAD
|
1.19.6.1 |
| 11-Dec-2007 |
yamt | sync with head.
|
1.19.4.1 |
| 26-Dec-2007 |
ad | Sync with head.
|
1.20.8.2 |
| 17-Jan-2009 |
mjf | Sync with HEAD.
|
1.20.8.1 |
| 03-Apr-2008 |
mjf | Sync with HEAD.
|
1.21.12.2 |
| 28-Apr-2009 |
skrll | Sync with HEAD.
|
1.21.12.1 |
| 19-Jan-2009 |
skrll | Sync with HEAD.
|
1.21.10.1 |
| 13-Dec-2008 |
haad | Update haad-dm branch to haad-dm-base2.
|
1.21.4.4 |
| 09-Oct-2010 |
yamt | sync with head
|
1.21.4.3 |
| 11-Aug-2010 |
yamt | sync with head.
|
1.21.4.2 |
| 16-May-2009 |
yamt | sync with head
|
1.21.4.1 |
| 04-May-2009 |
yamt | sync with head.
|
1.23.2.2 |
| 04-Jan-2009 |
christos | fix dev_t printf format.
|
1.23.2.1 |
| 03-Jan-2009 |
christos | file sbp.c was added on branch christos-time_t on 2009-01-04 01:59:40 +0000
|
1.24.2.1 |
| 13-May-2009 |
jym | Sync with HEAD.
Commit is split, to avoid a "too many arguments" protocol error.
|
1.28.4.2 |
| 05-Mar-2011 |
rmind | sync with head
|
1.28.4.1 |
| 30-May-2010 |
rmind | sync with head
|
1.28.2.2 |
| 17-Aug-2010 |
uebayasi | Sync with HEAD.
|
1.28.2.1 |
| 30-Apr-2010 |
uebayasi | Sync with HEAD.
|
1.33.12.1 |
| 02-Jun-2012 |
mrg | sync to latest -current.
|
1.33.8.2 |
| 22-May-2014 |
yamt | sync with head.
for a reference, the tree before this commit was tagged as yamt-pagecache-tag8.
this commit was splitted into small chunks to avoid a limitation of cvs. ("Protocol error: too many arguments")
|
1.33.8.1 |
| 23-May-2012 |
yamt | sync with head.
|
1.34.4.1 |
| 18-May-2014 |
rmind | sync with head
|
1.34.2.1 |
| 20-Aug-2014 |
tls | Rebase to HEAD as of a few days ago.
|
1.36.30.2 |
| 13-Apr-2020 |
martin | Mostly merge changes from HEAD upto 20200411
|
1.36.30.1 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
1.36.28.1 |
| 06-Sep-2018 |
pgoyette | Sync with HEAD
Resolve a couple of conflicts (result of the uimin/uimax changes)
|
1.39.10.1 |
| 21-Mar-2021 |
thorpej | Give config_found() the same variadic arguments treatment as config_search(). This commit only adds the CFARG_EOL sentinel to the existing config_found() calls. Conversion of config_found_sm_loc() and config_found_ia() call sites will be in subsequent commits.
|
1.40.8.1 |
| 04-Aug-2021 |
thorpej | Adapt to CFARGS().
|