Home | History | Annotate | Download | only in iscsi
History log of /src/sys/dev/iscsi/iscsi_rcv.c
RevisionDateAuthorComments
 1.27  03-Nov-2024  mlelstv Take lock when updating conn state.
 1.26  13-Sep-2022  mlelstv branches: 1.26.10;
kill_session now uses the session id to avoid stale session pointers.
protect network socket with rwlock to handle recconnects.
always take over socket from iscsid to prevent leaks.
keep a good connection alive.
don't forget child device when config_detach fails.
fix locking when reassigning CCBs.
pducount is protected by lock, no need for atomic.
some code rework, refined debug messages.
 1.25  04-Mar-2018  mlelstv Add sanity check.
 1.24  03-Dec-2017  christos - add a prefix to struct members (but not the ioctl ones because they affect
the API)
- use consistent variable names.
 1.23  25-Dec-2016  mlelstv branches: 1.23.8;
Lock correctly around CV calls.
Fix handling of session termination.
Enable MPSAFE processing for scsipi.
 1.22  15-Jun-2016  mlelstv branches: 1.22.2;
Work around an issue with MSG_WAITALL that would block for too long by
replacing it with a receive loop.
 1.21  15-Jun-2016  mlelstv Remove throttling code, instead signal scsipi layer to reduce the openings
and retry the command. Start with a small openings number and let scsipi
request to grow it up to the current send window.

Adjust ccb and pdu counts to avoid ressource shortages. These are still
very ad-hoc numbers, but seem to be sufficient for a Gigabit link.

Use separate condvar for PDU pool and add counter to help debugging.

Revert setting PDU disposition to UNUSED before freeing. free_pdu
uses this as a flag to detect already returned PDUs.

Add reference counter for open commands to defer unmapping a session
that would lead to crashes in scsipi.

Move session cleanup to cleanup thread.

Use get_sernum to retrieve current serial number where possible and
make it check for immediate commands itself.

Adjust debug output.
 1.20  05-Jun-2016  mlelstv Don't resume throttled CCBs when connection is terminating, except for
those being actively waited for. Stop unthrottling when reaching MaxCmdSN
again.
 1.19  05-Jun-2016  mlelstv more debug output
 1.18  05-Jun-2016  mlelstv Whitespace, braces.
 1.17  05-Jun-2016  mlelstv No need to acquire KERNEL_LOCK when entering network code.
Also use the socket callbacks.
 1.16  05-Jun-2016  mlelstv Handle ExpCmdSN and MaxCmdSN updates as specified. Don't compare
serial numbers as integers.
 1.15  05-Jun-2016  mlelstv Fix serial number check and account for commands in flight to avoid
unnecessary recovery actions.
 1.14  05-Jun-2016  mlelstv ignore invalid ITT
 1.13  05-Jun-2016  mlelstv More debugging output, changed debug levels for some.
 1.12  01-Jun-2016  mlelstv refactor callouts
remove timed out ccbs and connections from cleanup queue when stopping timeout.
 1.11  29-May-2016  mlelstv Several improvements to the ISCSI driver.

- Enable debug messages but set log level to be quiet. Provide a
system (hw.iscsi.debug) to set the log level at run time.
- Replace old tsleep/wakeup synchronization with mutexes and condvars.
- Defer actions from callouts (basically timeouts) to the cleanup thread.
- Protect lists and unique ids with mutexes. protect connection usecount
by using atomic operations.
- Assert kernel lock when calling into scsipi and network code.
- Use this to make send/receive/cleanup threads MPSAFE.

- Fix handling of out-of-CCB/out-of-PDU conditions against the scsipi layer.
- Bump number of PDUs to 128 to avoid virtually all out-of-PDU conditions

- Make use of softc structure for attach/detach operations.
- Track open file handles to prevent detach when busy.

- Move some global variables to make them static.

- Fix 'Overlapping Commands Attempted' error by marking commands as
simply ordered (ATTR_SIMPLE) like FreeBSD.
 1.10  30-May-2015  joerg Inline SET_CCB_TIMEOUT and SET_CONN_TIMEOUT
 1.9  30-May-2015  joerg Remove ISCSI_PERFTEST.
 1.8  30-May-2015  joerg Remove ISCSI_TEST_MODE and corresponding dev/iscsi_test.h header.
 1.7  15-May-2015  joerg Remove conditionals for NetBSD before 4.0.
 1.6  05-Sep-2014  matt branches: 1.6.2;
Try not to use f_data, use f_{vnode,socket,pipe,mqueue,kqueue,ksem} to get
a correctly typed pointer.
 1.5  20-Oct-2013  christos 2 splbios in a row does not make sense. make the second one splx.
 1.4  29-Dec-2012  mlelstv branches: 1.4.2;
- defer session cleanup to not force detachments
- use more and explicit locking
- improve connection recovery
- use larger timeouts
- handle ccb buffer underflow correctly
- simplify throttling code

Sessions can now temporarily exist without a valid
connection, you also need to update iscsid(8).
 1.3  24-Jun-2012  mlelstv branches: 1.3.2;
Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.
 1.2  05-Jun-2012  mhitch Fix system freeze when trying to write to a raw iSCSI device with MAXPHYS
bytes. Newfs does large writes when initializing the filesystem.
First, don't copy the head of a TAILQ to make a copy - the first entry will
still point back to the original head. This caused the ccb list to link to
itself, resulting in a continous loop processing the same ccb and blocked
interrupts. Use TAILQ_CONCAT() to copy the list.
Next, the ccb disposition was not set in the ccb when the ccb was throttled,
losing the CCBDISP_SCSIPI, so when a throttled ccb was resent, it failed to
call scscipi_done(), and left that I/O hanging.
I am now able to newfs an iSCSI device, was well as issued large writes
using dd.
 1.1  23-Oct-2011  agc branches: 1.1.2; 1.1.8;
Start to move the in-kernel iSCSI initiator, kindly contributed to the
NetBSD Foundation by Wasabi Systems, from

othersrc/external/bsd/iscsi/sys/dev/iscsi

to

src/sys/dev/iscsi
 1.1.8.2  03-Jul-2012  jdc Pull up revisions:
src/sys/dev/iscsi/iscsi_globals.h revisions 1.3,1.4
src/sys/dev/iscsi/iscsi_main.c revisions 1.4,1.5
src/sys/dev/iscsi/iscsi_text.c revisions 1.4,1.5
src/sys/dev/iscsi/iscsi_ioctl.c revisions 1.3,1.4
src/sys/dev/iscsi/iscsi_send.c revisions 1.3,1.4,1.5
src/sys/dev/iscsi/iscsi_utils.c revisions 1.2,1.3,1.4
src/sbin/iscsid/iscsid_discover.c revision 1.4
src/sys/dev/iscsi/iscsi_rcv.c revision 1.3
src/sbin/iscsictl/iscsic_driverif.c revisions 1.5,1.6
(requested by martin in ticket #357, with updates from mhitch and mlelstv).

avoid namespace pollution when debugging
don't panic when printing data for a dead (NULL) connection

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

use first successful connection to a ISNS server

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

report luns returns a 32bit list length.

Make digests work also on big endian machines.

it's really 32bit
 1.1.8.1  12-Jun-2012  riz Pull up following revision(s) (requested by mhitch in ticket #323):
sys/dev/iscsi/iscsi_send.c: revision 1.2
sys/dev/iscsi/iscsi_rcv.c: revision 1.2
Fix system freeze when trying to write to a raw iSCSI device with MAXPHYS
bytes. Newfs does large writes when initializing the filesystem.
First, don't copy the head of a TAILQ to make a copy - the first entry will
still point back to the original head. This caused the ccb list to link to
itself, resulting in a continous loop processing the same ccb and blocked
interrupts. Use TAILQ_CONCAT() to copy the list.
Next, the ccb disposition was not set in the ccb when the ccb was throttled,
losing the CCBDISP_SCSIPI, so when a throttled ccb was resent, it failed to
call scscipi_done(), and left that I/O hanging.
I am now able to newfs an iSCSI device, was well as issued large writes
using dd.
 1.1.2.3  22-May-2014  yamt sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
 1.1.2.2  23-Jan-2013  yamt sync with head
 1.1.2.1  30-Oct-2012  yamt sync with head
 1.3.2.3  03-Dec-2017  jdolecek update from HEAD
 1.3.2.2  20-Aug-2014  tls Rebase to HEAD as of a few days ago.
 1.3.2.1  25-Feb-2013  tls resync with head
 1.4.2.1  18-May-2014  rmind sync with head
 1.6.2.3  05-Feb-2017  skrll Sync with HEAD
 1.6.2.2  09-Jul-2016  skrll Sync with HEAD
 1.6.2.1  06-Jun-2015  skrll Sync with HEAD
 1.22.2.1  07-Jan-2017  pgoyette Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
 1.23.8.1  09-Apr-2018  bouyer Pull up following revision(s) (requested by mlelstv in ticket #709):
sys/dev/iscsi/iscsi_send.c: revision 1.37 via patch
sys/dev/iscsi/iscsi_rcv.c: revision 1.25 via patch
Return temporary errors when the session is trying to recover the last
connection. The scsipi layer will retry.
Add sanity check.
 1.26.10.1  02-Aug-2025  perseant Sync with HEAD

RSS XML Feed