Home | History | Annotate | Download | only in iscsi
History log of /src/sys/dev/iscsi/iscsi_utils.c
RevisionDateAuthorComments
 1.29  25-Nov-2023  mlelstv Adapt to bignum representation of target.
Fix negotiation for mutual authentication.
Prepare for more CHAP types.
Fix crashes for invalid socket descriptors passed to kernel.
Protect usecount with connection mutex, avoids race on connection close.
Minor cosmetics.
 1.28  13-Sep-2022  mlelstv branches: 1.28.4;
kill_session now uses the session id to avoid stale session pointers.
protect network socket with rwlock to handle recconnects.
always take over socket from iscsid to prevent leaks.
keep a good connection alive.
don't forget child device when config_detach fails.
fix locking when reassigning CCBs.
pducount is protected by lock, no need for atomic.
some code rework, refined debug messages.
 1.27  21-Apr-2019  maya wether -> whether
 1.26  01-Apr-2019  msaitoh Fix typo in comment (s/numer/number/).
 1.25  01-Feb-2019  mrg fix FALLTRHOUGH spell-o.
 1.24  03-Dec-2017  christos branches: 1.24.4;
- add a prefix to struct members (but not the ioctl ones because they affect
the API)
- use consistent variable names.
 1.23  05-Feb-2017  mlelstv Destroy callouts when cleaning up.
 1.22  25-Dec-2016  mlelstv branches: 1.22.2;
Lock correctly around CV calls.
Fix handling of session termination.
Enable MPSAFE processing for scsipi.
 1.21  15-Jun-2016  mlelstv branches: 1.21.2;
Remove throttling code, instead signal scsipi layer to reduce the openings
and retry the command. Start with a small openings number and let scsipi
request to grow it up to the current send window.

Adjust ccb and pdu counts to avoid ressource shortages. These are still
very ad-hoc numbers, but seem to be sufficient for a Gigabit link.

Use separate condvar for PDU pool and add counter to help debugging.

Revert setting PDU disposition to UNUSED before freeing. free_pdu
uses this as a flag to detect already returned PDUs.

Add reference counter for open commands to defer unmapping a session
that would lead to crashes in scsipi.

Move session cleanup to cleanup thread.

Use get_sernum to retrieve current serial number where possible and
make it check for immediate commands itself.

Adjust debug output.
 1.20  15-Jun-2016  mlelstv drop unused debug helper routine
 1.19  05-Jun-2016  mlelstv Handle freeing of PDU when referencing CCB is freed.
 1.18  05-Jun-2016  mlelstv acquire session lock when changing throttling queue
 1.17  05-Jun-2016  mlelstv initialize before check.
 1.16  05-Jun-2016  mlelstv ensure that timeout counter is cleared when ccb is (re-)used.
 1.15  05-Jun-2016  mlelstv Replace the simple tag counter with the command tag coming down from scsipi.
Also set attributes according to tag types.
 1.14  05-Jun-2016  mlelstv Fix locking for pdu flags here, in particular PDUF_INQUEUE.
 1.13  05-Jun-2016  mlelstv When stopping a callout, wait until the cleanup thread has processed them.
 1.12  05-Jun-2016  mlelstv More debugging output, changed debug levels for some.
 1.11  01-Jun-2016  mlelstv refactor callouts
remove timed out ccbs and connections from cleanup queue when stopping timeout.
 1.10  01-Jun-2016  mlelstv factor out sernum handling.
make incrementing sernum atomic.
declare variables for atomic operations as volatile.
 1.9  29-May-2016  mlelstv Several improvements to the ISCSI driver.

- Enable debug messages but set log level to be quiet. Provide a
system (hw.iscsi.debug) to set the log level at run time.
- Replace old tsleep/wakeup synchronization with mutexes and condvars.
- Defer actions from callouts (basically timeouts) to the cleanup thread.
- Protect lists and unique ids with mutexes. protect connection usecount
by using atomic operations.
- Assert kernel lock when calling into scsipi and network code.
- Use this to make send/receive/cleanup threads MPSAFE.

- Fix handling of out-of-CCB/out-of-PDU conditions against the scsipi layer.
- Bump number of PDUs to 128 to avoid virtually all out-of-PDU conditions

- Make use of softc structure for attach/detach operations.
- Track open file handles to prevent detach when busy.

- Move some global variables to make them static.

- Fix 'Overlapping Commands Attempted' error by marking commands as
simply ordered (ATTR_SIMPLE) like FreeBSD.
 1.8  30-May-2015  joerg Save space by making ack flag booleans.
 1.7  30-May-2015  joerg Remove ISCSI_PERFTEST.
 1.6  15-May-2015  joerg Remove conditionals for NetBSD before 4.0.
 1.5  29-Dec-2012  mlelstv branches: 1.5.14;
- defer session cleanup to not force detachments
- use more and explicit locking
- improve connection recovery
- use larger timeouts
- handle ccb buffer underflow correctly
- simplify throttling code

Sessions can now temporarily exist without a valid
connection, you also need to update iscsid(8).
 1.4  25-Jun-2012  mlelstv branches: 1.4.2;
Make digests work also on big endian machines.
 1.3  24-Jun-2012  mlelstv Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.
 1.2  09-Jun-2012  mlelstv Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.
 1.1  23-Oct-2011  agc branches: 1.1.2; 1.1.8;
Start to move the in-kernel iSCSI initiator, kindly contributed to the
NetBSD Foundation by Wasabi Systems, from

othersrc/external/bsd/iscsi/sys/dev/iscsi

to

src/sys/dev/iscsi
 1.1.8.1  03-Jul-2012  jdc Pull up revisions:
src/sys/dev/iscsi/iscsi_globals.h revisions 1.3,1.4
src/sys/dev/iscsi/iscsi_main.c revisions 1.4,1.5
src/sys/dev/iscsi/iscsi_text.c revisions 1.4,1.5
src/sys/dev/iscsi/iscsi_ioctl.c revisions 1.3,1.4
src/sys/dev/iscsi/iscsi_send.c revisions 1.3,1.4,1.5
src/sys/dev/iscsi/iscsi_utils.c revisions 1.2,1.3,1.4
src/sbin/iscsid/iscsid_discover.c revision 1.4
src/sys/dev/iscsi/iscsi_rcv.c revision 1.3
src/sbin/iscsictl/iscsic_driverif.c revisions 1.5,1.6
(requested by martin in ticket #357, with updates from mhitch and mlelstv).

avoid namespace pollution when debugging
don't panic when printing data for a dead (NULL) connection

Close file descriptor passed into the kernel on success.
Fix locking of file handle. More cleanup on error paths.
Keep track of CCBs, so they cannot be used after a session ends.
Handle CCB timeouts even when the connection is terminated.
Compute firstdata, firstimmed correctly.

assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

use first successful connection to a ISNS server

Add more debugging, fix filehandle usage, login negotiation and session
shutdown.
Add #ifdef'd code to send negotiation parameters in hex instead of base64,
so it works against older Linux targets.

report luns returns a 32bit list length.

Make digests work also on big endian machines.

it's really 32bit
 1.1.2.2  23-Jan-2013  yamt sync with head
 1.1.2.1  30-Oct-2012  yamt sync with head
 1.4.2.2  03-Dec-2017  jdolecek update from HEAD
 1.4.2.1  25-Feb-2013  tls resync with head
 1.5.14.4  28-Aug-2017  skrll Sync with HEAD
 1.5.14.3  05-Feb-2017  skrll Sync with HEAD
 1.5.14.2  09-Jul-2016  skrll Sync with HEAD
 1.5.14.1  06-Jun-2015  skrll Sync with HEAD
 1.21.2.2  20-Mar-2017  pgoyette Sync with HEAD
 1.21.2.1  07-Jan-2017  pgoyette Sync with HEAD. (Note that most of these changes are simply $NetBSD$
tag issues.)
 1.22.2.1  21-Apr-2017  bouyer Sync with HEAD
 1.24.4.1  10-Jun-2019  christos Sync with HEAD
 1.28.4.1  18-Dec-2023  martin Pull up following revision(s) (requested by mlelstv in ticket #505):

sys/dev/iscsi/iscsi_utils.c: revision 1.29
sys/dev/iscsi/iscsi.h: revision 1.5
sys/dev/iscsi/iscsi_ioctl.c: revision 1.34
sys/dev/iscsi/iscsi_globals.h: revision 1.28
sys/dev/iscsi/iscsi_text.c: revision 1.14
sys/dev/iscsi/iscsi_send.c: revision 1.40

Adapt to bignum representation of target.

Fix negotiation for mutual authentication.

Prepare for more CHAP types.

Fix crashes for invalid socket descriptors passed to kernel.

Protect usecount with connection mutex, avoids race on connection close.

Minor cosmetics.

RSS XML Feed