Clean up gt and peripherals.
This change tested compile only.

branches: 1.1.104; 1.1.126; 1.1.128;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Merge the [pgoyette-compat] branch

Remove stray ; to fix the build

Add a convenience function, com_init_regs_stride(), that shifts the register
offsets and size by the specified amount. Use in front-ends as appropriate.

Remove the COM_REGMAP option -- just use it all the time. While here,
garbage-collect the COM_FUNCMAP and COM_AU1X00 options, as there are
not used anywhere.

Clean up initialization of com_regs structure, in preparation for
some additional changers.

branches: 1.7.28; 1.7.30;
Revirt 'Move the Marvell extension to com_mv.c' at Sun Sep 1 04:51:24 UTC 2013.
build test only.

Move the Marvell extension to com_mv.c.

branches: 1.5.2;
Set mva_size in the console case.
Addresses first portion of PR#43990.

branches: 1.4.2; 1.4.4;
Add include opt_com.h.

branches: 1.3.2; 1.3.4;
Cleanup mvuart_match().

Add some Kirkwood/Discovery Innovation products.

Add UART and PCIe controller for Marvell SoC.
However not define attribute *_mbus in our tree yet.

Merge thorpej-cfargs2.

branches: 1.9.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.8.10;
s/lenght/length/

branches: 1.7.2;
Stop potential misuse of vendor names and USB vendor IDs in root hub
device and string descriptors.

Firstly: Few vendors have identical PCI-SIG vendor IDs and USB-IF vendor
IDs. As such, using the PCI vendor ID as a USB vendor ID may trample
on whomever is allocated that USB vendor ID.

Secondly: The vendor of the host controller hardware implementation has
little to nothing to do with our usbroothub implementation. Thus we
should not potentially associate any problems therewith to such third
party.

This change will result in root hubs being identified by USB Vendor ID
0x0000. Root hub vendor string will now be "NetBSD" (or, specifically:
ostype). Product ID (0x0000) and product strings remain unchanged.

branches: 1.6.16;
Merge nick-nhusb

- API / infrastructure changes to support memory management changes.
- Memory management improvements and bug fixes.
- HCDs should now be MP safe
- conversion to KERNHIST based debug
- FS/LS isoc support on ehci(4).
- conversion to kmem(9)
- Some USB 3 support - mostly from Takahiro HAYASHI (t-hash).
- interrupt transfers now get proper DMA operations
- general bug fixes
- kern/48308
- uhub status notification improvements
- umass(4) probe fix (applied to HEAD already)
- ohci(4) short transfer fix

branches: 1.5.4; 1.5.6; 1.5.10;
Support Armada 370 and DDR3 tags.

Fix size of EHCI register space.

branches: 1.3.4;
Support Marvell Armada XP.

Obtained from Marvell, Semihalf.

branches: 1.2.2; 1.2.8; 1.2.12; 1.2.22;
Support vendor dependent functions.

branches: 1.1.2;
Add Marvell EHCI Controller wrapper.
However, because this driver has some problems now, it will not work the
way things are going.

Omit needless rijndael dependencies.

Make crypto/rijindael optional again as cprng_strong does no longer
depend on it. Dependency is explicitly declared in files.foo if a
component requires it.

branches: 1.4.6;
make this compile again:
- remove unused config attributes
- rename a local variable to avoid a name conflict

branches: 1.3.2; 1.3.18; 1.3.22;
add new cryptographic accelerator driver 'mvxpsec.'

this driver controls CESA unit as same as mvcesa, but uses DMA engines and
does CBC operations, HMAC operations by hardware. about 2 kbytes of data
are processed at one. supported algorithms are:

- DES-CBC, 3DES-CBC, AES-CBC
- HMAC-SHA1, HMAC-MD5

non-CBC algorithm such as AES-GCM is not supported by CESA's acceleration
engine. mvcesa is still useful to implement such algorithms as combination of
accelerated block cipher and software chaining.

separate buffer management codes 'mvxpbm.c' from if_mvxpe.c.

the buffer management(ex. fill the rx descriptors/buffers) is done by H/W in
ARMADA XP/380, and is done by S/W in ARMADA 370. the H/W BM support is not yet
implemented, so all devices use the S/W management mode at this time.

move Marvell ARMADA SoC's device driver definitions from arm/marvell
to dev/marvell.

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.22.46;
Make gttswi MI and usuable from non-Marvell SoCs.
(should rename to mvi2c but ...)

Fix build failed with ofppc.
Move 'attach mvspi at mvsoc' to arch/arm/marvell/files.marvell.

Move mvspi defines into sys/dev/marvell/files.discovery.

branches: 1.19.2; 1.19.4;
Add Marvell CESA(Cryptographic Engines and Security Accelerator) module driver.
But support only PIO-mode now. Also AES-CBC not supported.
Don't know how to process to AES CBC in PIO-mode. I haven't found IV registers.

branches: 1.18.8;
Add Marvell EHCI Controller wrapper.
However, because this driver has some problems now, it will not work the
way things are going.

Add Marvell Secure Digital Input/Output (SDIO) Interface Driver.

Add SATA for Marvell SC/SoC.

Add UART and PCIe controller for Marvell SoC.
However not define attribute *_mbus in our tree yet.

Remove unnecessary define.
Reorder.
Add necessary attributes.

Add Marvell Gigabit Ethernet Controller on SC/SoC.
Will support on ofppc soon.
Tested on G4+PegasosII (kiyohara@)
G3+PegasosII (phx@)

Enable gtidmac.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.10.74; 1.10.96; 1.10.98;
merge ktrace-lwp.

Add entry for gti2c.c

branches: 1.8.4; 1.8.6;
"gtpci" doesn't provide an ISA bus, so it shouldn't have an "isabus"
attribute

Typos in comment description.

branches: 1.6.2;
Add an option to control whether the GT's internal PCI Arbiter should
be enabled or not.

defflag GT_ECC.

Add GT_PCI{0,1}_{IO,MEM}{SIZE,START} options

Make gtmpsc configurable via config file. (baud rate source, frequency).

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Merge thorpej-cfargs2.

branches: 1.29.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.28.32;
PR/51540: Henning Petersen: replace , with ;

branches: 1.27.2;
Improve spelling: regsiter -> register

This change is non-functional.

Approved by <riastradh>, <pgoyette>

branches: 1.26.18; 1.26.36;
Add notes for remembrance' sake. This is information obtained looking for
www.marvell.com.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

Fix debug messages.
- s/DEBUG/GT_DEBUG/.
- Indent.
- The old one is 20 bits in the mask of the address register, and the
new one is 16 bits.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.22.2;
Adapt to <powerpc/spr.h> breakup.

branches: 1.21.2;
struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.18.4; 1.18.10; 1.18.18;
Use a local temporary struct gt_softc* so we don't try to
de-reference void*. Restores buildability of this file.

use device_lookup_private to get softc

branches: 1.16.2; 1.16.4; 1.16.6; 1.16.8;
use aprint_*_dev and device_xname

branches: 1.15.14;
Interrupt handling changes, in discussion since February:

- Reduce available SPL levels for hardware devices to none, vm, sched, high.
- Acquire kernel_lock only for interrupts at IPL_VM.
- Implement threaded soft interrupts.

branches: 1.14.2;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.13.6; 1.13.18; 1.13.20; 1.13.24;
Remove more duplicate headers.
Patch by Slava Semushin <slava.semushin@gmail.com>

Again, this was tested by comparing obj files from a pristine and a patched
source tree against an i386/ALL kernel, and also for src/sbin/fsck_ffs,
src/sbin/fsdb and src/usr.sbin/makefs. Only changes in assert() line numbers
were detected in 'objdump -d' output.

branches: 1.12.20;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

s/locdesc_t/int/g

branches: 1.9.4;
nuke trailing whitespace

branches: 1.8.4; 1.8.6;
Put back a few locators.h includes that are still needed here. Now evbppc
kernels build clean once again

a round of autoconf cleanup:
-convert submatch() style functions (passed to config_search() or
config_found_sm()) to the locator passing variants
-pass interface attributes in some cases
-make submatch() functions look uniformly as far as possible
-avoid macros which just hide cfdata members, and reduce dependencies
on "locators.h"

Add gt_dma_bus_mem_to_phys and gt_dma_phys_to_bus_mem.

add missing __KERNEL_RCSID()

branches: 1.4.2;
Disable the watchdog during autoconf of sub-devices.
Some drivers (e.g. pciide(4)) can take long enough to probe that the
watchdog barks before they're done.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Relocate Discovery first thing in initppc (if not at expected address).
This implies that if PMON tells us where the GT is, we write that address
in gtbase.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Switch to generic __BIT/__BITS macro, which doesn't depend on
left-shifting negative values.

branches: 1.2.18; 1.2.36;
Clean up gt and peripherals.
This change tested compile only.

branches: 1.1.104; 1.1.126; 1.1.128;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

branches: 1.1.2; 1.1.4; 1.1.6;
Clean up gt and peripherals.
This change tested compile only.

branches: 1.1.2; 1.1.4; 1.1.6;
Clean up gt and peripherals.
This change tested compile only.

s/endianess/endianness/

Clean up gt and peripherals.
This change tested compile only.

branches: 1.4.74; 1.4.96; 1.4.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.2.2; 1.2.10; 1.2.12;
Use a subregion for the mac's ethernet registers. Shaves 512 bytes
from the driver.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.12.2; 1.12.4;
struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.10.4; 1.10.18;
use aprint_*_dev and device_xname

branches: 1.9.6;
Remove a local variable which is no longer used.

branches: 1.8.4;
lockmgr -> mutex

branches: 1.7.2;
Interrupt handling changes, in discussion since February:

- Reduce available SPL levels for hardware devices to none, vm, sched, high.
- Acquire kernel_lock only for interrupts at IPL_VM.
- Implement threaded soft interrupts.

branches: 1.6.2;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.5.14; 1.5.28; 1.5.30; 1.5.34;
use the "i2cbus" interface attribute rather than putting a string name
into the i2cbus attach args

branches: 1.4.4;
Use device_private().

branches: 1.3.4; 1.3.6; 1.3.8; 1.3.10; 1.3.12;
merge ktrace-lwp.

branches: 1.2.4; 1.2.6;
nuke trailing whitespace

branches: 1.1.2; 1.1.4;
Add a i2c driver for the onboard i2c/twsi controller on the GT642x0

Clean up gt and peripherals.
This change tested compile only.

branches: 1.4.64; 1.4.86; 1.4.88;
Use the SI capitalization for "Hz", "kHz", and "MHz" in comments and strings.
Add a space between numbers and Hz unit.

branches: 1.3.4; 1.3.6; 1.3.8; 1.3.10;
merge ktrace-lwp.

branches: 1.2.4; 1.2.6;
nuke trailing whitespace

branches: 1.1.2; 1.1.4;
Add a i2c driver for the onboard i2c/twsi controller on the GT642x0

Clean up gt and peripherals.
This change tested compile only.

branches: 1.18.2; 1.18.4;
struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.15.2;
remove extra semicolons.

branches: 1.14.2;
Replace most gcc-specific __attribute__ uses with BSD-style sys/cdef.h
preprocessor macros.

branches: 1.13.4; 1.13.6; 1.13.10;
use aprint_*_dev and device_xname

branches: 1.12.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.11.6; 1.11.8; 1.11.12;
Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

branches: 1.10.2; 1.10.4;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.9.14;
Use device_private().

branches: 1.8.4; 1.8.6; 1.8.8; 1.8.10; 1.8.12;
bare asm -> __asm

Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

de-__P

branches: 1.3.8; 1.3.10;
add missing __KERNEL_RCSID()

branches: 1.2.2;
Use PAGE_SIZE rather than NBPG.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

MVXORE_XEXCDPR and MVXORE_XEXBCR macros expect two params now, thus adjust
params accordingly, needed in order to fix GTIDMAC_DEBUG build option.

Unfortunately, there few more macros in gtidmac_dump_xorereg() like
MVXORE_XETMCR, MVXORE_XETMIVR, MVXORE_XETMCVR, MVXORE_XEIVRH, MVXORE_XEIVRL
which also expect two params, but second one doesn't seem to be a channel,
thus I am leaving it unfixed for now.

fix typos, mainly s/unsupport/unsupported/ in log messages.

Fix typo. unknwon -> unknown

Fix all remaining typos, mainly in comments but also in few definitions and log messages, reported by me in PR kern/54889.
Also fixed some additional typos in comments, found on review of same files or typos.

branches: 1.17.12;
s/transfered/transferred/

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.15.8; 1.15.10;
remove checks for failure after memory allocation calls that cannot fail:

kmem_alloc() with KM_SLEEP
kmem_zalloc() with KM_SLEEP
percpu_alloc()
pserialize_create()
psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Remove extra 0x. This bug was added when replacing bitmask_snprintf(9) with
snprintb(3) (in between NetBSD 5 and 6). Old bitmask_snprint(9) didn't add
0x" automatically for hexadecimal value, so old code used it with "0x%s".

branches: 1.13.2;
Support Marvell Dove. Use irq array. Dove's irqs not sequencial.
And remove debug printf().

Remove unused function.

branches: 1.11.6; 1.11.10;
Support Armada 370 and DDR3 tags.

Add ARMADAXP IDs.

branches: 1.9.2; 1.9.4;
Add "static".

Support Kirkwoods. Kirkwoods has 4ch for XORE and not has IDMAC. tested on OpenBlockS A6 with ch0 only.

Use proper ANSI prototypes for foo() -> foo(void)
Caught when compiling with -Wold-style-definition

branches: 1.6.2; 1.6.10; 1.6.14;
Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.

Fix information on the product with comment-out. This was obtained from
the data sheet of Marvell.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

Fix sume bugs.
- Why +1 ?
- mvidmac_dump_xoredesc() -> gtidmac_dump_xoredesc().
- bitmask_snprintf() -> snprintb().
Support big endian machines with GTIDMAC_CCHR_ENDIAN_BE.

Use kmem(9) instead of malloc(9) in gtidmac_attach().

branches: 1.1.2; 1.1.4;
Clean up gt and peripherals.
This change tested compile only.

s/endianess/endianness/

Fix macro MVXORE_CHAN2BASE(). The XORE has 2 channels per port.

branches: 1.3.2; 1.3.16; 1.3.20;
Support Kirkwoods. Kirkwoods has 4ch for XORE and not has IDMAC. tested on OpenBlockS A6 with ch0 only.

branches: 1.2.2; 1.2.10;
Support big endian machines.

branches: 1.1.2; 1.1.4;
Clean up gt and peripherals.
This change tested compile only.

Remove unused function.

branches: 1.2.6; 1.2.10;
Support Armada 370 and DDR3 tags.

branches: 1.1.2; 1.1.4; 1.1.6; 1.1.14; 1.1.24; 1.1.28;
Clean up gt and peripherals.
This change tested compile only.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.6.14; 1.6.16;
Replace most gcc-specific __attribute__ uses with BSD-style sys/cdef.h
preprocessor macros.

branches: 1.5.64; 1.5.68; 1.5.70; 1.5.74;
Change "inline" back to "__inline" in .h files -- C99 is still too
new, and some apps compile things in C89 mode. C89 keywords stay.

As per core@.

branches: 1.4.2; 1.4.4; 1.4.6;
bare asm -> __asm

merge ktrace-lwp.

branches: 1.2.4;
nuke trailing whitespace

branches: 1.1.2; 1.1.10; 1.1.12;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.5.40; 1.5.62; 1.5.64;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.4.26;
merge ktrace-lwp.

branches: 1.3.4;
nuke trailing whitespace

de-__P

branches: 1.1.2; 1.1.10; 1.1.12;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

fix various typos in comments and log messages.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.4.74; 1.4.96; 1.4.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.2.8; 1.2.10;
Uppercase CPU, plural is CPUs.

branches: 1.1.2;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

branches: 1.1.2; 1.1.4; 1.1.6;
Clean up gt and peripherals.
This change tested compile only.

Fix wrong KGDB condition and remove unused gtmpsc_kgdb_addr variable.

branches: 1.49.2;
Make gtmpsc_intr_rx/tx always static __inline to fix DEBUG enabled build.
Currently code depends on STATIC macro which is defined as empty with DEBUG
option, thus build fails since tx method uses static inline gt_sdma_imask().

Also add missing __inline for gtmpsc_intr_rx() definition.

Fix EV64260 kernel config when DEBUG is enabled.
Fix discussed with mrg@ in irc.

fix various typos in comments and messages.

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.46.18; 1.46.20;
centralize the dialout/call unit macros.

Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.44.2;
Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

branches: 1.43.4; 1.43.14; 1.43.18;
Rename ttymalloc() to tty_alloc(), and ttyfree() to tty_free() for
consistency. Remove some unnecessary malloc.h inclusions as well.

branches: 1.42.2;
Include uvm/uvm_extern.h to access uvmexp. gtmpsc.c doesn't need
uvm(9) API at all.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.37.2; 1.37.4;
struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

Remove extra whitespace added by a stupid tool.
XXX: more in src/sys/arch

bcopy -> memcpy

bzero -> memset

Change about 4500 of the K&R function definitions to ANSI ones.
There are still about 1600 left, but they have ',' or /* ... */
in the actual variable definitions - which my awk script doesn't handle.
There are also many that need () -> (void).
(The script does handle misordered arguments.)

branches: 1.31.2; 1.31.8;
Replace most gcc-specific __attribute__ uses with BSD-style sys/cdef.h
preprocessor macros.

branches: 1.30.2;
use device_lookup_private to get softc

use device_lookup_private to get softc

branches: 1.28.2; 1.28.4; 1.28.6; 1.28.8;
use aprint_*_dev and device_xname

branches: 1.27.14;
- Factor out too many copies of the same bit of tty code.
- Fix another tty signalling/wakeup problem.

branches: 1.26.2;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.25.2;
Fix a missing include noted by Gerald Lee on tech-kern

Use the softint API.

branches: 1.23.2; 1.23.14; 1.23.16; 1.23.18;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.22.2;
Remove more duplicate headers.
Patch by Slava Semushin <slava.semushin@gmail.com>

Again, this was tested by comparing obj files from a pristine and a patched
source tree against an i386/ALL kernel, and also for src/sbin/fsck_ffs,
src/sbin/fsdb and src/usr.sbin/makefs. Only changes in assert() line numbers
were detected in 'objdump -d' output.

Adapt MD code to KAUTH_DEVICE_TTY_OPEN, batch #2 from Matt Fleming, thanks!

Also, add forgotten splx() calls in some places.

branches: 1.20.4; 1.20.6;
- Use the LWP cached credentials where sane.
- Minor cosmetic changes.

'volatile' is not a valid return type qualifier - remove it.

branches: 1.18.2;
Include now needed <sys/kauth.h>, and fold a long line.

integrate kauth.

Use device_private().

Use device_unit().

branches: 1.14.4; 1.14.6; 1.14.8; 1.14.10; 1.14.12;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

Change the driver open function's conditional for overriding exclusive tty
use from checking the proc's uid to suser(9), and account for the use of
privileges. Noted by David Holland in PR kern/31126.

branches: 1.11.2;
Use underscores to prefix local variables in macros.

nuke trailing whitespace

branches: 1.9.8; 1.9.10;
add missing __KERNEL_RCSID()

branches: 1.8.2;
Tickle the watchdog while doing polled console i/o.
This is especially important if we spend any time in ddb. :)

In gtmpscinit_stop(), don't wait for abort completion status if the
receiver is disabled. It'll never complete in this case.

Use PAGE_SIZE rather than NBPG.

Make reset delay depend on the baud rate.

Make gtmpsc configurable via config file. (baud rate source, frequency).

Use generic softintr. switch from consinit to explicit cnattach
framework. Use bus_space for access register access.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Switch to generic __BIT/__BITS macro, which doesn't depend on
left-shifting negative values.

branches: 1.4.18; 1.4.36;
Clean up gt and peripherals.
This change tested compile only.

branches: 1.3.74; 1.3.96; 1.3.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.1.2; 1.1.10; 1.1.12;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.7.66; 1.7.88; 1.7.90;
Remove another instance of the SET/CLR/ISSET macro triplet, now found
in <sys/types.h>.

branches: 1.6.4; 1.6.6; 1.6.8;
merge ktrace-lwp.

branches: 1.5.4;
nuke trailing whitespace

branches: 1.4.2; 1.4.10; 1.4.12;
Make gtmpsc configurable via config file. (baud rate source, frequency).

Derive baud rate from cpu_timebase on powerpc.

Use generic softintr. switch from consinit to explicit cnattach
framework. Use bus_space for access register access.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Remove unnecessary include of <sys/malloc.h>.

fix typos in comments and log messages, mainly s/intrrupt/interrupt/.

Merge thorpej-cfargs2.

branches: 1.35.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.34.4;
Overhaul the interface to pci_configure_bus():
- Don't expose how PCI bus configuration resource management is implemented.
Provide a new resource provider API:

==> pciconf_resource_init() -- Initialize a PCI configuration resources
container.
==> pciconf_resource_add() -- Add a PCI configuration resource to the
container (I/O, MEM, or prefetchable MEM). Multiple resources of
each type may be added.
==> pciconf_resource_fini() -- Tear down the PCI configurtation resources
container once the bus has been configured.

This is much easier to use than the previous method of providing an
extent map for each kind of resource, and works better for e.g. ACPI
platforms that provide potentially multiple PCI resources in tables
provided by firmware.

- Re-implement PCI configuration resource management using vmem arenas,
rather than extent maps.

replace EX_NOWAIT with EX_WAITOK in device attach methods.
remove checks for failures that can no longer occur.

PCI Extended Configuration stuff written by nonaka@:
- Add PCI Extended Configuration Space support into x86.
- Check register offset of pci_conf_read() in MD part. It returns (pcireg_t)-1
if it isn't accessible.
- Decode Extended Capability in PCI Extended Configuration Space.
Currently the following extended capabilities are decoded:
- Advanced Error Reporting
- Virtual Channel
- Device Serial Number
- Power Budgeting
- Root Complex Link Declaration
- Root Complex Event Collector Association
- Access Control Services
- Alternative Routing-ID Interpretation
- Address Translation Services
- Single Root IO Virtualization
- Page Request
- TPH Requester
- Latency Tolerance Reporting
- Secondary PCI Express
- Process Address Space ID
- LN Requester
- L1 PM Substates
The following extended capabilities are not decoded yet:
- Root Complex Internal Link Control
- Multi-Function Virtual Channel
- RCRB Header
- Vendor Unique
- Configuration Access Correction
- Multiple Root IO Virtualization
- Multicast
- Resizable BAR
- Dynamic Power Allocation
- Protocol Multiplexing
- Downstream Port Containment
- Precision Time Management
- M-PCIe
- Function Reading Status Queueing
- Readiness Time Reporting
- Designated Vendor-Specific

branches: 1.31.6;
move some variables inside their #ifdef use.

branches: 1.30.2; 1.30.4;
Fix pci_conf_hook/interrupt for ARM.

converting extent(9) from malloc(9) to kmem(9)
preceding kmem-vmem-pool-uvm patch

releng@ acknowledged

branches: 1.28.4; 1.28.8;
PCI_FLAGS_IO_ENABLED and PCI_FLAGS_MEM_ENABLED changed their functional
role in NetBSD (drivers are no longer supposed to write these to
pa_flags) without changing name. Correct that.

Rename PCI_FLAGS_IO_ENABLED to PCI_FLAGS_IO_OKAY and
PCI_FLAGS_MEM_ENABLED to PCI_FLAGS_MEM_OKAY, thus making their names
consistent with the other PCI flags and poisoning 3rd-party driver
sources that use the flags in the old bad way.

This patch produces no binary changes in this set of PCI kernels when
they are compiled w/o 'options DIAGNOSTIC' and w/ -V MKREPRO=yes:

algor P4032 P5064 P6032
alpha GENERIC
amd64 GENERIC XEN3_DOM0
arc GENERIC
atari HADES MILAN-PCIIDE
bebox GENERIC
cats GENERIC
cobalt GENERIC
evbarm-el ADI_BRH ARMADILLO9 CP3100 GEMINI GEMINI_MASTER GEMINI_SLAVE
evbarm-el GUMSTIX HDL_G IMX31LITE INTEGRATOR IQ31244 IQ80310 IQ80321
evbarm-el IXDP425 IXM1200 KUROBOX_PRO
evbarm-el LUBBOCK MARVELL_NAS NAPPI NSLU2 SHEEVAPLUG SMDK2800 TEAMASA_NPWR
evbarm-el TEAMASA_NPWR_FC TS7200 TWINTAIL ZAO425
evbmips-el AP30 DBAU1500 DBAU1550 MALTA MERAKI MTX-1 OMSAL400 RB153 WGT624V3
evbmips64-el XLSATX
evbppc EV64260 MPC8536DS MPC8548CDS OPENBLOCKS200 OPENBLOCKS266
evbppc OPENBLOCKS266_OPT P2020RDB PMPPC RB800 WALNUT
hp700 GENERIC
i386 ALL XEN3_DOM0 XEN3_DOMU
ibmnws GENERIC
iyonix GENERIC
landisk GENERIC
macppc GENERIC
mvmeppc GENERIC
netwinder GENERIC
ofppc GENERIC
prep GENERIC
sandpoint GENERIC
sbmips-el GENERIC
sgimips GENERIC32_IP2x GENERIC32_IP3x
sparc GENERIC_SUN4U KRUPS
sparc64 GENERIC

branches: 1.27.2;
Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

Move memory protection parameters to MI part.
Gtpci believes the initialization of the firmware(boot-loader) if protection
information is not obtained.

Set NULL to tag when the property doesn't get it.

Remove unused gpio.h.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.21.2; 1.21.4;
struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.19.4; 1.19.18;
Put back a %s so that the format matches again. Fixes build for evbppc.

use aprint_*_dev and device_xname

branches: 1.17.14;
Interrupt handling changes, in discussion since February:

- Reduce available SPL levels for hardware devices to none, vm, sched, high.
- Acquire kernel_lock only for interrupts at IPL_VM.
- Implement threaded soft interrupts.

branches: 1.16.2;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.15.6; 1.15.18; 1.15.20; 1.15.24;
Remove more duplicate headers.
Patch by Slava Semushin <slava.semushin@gmail.com>

Again, this was tested by comparing obj files from a pristine and a patched
source tree against an i386/ALL kernel, and also for src/sbin/fsck_ffs,
src/sbin/fsdb and src/usr.sbin/makefs. Only changes in assert() line numbers
were detected in 'objdump -d' output.

branches: 1.14.8;
Use device_private().

branches: 1.13.4; 1.13.6; 1.13.8; 1.13.10; 1.13.12;
merge ktrace-lwp.

branches: 1.12.4;
nuke trailing whitespace

branches: 1.11.4; 1.11.6;
Phase out the use of a string as first "attach args" member to control
which bustype should be attached with a specific call to config_found()
(from a "mainbus" or a bus bridge).
Do it for isa/eisa/mca and pci/agp for now. These buses all attach to
an mi interface attribute "isabus", "eisabus" etc., and the autoconf
framework now allows to specify an interface attribute on config_found()
and config_search(), which limits the search of matching config data
to these which attach to that specific attribute.
So we basically have to call config_found_ia(..., "foobus", ...) where
such a bus is attached.
As a consequence, where a "mainbus" or alike also attaches other
devices (eg CPUs) which do not attach to a specific attribute yet,
we need at least pass an attribute name (different from "foobus") so
that the foo bus is not found at these places. This made some minor
changes necessary which are not obviously related to the mentioned buses.

add missing __KERNEL_RCSID()

branches: 1.9.2;
Add basic support for non-PCI host mode.

Add an option to control whether the GT's internal PCI Arbiter should
be enabled or not.

Remove #define DEBUG. (this was working right. The problem I encountered
was due to a bug in PPCBOOT. It was not ordering DIMM space largest to
smallest so that you could badly alignment memory).

Cleanup PCI support.

Split PCI initialization out of attach hook.

Enable I/O & memory access too.

Do minimal initialization of PCI.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

s/expresion/expression/ in comment.

branches: 1.6.60;
Erase the old definition macro that forgot to be erased.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.4.74; 1.4.96; 1.4.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.2.2; 1.2.10; 1.2.12;
Fix tyops. Add 2 defines.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Fix pci_conf_hook/interrupt for ARM.

branches: 1.10.8;
Move memory protection parameters to MI part.
Gtpci believes the initialization of the firmware(boot-loader) if protection
information is not obtained.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.8.42; 1.8.64; 1.8.66;
Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.7.20;
Change "inline" back to "__inline" in .h files -- C99 is still too
new, and some apps compile things in C89 mode. C89 keywords stay.

As per core@.

branches: 1.6.2; 1.6.4; 1.6.6;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

branches: 1.5.18;
Add basic support for non-PCI host mode.

Cleanup PCI support.

Split PCI initialization out of attach hook.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

s/endianess/endianness/

"no affect" -> "no effect" in man pages and comments.

Fix debug messages.
- s/DEBUG/GT_DEBUG/.
- Indent.
- The old one is 20 bits in the mask of the address register, and the
new one is 16 bits.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.3.74; 1.3.96; 1.3.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.1.2; 1.1.10; 1.1.12;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Switch to generic __BIT/__BITS macro, which doesn't depend on
left-shifting negative values.

branches: 1.5.18; 1.5.36;
Clean up gt and peripherals.
This change tested compile only.

branches: 1.4.74; 1.4.96; 1.4.98;
merge ktrace-lwp.

nuke trailing whitespace

branches: 1.2.8; 1.2.10;
boundary, not boundry. Inspired by Tom Cosgrove.

branches: 1.1.2;
Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

branches: 1.1.2; 1.1.4; 1.1.6;
Clean up gt and peripherals.
This change tested compile only.

Clean up gttwsi's register access stuff:
- Garbage-collect the obsolete GTTWSI_ALLWINNER option; it hasn't been
needed since FDT'ization of the Allwinner support code.
- Redefine thw "TWSI_*" register definitions to clearly call out:
-> The Marvell flavor of the offsets
-> The Allwinner flavor of the offsets
...and make the regular definitions indices into a register map.
- Pass the appropriate register map from the front-end to the core.
- Remove the customer register read/write callbacks -- they are no longer
needed now that each front-end passes an appropriate register map to
the core.

branches: 1.11.30; 1.11.38;
Make gttswi MI and usuable from non-Marvell SoCs.
(should rename to mvi2c but ...)

Make sc_started bool and true/false instead of 1/0

Issue the STOP-bit if needed.
And remove #ifdef ARMADAXP.

branches: 1.8.2;
There is no opt_mvsoc.h; the #ifdef ARMADAXP should be changed to some
inherited device property.

TWSI controller on Armada XP is a bit different. Support that.

Obtained from Marvell, Semihalf.

branches: 1.6.2;
Don't send a stop bit immediately after start bit transmission.

branches: 1.5.8;
Add timeout for wait.
Not send STOP, if received ACK.

Fix ack/no-ack. Last data sends with stop-bit without ack.

branches: 1.3.2;
Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

branches: 1.1.2; 1.1.4;
Clean up gt and peripherals.
This change tested compile only.

Make gttswi MI and usuable from non-Marvell SoCs.
(should rename to mvi2c but ...)

Issue the STOP-bit if needed.
And remove #ifdef ARMADAXP.

branches: 1.3.4;
TWSI controller on Armada XP is a bit different. Support that.

Obtained from Marvell, Semihalf.

branches: 1.2.2;
TWSI size is 0x100. Not 0x1000.

branches: 1.1.2; 1.1.4; 1.1.6; 1.1.14;
Clean up gt and peripherals.
This change tested compile only.

Clean up gt and peripherals.
This change tested compile only.

branches: 1.14.2; 1.14.4;
struct device * -> device_t, no functional changes intended.

branches: 1.13.42; 1.13.58;
Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.12.12;
'volatile' is not a valid return type qualifier - remove it.

branches: 1.11.2; 1.11.8;
Change "inline" back to "__inline" in .h files -- C99 is still too
new, and some apps compile things in C89 mode. C89 keywords stay.

As per core@.

branches: 1.10.2; 1.10.4; 1.10.6;
Remove leading __ from __(const|inline|signed|volatile) -- it is obsolete.

merge ktrace-lwp.

branches: 1.8.6;
Add I2C child hooks.

branches: 1.7.4; 1.7.6;
Put back a few locators.h includes that are still needed here. Now evbppc
kernels build clean once again

a round of autoconf cleanup:
-convert submatch() style functions (passed to config_search() or
config_found_sm()) to the locator passing variants
-pass interface attributes in some cases
-make submatch() functions look uniformly as far as possible
-avoid macros which just hide cfdata members, and reduce dependencies
on "locators.h"

Add gt_dma_bus_mem_to_phys and gt_dma_phys_to_bus_mem.

branches: 1.4.2;
Add basic support for non-PCI host mode.

Split PCI initialization out of attach hook.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Add a shared function to query the common properties used for configuring
an Ethernet address.

Rename property "mac-addr" -> "mac-address" to match everyone else.

sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@

branches: 1.60.10;
gfe_ifstart(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with
"IF_POLL() -> IF_DEQUEUE() on success".

Merge thorpej-cfargs2.

branches: 1.58.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.57.4;
Round of uvm.h cleanup.

The poorly named uvm.h is generally supposed to be for uvm-internal
users only.

- Narrow it to files that actually need it -- mostly files that need
to query whether curlwp is the pagedaemon, which should maybe be
exposed by an external header.

- Use uvm_extern.h where feasible and uvm_*.h for things not exposed
by it. We should split up uvm_extern.h but this will serve for now
to reduce the uvm.h dependencies.

- Use uvm_stat.h and #ifdef UVMHIST uvm.h for files that use
UVMHIST(ubchist), since ubchist is declared in uvm.h but the
reference evaporates if UVMHIST is not defined, so we reduce header
file dependencies.

- Make uvm_device.h and uvm_swap.h independently includable while
here.

ok chs@

Adopt <net/if_stats.h>

Adopt <net/if_stats.h>

branches: 1.54.4;
Use ETHER_LOCK()/ETHER_UNLOCK() for all ethernet drivers to protect ec_multi*.

Whitespace fix (mainly tabify).

-No functional change:
- Simplify struct ethercom's pointer near ETHER_FIRST_MULTI().
- Simplify MII structure initialization.
- u_int*_t -> uint*_t.
- KNF

These drivers do ether_ioctl() on SIOC{ADD,DEL}MULTI, SIOC{G,S}IFMEDIA and
default case in the switch statement. Only the default case didn't check the
return value with ENETRESET. Integrate them to one ether_ioctl() with
ENETRESET test. This change might improve some other ioctl()s which return
ENETRESET by calling if_init().

Change MII PHY read/write API from:

int (*mii_readreg_t)(device_t, int, int);
void (*mii_writereg_t)(device_t, int, int, int);
to:

int (*mii_readreg_t)(device_t, int, int, uint16_t *);
int (*mii_writereg_t)(device_t, int, int, uint16_t);

Now we can test if a read/write operation failed or not by the return value.

In 802.3 spec says that the PHY shall not respond to read/write transaction
to the unimplemented register(22.2.4.3). Detecting timeout can be used to
check whether a register is implemented or not (if the register conforms to
the spec). ukphy(4) can be used this for MII_MMDACR and MII_MMDAADR.

Note that I noticed that the following code do infinite loop in the
read/wirte function. If it accesses unimplemented PHY register, it will hang.
It should be fixed:

arm/at91/at91emac.c
arm/ep93xx/epe.c
arm/omap/omapl1x_emac.c
mips/ralink/ralink_eth.c
arch/powerpc/booke/dev/pq3etsec.c(read)
dev/cadence/if_cemac.c <- hkenken
dev/ic/lan9118.c


Tested with the following device:

axe+ukphy
axe+rgephy
axen+rgephy (tested by Andrius V)
wm+atphy
wm+ukphy
wm+igphy
wm+ihphy
wm+makphy
sk+makphy
sk+brgphy
sk+gentbi
msk+makphy
sip+icsphy
sip+ukphy
re+rgephy
bge+brgphy
bnx+brgphy
gsip+gphyter
rtk+rlphy
fxp+inphy (tested by Andrius V)
tlp+acphy
ex+exphy
epic+qsphy
vge+ciphy (tested by Andrius V)
vr+ukphy (tested by Andrius V)
vte+ukphy (tested by Andrius V)

Not tested (MAC):
arm:at91emac
arm:cemac
arm:epe
arm:geminigmac
arm:enet
arm:cpsw
arm:emac(omac)
arm:emac(sunxi)
arm:npe
evbppc:temac
macppc:bm
macppc:gm
mips:aumac
mips:ae
mips:cnmac
mips:reth
mips:sbmac
playstation2:smap
powerpc:tsec
powerpc:emac(ibm4xx)
sgimips:mec
sparc:be
sf
ne(ax88190, dl10019)
awge
ep
gem
hme
smsh
mtd
sm
age
alc
ale
bce
cas
et
jme
lii
nfe
pcn
ste
stge
tl
xi
aue
mue
smsc
udav
url

Not tested (PHY):
amhphy
bmtphy
dmphy
etphy
glxtphy
ikphy
iophy
lxtphy
nsphyter
pnaphy
rdcphy
sqphy
tlphy
tqphy
urlphy

branches: 1.49.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

branches: 1.48.14;
Move bpf_mtap and if_ipackets++ on Rx of each driver to percpuq if_input

The benefits of the change are:
- We can reduce codes
- We can provide the same behavior between drivers
- Where/When if_ipackets is counted up
- Note that some drivers still update packet statistics in their own
way (periodical update)
- Moved bpf_mtap run in softint
- This makes it easy to MP-ify bpf

Proposed on tech-kern and tech-net

branches: 1.47.2;
Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.

Introduce softint-based if_input

This change intends to run the whole network stack in softint context
(or normal LWP), not hardware interrupt context. Note that the work is
still incomplete by this change; to that end, we also have to softint-ify
if_link_state_change (and bpf) which can still run in hardware interrupt.

This change softint-ifies at ifp->if_input that is called from
each device driver (and ieee80211_input) to ensure Layer 2 runs
in softint (e.g., ether_input and bridge_input). To this end,
we provide a framework (called percpuq) that utlizes softint(9)
and percpu ifqueues. With this patch, rxintr of most drivers just
queues received packets and schedules a softint, and the softint
dequeues packets and does rest packet processing.

To minimize changes to each driver, percpuq is allocated in struct
ifnet for now and that is initialized by default (in if_attach).
We probably have to move percpuq to softc of each driver, but it's
future work. At this point, only wm(4) has percpuq in its softc
as a reference implementation.

Additional information including performance numbers can be found
in the thread at tech-kern@ and tech-net@:
http://mail-index.netbsd.org/tech-kern/2016/01/14/msg019997.html

Acknowledgment: riastradh@ greatly helped this work.
Thank you very much!

Convert sys/dev to use <sys/rndsource.h>.

sizeof doesn't evaluate the expression, so increment of rxd doesn't
happen. Move it out.

branches: 1.43.2;
this is not python (add braces)

branches: 1.42.2;
Merge tls-earlyentropy branch into HEAD.

branches: 1.41.2; 1.41.12;
Fix mii_statchg to take a 'struct ifnet *' instead of device_t. This fixes
problem with a common MDIO bus used for multiple interfaces.
Some drivers converted to CFATTACL_DECL_NEW.

Entropy-pool implementation move and cleanup.

1) Move core entropy-pool code and source/sink/sample management code
to sys/kern from sys/dev.

2) Remove use of NRND as test for presence of entropy-pool code throughout
source tree.

3) Remove use of RND_ENABLED in device drivers as microoptimization to
avoid expensive operations on disabled entropy sources; make the
rnd_add calls do this directly so all callers benefit.

4) Fix bug in recent rnd_add_data()/rnd_add_uint32() changes that might
have lead to slight entropy overestimation for some sources.

5) Add new source types for environmental sensors, power sensors, VM
system events, and skew between clocks, with a sample implementation
for each.

ok releng to go in before the branch due to the difficulty of later
pullup (widespread #ifdef removal and moved files). Tested with release
builds on amd64 and evbarm and live testing on amd64.

branches: 1.39.8; 1.39.12;
Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.

Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.

Clean up gt and peripherals.
This change tested compile only.

Push the bpf_ops usage back into bpf.h. Push the common ifp->if_bpf
check into the inline functions as well the fourth argument for
bpf_attach.

branches: 1.34.2; 1.34.4;
Redefine bpf linkage through an always present op vector, i.e.
#if NBPFILTER is no longer required in the client. This change
doesn't yet add support for loading bpf as a module, since drivers
can register before bpf is attached. However, callers of bpf can
now be modularized.

Dynamically loadable bpf could probably be done fairly easily with
coordination from the stub driver and the real driver by registering
attachments in the stub before the real driver is loaded and doing
a handoff. ... and I'm not going to ponder the depths of unload
here.

Tested with i386/MONOLITHIC, modified MONOLITHIC without bpf and rump.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.31.4;
*** Summary ***

When a link-layer address changes (e.g., ifconfig ex0 link
02:de:ad:be:ef:02 active), send a gratuitous ARP and/or a Neighbor
Advertisement to update the network-/link-layer address bindings
on our LAN peers.

Refuse a change of ethernet address to the address 00:00:00:00:00:00
or to any multicast/broadcast address. (Thanks matt@.)

Reorder ifnet ioctl operations so that driver ioctls may inherit
the functions of their "class"---ether_ioctl(), fddi_ioctl(), et
cetera---and the class ioctls may inherit from the generic ioctl,
ifioctl_common(), but both driver- and class-ioctls may override
the generic behavior. Make network drivers share more code.

Distinguish a "factory" link-layer address from others for the
purposes of both protecting that address from deletion and computing
EUI64.

Return consistent, appropriate error codes from network drivers.

Improve readability. KNF.

*** Details ***

In if_attach(), always initialize the interface ioctl routine,
ifnet->if_ioctl, if the driver has not already initialized it.
Delete if_ioctl == NULL tests everywhere else, because it cannot
happen.

In the ioctl routines of network interfaces, inherit common ioctl
behaviors by calling either ifioctl_common() or whichever ioctl
routine is appropriate for the class of interface---e.g., ether_ioctl()
for ethernets.

Stop (ab)using SIOCSIFADDR and start to use SIOCINITIFADDR. In
the user->kernel interface, SIOCSIFADDR's argument was an ifreq,
but on the protocol->ifnet interface, SIOCSIFADDR's argument was
an ifaddr. That was confusing, and it would work against me as I
make it possible for a network interface to overload most ioctls.
On the protocol->ifnet interface, replace SIOCSIFADDR with
SIOCINITIFADDR. In ifioctl(), return EPERM if userland tries to
invoke SIOCINITIFADDR.

In ifioctl(), give the interface the first shot at handling most
interface ioctls, and give the protocol the second shot, instead
of the other way around. Finally, let compatibility code (COMPAT_OSOCK)
take a shot.

Pull device initialization out of switch statements under
SIOCINITIFADDR. For example, pull ..._init() out of any switch
statement that looks like this:

switch (...->sa_family) {
case ...:
..._init();
...
break;
...
default:
..._init();
...
break;
}

Rewrite many if-else clauses that handle all permutations of IFF_UP
and IFF_RUNNING to use a switch statement,

switch (x & (IFF_UP|IFF_RUNNING)) {
case 0:
...
break;
case IFF_RUNNING:
...
break;
case IFF_UP:
...
break;
case IFF_UP|IFF_RUNNING:
...
break;
}

unifdef lots of code containing #ifdef FreeBSD, #ifdef NetBSD, and
#ifdef SIOCSIFMTU, especially in fwip(4) and in ndis(4).

In ipw(4), remove an if_set_sadl() call that is out of place.

In nfe(4), reuse the jumbo MTU logic in ether_ioctl().

Let ethernets register a callback for setting h/w state such as
promiscuous mode and the multicast filter in accord with a change
in the if_flags: ether_set_ifflags_cb() registers a callback that
returns ENETRESET if the caller should reset the ethernet by calling
if_init(), 0 on success, != 0 on failure. Pull common code from
ex(4), gem(4), nfe(4), sip(4), tlp(4), vge(4) into ether_ioctl(),
and register if_flags callbacks for those drivers.

Return ENOTTY instead of EINVAL for inappropriate ioctls. In
zyd(4), use ENXIO instead of ENOTTY to indicate that the device is
not any longer attached.

Add to if_set_sadl() a boolean 'factory' argument that indicates
whether a link-layer address was assigned by the factory or some
other source. In a comment, recommend using the factory address
for generating an EUI64, and update in6_get_hw_ifid() to prefer a
factory address to any other link-layer address.

Add a routing message, RTM_LLINFO_UPD, that tells protocols to
update the binding of network-layer addresses to link-layer addresses.
Implement this message in IPv4 and IPv6 by sending a gratuitous
ARP or a neighbor advertisement, respectively. Generate RTM_LLINFO_UPD
messages on a change of an interface's link-layer address.

In ether_ioctl(), do not let SIOCALIFADDR set a link-layer address
that is broadcast/multicast or equal to 00:00:00:00:00:00.

Make ether_ioctl() call ifioctl_common() to handle ioctls that it
does not understand.

In gif(4), initialize if_softc and use it, instead of assuming that
the gif_softc and ifp overlap.

Let ifioctl_common() handle SIOCGIFADDR.

Sprinkle rtcache_invariants(), which checks on DIAGNOSTIC kernels
that certain invariants on a struct route are satisfied.

In agr(4), rewrite agr_ioctl_filter() to be a bit more explicit
about the ioctls that we do not allow on an agr(4) member interface.

bzero -> memset. Delete unnecessary casts to void *. Use
sockaddr_in_init() and sockaddr_in6_init(). Compare pointers with
NULL instead of "testing truth". Replace some instances of (type
*)0 with NULL. Change some K&R prototypes to ANSI C, and join
lines.

branches: 1.30.2; 1.30.4;
Avoid the effects of name space pollution caused by <sys/rb.h>,
which defines rb_data, by instead naming the struct field rxb_data.

branches: 1.29.2; 1.29.4; 1.29.6; 1.29.8;
use aprint_*_dev and device_xname

branches: 1.28.6;
Start patching up the kernel so that a network driver always has
the opportunity to handle an ioctl before generic ifioctl handling
occurs. This will ease extending the kernel and sharing of code
between drivers.

First steps: Make the signature of ifioctl_common() match struct
ifinet->if_ioctl. Convert SIOCSIFCAP and SIOCSIFMTU to the new
ifioctl() regime, throughout the kernel.

Make many ethernet drivers share the common code for MII media
handling, ether_mediastatus() and ether_mediachange(). Check for
a non-ENXIO error return from mii_mediachg(). (ENXIO indicates
that a PHY is suspended.)

This patch shrinks the source code size by 979 lines. There was
a 5100-byte savings on the NetBSD/i386 kernel configuration, ALL.

I have made a few miscellaneous changes, too:

gem(4): use LIST_EMPTY(), LIST_FOREACH().
mtd(4): handle media ioctls, for a change!
axe(4): do not track link status in sc->axe_link any longer
nfe(4), aue(4), axe(4), udav(4), url(4): do not reset all PHYs
on a change of media

Except for the change to mtd(4), no functional changes are intended.

XXX This patch affects more architectures than I can feasibly
XXX compile and run. I have compiled macppc, sparc64, i386. I
XXX have run the patches on i386 boxen with bnx(4) and sip(4).
XXX Compiling and running on evbmips (MERAKI, ADM5120) is in
XXX progress.

branches: 1.26.2; 1.26.8;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.25.4;
Change a bazillion occurrences of code resembling this,

error = (cmd == SIOCADDMULTI) ?
ether_addmulti(ifr, &sc->sc_ec) :
ether_delmulti(ifr, &sc->sc_ec);

if (error == ENETRESET) {

to this,

if ((error = ether_ioctl(ifp, cmd, data)) == ENETRESET) {

which does the same thing.

(A bazillion is a very large number. This seems to make the i386
ALL kernel smaller by 3kB to 4kB.)

Use ifreq_getaddr() twice in es(4).

Whitespace nits.

branches: 1.24.2;
Constify: LLADDR -> CLLADDR. I'm aiming here to make it easier to
identify sockaddr_dl abuse that remains in the kernel, especially
the potential for overwriting memory past the end of a sockaddr_dl
with, e.g., memcpy(LLADDR(), ...).

branches: 1.23.2; 1.23.6;
Merge some of the less invasive changes from the vmlocking branch:

- kthread, callout, devsw API changes
- select()/poll() improvements
- miscellaneous MT safety improvements

branches: 1.22.2; 1.22.4;
Cast to char* and int before doing pointer arithmetic.

Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.20.14;
Use device_private().

Use device_cfdata().

Use device_parent().

branches: 1.17.4; 1.17.6; 1.17.8; 1.17.10; 1.17.12;
merge ktrace-lwp.

branches: 1.16.4;
nuke trailing whitespace

Allow the driver to allocate needs resources on attach and not free
depending on cf_flags (instead of on interface up / down).

Eliminate use of M_HASFCS.

branches: 1.13.8; 1.13.10;
Try to drain the Tx pending queues after dealing with Rx/Tx interrupts.

This fixes a bug whereby a fast cpu with a decent cache can easily
outstrip the GT's ability to put packets on the wire, resulting in a
permanent backlog of mbufs in the Tx pending queues under heavy Tx load.

The bug was masked if the packet buffer was mapped non-cached, which
slowed down the cpu to where it couldn't keep up with the GT at 100mbit.

add missing __KERNEL_RCSID()

branches: 1.11.2;
Always pass BUS_DMA_COHERENT to bus_dmamem_map() when allocating
descriptor/buffer memory.

Update inptr *after* we do the dmasync.

Fix overrun of TX buffer dmamap.

When attaching, make sure the "Reject Broadcast Mode", "Promiscuous Mode"
and "Pass Bad Frames" bits in the EPCR register are clear.

This works around a problem where firmware sets RBM for some reason before
handing control to the NetBSD kernel.

Use PAGE_SIZE rather than NBPG.

Deal with discovery strangeness/timing issue. Sometimes the Ownership bit
on descriptor doesn't get reset so look beyond to the next descriptor to
see if it's been returned. If it has, then just process the current one.

Update bpf interface to current. Make output buffers aligned to a
cacheline bounary. Only put hash table and descriptors in uncached
memory, buffers are in cached memory.

remove some unneeded code.

Use a subregion for the mac's ethernet registers. Shaves 512 bytes
from the driver.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Include <sys/rndsource.h> where it is actually used.

I had removed <sys/rnd.h> from files that didn't mention anything of
the rnd(9) API. But they included other files which assumed
<sys/rnd.h> had already been included.

branches: 1.12.6; 1.12.24;
Entropy-pool implementation move and cleanup.

1) Move core entropy-pool code and source/sink/sample management code
to sys/kern from sys/dev.

2) Remove use of NRND as test for presence of entropy-pool code throughout
source tree.

3) Remove use of RND_ENABLED in device drivers as microoptimization to
avoid expensive operations on disabled entropy sources; make the
rnd_add calls do this directly so all callers benefit.

4) Fix bug in recent rnd_add_data()/rnd_add_uint32() changes that might
have lead to slight entropy overestimation for some sources.

5) Add new source types for environmental sensors, power sensors, VM
system events, and skew between clocks, with a sample implementation
for each.

ok releng to go in before the branch due to the difficulty of later
pullup (widespread #ifdef removal and moved files). Tested with release
builds on amd64 and evbarm and live testing on amd64.

branches: 1.11.2;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

branches: 1.10.8;
Clean up gt and peripherals.
This change tested compile only.

branches: 1.9.16; 1.9.18;
Avoid the effects of name space pollution caused by <sys/rb.h>,
which defines rb_data, by instead naming the struct field rxb_data.

branches: 1.8.36; 1.8.38; 1.8.40; 1.8.42; 1.8.44;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.7.26;
merge ktrace-lwp.

branches: 1.6.4;
nuke trailing whitespace

Allow the driver to allocate needs resources on attach and not free
depending on cf_flags (instead of on interface up / down).

branches: 1.4.2; 1.4.10; 1.4.12;
Use PAGE_SIZE rather than NBPG.

Use a subregion for the mac's ethernet registers. Shaves 512 bytes
from the driver.

Cleanup. Move much of the code to bus_space instead of using
private mechanisms.

Add preliminary support Marvell (Galileo) Discovery System Controllers.
This code was contributed by Allegro Networks.

Add a shared function to query the common properties used for configuring
an Ethernet address.

s/funcstions/functions/ in comment.

sys: Drop redundant NULL check before m_freem(9)

m_freem(9) safely has accepted NULL argument at least since 4.2BSD:
https://www.tuhs.org/cgi-bin/utree.pl?file=4.2BSD/usr/src/sys/sys/uipc_mbuf.c

Compile-tested on amd64/ALL.

Suggested by knakahara@

branches: 1.67.2;
fix tripple/quadruple "r" letter typos in comments and log messages.

Correct byte-order for bufsize field of RX descriptor.

XXX
This bug affected only armeb. Unfortunately, the systems including
armel still lock up eventually with NFS root on mvgbe(4)...

m_freem() *after* bus_dmamap_sync() and bus_dmamap_load() for
that mbuf. This is mandatory for some archs.

Add DPRINTF() to catch failure of m_defrag() in mvgbe_encap().

Raise threshold of debug level to 3 for DPRINTF() in non-error path of
mvgbe_encap(). Without this change, debug level 2 is almost unusable...

Add ARMEB support to mvgbe(4).

For ARMEB, peripheral is configured to little-endian mode, even if
CPU itself is in big-endian mode. Therefore, we need to configure
the device to little-endian mode, and byte-swap descriptor fields
(unlike the case of powerpc).

Merge thorpej-cfargs2.

branches: 1.60.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.59.8;
Adopt <net/if_stats.h>

branches: 1.58.2;
if_flags is neither int nor short. It's unsigned short.

Use ETHER_LOCK()/ETHER_UNLOCK() for all ethernet drivers to protect ec_multi*.

Whitespace fix (mainly tabify).

No functional change:
- Simplify MII structure initialization and reference.
- u_int*_t -> uint*_t.
- KNF

On drivers which use MII(4) and have hook SIOC[GS]IFMEDIA which just pass to
ifmedia_ioctl(), the hook is not required because ether_ioctl has it
(if_ethersubr.c rev. 1.160). These drivers don't return ENETRESET in
ifmedia_ioctl(), so no functional change.

Change MII PHY read/write API from:

int (*mii_readreg_t)(device_t, int, int);
void (*mii_writereg_t)(device_t, int, int, int);
to:

int (*mii_readreg_t)(device_t, int, int, uint16_t *);
int (*mii_writereg_t)(device_t, int, int, uint16_t);

Now we can test if a read/write operation failed or not by the return value.

In 802.3 spec says that the PHY shall not respond to read/write transaction
to the unimplemented register(22.2.4.3). Detecting timeout can be used to
check whether a register is implemented or not (if the register conforms to
the spec). ukphy(4) can be used this for MII_MMDACR and MII_MMDAADR.

Note that I noticed that the following code do infinite loop in the
read/wirte function. If it accesses unimplemented PHY register, it will hang.
It should be fixed:

arm/at91/at91emac.c
arm/ep93xx/epe.c
arm/omap/omapl1x_emac.c
mips/ralink/ralink_eth.c
arch/powerpc/booke/dev/pq3etsec.c(read)
dev/cadence/if_cemac.c <- hkenken
dev/ic/lan9118.c


Tested with the following device:

axe+ukphy
axe+rgephy
axen+rgephy (tested by Andrius V)
wm+atphy
wm+ukphy
wm+igphy
wm+ihphy
wm+makphy
sk+makphy
sk+brgphy
sk+gentbi
msk+makphy
sip+icsphy
sip+ukphy
re+rgephy
bge+brgphy
bnx+brgphy
gsip+gphyter
rtk+rlphy
fxp+inphy (tested by Andrius V)
tlp+acphy
ex+exphy
epic+qsphy
vge+ciphy (tested by Andrius V)
vr+ukphy (tested by Andrius V)
vte+ukphy (tested by Andrius V)

Not tested (MAC):
arm:at91emac
arm:cemac
arm:epe
arm:geminigmac
arm:enet
arm:cpsw
arm:emac(omac)
arm:emac(sunxi)
arm:npe
evbppc:temac
macppc:bm
macppc:gm
mips:aumac
mips:ae
mips:cnmac
mips:reth
mips:sbmac
playstation2:smap
powerpc:tsec
powerpc:emac(ibm4xx)
sgimips:mec
sparc:be
sf
ne(ax88190, dl10019)
awge
ep
gem
hme
smsh
mtd
sm
age
alc
ale
bce
cas
et
jme
lii
nfe
pcn
ste
stge
tl
xi
aue
mue
smsc
udav
url

Not tested (PHY):
amhphy
bmtphy
dmphy
etphy
glxtphy
ikphy
iophy
lxtphy
nsphyter
pnaphy
rdcphy
sqphy
tlphy
tqphy
urlphy

Add intr_establish_xname support to arm and expose it to intrctl

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.50.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

branches: 1.49.8;
remove checks for failure after memory allocation calls that cannot fail:

kmem_alloc() with KM_SLEEP
kmem_zalloc() with KM_SLEEP
percpu_alloc()
pserialize_create()
psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Support Marvell Dove.

Move bpf_mtap and if_ipackets++ on Rx of each driver to percpuq if_input

The benefits of the change are:
- We can reduce codes
- We can provide the same behavior between drivers
- Where/When if_ipackets is counted up
- Note that some drivers still update packet statistics in their own
way (periodical update)
- Moved bpf_mtap run in softint
- This makes it easy to MP-ify bpf

Proposed on tech-kern and tech-net

Apply deferred if_start framework

if_schedule_deferred_start checks if the if_snd queue contains packets,
so drivers don't need to check it by themselves.

branches: 1.45.2;
Introduce m_set_rcvif and m_reset_rcvif

The API is used to set (or reset) a received interface of a mbuf.
They are counterpart of m_get_rcvif, which will come in another
commit, hide internal of rcvif operation, and reduce the diff of
the upcoming change.

No functional change.

Pass all unicast addresses if it is promisc mode.

Add more #warning message 'Please use mvxpe instead of this'.

Introduce softint-based if_input

This change intends to run the whole network stack in softint context
(or normal LWP), not hardware interrupt context. Note that the work is
still incomplete by this change; to that end, we also have to softint-ify
if_link_state_change (and bpf) which can still run in hardware interrupt.

This change softint-ifies at ifp->if_input that is called from
each device driver (and ieee80211_input) to ensure Layer 2 runs
in softint (e.g., ether_input and bridge_input). To this end,
we provide a framework (called percpuq) that utlizes softint(9)
and percpu ifqueues. With this patch, rxintr of most drivers just
queues received packets and schedules a softint, and the softint
dequeues packets and does rest packet processing.

To minimize changes to each driver, percpuq is allocated in struct
ifnet for now and that is initialized by default (in if_attach).
We probably have to move percpuq to softc of each driver, but it's
future work. At this point, only wm(4) has percpuq in its softc
as a reference implementation.

Additional information including performance numbers can be found
in the thread at tech-kern@ and tech-net@:
http://mail-index.netbsd.org/tech-kern/2016/01/14/msg019997.html

Acknowledgment: riastradh@ greatly helped this work.
Thank you very much!

add u-boot argument parser for Marvell ARMADA XP/370.
use 'ethaddr' and 'eth1addr' in u-boot argument to setup MAC address of mvgbe.

Convert sys/dev to use <sys/rndsource.h>.

branches: 1.39.4;
Merge tls-earlyentropy branch into HEAD.

branches: 1.38.2;
Support Armada 370 and DDR3 tags.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

Carefully set IFF_OACTIVE in mvgbe_start(). Even if mvgbe_encap()
returns other than 0, the TX ring might not full. Check whether
the TX ring has one or more packets. If the ring is empty,
dont' set IFF_OACTIVE because an TX complete interrupt never
occur and IFF_OACTIVE flags is left. The interface's timer
isn't reset, so a device timeout desn't occur.

Fixes a bug that IFF_OACTIVE flag is left on heavy load.
Part of PR#48568.

Support Basic Mode for Armada XP.

branches: 1.34.2;
Fix a bug that a multicast filter entry is incorrectly overrode
on some cases.

Check wheter an MII PHY is really connected or not.
This change privents panic if MII PHY port is not used.

Add MVGBE_EVENT_COUNTERS for debugging. Count rxoverrrun and wdogsoft.

Fix a bug that MVGBE_JLEN is miscalculated.

When an interrput is link change, notify link change to mii layer using
mii_pollstat().

Don't use M_HASFCS flag.

No functional change.
- Change style a bit.
- use "csc" for the variable name of struct mvgbec_softc in mvgbec_attach()
for consistency.

Add missing mii_tick() call.

Fix a bug that kernel panics when the system get a packet while calling
mvgbe_stop (via ifconfig down).

Add code to modify interrupt coalescing with sysctl.
- both TX side an RX side.
- different setting for each port
- TX side is hw.mvgbe.mvgbe*.ipginttx
- RX side is hw.mvgbe.mvgbe*.ipgintrx
- The default value is 768.
- The lowest value is 0
- For highest value, 0x3777 is used for V1, and 0xffff is used for V2.

Add Interrupt Coalescing setting by Robert Swindells.

- The MVGBE_RX_MAX_FRAME_LEN_ERROR bit is used to check whether a packet
is fragmented or not, so define new MVGBE_RX_IP_FRAGMENT with the same
value and use it.
- Remove the checking whether a packet length is lower than 72 octet.
This check is not used in Linux and FreeBSD. Tested with me (for Kirkwood)
and Kiyohara (for DiscoveryII).

Fix udpcsum-rx bug on fragmented case this time.
- Fix the usage of a local variable for csum_flags.
- It seemd that sometimes MVGBE_RX_L4_CHECKSUM_OK bit were set to 0
even if the checksum is correct and the packet was not fragmented.
So we don't set M_CSUM_TCP_UDP_BAD even if csum bit is 0.

- Fix a bug that a fragmented packet is marked as bad checksum. It causes
a real bug when HW checksum offload function is used. It was easy to
reproduce with NFS UDP mount.
- Fix a potential bug that a packet other than TCP and UDP is marked as bad
checksum.

Fix device timeout problem.
- Change the synching order of descriptors. First, sync descriptors except
first and then sync the first descriptor.
- To recover from an race condition, reduce the if_timer from 5 to 1 and
when timeout occur write MVGBE_TQC_ENQ bit again.

branches: 1.19.2;
Add missing bus_dmamap_sync() for the RX buffer.

Fix mii_statchg to take a 'struct ifnet *' instead of device_t. This fixes
problem with a common MDIO bus used for multiple interfaces.
Some drivers converted to CFATTACL_DECL_NEW.

Add 88F6282. tested only OpenBlockS A6.
Also fix irq 11 to 15. irq of 2nd NIC is 15.
Remove white-space.

branches: 1.16.2;
Entropy-pool implementation move and cleanup.

1) Move core entropy-pool code and source/sink/sample management code
to sys/kern from sys/dev.

2) Remove use of NRND as test for presence of entropy-pool code throughout
source tree.

3) Remove use of RND_ENABLED in device drivers as microoptimization to
avoid expensive operations on disabled entropy sources; make the
rnd_add calls do this directly so all callers benefit.

4) Fix bug in recent rnd_add_data()/rnd_add_uint32() changes that might
have lead to slight entropy overestimation for some sources.

5) Add new source types for environmental sensors, power sensors, VM
system events, and skew between clocks, with a sample implementation
for each.

ok releng to go in before the branch due to the difficulty of later
pullup (widespread #ifdef removal and moved files). Tested with release
builds on amd64 and evbarm and live testing on amd64.

branches: 1.15.2;
First step of random number subsystem rework described in
<20111022023242.BA26F14A158@mail.netbsd.org>. This change includes
the following:

An initial cleanup and minor reorganization of the entropy pool
code in sys/dev/rnd.c and sys/dev/rndpool.c. Several bugs are
fixed. Some effort is made to accumulate entropy more quickly at
boot time.

A generic interface, "rndsink", is added, for stream generators to
request that they be re-keyed with good quality entropy from the pool
as soon as it is available.

The arc4random()/arc4randbytes() implementation in libkern is
adjusted to use the rndsink interface for rekeying, which helps
address the problem of low-quality keys at boot time.

An implementation of the FIPS 140-2 statistical tests for random
number generator quality is provided (libkern/rngtest.c). This
is based on Greg Rose's implementation from Qualcomm.

A new random stream generator, nist_ctr_drbg, is provided. It is
based on an implementation of the NIST SP800-90 CTR_DRBG by
Henric Jungheim. This generator users AES in a modified counter
mode to generate a backtracking-resistant random stream.

An abstraction layer, "cprng", is provided for in-kernel consumers
of randomness. The arc4random/arc4randbytes API is deprecated for
in-kernel use. It is replaced by "cprng_strong". The current
cprng_fast implementation wraps the existing arc4random
implementation. The current cprng_strong implementation wraps the
new CTR_DRBG implementation. Both interfaces are rekeyed from
the entropy pool automatically at intervals justifiable from best
current cryptographic practice.

In some quick tests, cprng_fast() is about the same speed as
the old arc4randbytes(), and cprng_strong() is about 20% faster
than rnd_extract_data(). Performance is expected to improve.

The AES code in src/crypto/rijndael is no longer an optional
kernel component, as it is required by cprng_strong, which is
not an optional kernel component.

The entropy pool output is subjected to the rngtest tests at
startup time; if it fails, the system will reboot. There is
approximately a 3/10000 chance of a false positive from these
tests. Entropy pool _input_ from hardware random numbers is
subjected to the rngtest tests at attach time, as well as the
FIPS continuous-output test, to detect bad or stuck hardware
RNGs; if any are detected, they are detached, but the system
continues to run.

A problem with rndctl(8) is fixed -- datastructures with
pointers in arrays are no longer passed to userspace (this
was not a security problem, but rather a major issue for
compat32). A new kernel will require a new rndctl.

The sysctl kern.arandom() and kern.urandom() nodes are hooked
up to the new generators, but the /dev/*random pseudodevices
are not, yet.

Manual pages for the new kernel interfaces are forthcoming.

Add workaround for infrequently encountered DMA engine limitation.

branches: 1.13.2;
Only zero MVGBE_MTU on Orion platforms.

We occasionally will try to set up the multicast filter in a context that
kmem(9) is unusable (such as transmit timeout). Thus, put the filter table
on the stack instead, all 528 bytes of it.

Initialize MVGBE_MTU to 0, as suggested by the Orion databook.

If the platform firmware did not initialize this to 0 for us,
we were unable to transmit frames.

Use new style BPF calls.

Use cfdata_t

fix typo, and use the parent to determine the offset. From Dave Mills