Home | History | Annotate | Download | only in marvell
History log of /src/sys/dev/marvell/gtidmac.c
RevisionDateAuthorComments
 1.21  12-Jun-2024  andvar MVXORE_XEXCDPR and MVXORE_XEXBCR macros expect two params now, thus adjust
params accordingly, needed in order to fix GTIDMAC_DEBUG build option.

Unfortunately, there few more macros in gtidmac_dump_xorereg() like
MVXORE_XETMCR, MVXORE_XETMIVR, MVXORE_XETMCVR, MVXORE_XEIVRH, MVXORE_XEIVRL
which also expect two params, but second one doesn't seem to be a channel,
thus I am leaving it unfixed for now.
 1.20  02-Feb-2024  andvar fix typos, mainly s/unsupport/unsupported/ in log messages.
 1.19  19-Jun-2023  msaitoh Fix typo. unknwon -> unknown
 1.18  24-Jul-2021  andvar Fix all remaining typos, mainly in comments but also in few definitions and log messages, reported by me in PR kern/54889.
Also fixed some additional typos in comments, found on review of same files or typos.
 1.17  27-Dec-2019  msaitoh branches: 1.17.12;
s/transfered/transferred/
 1.16  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.15  01-Jun-2017  chs branches: 1.15.8; 1.15.10;
remove checks for failure after memory allocation calls that cannot fail:

kmem_alloc() with KM_SLEEP
kmem_zalloc() with KM_SLEEP
percpu_alloc()
pserialize_create()
psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.
 1.14  31-Mar-2017  msaitoh Remove extra 0x. This bug was added when replacing bitmask_snprintf(9) with
snprintb(3) (in between NetBSD 5 and 6). Old bitmask_snprint(9) didn't add
0x" automatically for hexadecimal value, so old code used it with "0x%s".
 1.13  07-Jan-2017  kiyohara branches: 1.13.2;
Support Marvell Dove. Use irq array. Dove's irqs not sequencial.
And remove debug printf().
 1.12  07-Jan-2017  kiyohara Remove unused function.
 1.11  15-Mar-2014  kiyohara branches: 1.11.6; 1.11.10;
Support Armada 370 and DDR3 tags.
 1.10  28-Sep-2013  kiyohara Add ARMADAXP IDs.
 1.9  10-Sep-2012  msaitoh branches: 1.9.2; 1.9.4;
Add "static".
 1.8  23-Jul-2012  kiyohara Support Kirkwoods. Kirkwoods has 4ch for XORE and not has IDMAC. tested on OpenBlockS A6 with ch0 only.
 1.7  30-Jan-2012  matt Use proper ANSI prototypes for foo() -> foo(void)
Caught when compiling with -Wold-style-definition
 1.6  01-Aug-2010  kiyohara branches: 1.6.2; 1.6.10; 1.6.14;
Cleanup foo_match().
+ Remove check for model.
+ Remove unnecessary null line.
 1.5  20-Jul-2010  kiyohara Fix information on the product with comment-out. This was obtained from
the data sheet of Marvell.
 1.4  11-Jul-2010  kiyohara Add macro MVA_{UNIT,OFFSET,IRQ}_DEFAULT.
 1.3  04-Jun-2010  kiyohara Fix sume bugs.
- Why +1 ?
- mvidmac_dump_xoredesc() -> gtidmac_dump_xoredesc().
- bitmask_snprintf() -> snprintb().
Support big endian machines with GTIDMAC_CCHR_ENDIAN_BE.
 1.2  02-Jun-2010  kiyohara Use kmem(9) instead of malloc(9) in gtidmac_attach().
 1.1  28-Apr-2010  kiyohara branches: 1.1.2; 1.1.4;
Clean up gt and peripherals.
This change tested compile only.
 1.1.4.4  05-Mar-2011  rmind sync with head
 1.1.4.3  03-Jul-2010  rmind sync with head
 1.1.4.2  30-May-2010  rmind sync with head
 1.1.4.1  28-Apr-2010  rmind file gtidmac.c was added on branch rmind-uvmplock on 2010-05-30 05:17:29 +0000
 1.1.2.3  17-Aug-2010  uebayasi Sync with HEAD.
 1.1.2.2  30-Apr-2010  uebayasi Sync with HEAD.
 1.1.2.1  28-Apr-2010  uebayasi file gtidmac.c was added on branch uebayasi-xip on 2010-04-30 14:43:27 +0000
 1.6.14.1  18-Feb-2012  mrg merge to -current.
 1.6.10.3  22-May-2014  yamt sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
 1.6.10.2  30-Oct-2012  yamt sync with head
 1.6.10.1  17-Apr-2012  yamt sync with head
 1.6.2.2  11-Aug-2010  yamt sync with head.
 1.6.2.1  01-Aug-2010  yamt file gtidmac.c was added on branch yamt-nfs-mp on 2010-08-11 22:53:37 +0000
 1.9.4.1  18-May-2014  rmind sync with head
 1.9.2.2  03-Dec-2017  jdolecek update from HEAD
 1.9.2.1  20-Aug-2014  tls Rebase to HEAD as of a few days ago.
 1.11.10.2  26-Apr-2017  pgoyette Sync with HEAD
 1.11.10.1  20-Mar-2017  pgoyette Sync with HEAD
 1.11.6.2  28-Aug-2017  skrll Sync with HEAD
 1.11.6.1  05-Feb-2017  skrll Sync with HEAD
 1.13.2.1  21-Apr-2017  bouyer Sync with HEAD
 1.15.10.2  08-Apr-2020  martin Merge changes from current as of 20200406
 1.15.10.1  10-Jun-2019  christos Sync with HEAD
 1.15.8.1  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)
 1.17.12.1  01-Aug-2021  thorpej Sync with HEAD.

RSS XML Feed