Home | History | Annotate | Download | only in cxgb
History log of /src/sys/dev/pci/cxgb/cxgb_main.c
RevisionDateAuthorComments
 1.10  07-Aug-2021  thorpej Merge thorpej-cfargs2.
 1.9  24-Apr-2021  thorpej branches: 1.9.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).
 1.8  04-Feb-2020  thorpej branches: 1.8.8;
Use ifmedia_fini().
 1.7  09-Dec-2018  jdolecek branches: 1.7.6;
use pci_intr_establish_xname()

XXX due to 2008-01-17 '10 gigabit Chelsio cards now compile and work, although
XXX not very well yet' commit this looks like having worked in past, but since
XXX ~2010 received only mechanical updates, and currently it's unreferenced
XXX and uncompilable - does it make sense to keep the driver around?
 1.6  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.5  26-Jun-2018  msaitoh branches: 1.5.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.
 1.4  23-Jan-2013  joerg branches: 1.4.36;
Make cxgb at least compilable. Fix _rt_key usage.
 1.3  27-Oct-2012  chs split device_t/softc for all remaining drivers.
replace "struct device *" with "device_t".
use device_xname(), device_unit(), etc.
 1.2  18-May-2011  dyoung branches: 1.2.4; 1.2.14;
MI code must #include <sys/bus.h>, not <machine/bus.h>.
 1.1  21-Mar-2010  jklos branches: 1.1.2; 1.1.4; 1.1.6; 1.1.8;
Reorganizing all Chelsio 10 gig files into separate directory.
 1.1.8.1  06-Jun-2011  jruoho Sync with HEAD.
 1.1.6.2  11-Aug-2010  yamt sync with head.
 1.1.6.1  21-Mar-2010  yamt file cxgb_main.c was added on branch yamt-nfs-mp on 2010-08-11 22:54:05 +0000
 1.1.4.3  31-May-2011  rmind sync with head
 1.1.4.2  30-May-2010  rmind sync with head
 1.1.4.1  21-Mar-2010  rmind file cxgb_main.c was added on branch rmind-uvmplock on 2010-05-30 05:17:40 +0000
 1.1.2.2  30-Apr-2010  uebayasi Sync with HEAD.
 1.1.2.1  21-Mar-2010  uebayasi file cxgb_main.c was added on branch uebayasi-xip on 2010-04-30 14:43:44 +0000
 1.2.14.2  25-Feb-2013  tls resync with head
 1.2.14.1  20-Nov-2012  tls Resync to 2012-11-19 00:00:00 UTC
 1.2.4.2  22-May-2014  yamt sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
 1.2.4.1  30-Oct-2012  yamt sync with head
 1.4.36.3  26-Dec-2018  pgoyette Sync with HEAD, resolve a few conflicts
 1.4.36.2  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)
 1.4.36.1  28-Jul-2018  pgoyette Sync with HEAD
 1.5.2.2  08-Apr-2020  martin Merge changes from current as of 20200406
 1.5.2.1  10-Jun-2019  christos Sync with HEAD
 1.7.6.1  29-Feb-2020  ad Sync with head.
 1.8.8.2  22-Mar-2021  thorpej Audit CFARG_IATTR in config_found() calls, and remove it in situations
where the interface attribute is not ambiguous.
 1.8.8.1  22-Mar-2021  thorpej Mechanical conversion of config_found_sm_loc() -> config_found().
CFARG_IATTR usage needs to be audited.
 1.9.8.1  04-Aug-2021  thorpej Adapt to CFARGS().

RSS XML Feed