usb *hci: Always set ux_status before usbd_xfer_schedule_timeout.

Add an assert to usbd_xfer_schedule_timeout to enforce this.

Since access to ux_status is serialized by the bus lock, and nothing
releases the bus lock in the interim, this doesn't make a functional
change. But it does reduce confusion by readers, who no longer have
to worry if some callers got the order wrong. It could also now
potentially be factored out in a subsequent commit.

usb: Hold pipe lock across upm_transfer and upm_start.

This simplifies the code and fixes races with abort. Access to the
pipe's queue is now done exclusively while the pipe is locked.

usb: Factor usb_transfer_complete out of ubm_abortx method.

usb: Factor usb_insert_transfer out of upm_transfer and make private.

Almost every upm_transfer function starts with:

mutex_enter(&sc->sc_lock);
err = usb_insert_transfer(xfer);
mutex_exit(&sc->sc_lock);
if (err)
return err;

Some of them have debug messages sprinkled in here too, or assert
that err == USBD_NORMAL_COMPLETION (alternative is USBD_IN_PROGRESS,
only for pipes with up_running or up_serialise, presumably not
applicable for these types of pipes). Some of them also assert
xfer->ux_status == USBD_NOT_STARTED, which is guaranteed on entry and
preserved by usb_insert_transer.

Exceptions:

- arch/mips/adm5120/dev/ahci.c ahci_device_isoc_transfer just returns
USBD_NORMAL_COMPLETION, but I'm pretty sure this is and always has
been broken anyway, so won't make anything worse (if anything, might
make it better...)

- external/bsd/dwc2/dwc2.c dwc2_device_bulk_transfer and
dwc2_device_isoc_transfer _also_ issue dwc2_device_start(xfer)
under the lock. This is probably a better way to do it, but let's
do it uniformly across all HCIs at once.

- rump/dev/lib/libugenhc/ugenhc.c rumpusb_device_bulk_transfer
sometimes returns USBD_IN_PROGRESS _without_ queueing the transfer,
in the !rump_threads case. Not really sure how this is supposed to
work... If it actually breaks anything, we can figure it out.

Change the usb_mem API to take a bus_dma_tag_t in usb_allocmem instead of
a struct usbd_bus *.

This allows an HCD to use more than one tag.

More converstion from usbd_status to int for function error reporting.
This time it's the turn of usb_allocmem.

(missed in previous commit)

usb: Omit bogus assertions about struct usbd_pipe::up_intrxfer.

These assertions were only valid for pipes at UE_IN_DIR, UE_INTERRUPT
endpoints created with usbd_open_pipe_intr, which uses up_intrxfer to
pass the struct usbd_xfer object to usbd_close_pipe to free later.

In contrast, for pipes at UE_OUT_DIR, UE_INTERRUPT endpoints,
up_intrxfer is never initialized, so the assertion cannot be right.
In principle we might even have more than one outstanding interrupt
transfer at a time, rendering the point of the assertion moot anyway.

Found by interrupting a uhidev write to a u2f device.

ok nick

branches: 1.74.2;
Update ux_length in usbd_setup_isoc_xfer and use this to usb_syncmem
in the HCDs

Switch USB to use non-coherent buffers for data transfers in the
same way as OpenBSD.

The use of coherent (uncacheable on ARM and other arches) mappings
for transfer buffers impacts performance, espcially where memcpys
are involved.

Audit the necessary usb_syncmem operations - a few were missing.

Fix a memory leak. Spotted by nat@

#ifdef DIAGNOSTIC --> __diagused

Fix non-DIAGNOSTIC builds.

Fix mistakes in previous sloppy change with root intr xfers.

- Make sure ux_status is set to USBD_IN_PROGRESS when started.
Otherwise, if it is still in flight when we abort the pipe,
usbd_ar_pipe will skip calling upm_abort.

- Initialize ux_status under the lock; in principle a completion
interrupt (or a delay) could race with the initialization.

- KASSERT that the xfer is in progress when we're about to complete
it.

Candidate fix for PR kern/54963 for other HCI drivers than uhci.

ok nick
ok phone

(This is the change that nick evidently MEANT to ok when he ok'd the
previous one!)

Fix steady state of root intr xfers.

Why?

- Avoid completing a root intr xfer multiple times in races.
- Avoid potential use-after-free in poll_hub callouts (uhci, ahci).

How?

- Use sc->sc_intr_xfer or equivalent to store only a pending xfer
that has not yet completed -- whether successfully, by timeout, or
by synchronous abort. When any of those happens, set it to null
under the lock, so the xfer is completed only once.

- For hci drivers that use a callout to poll the root hub (uhci, ahci):

. Pass the softc pointer, not the xfer, to the callout, so the
callout is not even tempted to use xfer after free -- if the
callout fires, but the xfer is synchronously aborted before the
callout can do anything, the xfer might be freed by the time the
callout starts to examine it.

. Teach the callout to do nothing if it is callout_pending after it
has fired. This way:

1. completion or synchronous abort can just callout_stop
2. start can just callout_schedule

If the callout had already fired before (1), and doesn't acquire
the bus lock until after (2), it may be tempted to abort the new
root intr xfer just after submission, which would be wrong -- so
instead we just have the callout do nothing if it notices it has
been rescheduled, since it will fire again after the appropriate
time has elapsed.

Factor out HCI-independent xfer completion logic.

New API for HCI drivers to synchronize hardware completion
interrupts, synchronous aborts, and asynchronous timeouts:

- When submitting an xfer to hardware, call
usbd_xfer_schedule_timeout(xfer).

- On HCI completion interrupt for xfer completion:

if (!usbd_xfer_trycomplete(xfer))
return; /* timed out or aborted, ignore it */

- In upm_abort methods, call usbd_xfer_abort(xfer).

For HCI drivers that use this API (not needed in drivers that don't,
or for xfers like root intr xfers that don't use it):

- New ubm_abortx method serves role of former *hci_abort_xfer, but
without any logic for wrangling timeouts/callouts/tasks -- caller
in usbd_xfer_abort has already handled them.

- New ubm_dying method, returns true if the device is in the process
of detaching, used by the timeout logic.

Converted and tested:
- ehci
- ohci

Converted and compile-tested:
- ahci (XXX did this ever work?)
- dwc2
- motg (XXX missing usbd_xfer_schedule_timeout in motg_*_start?)
- uhci
- xhci

Not changed:

- slhci (sys/dev/ic/sl811hs.c) -- doesn't use a separate per-xfer
callout for timeouts (XXX but maybe should?)

- ugenhc (sys/rump/dev/lib/libugenhc/ugenhc.c) -- doesn't manage its
own transfer timeouts

- vhci -- times transfers out only on detach; could be adapted easily
if we wanted to use the xfer->ux_callout

branches: 1.66.2;
Consistency.

build fix

Calulate the right lenght for isoc transfer and the usb_syncmem

PR/54696: Kernel panic in bus_dma.c on Raspberry Pi 3B/3B+

Use size_t for loop count variable

Need <sys/sysctl.h> for previous

Make dwc2debug sysctl'able

KNF

branches: 1.59.4;
- dwc2 need calling linux_workqueue_init() to avoid panic.
- use INIT_ONCE/FINI_ONCE to linux_workqueue_{init,fini}() for being called from dwc2.

TODO: dwc2 should be written as kernel module depenging on a linux module.

Fix assertion failures triggered by usbdi.c,v 1.182, when devices
are detached.

This is because xfers of USBD_NOT_STARTED can be removed from queue
in an invisible way to host controller drivers.

Discussed on tech-kern.

Revert the KASSERT

Add a KASSERT

consolidate the handling of polling across HC drivers, and generic USB:
- don't take mutexes if polling
- normalise the code across all drivers
- add some not yet code to block discovery to/from polling
- minor CSE
- adjust comment for usbd_set_polling() to reality now i properly
understand what it is used for and why.

this, with a hack to make RB_ASKNAME to wait 5 seconds allows boot -a
work with USB keyboards. there are still multiple issues remaining:
- discovery and polling need to be mutually exclusive
- attachment of ukbd and wskbd is not handled by config_pending, and
the 5 second delay isn't going to always be enough.

Fix non-DIAGNOSTIC build

Fix debug build. Also make formats more consistent with others in
DPRINTF added in the previous commit.

pull across abort fixes from nick-nhusb. add more abort fixes, using
ideas from Taylor and Nick, and myself. special thanks to both who
inspired much of the code here, if not wrote it directly.

among other problems, this assert should no longer trigger:

panic: kernel diagnostic assertion "xfer->ux_state == XFER_ONQU" failed: file "/current/src/sys/dev/usb/usbdi.c", line 914

using usbhist i was able to track down my instance of it being related
to userland close() beginning, dropping the sc_lock, and then the usb
softintr completes the transfer normally, and when it is done, the
abort path attempts to re-complete the transfer, and the above assert
is tripped.


changes from nhusb were commited with these logs:
--
Move the struct usb_task to struct usbd_xfer for everyone to use.
--
Set device transfer status to USBD_IN_PROGRESS if start methods succeeds
--
Actually set the transfer status on transfers in ohci_abort_xfer and
the controller is dying
--
Don't supply the lock to callout_halt when polling as it won't be held
--
Improve transfer abort
--
Mark device transfers as USBD_IN_PROGRESS appropriately and improve
abort handling
--
#ifdef DIAGNOSTIC -> KASSERT and add another KASSERT
--
Mark device transfers as USBD_IN_PROGRESS appropriately and improve
abort handling
--

additional changes include:
- initialise the usb abort task in the HCI allocx routine, so that it
can be safely usb_rem_task()'d.
- rework the handling of softintr vs cancellation vs timeout abort based
upon a scheme from Taylor:
when completing a transfer normally:
- if the status is not in progress, it must be cancelled or timed out,
and we should not process this xfer.
- set the status as normal.
- unconditionallly callout_stop() and usb_rem_task(). they're safe and
either aren't running, or will run and do nothing.
- finally call usb_transfer_complete().
when aborting a transfer:
- status should be cancelled or timed out.
- if cancelling, callout_halt and usb_rem_task_wait() to make sure the
timer is either done or cancelled.
- at this point, the ux_status must not be cancelled or timed out, and
if it is not in progress we're done.
- set the status.
- if the controller is dying, just return.
- perform HCI-specific tasks to abort this xfer.
- finally call usb_transfer_complete().
for the timeout and timeout task:
- if the HCI is not dying, and the ux_status is in progress, then
trigger the usb abort task.
- remove UXFER_ABORTWAIT and UXFER_ABORTING.

tested on:
- multiple PC systems with several types of devices: ugen/UPS, ucom,
umass with disk, ssd and cdrom backends, kbd, ms, using uhci, ehci
and xhci.
- erlite3: sd@umass on dwc2.
- sunblade2000: kbd/ms and umass disk on ohci.

untested:
- motg, slhci and ahci. motg has some portion of the new scheme
applied, but slhci and ahci require more study.

future work includes pushing a lot of the common abort handling into
usbdi.c and leaving upm_abort() for HC specific tasks, but this change
is pullup-able to netbsd-7 and netbsd-8 as it does not change any
external API, as well as removing over 100 lines of code while adding
over 30 new asserts.

XXX: pullup-7, pullup-8.

aprint_verbose the core version

Do not call usb_syncmem(9) with len = 0 to avoid diagnostic assertion
failure in bus_dmamap_sync(9) on Raspberry Pi 3 Model B running in
aarch64 mode.

Workaround for PR port-evbarm/53503.

branches: 1.49.2;
Stop potential misuse of vendor names and USB vendor IDs in root hub
device and string descriptors.

Firstly: Few vendors have identical PCI-SIG vendor IDs and USB-IF vendor
IDs. As such, using the PCI vendor ID as a USB vendor ID may trample
on whomever is allocated that USB vendor ID.

Secondly: The vendor of the host controller hardware implementation has
little to nothing to do with our usbroothub implementation. Thus we
should not potentially associate any problems therewith to such third
party.

This change will result in root hubs being identified by USB Vendor ID
0x0000. Root hub vendor string will now be "NetBSD" (or, specifically:
ostype). Product ID (0x0000) and product strings remain unchanged.

branches: 1.48.2;
Fix KASSERT panic. When detaching USB host controoler, the following panic
occured:
kernel diagnostic assertion "sc->sc_intrxfer == xfer" failed: file "../../../../dev/usb/ohci.c", line 1720
Clear sc_intrxfer correctly. Adviced by Nick and tested by me.

s/PR_NOWAIT/PR_WAITOK/ in HCD allocx (allocate xfer) method

branches: 1.46.2;
remove checks for failure after memory allocation calls that cannot fail:

kmem_alloc() with KM_SLEEP
kmem_zalloc() with KM_SLEEP
percpu_alloc()
pserialize_create()
psref_class_create()

all of these paths include an assertion that the allocation has not failed,
so callers should not assert that again.

Add a missing usb_syncmem(... BUS_DMASYNC_PRE{READ,WRITE}) for the
transfer buffer

Change the SOFTINT level from NET to SERIAL for the USB softint handler.
This gives the callback a chance of running when another softint handler
at SOFTINT_NET has blocked holding a lock, e.g. softnet_lock and most of
the network stack.

Should fix/help
kern/49065 - ifconfig tun0 ... sequence locks up system / lockup: softnet_lock held across usb xfr
kern/50491 - unkillable wait in usbd_transfer while using usmsc0 on raspberry pi 2
kern/51395 - USB Ethernet makes xhci hang

and probably others

branches: 1.43.2;
usb is attached with config_interrupts so we can G/C the code to support
transfers when this wasn't the case.

Merge nick-nhusb

- API / infrastructure changes to support memory management changes.
- Memory management improvements and bug fixes.
- HCDs should now be MP safe
- conversion to KERNHIST based debug
- FS/LS isoc support on ehci(4).
- conversion to kmem(9)
- Some USB 3 support - mostly from Takahiro HAYASHI (t-hash).
- interrupt transfers now get proper DMA operations
- general bug fixes
- kern/48308
- uhub status notification improvements
- umass(4) probe fix (applied to HEAD already)
- ohci(4) short transfer fix

Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Trailing whitespace.

Update for latest dwc2 dist

Stop the callout if the transfer didn't get enqueued

Update for latest dwc2

Whitespace

Move rd assignment. Spotted by christos@. Thanks.

Do BUS_DMASYNC_POST{READ,WRITE} on transfer buffers appropriately

Whitespace.

branches: 1.32.2;
dwc2_hubd appears to be unused so #if 0 it in order to appease clang

branches: 1.31.2; 1.31.4;
Remove #ifdef DIAGNOSTIC around sc from the root interrupt abort methods
now it's always used.

Prevent the root hub sending updates once the root interrupt abort is
called.

Simplify the freeing of the interrupt pipe transfer. Inspired by OpenBSD.

Use DWC2_XFER2DPIPE

Use the right macro in dwc2_root_intr_start

branches: 1.26.2; 1.26.4; 1.26.6;
Small bit of tidyup and remove a XXX now that it's possible.

Call callout_reset on the xfer timeoute_handle before calling
dwc2_hcd_urb_enqueue

Change a KASSERT to a KASSERTMSG and add a DPRINTFN.

Protect access of urb->hcpriv by adapting the following change from the
Raspberry PI dwc_otg driver.

https://github.com/raspberrypi/linux/commit/38753ce72d4f10d5d0f1ed27fa691a2ba8910941

dwc_otg: prevent OOPSes during device disconnects

The dwc_otg_urb_enqueue function is thread-unsafe. In particular the
access of urb->hcpriv, usb_hcd_link_urb_to_ep, dwc_otg_urb->qtd and
friends does not occur within a critical section and so if a device
was unplugged during activity there was a high chance that the
usbcore hub_thread would try to disable the endpoint with partially-
formed entries in the URB queue. This would result in BUG() or null
pointer dereferences.

Fix so that access of urb->hcpriv, enqueuing to the hardware and
adding to usbcore endpoint URB lists is contained within a single
critical section.

KASSERT that the transfer callout is not pending.

Removes a XXX

Drop the intr_lock when calling usb_schedsoftintr so that we don't lock
against ourself in dwc2_softintr in the polling case.

Zeroise the whole urb including the iso_descs array

Correct the interval assignment for isoc and intr transfers.

Use PRIxBUSADDR in DPRINTF. Problem pointed out by kiyohara.

Remove unused variable.

Don't always define DWC2_DEBUG

Remove unused usbd_xfer_handle from dwc2_pipe.

Minor cleanup.

Remove daft KASSERTs

Make this compile for more option combinations.

Translate ENODEV to USBD_INVAL

At least attempt to handle USBD_DEFAULT_INTERVAL.

A small code simplification

Pass any error from dwc2_device_start upwards.

First pass at isoc transfer support - seems to work. More testing
required.

Tidyup dwc2_host_is_b_hnp_enabled

Missed a sc->sc_intr_lock to hsotg->lock change from earlier commit.

Improve a couple of DPRINTFs

Use the hsotg->lock spin lock solely

Improve a couple of DPRINTFs

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

dwc2: Use getticks(), not hardclock_ticks.

Get drm to build on arm64 again.


Author: Jared McNeill <jmcneill@NetBSD.org>
Committer: Taylor R Campbell <riastradh@NetBSD.org>

Fix fallout from linux/gfp.h -> common.

branches: 1.9.16; 1.9.18;
Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

In msleep use udelay if cold or sleep is small enough. This is mostly
copied from the drm2 version.

Update for latest dwc2

KNF

Use IPL_VM for dwc2_intr and mark as MP safe where possible.

#include "opt_usb.h"

branches: 1.3.2;
Use IPL_SCHED for dwctwo(4) - no need for the KERNEL_LOCK.

branches: 1.2.4; 1.2.6; 1.2.8; 1.2.10; 1.2.14;
Don't always define DWC2_DEBUG

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

Factor out HCI-independent xfer completion logic.

New API for HCI drivers to synchronize hardware completion
interrupts, synchronous aborts, and asynchronous timeouts:

- When submitting an xfer to hardware, call
usbd_xfer_schedule_timeout(xfer).

- On HCI completion interrupt for xfer completion:

if (!usbd_xfer_trycomplete(xfer))
return; /* timed out or aborted, ignore it */

- In upm_abort methods, call usbd_xfer_abort(xfer).

For HCI drivers that use this API (not needed in drivers that don't,
or for xfers like root intr xfers that don't use it):

- New ubm_abortx method serves role of former *hci_abort_xfer, but
without any logic for wrangling timeouts/callouts/tasks -- caller
in usbd_xfer_abort has already handled them.

- New ubm_dying method, returns true if the device is in the process
of detaching, used by the timeout logic.

Converted and tested:
- ehci
- ohci

Converted and compile-tested:
- ahci (XXX did this ever work?)
- dwc2
- motg (XXX missing usbd_xfer_schedule_timeout in motg_*_start?)
- uhci
- xhci

Not changed:

- slhci (sys/dev/ic/sl811hs.c) -- doesn't use a separate per-xfer
callout for timeouts (XXX but maybe should?)

- ugenhc (sys/rump/dev/lib/libugenhc/ugenhc.c) -- doesn't manage its
own transfer timeouts

- vhci -- times transfers out only on detach; could be adapted easily
if we wanted to use the xfer->ux_callout

branches: 1.6.4; 1.6.6;
Remove unused struct member (usbd_xfer now has a struct usb_task)

branches: 1.5.16; 1.5.18;
Merge nick-nhusb

- API / infrastructure changes to support memory management changes.
- Memory management improvements and bug fixes.
- HCDs should now be MP safe
- conversion to KERNHIST based debug
- FS/LS isoc support on ehci(4).
- conversion to kmem(9)
- Some USB 3 support - mostly from Takahiro HAYASHI (t-hash).
- interrupt transfers now get proper DMA operations
- general bug fixes
- kern/48308
- uhub status notification improvements
- umass(4) probe fix (applied to HEAD already)
- ohci(4) short transfer fix

Support external DMA mode and provide an interface for DMA address configuration

branches: 1.3.4; 1.3.6; 1.3.8; 1.3.10; 1.3.12; 1.3.16;
Remove unused usbd_xfer_handle from dwc2_pipe. (missed commit)

Use the hsotg->lock spin lock solely

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

Note where we're tracking dwc2 from now.

branches: 1.3.4; 1.3.6; 1.3.8; 1.3.10; 1.3.12; 1.3.16;
New dwc2 location - it moved out of staging.

Better instructions

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

Explicitly use -I$S/external/bsd/dwc2/dist for dwc2 instead of possibly
getting that include path via DRM. Fixes evbmips cavium kernel build.

Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

branches: 1.2.2;
Improve USB debugging with USBHIST based on KERNHIST.

Convert some DPRINTFs to USBHIST_LOG and allow usbdebug, ehcidebug and
umassdebug to be changed via sysctl.

Remove the #define mess in usb.h.

This was started by mrg@ and updated by reinoud@

branches: 1.1.4; 1.1.6; 1.1.8; 1.1.10; 1.1.14;
Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

From upstream, fixes issues with isochronous transfers.

branches: 1.13.54;
Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Trailing whitespace

Merge conflicts

kern/50185: dwctwo attach failure

Another hunk went walkabout during the import - reapply with a little
update

Re-apply hunk that got lost in the recent import. CVS is fun!

Merge conflicts

Support external DMA mode and provide an interface for DMA address configuration

branches: 1.6.4; 1.6.6; 1.6.8; 1.6.10; 1.6.12; 1.6.16;
Merge conflicts.

Fix non-USB_DEBUG (and non-DWC2_DEBUG) build

Merge conflicts.

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Merge
https://github.com/torvalds/linux/commit/38d2b5fb75c15923fb89c32134516a623515bce4
to mitigate USB NAK interrupt storms, with an extra change from
skrll@ to also mitigate interrupt storms on the non-split case with
older DWC2 cores.

Fixes woeful USB disk performance on an ERLITE.

Much thanks to skrll@ for pointer to the above patch, handling the
non-split case and testing.

branches: 1.8.10; 1.8.16; 1.8.18;
Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Merge conflicts

Merge conflicts

branches: 1.5.4; 1.5.6; 1.5.8; 1.5.10; 1.5.12; 1.5.16;
Merge conflicts.

Merge conflicts.

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Merge conflicts

Merge conflicts

branches: 1.8.4; 1.8.6; 1.8.8; 1.8.10; 1.8.12; 1.8.16;
Fix non-DWC2_DEBUG build.

Merge conflicts.

Fix non-USB_DEBUG (and non-DWC2_DEBUG) build

Merge conflicts.

Use the hsotg->lock spin lock solely

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Change the usb_mem API to take a bus_dma_tag_t in usb_allocmem instead of
a struct usbd_bus *.

This allows an HCD to use more than one tag.

Tidy up more error handling confusion

branches: 1.24.4;
Switch USB to use non-coherent buffers for data transfers in the
same way as OpenBSD.

The use of coherent (uncacheable on ARM and other arches) mappings
for transfer buffers impacts performance, espcially where memcpys
are involved.

Audit the necessary usb_syncmem operations - a few were missing.

Fix error path, kmem_free doesn't allow NULL pointers.
Fix compilation with CONFIG_USB_DWC2_TRACK_MISSED_SOFS.

Fix fallout from linux/gfp.h -> common.

Merge
https://github.com/torvalds/linux/commit/38d2b5fb75c15923fb89c32134516a623515bce4
to mitigate USB NAK interrupt storms, with an extra change from
skrll@ to also mitigate interrupt storms on the non-split case with
older DWC2 cores.

Fixes woeful USB disk performance on an ERLITE.

Much thanks to skrll@ for pointer to the above patch, handling the
non-split case and testing.

Fix the alignment argument to usb_allocmem in dwc2_hc_setup_align_buf

branches: 1.19.10; 1.19.16; 1.19.18;
Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Merge conflicts

Report an error when return -ENODEV for the unsupported setup.

Merge conflicts

branches: 1.15.2;
Simplify the NAK holdoff change.

Adapt the NAK holdoff scheme for FS/LS devices from the Raspberry Pi
Foundation driver.

Should fix PR/49019 - RPI: interrupt storm when url0 is up

branches: 1.13.2; 1.13.4;
Trailing whitespace.

branches: 1.12.2; 1.12.4; 1.12.6;
Merge conflicts.

Fix non-USB_DEBUG (and non-DWC2_DEBUG) build

Protect access of urb->hcpriv by adapting the following change from the
Raspberry PI dwc_otg driver.

https://github.com/raspberrypi/linux/commit/38753ce72d4f10d5d0f1ed27fa691a2ba8910941

dwc_otg: prevent OOPSes during device disconnects

The dwc_otg_urb_enqueue function is thread-unsafe. In particular the
access of urb->hcpriv, usb_hcd_link_urb_to_ep, dwc_otg_urb->qtd and
friends does not occur within a critical section and so if a device
was unplugged during activity there was a high chance that the
usbcore hub_thread would try to disable the endpoint with partially-
formed entries in the URB queue. This would result in BUG() or null
pointer dereferences.

Fix so that access of urb->hcpriv, enqueuing to the hardware and
adding to usbcore endpoint URB lists is contained within a single
critical section.

Resolve conflicts.

Simplify variable assignment and avoid gcc warnings.

Be strictly correct about chan->xfer_dma assignment and avoid calling
DMAADDR on fully transfered data phase of a control transfer.

Without this change the KASSERT(offset < dma->block->size) in usb_dmaaddr
would fire.

Found by anon when testing athn(4).

Merge conflicts.

Some core configurations cannot support LS traffic on a FS root port.

Fix adapted from the github.com/raspberrypi driver.

Tidyup dwc2_host_is_b_hnp_enabled

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Merge
https://github.com/torvalds/linux/commit/38d2b5fb75c15923fb89c32134516a623515bce4
to mitigate USB NAK interrupt storms, with an extra change from
skrll@ to also mitigate interrupt storms on the non-split case with
older DWC2 cores.

Fixes woeful USB disk performance on an ERLITE.

Much thanks to skrll@ for pointer to the above patch, handling the
non-split case and testing.

branches: 1.14.10; 1.14.16; 1.14.18;
Merge nick-nhusb

- API / infrastructure changes to support memory management changes.
- Memory management improvements and bug fixes.
- HCDs should now be MP safe
- conversion to KERNHIST based debug
- FS/LS isoc support on ehci(4).
- conversion to kmem(9)
- Some USB 3 support - mostly from Takahiro HAYASHI (t-hash).
- interrupt transfers now get proper DMA operations
- general bug fixes
- kern/48308
- uhub status notification improvements
- umass(4) probe fix (applied to HEAD already)
- ohci(4) short transfer fix

Reduce diff to upstream by using

sys/external/bsd/{include/workqueue.h,linux/linux_work.c}

This also fixes CI20 dwctwo start up as reported by macallan@

Merge conflicts

Fix DWC2_READ_4 in dwc2_sample_frrem which is unused

Merge conflicts

branches: 1.9.2;
Adapt the NAK holdoff scheme for FS/LS devices from the Raspberry Pi
Foundation driver.

Should fix PR/49019 - RPI: interrupt storm when url0 is up

branches: 1.8.4; 1.8.6; 1.8.8; 1.8.10;
Merge conflicts.

Make CONFIG_USB_DWC2_DEBUG_PERIODIC compile.

Merge conflicts.

First pass at isoc transfer support - seems to work. More testing
required.

Tidyup dwc2_host_is_b_hnp_enabled

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

From upstream, fixes issues with isochronous transfers.

branches: 1.11.6;
dwc2: KASSERT(A && B) -> KASSERT(A); KASSERT(B)

Change the usb_mem API to take a bus_dma_tag_t in usb_allocmem instead of
a struct usbd_bus *.

This allows an HCD to use more than one tag.

Switch USB to use non-coherent buffers for data transfers in the
same way as OpenBSD.

The use of coherent (uncacheable on ARM and other arches) mappings
for transfer buffers impacts performance, espcially where memcpys
are involved.

Audit the necessary usb_syncmem operations - a few were missing.

branches: 1.8.18;
Trailing whitespace

Merge conflicts

branches: 1.6.4; 1.6.6; 1.6.8; 1.6.10; 1.6.12; 1.6.16;
Merge conflicts.

Remove unused variables.

Merge conflicts.

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

From upstream, fixes issues with isochronous transfers.

branches: 1.15.36;
Fixup previous to not break ping protocol. My bad.

Merge
https://github.com/torvalds/linux/commit/38d2b5fb75c15923fb89c32134516a623515bce4
to mitigate USB NAK interrupt storms, with an extra change from
skrll@ to also mitigate interrupt storms on the non-split case with
older DWC2 cores.

Fixes woeful USB disk performance on an ERLITE.

Much thanks to skrll@ for pointer to the above patch, handling the
non-split case and testing.

branches: 1.13.10; 1.13.16; 1.13.18;
Merge conflicts

Merge conflicts

branches: 1.11.2;
Simplify the NAK holdoff change.

Adapt the NAK holdoff scheme for FS/LS devices from the Raspberry Pi
Foundation driver.

Should fix PR/49019 - RPI: interrupt storm when url0 is up

branches: 1.9.2; 1.9.4;
Recover from channel halt errors by using the 3 strikes xacterr rule.

Adapted from the RaspberryPI linux driver.

This allows the rum(4) I was sent to be somewhat usable. Need to
investigate further what is causing the problem in the first place.

Might help PR/49019 (RPI: interrupt storm when url0 is up)

branches: 1.8.2; 1.8.4; 1.8.6;
Merge conflicts.

Fix non-USB_DEBUG (and non-DWC2_DEBUG) build

Resolve conflicts.

Merge conflicts.

Use the hsotg->lock spin lock solely

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Change the usb_mem API to take a bus_dma_tag_t in usb_allocmem instead of
a struct usbd_bus *.

This allows an HCD to use more than one tag.

Merge
https://github.com/torvalds/linux/commit/38d2b5fb75c15923fb89c32134516a623515bce4
to mitigate USB NAK interrupt storms, with an extra change from
skrll@ to also mitigate interrupt storms on the non-split case with
older DWC2 cores.

Fixes woeful USB disk performance on an ERLITE.

Much thanks to skrll@ for pointer to the above patch, handling the
non-split case and testing.

branches: 1.14.10; 1.14.16; 1.14.18;
Merge conflicts

Fix build.

Merge conflicts

branches: 1.11.2;
Adapt the NAK holdoff scheme for FS/LS devices from the Raspberry Pi
Foundation driver.

Should fix PR/49019 - RPI: interrupt storm when url0 is up

branches: 1.10.2; 1.10.4;
Trailing whitespace.

branches: 1.9.2; 1.9.4; 1.9.6;
Merge conflicts.

Fix non-USB_DEBUG (and non-DWC2_DEBUG) build

Protect access of urb->hcpriv by adapting the following change from the
Raspberry PI dwc_otg driver.

https://github.com/raspberrypi/linux/commit/38753ce72d4f10d5d0f1ed27fa691a2ba8910941

dwc_otg: prevent OOPSes during device disconnects

The dwc_otg_urb_enqueue function is thread-unsafe. In particular the
access of urb->hcpriv, usb_hcd_link_urb_to_ep, dwc_otg_urb->qtd and
friends does not occur within a critical section and so if a device
was unplugged during activity there was a high chance that the
usbcore hub_thread would try to disable the endpoint with partially-
formed entries in the URB queue. This would result in BUG() or null
pointer dereferences.

Fix so that access of urb->hcpriv, enqueuing to the hardware and
adding to usbcore endpoint URB lists is contained within a single
critical section.

Resolve conflicts.

Remove unused variable.

Merge conflicts.

Resolve conflicts

Adapt the Synopsys DWC2 driver to NetBSD.

Still work-in-progress

branches: 1.1.1;
Initial revision

Merge conflicts

Merge conflicts

branches: 1.2.4; 1.2.6; 1.2.8; 1.2.10; 1.2.12; 1.2.16;
Resolve conflicts

branches: 1.1.1;
Initial revision