History log of /src/sys/fs/nfs/client/nfs_clvfsops.c |
Revision | | Date | Author | Comments |
1.3 |
| 03-Sep-2018 |
riastradh | Rename min/max -> uimin/uimax for better honesty.
These functions are defined on unsigned int. The generic name min/max should not silently truncate to 32 bits on 64-bit systems. This is purely a name change -- no functional change intended.
HOWEVER! Some subsystems have
#define min(a, b) ((a) < (b) ? (a) : (b)) #define max(a, b) ((a) > (b) ? (a) : (b))
even though our standard name for that is MIN/MAX. Although these may invite multiple evaluation bugs, these do _not_ cause integer truncation.
To avoid `fixing' these cases, I first changed the name in libkern, and then compile-tested every file where min/max occurred in order to confirm that it failed -- and thus confirm that nothing shadowed min/max -- before changing it.
I have left a handful of bootloaders that are too annoying to compile-test, and some dead code:
cobalt ews4800mips hp300 hppa ia64 luna68k vax acorn32/if_ie.c (not included in any kernels) macppc/if_gm.c (superseded by gem(4))
It should be easy to fix the fallout once identified -- this way of doing things fails safe, and the goal here, after all, is to _avoid_ silent integer truncations, not introduce them.
Maybe one day we can reintroduce min/max as type-generic things that never silently truncate. But we should avoid doing that for a while, so that existing code has a chance to be detected by the compiler for conversion to uimin/uimax without changing the semantics until we can properly audit it all. (Who knows, maybe in some cases integer truncation is actually intended!)
|
1.2 |
| 13-Dec-2016 |
pgoyette | branches: 1.2.14; 1.2.16; Adapt code for our location of the nfs headers, and some updates for differences in kernel options(4) handling
|
1.1 |
| 30-Sep-2013 |
dholland | branches: 1.1.1; Initial revision
|
1.1.1.2 |
| 18-Nov-2016 |
pgoyette | Update to FreeBSD revision 308975 ( approx 2016-11-18 07:30 UTC)
If I'm going to try to get this working, I should at least start with the most recent code available.
|
1.1.1.1 |
| 30-Sep-2013 |
dholland | branches: 1.1.1.1.4; 1.1.1.1.6; 1.1.1.1.10; 1.1.1.1.12; 1.1.1.1.16; Import FreeBSD's "newnfs" nfs client and server code. This contains nfsv4 as well as new implementations of nfsv3 and nfsv2.
This import is from tonight's FreeBSD head and is unchanged from there except for automated munging of rcsids, rearranging of paths, and an autogenerated files.* file that might or might not be syntactically valid. (I will check in the script that does this shortly.)
There is not the slightest chance this will configure yet, let alone compile or run.
|
1.1.1.1.16.1 |
| 07-Jan-2017 |
pgoyette | Sync with HEAD. (Note that most of these changes are simply $NetBSD$ tag issues.)
|
1.1.1.1.12.2 |
| 05-Feb-2017 |
skrll | Sync with HEAD
|
1.1.1.1.12.1 |
| 05-Dec-2016 |
skrll | Sync with HEAD
|
1.1.1.1.10.3 |
| 03-Dec-2017 |
jdolecek | update from HEAD
|
1.1.1.1.10.2 |
| 20-Aug-2014 |
tls | Rebase to HEAD as of a few days ago.
|
1.1.1.1.10.1 |
| 30-Sep-2013 |
tls | file nfs_clvfsops.c was added on branch tls-maxphys on 2014-08-20 00:04:26 +0000
|
1.1.1.1.6.2 |
| 22-May-2014 |
yamt | sync with head.
for a reference, the tree before this commit was tagged as yamt-pagecache-tag8.
this commit was splitted into small chunks to avoid a limitation of cvs. ("Protocol error: too many arguments")
|
1.1.1.1.6.1 |
| 30-Sep-2013 |
yamt | file nfs_clvfsops.c was added on branch yamt-pagecache on 2014-05-22 11:41:00 +0000
|
1.1.1.1.4.2 |
| 18-May-2014 |
rmind | sync with head
|
1.1.1.1.4.1 |
| 30-Sep-2013 |
rmind | file nfs_clvfsops.c was added on branch rmind-smpnet on 2014-05-18 17:46:05 +0000
|
1.2.16.1 |
| 10-Jun-2019 |
christos | Sync with HEAD
|
1.2.14.1 |
| 06-Sep-2018 |
pgoyette | Sync with HEAD
Resolve a couple of conflicts (result of the uimin/uimax changes)
|