Home | History | Annotate | Download | only in rumpvfs
History log of /src/sys/rump/librump/rumpvfs/devnull.c
RevisionDateAuthorComments
 1.8  03-Sep-2018  riastradh Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)
 1.7  26-Jan-2016  pooka branches: 1.7.2; 1.7.8; 1.7.16; 1.7.18;
Put the kernelside rump kernel headers into <rump-sys> instead of
sprinkling them around the faction directories. Avoids having
to add a CPPFLAGS (or several) to pretty much every component
Makefile.

Leave compat headers around in the old locations.

The commit changes some autogenerated files, but I'll fix the
generators shortly and regen.
 1.6  25-Jul-2014  dholland branches: 1.6.4;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.
 1.5  16-Mar-2014  dholland branches: 1.5.2;
Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.
 1.4  04-Apr-2013  pooka branches: 1.4.4;
create null devices
 1.3  10-Feb-2011  pooka branches: 1.3.4; 1.3.14;
support /dev/zero
 1.2  07-Jul-2010  pooka branches: 1.2.2; 1.2.4;
Borrow /dev/mem major from i386 for /dev/null and autogenerate node.
 1.1  17-Dec-2009  pooka branches: 1.1.2; 1.1.4; 1.1.6;
* implement rump_vfs_makeonedevnode(), where the interface for creating
multiple nodes doesn't make sense: e.g. /dev/null would've had to
be created with ("/dev/nul", 'l', 1)
* implement said /dev/null (just for show)
 1.1.6.1  05-Mar-2011  rmind sync with head
 1.1.4.3  11-Aug-2010  yamt sync with head.
 1.1.4.2  11-Mar-2010  yamt sync with head
 1.1.4.1  17-Dec-2009  yamt file devnull.c was added on branch yamt-nfs-mp on 2010-03-11 15:04:39 +0000
 1.1.2.1  17-Aug-2010  uebayasi Sync with HEAD.
 1.2.4.1  17-Feb-2011  bouyer Sync with HEAD
 1.2.2.1  06-Jun-2011  jruoho Sync with HEAD.
 1.3.14.3  03-Dec-2017  jdolecek update from HEAD
 1.3.14.2  20-Aug-2014  tls Rebase to HEAD as of a few days ago.
 1.3.14.1  23-Jun-2013  tls resync from head
 1.3.4.1  22-May-2014  yamt sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs. ("Protocol error: too many arguments")
 1.4.4.1  18-May-2014  rmind sync with head
 1.5.2.1  10-Aug-2014  tls Rebase.
 1.6.4.1  19-Mar-2016  skrll Sync with HEAD
 1.7.18.1  10-Jun-2019  christos Sync with HEAD
 1.7.16.1  06-Sep-2018  pgoyette Sync with HEAD

Resolve a couple of conflicts (result of the uimin/uimax changes)
 1.7.8.2  29-Apr-2017  pgoyette Remove more unnecessary #include for sys/localcount.h
 1.7.8.1  27-Apr-2017  pgoyette Restore all work from the former pgoyette-localcount branch (which is
now abandoned doe to cvs merge botch).

The branch now builds, and installs via anita. There are still some
problems (cgd is non-functional and all atf tests time-out) but they
will get resolved soon.
 1.7.2.3  26-Jul-2016  pgoyette Rename LOCALCOUNT_INITIALIZER to DEVSW_MODULE_INIT. This better describes
what we're doing, and why.
 1.7.2.2  19-Jul-2016  pgoyette Instead of repeatedly typing the conditional initialization of the
.d_localcount members in the various {b,c}devsw, define an initializer
macro and use it. This also removes the need for defining new symbols
for each 'struct localcount'.

As suggested by riastradh@
 1.7.2.1  18-Jul-2016  pgoyette Rump drivers are always installed via devsw_attach() so we need to
always allocate a 'struct localcount' for these drivers whenever they
are built as modules.

RSS XML Feed