Get rid of static Atffiles and let bsd.test.mk generate them on the fly.

branches: 1.5.2;
Re-add the NetBSD CVS Id tag to the header. It just had to be quoted to
be accepted by the parser; i.e. no bug in the code :-)

Note to self: do not try to "fix" stuff the last minute before going to
sleep.

Use proper specification for a glob pattern.

Back out the change to introduce the X-NetBSD-Id header entry. For some
reason the parser does not accept its contents... You know, one should
always test even trivial changes!

Will review this in more depth tomorrow to find the real root cause of the
problem and rule out a fix for ATF.

Add the NetBSD Id tag to the Atffiles. Issue raised by pooka@ a while ago.

Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

PR/55102: Kamil Rytarowski: Duplicate fifo_vnodeop_entries,
fifo_vnodeop_opv_desc symbols.

Many filesystems ffs, lfs, ulfs, chfs, ext2fs etc. use fifofs
internally for their fifo vnops. NFS does too, but it also needs
networking anyway. Unfortunately fifofs brings in a lot of the
networking code so that the rumpkernel is not well partition. In
addition the fifo code is rarely used.

The existing hack depended on duplicating the above symbols and
adding minimal functionality for the majority of the the tests
(except the ffs and the puffs one). In these two cases both symbols
were loaded and the symbol sizes clashed which broke the sanitizers.
While this can be fixed with weak symbols and other kinds of
indirection, it is more straight forward to select between the
minimal and the full fifofs implementation by introducing a new
shared library librumpvfs_nofifofs.

Centralize the base rump libraries into a variable used by all the other
Makefiles so that we can make changes to it centrally as needed and have
less mess. Fixes the sun2 build that needs rumpvfs after librump after
the latest changes.

branches: 1.14.24;
Fix static linking for the tests: -lrump is also used by -lrumpuser,
so we also need -lrump after -lrumpuser. Fixes build for sun2.

branches: 1.13.12; 1.13.22;
Remove accidentally committed part (which I need to run these tests
for a -current rump kernel on NetBSD 5.1)

Add test case for problem described by yamt in PR kern/44086.
"large writes with PUFFS_KFLAG_NOCACHE_PAGE ends up with EIO"

Fuzztest puffs mount. There are n different levels of testing:
each one pours more and more sane garbage into the args to that
the mount progresses further and further. Level 8 (at least when
writing this comment) should be the one where mounting actually
succeeds.

Our metric of success is crash / no crash.

Fold the puffs private and vfs tests mount/unmount routines together.
To achieve this, add a file system private parameter to the newfs
method (which will obviously not be used by vfs tests).

njoly ok

Get rid of static Atffiles and let bsd.test.mk generate them on the fly.

put stuff requiring -lpuffs behind -DPUFFSDUMP

WARNS=2

Add some basic tests for inactive/reclaim. To make this possible,
adjust the read/write shovel threads so, that we can tap into the
operations between puffs(9) and the file server.

Add test cases for file servers which present the root node not as
a directory but as a regular file, symbolic link (although that
can't be unmounted without killing the server!), fifo or character
device.

Add the most basic test for puffs(dtfs): mount/unmount. There's
still a lot of work to do here, but I want to get to testbuilding
the tree ;)

TODO examples:
* integrate this with rump_syspuffs (and remove the stupid ``sys'' from there)
* integrate with njoly's fs-independent tests
* cleanup a lot
* write more tests

*sigh*, I wish we'd had testing tools like this 5 years ago when
I was writing puffs. It would have made a lot of things a lot
better and a lot easier.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

branches: 1.2.2;
Install the data files.

Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

Remove clause 3 and 4 from TNF licenses

branches: 1.1.2; 1.1.6;
Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

branches: 1.1.2;
Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

branches: 1.1.2;
Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

branches: 1.1.2;
Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

branches: 1.3.2;
Copy the host key into the work directory and tell the server to use this
instead of the source file, because we need to set strict permissions on it.
Otherwise sshd refuses to start.

Note that we cannot set the permissions of the installed ssh_config_key file
to 400 because unprivileged users could then be unable to run the tests.

Properly capture the output of the SSH server. Its -e flag is supposed to
be used alongside -D, but as this was not documented I thought it was a bug
and "fixed" -e's behavior locally (so I got the correct output before, but
nobody else).

Also, fix a race condition that could cause the SSH server to not be killed
if the pid file was not written before the kill, which might happen on very
fast machines. There still may be a problem when trying to do the connection
if the server has not yet finished initialization...

Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Don't play with "../.." in includes for h_macros.h; deal with it centrally.
Minor fixes.

- Change vcache_reclaim() to always call VOP_INACTIVE() before VOP_RECLAIM().
When called from vrecycle() or vgone() there is a window where the refcount
is greater than zero and another thread could get and release a reference
that would miss VOP_INACTIVE() as the refcount doesn't drop to zero.

Adjust test fs/puffs/t_basic: test VOP_INACTIVE count being greater zero.

- Make vrecycle() more robust by checking v_usecount first and preventing
further references across vn_lock(). Fixes a deadlock where one thread
starts unmount, second thread locks a directory and allocates a vnode
and first thread tries to vrecycle() the directory.
First thread holds vfs_busy and wants vnode, second thread holds vnode
and wants vfs_busy.

- With these fixes in place change cleanvnode() to use vget()/vrecycle()
to reclaim the vnode.

branches: 1.12.8;
fix unused variable warnings

branches: 1.11.4; 1.11.10;
reinstate #ifdef PUFFSDUMP around otherwise unused function
which requires symbols from -lpuffs, not linked

update /dev/null rump minor to make test pass again

branches: 1.9.2;
Add test case for PR kern/44093 (fixed already, but tested to fail
without fix applied).

Now that atf issue #53 has been fixed, remove the
child-must-dies-before-parent kludge.

Fold the puffs private and vfs tests mount/unmount routines together.
To achieve this, add a file system private parameter to the newfs
method (which will obviously not be used by vfs tests).

njoly ok

put stuff requiring -lpuffs behind -DPUFFSDUMP

WARNS=2

Add some basic tests for inactive/reclaim. To make this possible,
adjust the read/write shovel threads so, that we can tap into the
operations between puffs(9) and the file server.

Add test cases for file servers which present the root node not as
a directory but as a regular file, symbolic link (although that
can't be unmounted without killing the server!), fifo or character
device.

Call rump_init() only after we have fork&exec'd the file server.
Otherwise the test would on rare occasions hang (I guess this was
due to calling sprintf/close between fork&exec in a threaded
program?).

Add the most basic test for puffs(dtfs): mount/unmount. There's
still a lot of work to do here, but I want to get to testbuilding
the tree ;)

TODO examples:
* integrate this with rump_syspuffs (and remove the stupid ``sys'' from there)
* integrate with njoly's fs-independent tests
* cleanup a lot
* write more tests

*sigh*, I wish we'd had testing tools like this 5 years ago when
I was writing puffs. It would have made a lot of things a lot
better and a lot easier.

fix typos in word "successful".

Don't play with "../.." in includes for h_macros.h; deal with it centrally.
Minor fixes.

branches: 1.5.14;
Do not set PUFFS_KFLAG_CACHE_FS_TTL for PUFFS tests

branches: 1.4.6; 1.4.8;
poll the putter fd instead of doing a blocking read. Long story
short: we don't have to wait for the fs syncer to run for the
close to succeed.

Make random garbage more widely available.

the old thread which does not return not returning a value
undetectable to all but the sh3 compiler trick

Fuzztest puffs mount. There are n different levels of testing:
each one pours more and more sane garbage into the args to that
the mount progresses further and further. Level 8 (at least when
writing this comment) should be the one where mounting actually
succeeds.

Our metric of success is crash / no crash.

Don't play with "../.." in includes for h_macros.h; deal with it centrally.
Minor fixes.

branches: 1.1.28;
Add test case for problem described by yamt in PR kern/44086.
"large writes with PUFFS_KFLAG_NOCACHE_PAGE ends up with EIO"

Move tests psshfs from fs/puffs to fs/psshfs. The former is going
to be populated by tests which actually test puffs soon.

jmmv ok

Properly mark some test cases as having a cleanup routine. Stupidity of
the API? Most likely; will revise it.

Fixes atf-run breaking when running t_psshfs. This does not resolve the
underlying issue though, which is atf-run getting confused trying to
unmount the temporary mount point by itself (I think). (I'm now wondering
if atf should be bothering about unmounting stuff at all. Maybe not. It is
a tricky and uncommon thing.)

atf-0.9 introduces an use.fs test-case property to allow tests to write to
their work directory. The purpose is to be able to know which tests intend
to touch the file system and to allow a minor optimization in atf-run.

Define use.fs=true for all those tests requiring it. (This highlights that
some tests currently require modifying the file system but conceptually
they shouldn't be... which leaves room for further improvements/cleanups
later :-)

Adjust tests to work with the new API in ATF 0.6.

Convert TNF licenses to new 2 clause variant

branches: 1.3.2; 1.3.6;
Copy the host key into the work directory and tell the server to use this
instead of the source file, because we need to set strict permissions on it.
Otherwise sshd refuses to start.

Note that we cannot set the permissions of the installed ssh_config_key file
to 400 because unprivileged users could then be unable to run the tests.

Properly capture the output of the SSH server. Its -e flag is supposed to
be used alongside -D, but as this was not documented I thought it was a bug
and "fixed" -e's behavior locally (so I got the correct output before, but
nobody else).

Also, fix a race condition that could cause the SSH server to not be killed
if the pid file was not written before the kill, which might happen on very
fast machines. There still may be a problem when trying to do the connection
if the server has not yet finished initialization...

Beleatedly add some regression tests for a couple of problems I found in
psshfs and that pooka@ already fixed a while ago. These were rather tricky
to get working.

Define _KERNTYPES for things that need it.

Get rid of static Atffiles and let bsd.test.mk generate them on the fly.

* need TESTSDIR
* remove force-fed -g

NO ATFFILE HERE

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).

support pathconf (more or less copypasted from ufs). for njoly's tests.

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).

prevent rename of source directory under itself

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).

fix typos in word "successful".

fix unused variable warnings

branches: 1.3.4; 1.3.10;
Reset node's parent pointer when it's removed. Technically the
parent still exists, but allows us to avoid complicated g/c algorithms
if the parent *is* removed.

branches: 1.2.2;
prevent rename of source directory under itself

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).

fix various typos in comments, messages and documentation.

Restore binary compatibility by using the statvfs90 structure internally.

branches: 1.3.30;
add missing includes

branches: 1.2.6; 1.2.12;
return correct errno

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).

fix unused variable warnings

branches: 1.9.6;
Check directory write access for DELETE operation. And while here,
small indentation adjust.

branches: 1.8.4;
Reset node's parent pointer when it's removed. Technically the
parent still exists, but allows us to avoid complicated g/c algorithms
if the parent *is* removed.

branches: 1.7.2;
support pathconf (more or less copypasted from ufs). for njoly's tests.

Check that nobody raced us into the source dir while it was unlocked
in preparation for rename.

Return correct error values from a bunch of questionable renames.

There's no substitute for single-stepping do_sys_rename() into ffs
when trying to figure out what error should come from what layer...
well, at least apart from TNT.

* remove target node from right directory
* remove what i guess to be a useless if-clause (although with
file systems you can never be sure)

check we don't rename onto a non-empty directory

prevent rename of source directory under itself

Move the Delectable Test File System from share/examples/puffs/dtfs
to tests/fs/puffs/h_dtfs.

No functional change (apart from adjusting the Makefile for test builds).