Remove "-g" from CPPFLAGS and LDFLAGS in curses tests.

The debug information contains embedded references to the src directory,
which is bad for reproducible builds.

branches: 1.6.2; 1.6.6; 1.6.8;
It's ATFFILE=no, not NOATFFILE=true. This fixes the contents of the
installed Atffile, and allows the tests to actually run.

document non-literal format strings

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
Default to -Wno-sign-compare -Wno-pointer-sign for clang.
Push -Wno-array-bounds down to the cases that depend on it.
Selectively disable warnings for 3rd party software or non-trivial
issues to be reviewed later to get clang -Werror to build most of the
tree.

Explicitly list -lterminfo after -lcurses, to support static builds.

Add atf for libcurses with some tests

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: remove wrong comments

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

Incorrect licence was applied - fix this.

Add atf for libcurses with some tests

tests/libcurses: fix typo in comment

tests/libcurses: clean up comments

Cosmetic fixes. No functional changes intended.
- Reorganize logic to reduce indent levels significantly.
- Use ``for'' rather than ``while''.

tests/libcurses: add parentheses around argument to sizeof

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: protect against short writes

The previous code only errored out if a write failed completely. If it
was partially written, the program continued without writing the rest of
it.

Extract the common code into a few functions that write raw data to the
parent process.

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in child process

The child process only ever needs 2 ends of the pipes: one for reading
the commands, one for writing back the results.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: replace remaining strcasecmp with strcmp

There is no reason to write special functions in a different case than
the canonical one, just like for the regular curses functions.

tests/libcurses: compare function names case-sensitive

There is absolutely no reason to write function names in upper case or
mixed case.

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

branches: 1.4.42;
- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

Turn warns on for all tests and fix all the bugs.

branches: 1.2.2;
add missing header files.

Add atf for libcurses with some tests

tests/libcurses: fix grammar in comment (since yesterday)

tests/libcurses: clean up comments

tests/libcurses: fix argument handling for mvwget_wch

There's currently no test for that function, therefore no functional
change.

tests/libcurses: unexport argument handling functions

No functional change.

tests/libcurses: KNF for while loop

tests/libcurses: remove redundant argument numbers

Since all arguments are processed in increasing order, there is no need
to add the redundant argument numbers. Most of the curses functions
have less than 5 arguments, which makes it easy enough to count the ARG
macros.

Changes to curses_commands.c:

* replace ^(\tARG_\w+\()\d(?:, |) with $1
* replace (define ARG_\w+\()i,\s with $1
* replace args\[i\] with *args++
* replace \(i\) with ()
* replace \(void\)0 with args++

The wrong argument count in cmd_mvwget_wch is still detected by
lint.lua, as it was before. There is no test yet that covers this
function.

Reapply fix for big-endian environments, which was lost when GSoC results
were merged...

http://www.nerv.org/netbsd/?q=id:20200620T075016Z.3584036ccf31f69ee76ea4a02e9be30ff081df21

> Fix false positive for mvscanw tests on big endian machines.
>
> When conversion specifier is not a derivative form of "%s", retrieve
> input as 32bit integer, and then convert to string literal. Then we
> can avoid interpretation from ASCII code to integer, which is
> apparently byte-order depended.

When mvscanw(3) fails, string is not modified.
Let's ignore the 2nd result for this case.

s/&string/string/ for mvscanw(3); string is already pointer to buffer.

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: remove excess empty lines

tests/libcurses: query function arguments in consistent order

tests/libcurses: don't access args directly

By providing declarative syntax for accessing the arguments, the
unnecessarily detailed boilerplate code is hidden. This allows easy
inspection by tools and humans, to check for typos and other mistakes.

tests/libcurses: replace ARG_CHTYPE_STRING with ARG_CHTYPE

All uses of the previous macro did not treat the argument as a string or
array of chtype, but as a single chtype. It's strange that the previous
code arbitrarily split the access to the argument by first storing it as
a pointer and then dereferencing it.

No functional change.

tests/libcurses: add shortcut macros for SCREEN and unsigned int

tests/libcurses: remove redundant comments

There is nothing surprising about call2, call3 or call4.

tests/libcurses: reduce boilerplate in function dispatcher

No functional change. The generated code for GCC 9.3 on NetBSD 9.99.80
x86_64 is exactly the same as before.

tests/libcurses: reduce boilerplate in function dispatcher

This makes the code more declarative and easier to reason about.

The generated code stays exactly the same.

tests/libcurses: fix scanf parameter for unsigned int

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

Fix false positive for mvscanw tests on big endian machines.

When conversion specifier is not a derivative form of "%s", retrieve
input as 32bit integer, and then convert to string literal. Then we
can avoid interpretation from ASCII code to integer, which is
apparently byte-order depended.

Start supporting wide char tests.

Fix argument parsing for mvinsch, last arg is a chtype not a string.

branches: 1.7.30;
* Fix mvscanw return
* Fix the *vline family of calls, one argument is chtype not int

branches: 1.6.2; 1.6.8;
- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

fix bug where we read the same argument twice. Name the timeout val the
same 'tval' in both timeout routines.

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
Apply patch provided by mrg to fix bad calls to vw_printw and vw_scanw

Fix obvious bug.
(note: this file still doesn't build on amd64)

Add atf for libcurses with some tests

tests/libcurses: clean up comments

tests/libcurses: unexport argument handling functions

No functional change.

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: remove wrong comments

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

Incorrect licence was applied - fix this.

Add atf for libcurses with some tests

tests/libcurses: make error handling in the linter simpler

tests/libcurses: improve code locality in linter

No functional change.

tests/libcurses: improve local variable names in linter

tests/libcurses: remove redundant argument numbers

Since all arguments are processed in increasing order, there is no need
to add the redundant argument numbers. Most of the curses functions
have less than 5 arguments, which makes it easy enough to count the ARG
macros.

Changes to curses_commands.c:

* replace ^(\tARG_\w+\()\d(?:, |) with $1
* replace (define ARG_\w+\()i,\s with $1
* replace args\[i\] with *args++
* replace \(i\) with ()
* replace \(void\)0 with args++

The wrong argument count in cmd_mvwget_wch is still detected by
lint.lua, as it was before. There is no test yet that covers this
function.

tests/libcurses: remove unused code in linter

tests/libcurses: query function arguments in consistent order

tests/libcurses: add parentheses around argument to sizeof

tests/libcurses: extract read_command_argument from process_commands

Having code indented so far to the right that each word gets its own
line is ridiculous. Fix that.

While here, remove the cargo-cult realloc pattern, which is not needed
if the process exits immediately on error.

While here, reduce the indentation of the code by returning early.

No functional change.

tests/libcurses: fix reading from the parent process

In case of a short read, processing the incomplete data invoked
undefined behavior.

tests/libcurses: fix child process handling

The child process needs to be properly controlled by the parent process.
Otherwise it is not possible to get code coverage data from it using
gcov since that requires the child process to exit normally. Previously
the child process had been killed because its parent had exited.

tests/libcurses: clean up remaining include guard, comments

No functional change.

tests/libcurses: fix pipe handling in child process

The child process only ever needs 2 ends of the pipes: one for reading
the commands, one for writing back the results.

tests/libcurses: format misleading do-while loop

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

branches: 1.6.42;
- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
add missing header files.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: clean up remaining include guard, comments

No functional change.

tests/libcurses: fix pipe handling in child process

The child process only ever needs 2 ends of the pipes: one for reading
the commands, one for writing back the results.

tests/libcurses: fix typo in license text

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it

Turn warns on for all tests and fix all the bugs.

branches: 1.1.2;
Add atf for libcurses with some tests