Home | History | Annotate | Download | only in slave
History log of /src/tests/lib/libcurses/slave/curses_commands.c
RevisionDateAuthorComments
 1.31  07-Dec-2021  rillig tests/libcurses: fix grammar in comment (since yesterday)
 1.30  06-Dec-2021  rillig tests/libcurses: clean up comments
 1.29  13-Jun-2021  rillig tests/libcurses: fix argument handling for mvwget_wch

There's currently no test for that function, therefore no functional
change.
 1.28  13-Jun-2021  rillig tests/libcurses: unexport argument handling functions

No functional change.
 1.27  13-Jun-2021  rillig tests/libcurses: KNF for while loop
 1.26  13-Jun-2021  rillig tests/libcurses: remove redundant argument numbers

Since all arguments are processed in increasing order, there is no need
to add the redundant argument numbers. Most of the curses functions
have less than 5 arguments, which makes it easy enough to count the ARG
macros.

Changes to curses_commands.c:

* replace ^(\tARG_\w+\()\d(?:, |) with $1
* replace (define ARG_\w+\()i,\s with $1
* replace args\[i\] with *args++
* replace \(i\) with ()
* replace \(void\)0 with args++

The wrong argument count in cmd_mvwget_wch is still detected by
lint.lua, as it was before. There is no test yet that covers this
function.
 1.25  04-Apr-2021  rin Reapply fix for big-endian environments, which was lost when GSoC results
were merged...

http://www.nerv.org/netbsd/?q=id:20200620T075016Z.3584036ccf31f69ee76ea4a02e9be30ff081df21

> Fix false positive for mvscanw tests on big endian machines.
>
> When conversion specifier is not a derivative form of "%s", retrieve
> input as 32bit integer, and then convert to string literal. Then we
> can avoid interpretation from ASCII code to integer, which is
> apparently byte-order depended.
 1.24  04-Apr-2021  rin When mvscanw(3) fails, string is not modified.
Let's ignore the 2nd result for this case.
 1.23  04-Apr-2021  rin s/&string/string/ for mvscanw(3); string is already pointer to buffer.
 1.22  13-Feb-2021  rillig tests/libcurses: clean up inclusion guards, function declarations

No functional change.
 1.21  12-Feb-2021  rillig tests/libcurses: remove excess empty lines
 1.20  12-Feb-2021  rillig tests/libcurses: query function arguments in consistent order
 1.19  12-Feb-2021  rillig tests/libcurses: don't access args directly

By providing declarative syntax for accessing the arguments, the
unnecessarily detailed boilerplate code is hidden. This allows easy
inspection by tools and humans, to check for typos and other mistakes.
 1.18  12-Feb-2021  rillig tests/libcurses: replace ARG_CHTYPE_STRING with ARG_CHTYPE

All uses of the previous macro did not treat the argument as a string or
array of chtype, but as a single chtype. It's strange that the previous
code arbitrarily split the access to the argument by first storing it as
a pointer and then dereferencing it.

No functional change.
 1.17  12-Feb-2021  rillig tests/libcurses: add shortcut macros for SCREEN and unsigned int
 1.16  12-Feb-2021  rillig tests/libcurses: remove redundant comments

There is nothing surprising about call2, call3 or call4.
 1.15  12-Feb-2021  rillig tests/libcurses: reduce boilerplate in function dispatcher

No functional change. The generated code for GCC 9.3 on NetBSD 9.99.80
x86_64 is exactly the same as before.
 1.14  12-Feb-2021  rillig tests/libcurses: reduce boilerplate in function dispatcher

This makes the code more declarative and easier to reason about.

The generated code stays exactly the same.
 1.13  09-Feb-2021  rillig tests/libcurses: fix scanf parameter for unsigned int
 1.12  08-Feb-2021  rillig tests/libcurses: fix typo in license text
 1.11  24-Oct-2020  blymn Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.
 1.10  20-Jun-2020  rin Fix false positive for mvscanw tests on big endian machines.

When conversion specifier is not a derivative form of "%s", retrieve
input as 32bit integer, and then convert to string literal. Then we
can avoid interpretation from ASCII code to integer, which is
apparently byte-order depended.
 1.9  26-May-2019  blymn Start supporting wide char tests.
 1.8  26-Apr-2019  blymn Fix argument parsing for mvinsch, last arg is a chtype not a string.
 1.7  19-Sep-2012  blymn branches: 1.7.30;
* Fix mvscanw return
* Fix the *vline family of calls, one argument is chtype not int
 1.6  15-Sep-2011  blymn branches: 1.6.2; 1.6.8;
- add support for getparyx and getyx calls
- allow a NULL pointer to be returned to the director
- add support for passing back a single chtype character
- fix some indentation
- fix a lot of curses command calls that were just plain wrong
- don't try to allocate storage for a NULL parameter, it doesn't need it
 1.5  29-Aug-2011  christos fix bug where we read the same argument twice. Name the timeout val the
same 'tval' in both timeout routines.
 1.4  11-Jun-2011  christos Turn warns on for all tests and fix all the bugs.
 1.3  11-Apr-2011  blymn branches: 1.3.2;
Apply patch provided by mrg to fix bad calls to vw_printw and vw_scanw
 1.2  10-Apr-2011  dholland Fix obvious bug.
(note: this file still doesn't build on amd64)
 1.1  10-Apr-2011  blymn Add atf for libcurses with some tests
 1.3.2.1  23-Jun-2011  cherry Catchup with rmind-uvmplock merge.
 1.6.8.1  20-Nov-2012  tls Resync to 2012-11-19 00:00:00 UTC
 1.6.2.1  30-Oct-2012  yamt sync with head
 1.7.30.1  10-Jun-2019  christos Sync with HEAD

RSS XML Feed