Reduce duplicate codes

Introduce net_common.sh that is to share common functions used in tests
for networking. This commit commonizes extract_new_packets. Other duplicate
codes will be moved to the file in further commits.

branches: 1.3.2;
Fix TESTS_SH assignment

Add tests for IPv4 DAD

Add tests for ARP

tests: add tests for ARP address resolution

branches: 1.48.2;
tests: add tests for ARP cache entry creations

tests: dedup t_arp.sh like others (NFC)

tests, arp: add tests for GARP on link up

branches: 1.45.6; 1.45.8;
arp tests: Delete ARP entry after failed ping test

As it might hang around in WAITDELETE for a few seconds.

arp_rtm: Only ping once

Pointless doing 10 pings.
On a slow system, it's possible that many RTM_MISS messages could
overflow into the next test.

Don't check lifetime when testing published

arp test: Use the ndp cache expiration test in place of the old one

As the logic is the same.
While here, GC some variables and comment out a redundant sleep.

tests: check RTA_AUTHOR in messages

t_arp: Wait for 10 seconds for RTM_MISS

Let's try increasing the ping timeout to try and fix PR misc/54525.

tests: fix ARP and NDP tests for RTM_* messages

While here add tests for RTM_MISS.

tests: use rump_server_add_iface to create interfaces

branches: 1.37.2;
Get rid of all the -lrumpdev and -lrumpvfs that are no longer needed
after moving rump's mainbus from rumpdev to rumpkern.

Produces the same atf-run results as before.

branches: 1.36.2;
Add tests for GARP without DAD

Additionally make the existing tests for GARP more explicit.

Improve packet checks and error reporting

branches: 1.34.2;
Clean up the arp_rtm subtest...

1. Be assertive when claiming the pid of the background route monitor command,
not polite... (ie: $! will give you the pid, $? is just 0 there).
2. Since "wait 0" simply (always) exits with status 127, immediately (we
know without thinking that we have no child with pid 0) the waits were
ineffective - now (after fix #1) they work .. which requires the
route monitor that watches the arp -d to exit after 1 message, not 2,
as 1 is all it gets. (If there really should be 2, someone needs to
find out why the kernel is sending only 1 - I am not that someone).
3. The file contents need to be read only once, no matter how many patterns
we need to look for, save some work, and do it that way (this is not
really a bug,m but saving time for the ATF tests is always a good thing.)

Not sure if this will stop it randomly failing on bablyon5, but it might.
(The likely cause is that the "route.monitor" has not flushed its stdout
buffers at the time the "grep -A 3" [aside: why that way to read the file??]
is performed, so fails to find its expected output ... the route monitor would
get an extra message once interfaces start being destroyed, I assume, and
would exit then, flushing its buffer, but by then it is too late.
If that is/was the cause, then it should be fixed now.)

Enable to remove multiple ARP/NDP entries for one destination

The kernel can have multiple ARP/NDP entries which have an indentical
destination on different interfaces. This is normal and can be
reproduce easily by ping -I or ping6 -S. We should be able to remove
such entries.

arp -d <ip> and ndp -d <ip> are changed to fetch all ARP/NDP entries
and remove matched entries. So we can remove multiple entries
described above. This fetch all and selective removal behavior is
the same as arp <ip> and ndp <ip>; they also do fetch all entries
and show only matched entries.

Related to PR 51179

Restore ARP/NDP entries to route show and netstat -r

Requested by dyoung@ some time ago

Drop RTF_LLINFO flag (now it's RTF_LLDATA) from local routes

They don't have llinfo anymore. And also the change fixes unexpected
behavior of ARP proxy.

Drop RTF_UP from a routing message of a deleted ARP/NDP entry

Improve backward compatibility of (fake) routing messages on adding an ARP/NDP entry

A message originally included only DST and GATEWAY. Restore it.

Fix usage of routing messages on arp -d and ndp -d

It didn't work as we expected; we should set RTA_GATEWAY not
RTA_IFP on RTM_GET to return an if_index and the kernel should
use it on RTM_DELETE.

Test implicit removals of ARP/NDP entries

One test case reproudces PR 51179.

Don't create a permanent L2 cache entry on adding an address to an interface

It was created to copy FreeBSD, however actually the cache isn't
necessary. Remove it to simplify the code and reduce the cost to
maintain it (e.g., keep a consistency with a corresponding local
route).

Set net.inet.arp.keep only if it's required

Add missing declarations for cleanup

Test routing messages emitted on operations of ARP/NDP entries

branches: 1.22.6;
Share rump_server start/stop and interface creation/destruction functions

The common functions store socks of rump_servers, interfaces of rump_servers
and buses that intefaces connect and allow to destroy them with common
functions without specifying which socks, interfaces and buses we should
destroy.

This change reduces lots of similar setup/cleanup codes.

Move get_macaddr to net_common.sh

Move HIJACKING definition to net_common.sh

Reduce duplicate codes

Introduce net_common.sh that is to share common functions used in tests
for networking. This commit commonizes extract_new_packets. Other duplicate
codes will be moved to the file in further commits.

Accept DEBUG environment variable

By doing so, we can easily turn DEBUG on/off without modifying
the ATF scripts.

no functional change

branches: 1.16.2;
Make a bunch of test names self-descriptive

Add a test case for static ARP

It tests receiving an ARP request that has a spa (i.e., IP address) whose
ARP entry already exists in the table as a static ARP entry.

Separate nexthop caches from the routing table

By this change, nexthop caches (IP-MAC address pair) are not stored
in the routing table anymore. Instead nexthop caches are stored in
each network interface; we already have lltable/llentry data structure
for this purpose. This change also obsoletes the concept of cloning/cloned
routes. Cloned routes no longer exist while cloning routes still exist
with renamed to connected routes.

Noticeable changes are:
- Nexthop caches aren't listed in route show/netstat -r
- sysctl(NET_RT_DUMP) doesn't return them
- If RTF_LLDATA is specified, it returns nexthop caches
- Several definitions of routing flags and messages are removed
- RTF_CLONING, RTF_XRESOLVE, RTF_LLINFO, RTF_CLONED and RTM_RESOLVE
- RTF_CONNECTED is added
- It has the same value of RTF_CLONING for backward compatibility
- route's -xresolve, -[no]cloned and -llinfo options are removed
- -[no]cloning remains because it seems there are users
- -[no]connected is introduced and recommended
to be used instead of -[no]cloning
- route show/netstat -r drops some flags
- 'L' and 'c' are not seen anymore
- 'C' now indicates a connected route
- Gateway value of a route of an interface address is now not
a L2 address but "link#N" like a connected (cloning) route
- Proxy ARP: "arp -s ... pub" doesn't create a route

You can know details of behavior changes by seeing diffs under tests/.

Proposed on tech-net and tech-kern:
http://mail-index.netbsd.org/tech-net/2016/03/11/msg005701.html

Improve tests of proxy arp

The tests make it clear how it behaves though, I don't know if the current
behavior is what it should be.

Add tests on activating a new MAC address

Add basic tests for Proxy ARP

The tests don't much enough and need more realitic tests, for example
tests for a setup using ppp found in PR 44032.

Make checks strict

rump.arp should fail with File exists (EEXIST).

Reflect the current ARP cache implementation in tests

net.inet.arp.prune and net.inet.arp.refresh were obsoleted.

Reflect a fix on rt_refcnt

The test was adjusted based on wrong behavior.

Check MAC address of ARP caches additionally

Return 0 explicitly to avoid unexpected failures when $DEBUG=false

Add tests of cache overwriting

Add tests for temp option

Add tests for arp -a option

Add tests for GARP

Add tests for ARP

tests, arp: add tests of address duplications without DAD

branches: 1.15.14; 1.15.22; 1.15.24;
Improve test stability and output messages on failure

Improve test stability and output messages on failure

branches: 1.13.2;
Share rump_server start/stop and interface creation/destruction functions

The common functions store socks of rump_servers, interfaces of rump_servers
and buses that intefaces connect and allow to destroy them with common
functions without specifying which socks, interfaces and buses we should
destroy.

This change reduces lots of similar setup/cleanup codes.

Add missing bus argument for extract_new_packets

Move HIJACKING definition to net_common.sh

Reduce duplicate codes

Introduce net_common.sh that is to share common functions used in tests
for networking. This commit commonizes extract_new_packets. Other duplicate
codes will be moved to the file in further commits.

Accept DEBUG environment variable

By doing so, we can easily turn DEBUG on/off without modifying
the ATF scripts.

adjust for new ifconfig output.

+ -lrumpdev

branches: 1.6.2;
Give a chance to send a DAD announce packet

ifconfig -w ensures IP addresses have left tentative state, however,
it doesn't guarantee that a DAD announce packet is sent. The kernel
clears tentative flag and then sends the packet so that ifconfig -w
can return before the kernel sends the packet.

Disable another tentative state check

It's too ephemeral to check robustly.

Improve test stability

- Take a diff between packet dumps and use it for packet checking
- it's resistant against packet reorder
- Seep 2 sec to make sure a NS message is sent
- Disable tentative state check for now
- it's too ephemeral to check robustly

Remove remaining debug code

Fix cleanup; halt all running rump_servers

Add tests for IPv4 DAD