History log of /src/tests/usr.bin/xlint/lint1/msg_115.c |
Revision | | Date | Author | Comments |
1.11 |
| 28-Mar-2023 |
rillig | lint: warn about extern declarations outside headers
https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html
|
1.10 |
| 16-Jun-2022 |
rillig | tests/lint: make expectation lines in the tests more detailed
This commit migrates msg_100 until msg_199.
|
1.9 |
| 16-Aug-2021 |
rillig | tests/lint: document history of initialization of const members
|
1.8 |
| 14-Aug-2021 |
rillig | lint: allow initialization of struct with constant member
The operator INIT, just like RETURN and FARG, initializes an object with an expression. The target object of such an initialization may be a struct with constant members.
The operator ASSIGN, on the other hand, is entirely different. It overwrites the existing value of the object, and this is not allowed for structs that have a constant member. Therefore it was wrong to use the operator ASSIGN for initialization.
|
1.7 |
| 10-Aug-2021 |
rillig | lint: fix 3 of the 4 wrong messages about lvalue in initial assignment
|
1.6 |
| 31-Jul-2021 |
rillig | tests/lint: demonstrate more wrong warnings for const struct members
The code 't_const = false' occurs 4 times in the lint code, each corresponding to one of the wrong warnings in the test.
This bug has been existing at least since 2001. Back then, the lint output was:
2001.12.24.20.52.09 | (23): lint error: popctrl() 1 | (15): syntax error [249] | (19): warning: left operand of 'FARG' must be modifiable lvalue [115] | (21): syntax error [249] | (23): warning: function initialize_const_struct_member falls off bottom without returning value [217] | exit status 1
from 2002.12.06.03.27.39 | (23): lint error: func.c, 168: popctrl() | (15): warning: left operand of '=' must be modifiable lvalue [115] | (19): warning: left operand of 'FARG' must be modifiable lvalue [115] | (21): syntax error [249] | (23): warning: function initialize_const_struct_member falls off bottom without returning value [217] | exit status 1 until 2003.10.27.00.12.44
|
1.5 |
| 31-Jul-2021 |
rillig | tests/lint: demonstrate wrong error message for initialization
Seen in usr.bin/make/var.c:4022 in C99 mode, where a ModChain variable is initialized and two of the members are const-qualified.
|
1.4 |
| 31-Jan-2021 |
rillig | lint: add expections to tests
msg_098: fix suffix for floating point constant msg_127: remove prototype msg_146: fix return type
|
1.3 |
| 17-Jan-2021 |
rillig | lint: add test for incrementing const variable
|
1.2 |
| 08-Jan-2021 |
rillig | lint: add tests for several messages
|
1.1 |
| 02-Jan-2021 |
rillig | lint: add a test for each message produced by lint1
Having a test for each message ensures that upcoming refactorings don't break the basic functionality. Adding the tests will also discover previously unknown bugs in lint.
The tests ensure that every lint message can actually be triggered, and they demonstrate how to do so. Having a separate file for each test leaves enough space for documenting historical anecdotes, rationale or edge cases, keeping them away from the source code.
The interesting details of this commit are in Makefile and t_integration.sh. All other files are just auto-generated.
When running the tests as part of ATF, they are packed together as a single test case. Conceptually, it would have been better to have each test as a separate test case, but ATF quickly becomes very slow as soon as a test program defines too many test cases, and 50 is already too many. The time complexity is O(n^2), not O(n) as one would expect. It's the same problem as in tests/usr.bin/make, which has over 300 test cases as well.
|