| History log of /src/tests/usr.bin/xlint/lint1/msg_239.c |
| Revision | | Date | Author | Comments |
| 1.10 |
| 10-Apr-2025 |
rillig | lint: do not warn about constant operand of '!'
Like its related warning about a constant condition, the purpose of this
warning is unclear, and suppressing the warning requires special lint
comments, thus cluttering the code.
The message itself is still kept in err.c to keep the '-X 239' option
valid. These LINTFLAGS will be removed in a follow-up commit.
The lint comments /* CONSTCOND */, as well as its more verbose forms /*
CONSTANTCOND */ and /* CONSTANTCONDITION */ are no longer needed and can
be removed.
|
| 1.9 |
| 06-Apr-2025 |
rillig | lint: remove warning about 'constant in conditional context'
In a full NetBSD build, this warning occurs about 2400 times, making it
the top 9 warning overall. There is no evidence though that this
warning detects any real bugs, so the noise it makes is not warranted.
In this first step, the warning is still listed in the lint(7) manual
page, as removing it from there would immediately make all places with
"LINTFLAGS += -X 161" fail. These '-X 161' flags cannot be removed
first because then, the warning would step in and make the build fail.
The next step is to clean up the "-X 161" options from all LINTFLAGS,
and then the final step is to remove the warning from err.c.
|
| 1.8 |
| 02-Aug-2023 |
rillig | branches: 1.8.2;
lint: distinguish between arguments and parameters
|
| 1.7 |
| 07-Jul-2023 |
rillig | lint: warn about function definitions without header declaration
The existing warning was only issued for function declarations, not for
function definitions.
The interesting change in the tests is in msg_351.c. Many other tests
use non-static functions due to their syntactic brevity. In these
tests, the warning is disabled individually, to allow new functions to
be added without generating warning 351.
|
| 1.6 |
| 16-Jun-2022 |
rillig | tests/lint: add more details to messages in msg_200 until msg_299
Add some tests that were previously empty. Some other tests are still
empty.
|
| 1.5 |
| 05-Apr-2021 |
rillig | tests/lint: one comment per expected diagnostic
This makes it possible to check for diagnostics that contain commas.
|
| 1.4 |
| 02-Apr-2021 |
rillig | lint: reword message about constant argument to '!'
In the other messages, operators are typically written in their literal
form as well. Using single quotes disambiguates them from normal
punctuation.
|
| 1.3 |
| 02-Apr-2021 |
rillig | tests/lint: add test for constant argument to '!'
|
| 1.2 |
| 21-Feb-2021 |
rillig | lint: force each test to declare the expected diagnostics
By listing the expected diagnostics directly at the code that triggers
the diagnostics, it is easier to cross-check whether the diagnostics
make sense.
No functional change to lint itself.
|
| 1.1 |
| 02-Jan-2021 |
rillig | lint: add a test for each message produced by lint1
Having a test for each message ensures that upcoming refactorings don't
break the basic functionality. Adding the tests will also discover
previously unknown bugs in lint.
The tests ensure that every lint message can actually be triggered, and
they demonstrate how to do so. Having a separate file for each test
leaves enough space for documenting historical anecdotes, rationale or
edge cases, keeping them away from the source code.
The interesting details of this commit are in Makefile and
t_integration.sh. All other files are just auto-generated.
When running the tests as part of ATF, they are packed together as a
single test case. Conceptually, it would have been better to have each
test as a separate test case, but ATF quickly becomes very slow as soon
as a test program defines too many test cases, and 50 is already too
many. The time complexity is O(n^2), not O(n) as one would expect.
It's the same problem as in tests/usr.bin/make, which has over 300 test
cases as well.
|
| 1.8.2.1 |
| 02-Aug-2025 |
perseant | Sync with HEAD
|
