Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

fix -Wsign-compare issue

remove debugging code.

fix off-by-one bug that did not add a tag for "foo" in
"typedef struct foo { int x; } foo_t";
as intended.

branches: 1.15.6; 1.15.16; 1.15.28; 1.15.30; 1.15.32; 1.15.34;
Coverity CID 2913: Check for EOF before using char as index to array.

Avoid iswhite(EOF) - fixes coverty CIDs 365 and 1196
I'm not at all sure EOF handling is correct anyway - but it probably only
affects the last line of a file (and maybe last lines without \n).
In particular I suspect that 'ungetc(EOF, file)' doesn't do the expected
thing, and that fseek() needs to be preceeded by clearerr(). But life it short.

Fix a couple of stack-smashing buffer overflows.

Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.10.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Make this compilable as a host tool.

teach ctags(1) about // comments.

Don't recognize `int (*f)();' as a function. The false match caused the
next real function to be eaten and skipped during the forward scan for `{'.

Restores about 35 lost functions to the kernel tags file.

Now understands white space between # and define.

Deal with the gnu __attribute__ keyword, which is in an odd place and
breaks the ctags function-recognition algorithm.

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ctags: fix pointer-sign issues

Refactor init() to avoid -Wpointer-sign for host builds.
Uses same cast pattern used in ctags.h.

Remove many HAVE_GCC || HAVE_PCC conditionals as the options also apply
to Clang. Add a few cases of HAVE_LLVM for -fno-strict-aliasing.

branches: 1.12.2;
remove most of the remaining HAVE_GCC tests that are always true in
the modern world.

branches: 1.11.4;
Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.10.6;
Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.

branches: 1.9.22;
don't do the -Wno-pointer-sign dance for host programs.

sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4.

Kill __P(), use ANSI function declarations, constify; WARNS=3.

Now that <bsd.prog.mk> DTRT if HOSTPROG is defined (i.e, it is a no-op),
there's no need to special-case .include-ing it.

Make this compilable as a host tool.

use CPPFLAGS instead of CFLAGS

branches: 1.3.4;
Merge with 4.4Lite

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Remove workaround for ancient HTML generation code.

Change some standard exit status text to ".Ex -std"
From Eitan Adler in PR bin/47790.

branches: 1.16.6; 1.16.12; 1.16.22;
Reorder to canonical order.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

`;' as macro arguments also need quoting.

New sentence, new line. Some mdoc cleanup.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Sort sections.

Whitespace cleanup.

For commands and utilities, use EXIT STATUS rather than RETURN VALUES or
DIAGNOSTICS as appropriate (and documented in mdoc(7)).

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Fix typo reported by Wolfgang Helbig <helbig@Informatik.BA-Stuttgart.DE>
in PR 7056.

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

Fix spelling errors.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

PR bin/58786 Partly fix ctags -u processing

RVP pointed out that the command in the previous version to
remove old entries from the tags file would fail, if some were
not there (-u being used to add a new file's tags) as grep
exits 1 when the pattern is not found. (The original version
would almost never fail, even when it should have, as its status
was just from the final "rm" command).

So make the command more complex to deal with that.

While there, do away with the OTAGS nonsense, and use mktemp(1) instead.

Also do away with the absurdly short 100 byte command buffer, and
use asprintf() instead.

And also properly quote strings being passed to system(3) (why the
code needs to use system(3) at all is an entirely different question).

There are still oh so many weirdnesses in this program, but when
used in the typical way, it should be no worse than it ever was.

XXX no pullups intended

PR bin/58786 More ctags error handling

Inspired by RVP's patch in PR bin/58786 add handling of write
errors, and failures to build or execute commands used in
implementing the -u option but implemented a little differently
(and avoiding adding yet more 80 column violations to this mess).

The processing of -u needs to be completely redone sometime, I mean,
no-one would really ever want to keep a file named OTAGS in "." would they?
Really???

XXX - pullups? Probably not, no-one has ever cared about this before.

PR bin/58786 - fix exit status when tags file open fails

From RVP ... always exit(1) when opening new tags file fails.

branches: 1.15.2;
s/psuedo/pseudo/ in comments.

ctags: fix pointer-sign issues

Refactor init() to avoid -Wpointer-sign for host builds.
Uses same cast pattern used in ctags.h.

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.12.60;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.11.28;
Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.9.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Make this compilable as a host tool.

Add { and } to shut up egcs. Reformat the more questionable code.

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Sync with 4.4lite2

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

branches: 1.8.12; 1.8.22; 1.8.34; 1.8.38; 1.8.40;
Kill __P(), use ANSI function declarations, constify; WARNS=3.

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Roll in fixes to permit cross-compiling from non-NetBSD hosts. This
round has been tested on Solaris/x86 and Linux hosts.

* Add host tools cap_mkdb, ctags, m4, uudecode.
* Protect __RCSID() and __COPYRIGHT() better.
* Reduce the number of places that need to include "config.h", to keep
sources closer to their "vanilla" versions.
* Add more compat #defines and autoconf-checked functions.

teach ctags(1) about // comments.

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.11.46;
Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

branches: 1.10.12; 1.10.22; 1.10.34; 1.10.38; 1.10.40;
Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.8.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Make this compilable as a host tool.

char -> unsigned char

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

branches: 1.10.12; 1.10.22; 1.10.34; 1.10.38; 1.10.40;
Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.8.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Make this compilable as a host tool.

char -> unsigned char

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Output format fix for -x mode.

Ensure there is always a space between the symbol name and the line
number, rather than only when either the symbol is 15 chars or shorter,
or the line number is 3 digits or shorter. That is, previously a
symbol appearing 1000 or more lines into a file, with a name of 16
chars or longer, would produce (something like):

A_very_long_symbol_name2345 filename ...

No more.

Now it will be:

A_very_long_symbol_name 2345 filename ...

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

branches: 1.9.12; 1.9.22; 1.9.34; 1.9.38; 1.9.40;
Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.7.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Make this compilable as a host tool.

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Update lseek() constants:
L_SET -> SEEK_SET

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Don't follow node->left after free(node).
Optimise out recursion unless both node->left and node->right non-NULL.
Fixes coverty CIDs 26 and 27.

Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.9.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Make this compilable as a host tool.

disambiguate if/else block

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

cfree -> free

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

branches: 1.11.6; 1.11.16; 1.11.28; 1.11.32; 1.11.34;
Avoid iswhite(EOF) - fixes coverty CIDs 365 and 1196
I'm not at all sure EOF handling is correct anyway - but it probably only
affects the last line of a file (and maybe last lines without \n).
In particular I suspect that 'ungetc(EOF, file)' doesn't do the expected
thing, and that fseek() needs to be preceeded by clearerr(). But life it short.

Kill __P(), use ANSI function declarations, constify; WARNS=3.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.8.2;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Make this compilable as a host tool.

receive, not recieve

teach ctags(1) about // comments.

WARNSify, fix .Nm usage, getopt returns -1 not EOF

Merge with 4.4Lite

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Merge with 4.4Lite

branches: 1.1.1;
Initial revision