error: disable lint's strict bool mode when building with Clang

The Clang preprocessor does not mark sections from system headers.
Lint's strict bool mode relies on these markers to allow the functions
from <ctype.h> to be used as 'bool', even though their declared return
type is 'int'. Without these markers, lint complains that the "right
operand of '&&' must be bool, not 'int'". Until this is fixed in lint,
disable strict bool mode.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: fix lint warnings

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

pass -Wshadow

Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.6.14;
Convert to raise_default_signal(3).

branches: 1.5.8;
WFORMAT is no more...

More format string cleanup by sommerfeld.

branches: 1.3.8; 1.3.16;
Sync with 4.4lite2

Add RCS indentifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error.1: fix markup

error: move comment above the main function to the manual page

While here, clean up the markup of the manual page, removing unnecessary
emphasis.

error: fix typos

Remove workaround for ancient HTML generation code.

Convert reference to f77(1) from .Xr to .Ic as we don't have it any more.
Ok from wiz@

Fix the csh(1) example ("make ... |& error ...", not "make ... | error ..."),
and add a sh(1) example ("make ... 2>&1 | error ...").

branches: 1.17.4;
Fix macro name in SYNOPSIS.

Sort options, merge single letter options in synopsis.

- use getopt
- use err
- add -p <filelevel> to chop levels like patch
- document all the options

\\ -> \e

fix spelling of accidentally; from Zapher

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

users's -> user's (from Igor Sobrado in PR misc/19700)

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

Edit -mdoc usage.

* There is no -indent option to .Bd or .Bl, although you would
never know that from its frequent use in this tree. There is a
"-offset indent" combination that makes sense, and you can certainly
say "-width indent".

* Also, you can't markup the -width option argument, tho you CAN
use a callable macro. So "-width Ar filename" doesn't make sense,
but either "-width Ar" or "-width filename" does, as might something
like "-width xxfilename" for a little extra space.

* There are a lot of needlessly complex hanging tag macros in man4 used
to create simple item lists. Those should be simplified one of these
days before someone copies and edits yet another man4 page.

Use standard headers, drop a .Pp.

Replace some .Xr to non-existing man pages with .Ic (since we don't
even have the matching programs).

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

WARNSify (big job!), fix .Nm usage

fix typo; from Saitoh Masanobu in PR misc/3199.

Sync with 4.4lite2

Add RCS indentifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: clean up comparison of word vectors

The function wordvcmp returned -1 when either of the word vectors was
short; this made the function asymmetric. Since the function is only
used to compare two word vectors for equality, restrict it to this
particular use case.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

Don't use non-literal format strings. Split it up depending on the
number of arguments used.

branches: 1.18.2; 1.18.4;
avoid "... dutch" being interpreted as a pascal continuation message, and
core-dumping.

remove unused.

- use getopt
- use err
- add -p <filelevel> to chop levels like patch
- document all the options

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

Sprinkle const.

Whitespace.

sprinkle static

branches: 1.10.16;
Support an explicit Q_error return from inquire(), which is returned
if there was an error on reading the reply.
Stops an infinite loop if you ^D the query.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

get rid of strsave(), use strdup directly

Remove #ifndef'd __STDC__ code. ANSIfy.

fix redundant and nested decls

Get rid of multiply defined common symbols
langauge should be language in error.h

WARNSify (big job!), fix .Nm usage

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: remove redundant parentheses around return value

No binary change.

Use this program's Strdup() instead of strdup() so it exits on failure
instead of dumping core.

Use rewind() instead of freopen()'ing the same file for no reason. Also,
close the file when done instead of dropping it on the floor. Obsoletes
PR 50579.

Remove unnecessary fclose(3) call

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

pass -Wshadow

Sprinkle const.

Whitespace.

sprinkle static

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

get rid of strsave(), use strdup directly

Remove #ifndef'd __STDC__ code. ANSIfy.

fix redundant and nested decls

Eliminate hard coded buffer sizes in fgets() statements, use
strlcpy() to avoid buffer overflows, increase filename buffer
to MAXPATHLEN. (from OpenBSD)

char -> unsigned char

WARNSify (big job!), fix .Nm usage

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: clean up comparison of word vectors

The function wordvcmp returned -1 when either of the word vectors was
short; this made the function asymmetric. Since the function is only
used to compare two word vectors for equality, restrict it to this
particular use case.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: remove redundant parentheses around return value

No binary change.

use getline(3)

branches: 1.17.42;
gcc 4.5 error support ("file:line:col: error" instead of "file:line: error")

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

Sprinkle const.

Whitespace.

sprinkle static

Coverity CID 2331: Plug memory leak.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #ifndef'd __STDC__ code. ANSIfy.

fix a multitude of core dumps because most functions were not checking
the length of the word list.

char -> unsigned char

Get rid of multiply defined common symbols
langauge should be language in error.h

WARNSify (big job!), fix .Nm usage

Handle long lines without core-dumping.

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: move comment above the main function to the manual page

While here, clean up the markup of the manual page, removing unnecessary
emphasis.

error: fix typos

fix various typos, mainly in comments.

avoid "... dutch" being interpreted as a pascal continuation message, and
core-dumping.

- KNF
- more static
- fix argument parsing.

Sync usage with man page.

- use getopt
- use err
- add -p <filelevel> to chop levels like patch
- document all the options

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

Sprinkle const.

woops (doh!)

Whitespace.

sprinkle static

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.10.12; 1.10.14;
Support an explicit Q_error return from inquire(), which is returned
if there was an error on reading the reply.
Stops an infinite loop if you ^D the query.

Spell the plural of suffix "suffixes", not "suffices".
Inspired by PR 24400 by Todd Vierling.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #ifndef'd __STDC__ code. ANSIfy.

Fix various misspellings of compatible/compatibility.

Get rid of multiply defined common symbols
langauge should be language in error.h

WARNSify (big job!), fix .Nm usage

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

Whitespace.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

For temporary files' pathnames, check $TMPDIR before falling back to _PATH_TMP.

branches: 1.3.12;
Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

Fix various typos, mainly in comments and log/error messages.

branches: 1.24.2;
error: clean up comparison of word vectors

The function wordvcmp returned -1 when either of the word vectors was
short; this made the function asymmetric. Since the function is only
used to compare two word vectors for equality, restrict it to this
particular use case.

error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: remove redundant parentheses around return value

No binary change.

fix various typos, mainly in comments.

PR 51298 David Binderman: simplify redundant conditionals

avoid "... dutch" being interpreted as a pascal continuation message, and
core-dumping.

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

Sprinkle const.

Whitespace.

sprinkle static

Coverity CID 2333: Fix memory leak.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

get rid of strsave(), use strdup directly

Remove #ifndef'd __STDC__ code. ANSIfy.

fix redundant and nested decls

Eliminate hard coded buffer sizes in fgets() statements, use
strlcpy() to avoid buffer overflows, increase filename buffer
to MAXPATHLEN. (from OpenBSD)

char -> unsigned char

Get rid of multiply defined common symbols
langauge should be language in error.h

WARNSify (big job!), fix .Nm usage

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: clean up comparison of word vectors

The function wordvcmp returned -1 when either of the word vectors was
short; this made the function asymmetric. Since the function is only
used to compare two word vectors for equality, restrict it to this
particular use case.

error: small cleanups

error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: remove redundant parentheses around return value

No binary change.

error: fix lint warnings

fix various typos in comments.

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

Sprinkle const.

Whitespace.

sprinkle static

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

get rid of strsave(), use strdup directly

the function is equivalent to strdup.

Remove #ifndef'd __STDC__ code. ANSIfy.

strcmp returns an int not a ptr so don't compare to NULL

Eliminate hard coded buffer sizes in fgets() statements, use
strlcpy() to avoid buffer overflows, increase filename buffer
to MAXPATHLEN. (from OpenBSD)

Fix serious bug with string overruns that caused error to coredump randomly
on NetBSD, and each time on other OS's. Also 0 -> NULL or 0 -> '\0' where
appropriate.

Don't assume isspace(0) == 1

branches: 1.6.2;
char -> unsigned char

WARNSify (big job!), fix .Nm usage

Handle long lines without core-dumping.

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).

error: use separate tokens for characters, integers and pointers

Assisted by lint's queries 10, 14, 15.

No binary change.

error: enable lint's strict bool mode

This cleans up the inconsistencies between 'int', 'boolean' and 'bool'.

error: remove redundant parentheses around return value

No binary change.

error: fix lint warnings

can't happen, but gcc can't figure it out.

branches: 1.27.32;
Don't use non-literal format strings. Split it up depending on the
number of arguments used.

branches: 1.26.4; 1.26.6;
Simplify

use warn/err.

counting was off, and setting things to themselves does not work very welll.

- use getopt
- use err
- add -p <filelevel> to chop levels like patch
- document all the options

Pass WARNS=4, not without some gross preprocessor hackery.
XXX: does this program actually do anything useful these days?

Assorted minor cleanup:
- use stdbool.h (partly)
- move extern declarations of data to header files
- use right types for calloc() wrapper
- remove bogus casts on return values
- remove excessive Pascal-style parentheses in conditionals
- a couple const fixes
- fix some typos in comments

pass -Wshadow

Sprinkle const.

Whitespace.

sprinkle static

Convert to raise_default_signal(3).

branches: 1.15.4; 1.15.6;
Support an explicit Q_error return from inquire(), which is returned
if there was an error on reading the reply.
Stops an infinite loop if you ^D the query.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #ifndef'd __STDC__ code. ANSIfy.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

fix redundant and nested decls

More format string cleanup by sommerfeld.

branches: 1.9.4;
For temporary files' pathnames, check $TMPDIR before falling back to _PATH_TMP.

branches: 1.8.2; 1.8.6;
remove unused extern.

fix compile warnings on the alpha.

WARNSify (big job!), fix .Nm usage

NULL => 0 (Arne Juul; PR#3629)

use mkstemp() instead of mktemp()

Sync with 4.4lite2

Add RCS identifiers.

branches: 1.1.1;
added, from net/2 (patch 119).