Home | History | Annotate | Download | only in make
History log of /src/usr.bin/make/metachar.h
RevisionDateAuthorComments
 1.20  08-Jan-2022  rillig make: rename is_shell_metachar, fix character conversion warning

No binary change.
 1.19  15-Dec-2021  rillig make: remove redundant comments for multiple-inclusion guards
 1.18  15-Dec-2021  rillig make: mark several functions whose result must be used

Suggested by sjg, to catch more bugs like the memory leak in cond.c
1.303 from 2021-12-13.

No binary change.
 1.17  21-Jun-2021  rillig make: replace macro is_shell_metachar with inline function

No functional change.
 1.16  03-Apr-2021  rillig make: use C99 bool type instead of defining its own

No functional change.
 1.15  19-Jan-2021  rillig make(1): remove do-not-format markers from comments

These markers had been used inconsistently. Furthermore the source code
had not been formatted automatically before 2020 at all, otherwise there
wouldn't have been any trailing whitespace left.
 1.14  16-Jan-2021  rillig make(1): fix a few inconsistencies for lint's strict bool mode
 1.13  10-Jan-2021  rillig make(1): consistently use boolean expressions in conditions

Most of the make code already followed the style of explicitly writing
(ptr != NULL) instead of the shorter (ptr) in conditions.

The remaining 50 instances have been found by an experimental,
unpublished check in lint(1) that treats bool expressions as
incompatible to any other scalar type, just as in Java, C#, Pascal and
several other languages.

The only unsafe operation on Boolean that is left over is (flags &
FLAG), for an enum implementing a bit set. If Boolean is an ordinary
integer type (the default), some high bits may get lost. But if Boolean
is the same as _Bool (by compiling with -DUSE_C99_BOOLEAN), C99 6.3.1.2
defines that a conversion from any scalar to the type _Bool acts as a
comparison to 0, which cannot lose any bits.
 1.12  10-Nov-2020  rillig make(1): use consistent definition for MAKE_INLINE
 1.11  31-Oct-2020  rillig make(1): remove unused code from needshell

Since usr.bin/xinstall no longer uses this code, there is no need to
keep the second parameter.
 1.10  31-Oct-2020  rillig make(1): rename ismeta to is_shell_metachar

The old name was too broad.
 1.9  13-Sep-2020  rillig make(1): fix position of MAKE_ATTR_UNUSED in inline functions

The attribute needs to be before the return type, otherwise GCC 5
complains that Hash_GetValue is defined but not used, when compiling
with USER_CPPFLAGS=-Dinline=. The other functions don't get any
warnings. It's probably because Hash_GetValue is the only inline
function that returns a pointer.
 1.8  11-Sep-2020  rillig make(1): add wrappers around ctype.h functions

This avoids casting the argument to unsigned char, and to cast the
result of toupper/tolower back to char.
 1.7  25-Aug-2020  rillig make(1): allow make to be compiled in C90 mode

Since the inline functions are the only C99 feature used by now, setting
USER_CFLAGS='-std=c90 -ansi -Dinline=' is enough for compiling make with
a C90 compiler.
 1.6  23-Aug-2020  rillig make(1): remove unused declarations from header files
 1.5  13-Aug-2020  rillig make(1): follow naming conventions for multiple-inclusion guards

This avoids undefined behavior.
 1.4  21-Jun-2015  christos remove <sys/cdefs.h> for portability reasons
 1.3  19-Jun-2015  christos make needshell customizable, so that xinstall can use it.
 1.2  19-Jun-2015  christos create needshell so we don't scan the string multiple times.
 1.1  17-Jun-2015  christos centralize shell metachar handling.

RSS XML Feed