Home | History | Annotate | Download | only in unit-tests
History log of /src/usr.bin/make/unit-tests/cond-cmp-string.mk
RevisionDateAuthorComments
 1.21  28-Jun-2025  rillig make: consistently use double quotes in error messages

Previously, some error messages used single quotes, very few used
backticks or parentheses, most already used double quotes.

While here, reword a few error messages to be clearer or more consistent
with related error messages.
 1.20  06-Aug-2024  rillig make: in error message about conditionals, use single quotes

Single quotes are used less often in the conditionals themselves, which
leads to fewer confusions.
 1.19  23-Apr-2024  rillig make: clean up comments, code and tests
 1.18  19-Nov-2023  rillig tests/make: replace 'variable expression' with 'expression'

Each expression is based on a variable, there's no need for the
verbosity. The wording in make's diagnostics will be changed in a
follow-up commit.
 1.17  28-Mar-2023  rillig tests/make: add expectations for string comparison errors
 1.16  08-May-2022  rillig tests/make: migrate cond1 test to other, more specific tests

The tests in cond1 were a mixture of "everything related to conditions",
and the test cases were heavily dependent on each other, which made them
hard to understand. Move each test case to its corresponding
special-purpose test.
 1.15  11-Dec-2021  rillig tests/make: proofread and clean up comments for function 'empty'

This prepares a refactoring for handling the function 'empty' in
conditionals like '.if'.

The function 'empty' is fundamentally different from all other functions
since it is parsed differently and passes its result on different path
than the other functions. Splitting up these code paths will untangle
the control flow of parsing a condition like 'empty(VARNAME)'. It will
also remove several ARGSUSED and MAKE_ATTR_UNUSED that make the current
code smell.
 1.14  19-Jan-2021  rillig make(1): add test for unsupported relational string comparisons
 1.13  15-Nov-2020  rillig make(1): clean up some tests

Fix some mistakes in comments.

Improve some comments to be easier understandable.

Inline variables that are irrelevant for the test at hand (RUN,
MAKE_CMD).

Remove references to functions and constants that have since been removed
or renamed.
 1.12  08-Nov-2020  rillig make(1): add test for comparing numbers with strings
 1.11  30-Oct-2020  rillig make(1): fix comments in test for string literals in conditions
 1.10  30-Oct-2020  rillig make(1): fix parse error in string literal in conditional

The string literal "${VAR} " had produced a "Malformed conditional", at
least since 2003. (That's the oldest make I have available for testing.)
Strange that nobody else noticed that in the last 17 years.
 1.9  30-Oct-2020  rillig make(1): add more test cases that fail in condition string literals
 1.8  30-Oct-2020  rillig make(1): add test for two variable expressions in a string literal
 1.7  30-Oct-2020  rillig make(1): demonstrate parse error in string interpolation in condition
 1.6  24-Oct-2020  rillig make(1): indent directives like .info, .if, .for consistently

Done by "pkglint -F *.mk", no manual corrections.
 1.5  11-Sep-2020  rillig make(1): fix tests about nonexistent = and === operators
 1.4  11-Sep-2020  rillig make(1): add tests for the unknown = and === operators
 1.3  20-Aug-2020  rillig make(1): add test for string literals in comparisons
 1.2  16-Aug-2020  rillig make(1): describe the purpose of each newly added unit test dummy
 1.1  16-Aug-2020  rillig make(1): add dummies for fine-grained tests, one per single feature

The test names have been derived from the current manual page.

All these tests are dummies right now, and the code from the existing
tests will be moved into the new tests step by step.

This is done to prevent modmisc, escape, varmod-edge and varmisc from
growing without any bounds, and to reduce the side-effects of one test
to the others.

RSS XML Feed