Home | History | Annotate | Download | only in unit-tests
History log of /src/usr.bin/make/unit-tests/cond-short.mk
RevisionDateAuthorComments
 1.24  28-Jun-2025  rillig make: consistently use double quotes in error messages

Previously, some error messages used single quotes, very few used
backticks or parentheses, most already used double quotes.

While here, reword a few error messages to be clearer or more consistent
with related error messages.
 1.23  19-Nov-2023  rillig branches: 1.23.2;
tests/make: replace 'variable expressions' with 'expressions'
 1.22  19-Nov-2023  rillig tests/make: replace 'variable expression' with 'expression'

Each expression is based on a variable, there's no need for the
verbosity. The wording in make's diagnostics will be changed in a
follow-up commit.
 1.21  19-Oct-2023  rillig tests/make: clean up, explain and reorganize several tests
 1.20  04-Mar-2023  rillig tests/make: use proper variable names in short-circuit test

The previous variable names V42, V66, iV1 and iV2 didn't carry enough
information to be readily readable, making the test hard to understand.

Rename the variables to be more expressive. While here, properly
explain what happened behind the scenes in 2020 and how the evaluation
of conditions was fixed after discovering the actual cause of the
unexpected error messages.
 1.19  27-Dec-2021  rillig make: clean up comments
 1.18  12-Dec-2021  rillig tests/make: add tests for irrelevant function calls
 1.17  07-Sep-2021  rillig tests/make: expand on the history of unnecessary evaluation
 1.16  14-Mar-2021  rillig tests/make: add test for short-circuit evaluation of modifiers
 1.15  01-Dec-2020  rillig make(1): document handling of irrelevant conditions before 2020-07-09
 1.14  01-Dec-2020  rillig make(1): adjust condition descriptions in test cond-short

Before, the conditions in the output had been expanded, which made them
illegible. The expanded conditions were unrealistic as well since the
evaluation flags differ between a condition and normal evaluation
(VARE_WANTRES, VARE_UNDEFERR).
 1.13  30-Nov-2020  rillig make(1): document how short-circuit evaluation behaved on 2020-07-03
 1.12  15-Nov-2020  rillig make(1): add remarks to the tests about conditions
 1.11  24-Oct-2020  rillig make(1): use consistent indentation in variable assignments

Initial work by "pkglint -F *.mk", manually adjusted in a few places.
 1.10  24-Oct-2020  rillig make(1): indent directives like .info, .if, .for consistently

Done by "pkglint -F *.mk", no manual corrections.
 1.9  19-Aug-2020  rillig make(1): add empty lines to separate the test cases in cond-short
 1.8  19-Jul-2020  rillig make(1): add test for assignment operators in conditions
 1.7  09-Jul-2020  sjg compare_expression: return after fetch lhs and rhs if !doEval

Otherwise we end up throwing warings/errors for valid
conditionals due to not expanding variables fully.

Add tests to catch this.

Reviewed by: rillig
 1.6  02-Jul-2020  rillig make(1): demonstrate some more cases for unintended evaluation
 1.5  02-Jul-2020  rillig make(1): fix unnecessary evaluation of :M and :N modifiers
 1.4  02-Jul-2020  rillig make(1): demonstrate another unintended variable evaluation
 1.3  02-Jul-2020  rillig make(1): demonstrate another unnecessary condition evaluation
 1.2  28-Jun-2020  rillig make(1): fix evaluation of unreachable conditions

Since 2015-10-11, make had evaluated unreachable conditions even though
the manual page said it didn't.
 1.1  28-Jun-2020  rillig make(1): demonstrate bug when evaluating conditions
 1.23.2.1  02-Aug-2025  perseant Sync with HEAD

RSS XML Feed