Home | History | Annotate | Download | only in unit-tests
History log of /src/usr.bin/make/unit-tests/sh-flags.exp
RevisionDateAuthorComments
 1.4  12-Feb-2022  rillig make: fix echoing of command with '-' in silent target in jobs mode

Since job.c 1.83 from 2003-12-20, the command had been echoed even if
the target had the attribute '.SILENT'.

In sh-flags.exp, each removed 'echo' command is below a target name
matching the pattern 'opt-?j????-tgt-??s-cmd-?i?', which means that the
target was marked as silent, either through a global '.SILENT'
declaration or the command line option '-s' or the attribute '.SILENT'
on the target.

Reported by Alan Barrett in PR#45356.
 1.3  12-Dec-2020  rillig make(1): reduce number of test cases in sh-flags.mk

The field job->echo is initialized in JobStart (and in JobOpenTmpFile).
After that, it is not modified anymore. Therefore it is not necessary
to run these test cases redundantly.

The field job->ignerr, on the other hand, is modified later on. For
these cases, the many remaining test cases are still needed.
 1.2  10-Dec-2020  rillig make(1): fix test for command flags

The "false" is supposed to be run not only if the command has the '-'
flag, but also if the target is marked as .IGNORE or if the command line
option -i is given.

After the failed command, the remaining commands are skipped, therefore
the final echo for the empty line had to be moved up, at the beginning
of the target.
 1.1  10-Dec-2020  rillig make(1): test all combinations of switches for running commands

The code in JobPrintSpecials is rather complicated and contains
surprising interaction between some of the switches.

To see the exact effects of the switches, record the current state and
its output, to prevent accidental breakage during the upcoming
refactorings.

RSS XML Feed