bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.15.26;
config() in manconf.c now verifies _build (and _crunch) command
templates with fmtcheck(3) so annotate the printf that uses these
commands as safe with a __format_arg wrapper and drop
-Wno-format-nonliteral.

XXX: Using local wrapper for now, solving this in general would be
nice, but it raises namespace pollution issues.

XXX^2: catman(8) also uses manconf.c and uses _build and _crunch so it
can also benefit from this (but see above).

Use -Wno-format-nonliteral instead of blanket -Wno-format.

use -Wno-format and revert "fixstring"

WARNS=6
- fix cast qual issues
- don't use snprintf on a user-provided buffer

branches: 1.11.6; 1.11.12; 1.11.16;
Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.10.14;
Convert to using raise_default_signal(3).

branches: 1.9.8;
WFORMAT is no more...

Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

branches: 1.7.2;
More format string cleanup by sommerfeld.

branches: 1.6.8; 1.6.16;
Sync with 4.4BSD-Lite2

specify man pages the new way.

add man(1) ; part of new man(1) package from Bostic

Add RCS indentifiers.

Add makewhatis script

branches: 1.1.1;
Initial revision

Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

- getlist(): add "int create" arg, which creates list if it's not present
(using guts of now defunct addlist())
- use TAILQ_*() macros appropriately when manipulating tailqs

branches: 1.15.2;
Wrap RCSID in #ifdef/#endif, for build.sh -t on non-NetBSD system.

g/c removelist()/renamelist(), the only user (catman(8)) was modified to not use them

Add a comment to note that removelist() and renamelist() are used by catman(8)

Well, the removelist and renamelist functions were not unused;
they are still used by catman. Add them back.

allow to specify relative paths for sections in man.conf - they are used
similarily to _subdir, but only when appropriate
fix -m handling, so that e.g. "man -m . 3 printf" works as it should
add new -S flag, to specify a string the result path has to contain
g/c some unused stuff

Written by Chuck Cranor, with only cosmetic changes & const poisoning by me.

branches: 1.10.6;
Handle '_crunch' section.
Add removelist() function
Add renamelist() function

branches: 1.9.2;
char -> unsigned char

cleanup for WARNS=1

Sync with 4.4BSD-Lite2

Sync with 4.4-Lite, plus local changes.

rename fgetline()

kill a bit of redudancy

kill that hack

#ifdef out a changed interface, for now

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic

Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

- getlist(): add "int create" arg, which creates list if it's not present
(using guts of now defunct addlist())
- use TAILQ_*() macros appropriately when manipulating tailqs

branches: 1.5.4;
Well, the removelist and renamelist functions were not unused;
they are still used by catman. Add them back.

allow to specify relative paths for sections in man.conf - they are used
similarily to _subdir, but only when appropriate
fix -m handling, so that e.g. "man -m . 3 printf" works as it should
add new -S flag, to specify a string the result path has to contain
g/c some unused stuff

Written by Chuck Cranor, with only cosmetic changes & const poisoning by me.

branches: 1.3.6;
Handle '_crunch' section.
Add removelist() function
Add renamelist() function

branches: 1.2.8;
Sync with 4.4BSD-Lite2

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic

PR/59625: Ingo Schwarze: Add a new -l flag that specifies to interpret
arguments as filenames, keeping the current behavior of interpreting
arguments as filenames if they begin with "/" "./" or "../" for compatibility.
In the future we can remove that.

man(1): document arguments in the list

For options that have an argument, add that argument to
the entry in the list.

branches: 1.30.4;
man.1: add a small note about alternate machine name searches

Document -f option for man(1).
Also remove unsupported options for `man -k` from the synopsis and usage.

More detail about treating a local file as a man page,
and about how to request machine-specific man pages.
re

Merge riastradh-drm2 to HEAD.

whatis.db is no more, so don't mention its location in FILES.

Remove unnecessary line wrap.

branches: 1.24.2; 1.24.8; 1.24.12;
Refer to X11R7.

Fix usage in man page and sync usage in executable with it.

Add support for man -p to print the search path for manual pages (not
including cat page directories).

From Abhinav Upadhyay as part of Google's Summer of Code 2011

branches: 1.21.4;
Mimic OSX behaviour:

On OS X it is possible to specify the manpage filename
with a full or relative path like this:

man ./foo.5

or

man /cd/foo/bar.1.gz

This is really helpful to view the manpage quickly while editing it.

patch presented on current-users@ and tech-userlevel@:
http://mail-index.netbsd.org/current-users/2009/10/06/msg010767.html
http://mail-index.netbsd.org/tech-userlevel/2009/10/06/msg002675.html

No objections

branches: 1.20.28; 1.20.34;
Bump date for previous, slightly reword a sentencen.

rework the wording in these man pages (mainly in man.conf.5) based on
some old notes I found to make it clearer and easier to understand
how the man stuff works (hopefully!).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

New sentence, new line. Some mdoc cleanup.

Remove unneeded Ns.

Whitespace cleanup.

Remove /usr/X11/man/whatis.db from path list, as it can no longer found
in /etc/man.conf

Supply missing "as".

branches: 1.11.2;
Allow "-s" to specify a section name, ala the SysV man command.
Unlike the SysV man command, this doesn't allow for the -s argument
to be a list.

allow to specify relative paths for sections in man.conf - they are used
similarily to _subdir, but only when appropriate
fix -m handling, so that e.g. "man -m . 3 printf" works as it should
add new -S flag, to specify a string the result path has to contain
g/c some unused stuff

Written by Chuck Cranor, with only cosmetic changes & const poisoning by me.

branches: 1.9.6;
Doc previously undocumented `-k' option, correctly note mutually exclusive
options, various stylistic changes.
Closes PR bin/8325.

Fall back to more(1) if PAGER is set but null.

branches: 1.7.2;
More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Added .Xr mdoc 7 and .Xr mdoc.samples 7 per PR#5284

RCS Id Police.

fix up .Nm usage

fix typo

Sync with 4.4-Lite, plus local changes.

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic

Fix comment: '-f' and '-k' are in fact documented these days

PR/59625: Ingo Schwarze: Add a new -l flag that specifies to interpret
arguments as filenames, keeping the current behavior of interpreting
arguments as filenames if they begin with "/" "./" or "../" for compatibility.
In the future we can remove that.

man.c: minor KNF

man: remove unused global variable 'instype' (since yesterday)

No functional change.

man: remove trailing whitespace

No binary change.

man: fix type mismatch between enum and int (since yesterday)

No binary change.

man.c: fix -m option so it works as documented

Refactoring work in man.c r. 1.40 from twelve years ago introduced a
regression where input from the -m option was appended rather than
prepended to the search paths. Problem reported by C. Chapman on
netbsd-users.

Exit successfully after printing the search path, stop further processing.

Continuing to process had the unintended effect that `man` failed to find
a matching manual page for {EMPTY LIST OF REQUESTED MANUAL PAGES}, and
exited with 1.

Prompted by a fish shell snippet that tried and failed to distinguish between
FreeBSD man (-p takes argument) and NetBSD man (-p no argument) by comparing
`man -p` exit code.

ok riastradh, logix (which also pointed out the manual page SYNOPSIS is
saying man -p should be used this way).

branches: 1.67.2; 1.67.4;
move 'utsname' to the main() function scope, so that the reference to
it outside the block remains valid.

should fix an asan reported issue.

branches: 1.66.2; 1.66.8;
Teach man -p to respect the MANPATH environment variable and the -M option.

Currently, `man -p` generates its output based on the value of the _default tag
in man.conf. However, man(1) modifies its search path based on the value of the
MANPATH variable and the list of directories specified via the -M option. In such
a case, `man -p` does not represent the correct search path. This commit intends
to fix this.

This change has the side effect that now the output of `man -p` will also include
the machine class specific subdirectories (such as man8/x86), while previously it
did not. The output would include subdirectories only for those machine classes
which are specified in the man.conf file.

Also, with this change, it is possible to run makemandb(8), by setting MANPATH
environment variable (e.g. env MANPATH=/usr/share/man makemandb).

Patch reviewed by wiz@

Fix comment indentation at couple of places: Use \t instead of space

branches: 1.64.6;
Document -f option for man(1).
Also remove unsupported options for `man -k` from the synopsis and usage.

Remove unused include and unused constant. Ok from christos@.

For an argument to be interpreted as a local file name, bypassing the
search rules in man.conf or MANPATH, it must begin with "/", "./", or
"../". Simply testing whether it contains "/" is wrong, because it
breaks usage like "man 8 vax/boot".

This reverts revision 1.57 dated 2013-10-06,
"Be more permissive in interpreting man pages as filenames".

branches: 1.61.4;
config() in manconf.c now verifies _build (and _crunch) command
templates with fmtcheck(3) so annotate the printf that uses these
commands as safe with a __format_arg wrapper and drop
-Wno-format-nonliteral.

XXX: Using local wrapper for now, solving this in general would be
nice, but it raises namespace pollution issues.

XXX^2: catman(8) also uses manconf.c and uses _build and _crunch so it
can also benefit from this (but see above).

Instead of guessing the suffix in the code, use the suffix list previously
loaded via man.conf(5). While there, zap unused iteration code.
(Franco Fichtner)

add more compression suffixes and local suffixes.

Recognize .gz and .bz2 suffixes so $ man ./man.1.gz works. From Franco Fichter
via dfly.

Be more permissive in interpreting man pages as filenames, from Franco
Fichter via dfly. fixes:
$ man usr.bin/man/man.1

Mark the dead.

Constify some more.

Spell "keywords" without space. Fix couple of typos.

manual_find_buildkeyword() - now that we control the format string, we
may use asterisk precision specification instead of temporary
modifying the _build string itself.

Fix manual_find_buildkeyword() to not use non-literal printf format.

Don't access memory outside the array if tmpdirlen == 0.

use -Wno-format and revert "fixstring"

Set the string to NUL instread of providing an new empty string (from uwe)

WARNS=6
- fix cast qual issues
- don't use snprintf on a user-provided buffer

Revert previous; other errors from WARNS=3 obscured the error in jump().

Constify jump() arguments appropriately.

Move manstate::pagerlen so that its "length of the above" comment makes sense.

branches: 1.44.6; 1.44.10;
If the default path doesn't result in a match, bail out early instead of
running into a segmentation fault. Based on patch by Abhinav Upadhyay.

branches: 1.43.2;
Fix usage in man page and sync usage in executable with it.

Add support for man -p to print the search path for manual pages (not
including cat page directories).

From Abhinav Upadhyay as part of Google's Summer of Code 2011

branches: 1.41.4;
get the value of the entry for the class not the key.

- centralize the snprintf code.
- use err where appropriate.
- add machclass which should be x86 when i386 and amd64 and can be specified
in man.conf as:
_i386 x86
_amd64 x86
so that we can support merged pages. Nothing uses this yet.

Mimic OSX behaviour:

On OS X it is possible to specify the manpage filename
with a full or relative path like this:

man ./foo.5

or

man /cd/foo/bar.1.gz

This is really helpful to view the manpage quickly while editing it.

patch presented on current-users@ and tech-userlevel@:
http://mail-index.netbsd.org/current-users/2009/10/06/msg010767.html
http://mail-index.netbsd.org/tech-userlevel/2009/10/06/msg002675.html

No objections

- use EXIT_FAILURE/EXIT_SUCCESS
- whitespace nits
- ansify cleanup()/usage()
- remove pointless parenthesis on return

branches: 1.37.4; 1.37.10;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.36.8;
Convert to using raise_default_signal(3).

branches: 1.35.4;
Since MAN_DEBUG is constant, go from if (MAN_DEBUG) to #if MAN_DEBUG

Coverity CID 2996: Don't return without closing fp.

modified man(1):
- avoid double slashes when displaying man pages (got tired
of '/usr/share/man//cat1/man.0').
- got rid of __P() while working on it.
- incorporate some of my old notes explaining how manpath works into the
comments of the code itself.
- renamed some of the vars so that the code is consistent throughout
(and hopefully clearer and easier to understand)
- fixed relative man paths for multiple man pages (man did a chdir()
on the first man page it had to format --- this broke any remaining
relative path man pages left to process). save old directory and
fchdir() back to it after formatting.
- improved doc on "man -h" which does more than just whatis(1) [e.g.
"man -h fopen" prints the required include files and the prototypes
rather than just the one-liner you get with whatis(1)]
- manconf.c now fills in the "len" length field in the TAG/ENTRY
structures (man now uses len).

revise man.conf file reading stuff to return error on failure in
addentry/gettag (fka getlist) rather than just err()ing out. this
allows man(1) to call cleanup and delete its tmp files rather than
just leave them floating. revise other apps using this code
(makewhatis, apropos, catman, whatis) to expect this. also remove
__P on updated files.

change an int to size_t

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

- getlist(): add "int create" arg, which creates list if it's not present
(using guts of now defunct addlist())
- use TAILQ_*() macros appropriately when manipulating tailqs

branches: 1.27.2;
Fix longstanding misuse of glob(3) and fnmatch(3) in man page search.
glob(3)-special characters are now escaped in the supplied man page names.

Makes ``man ['' work without mysterious quoting.

convert to use getprogname()

Allow "-s" to specify a section name, ala the SysV man command.
Unlike the SysV man command, this doesn't allow for the -s argument
to be a list.

check_pager() was using an uninitialized variable; fix it.

allow to specify relative paths for sections in man.conf - they are used
similarily to _subdir, but only when appropriate
fix -m handling, so that e.g. "man -m . 3 printf" works as it should
add new -S flag, to specify a string the result path has to contain
g/c some unused stuff

Written by Chuck Cranor, with only cosmetic changes & const poisoning by me.

branches: 1.22.2;
Use uname(3) to determine MACHINE type.

revert previous

remove superfluous '-' in getopt string

branches: 1.19.2;
Try $TMPDIR first, then fall back to _PATH_TMP.

A caught signal is blocked in the handler and
must be unblocked to do the default action.
The old code may generate weird exit status
on signals.

Remove temp file on SIGPIPE (such as "man sh | head").

Fall back to more(1) if PAGER is set but null.

branches: 1.15.2;
char -> unsigned char

We can't define MACHINE from a makefile in Rhapsody, because you might be cross
compiling, or building a fat (multi-architecture) binary. Our compiler
defines __ARCHITECTURE__ for this use.
Fixed an off-by-one error that may occasionally cause man to seg fault. Found
by using a special strict malloc() implementation.

Add { and } to shut up egcs. Reformat the more questionable code.

Since GLOB_NOCHECK is not set, explicitly check for a return value of
GLOB_NOMATCH from glob(). Noticed by Juergen Hannken-Illjes.

GLOB_QUOTE is dead; per POSIX, backslash quoting of special characters being
enabled is the default behaviour.

When man was "fixed" to chdir() to the man root as historical man does,
it broke the -M option on relative paths (the chdir works as it should,
but the relative man page path is still used whole in nroff). This
repairs the situation by chopping the full pathname in half--one part
for the chdir, one part for the filename.

branches: 1.9.2;
cleanup for WARNS=1

resize a pathname buffer to MAXPATHLEN; from Matthias Scheler in PR 4101

Sync with 4.4BSD-Lite2

Pay attention to the section number, even if MANPATH or -M is specified.

Sync with 4.4-Lite, plus local changes.

Fix from Christos Zoulas which makes relative paths in .so lines work when
man pages are formatted.

fix from bostic for multiple match problem

fix from Keith White <kwhite@csi.UOttawa.CA>, to DTRT when man -w's output
is redirected.

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic

kill redundant copy of src/etc/man.conf

branches: 1.1.1;
Initial revision

man.conf.5: improve wording on searching alternate machine paths

As requested by uwe@. Hopefully this is clearer now.

man.conf(5): Tweak formatting for prettier PS output.

man.conf.5: add details about the machine line and search order

Also, tweak some grammar, style, and markup while here.

Replace makewhatis(8) with makemandb(8) in SEE ALSO.

change _whatdb => _mandb as that is the correct keyword here,
and move it to the correct position in the list.

there is no more makewhatis; it has been replaced by makemandb

branches: 1.24.6;
Prefer Aq to \*[Lt] etc.

* adjust indentation of list block
* fix capitalization
* remove superfluous word ('The')

Patch supplied by Bug Hunting.

branches: 1.22.2;
document _machine

Document the reality that the _build and _crunch commands should each
contain exactly one "%s". The previous description allowed any number
of "%s" in the _build command, but that does not match the actual
behaviour of either man(1) or catman(8).

branches: 1.20.34;
Add "catman" to the SEE ALSO.

Bump date for previous.
New sentence, new line.
Remove trailing whitespace.

fix .Xr to invalid man page that i put in by mistake

rework the wording in these man pages (mainly in man.conf.5) based on
some old notes I found to make it clearer and easier to understand
how the man stuff works (hopefully!).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

New sentence, new line. Some mdoc cleanup.

Xr makewhatis 8, not 1.

xref makewhatis(8), it now uses man.conf too

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Sort sections.

Whitespace cleanup.

_whatdb has supported glob(3)ing pathnames for over 3 years ...

allow to specify relative paths for sections in man.conf - they are used
similarily to _subdir, but only when appropriate
fix -m handling, so that e.g. "man -m . 3 printf" works as it should
add new -S flag, to specify a string the result path has to contain
g/c some unused stuff

Written by Chuck Cranor, with only cosmetic changes & const poisoning by me.

branches: 1.7.2;
Typos (from OpenBSD)

branches: 1.6.4;
Document '_crunch' section.

branches: 1.5.2;
RCS Id Police.

fix up .Nm usage

Sync with 4.4-Lite, plus local changes.

fix slight docbug

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic

Check _build and _crunch commands with fmtcheck(3), warn about and
ignore bad ones.

WARNS=6
- fix cast qual issues
- don't use snprintf on a user-provided buffer

branches: 1.6.6; 1.6.28; 1.6.34;
pass lint, from anon ymous

branches: 1.5.12; 1.5.18;
modified man(1):
- avoid double slashes when displaying man pages (got tired
of '/usr/share/man//cat1/man.0').
- got rid of __P() while working on it.
- incorporate some of my old notes explaining how manpath works into the
comments of the code itself.
- renamed some of the vars so that the code is consistent throughout
(and hopefully clearer and easier to understand)
- fixed relative man paths for multiple man pages (man did a chdir()
on the first man page it had to format --- this broke any remaining
relative path man pages left to process). save old directory and
fchdir() back to it after formatting.
- improved doc on "man -h" which does more than just whatis(1) [e.g.
"man -h fopen" prints the required include files and the prototypes
rather than just the one-liner you get with whatis(1)]
- manconf.c now fills in the "len" length field in the TAG/ENTRY
structures (man now uses len).

revise man.conf file reading stuff to return error on failure in
addentry/gettag (fka getlist) rather than just err()ing out. this
allows man(1) to call cleanup and delete its tmp files rather than
just leave them floating. revise other apps using this code
(makewhatis, apropos, catman, whatis) to expect this. also remove
__P on updated files.

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

branches: 1.2.2;
Pull in config.h when building has a host tool.

Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

man: remove trailing whitespace

No binary change.

modified man(1):
- avoid double slashes when displaying man pages (got tired
of '/usr/share/man//cat1/man.0').
- got rid of __P() while working on it.
- incorporate some of my old notes explaining how manpath works into the
comments of the code itself.
- renamed some of the vars so that the code is consistent throughout
(and hopefully clearer and easier to understand)
- fixed relative man paths for multiple man pages (man did a chdir()
on the first man page it had to format --- this broke any remaining
relative path man pages left to process). save old directory and
fchdir() back to it after formatting.
- improved doc on "man -h" which does more than just whatis(1) [e.g.
"man -h fopen" prints the required include files and the prototypes
rather than just the one-liner you get with whatis(1)]
- manconf.c now fills in the "len" length field in the TAG/ENTRY
structures (man now uses len).

revise man.conf file reading stuff to return error on failure in
addentry/gettag (fka getlist) rather than just err()ing out. this
allows man(1) to call cleanup and delete its tmp files rather than
just leave them floating. revise other apps using this code
(makewhatis, apropos, catman, whatis) to expect this. also remove
__P on updated files.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

branches: 1.1.2;
Rename man/config.{c,h} to man/manconf.{c,h}, so we don't have to
worry about problems including "config.h" when building as a host
tool.

put back _PATH_WHATIS, it is used.

Remove unused include and unused constant. Ok from christos@.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Try $TMPDIR first, then fall back to _PATH_TMP.

branches: 1.3.8;
Sync with 4.4BSD-Lite2

Sync with 4.4-Lite, plus local changes.

branches: 1.1.1;
add man(1) ; part of new man(1) package from Bostic