bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

convert HAVE_GCC == 7 to HAVE_GCC >= 7.

- use -Wno-error=format-truncation

branches: 1.11.76;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Make gcc 2.96 (and maybe earlier) happier. Include <stdlib.h>,<string.>,
etc. as appropriate to get exit,srncmp,abs,abort,etc.
Add -I${.CURDIR} to a few Makefiles

.y.c <sys.mk> rule fixes. Don't create a y.tab.h file unless asked for,
and use smarter creation of the header file.

merge lite-2.

Don't need -I${.CURDIR}

rdist is no longer setuid root.

branches: 1.5.2;
RCS id police.

From Christos: kill the last bits of sprintf(), and use regcomp/regexec
rather than re_comp/re_exec. (I committed my sprintf sweep-up before
I realized that Christos had already done it...)

branches: 1.3.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

RCS ID police

update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

branches: 1.1.1;
Initial revision

Use __dead and __printflike.

Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.17.30;
Coverity CID 2341, 2342: Plug memory leak.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Avoid confict with reserved identifier "log".

Remove #if __STDC__. De-__P() and ANSIfy.

branches: 1.13.2;
More format string cleanup by sommerfeld.

branches: 1.12.2; 1.12.10;
de-ja-vous
This thing was still using <sys/dir.h> and struct direct.
Get rid of the time warp.

Include <time.h>, needed for various definitions.

Use S_IS*(), not S_IF*.

Use S_IS*().
Use mode_t, uid_t, and gid_t as appropriate.
Don't use futimes(2) on a directory.

merge lite-2.

RCS id police.

From Christos: kill the last bits of sprintf(), and use regcomp/regexec
rather than re_comp/re_exec. (I committed my sprintf sweep-up before
I realized that Christos had already done it...)

branches: 1.5.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Use <dirent.h> instead of <sys/dir.h>.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

more clobbering fixes.

fix clobbered variable

branches: 1.28.6; 1.28.12;
Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.27.20;
From Anon Ymous:
Convert "(void)&" constructs to "volatile".
Check gid against (gid_t)-1 rather than >= 0; gid_t is unsigned.
Flag some parameters __unused so this will compile with -Werror.

Append only '@host' to notify email addresses when the destination
host is of the format 'login@host'. Fixes PR 14412; reviewed by
<christos>.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

strlcpy

Avoid confict with reserved identifier "log".

Remove #if __STDC__. De-__P() and ANSIfy.

branches: 1.20.4;
apply patches in PR bin/9249: rdist doesn't remove temporary file, from
<Michael.Eriksson@era-t.ericsson.se> to ensure we always remove the tempfile
(broken since mkstemp() was introduced).

branches: 1.19.6;
check some more syscall return values. use mkstemp.

de-ja-vous
This thing was still using <sys/dir.h> and struct direct.
Get rid of the time warp.

Fix more borken compiler lossage, this time for m68k.

branches: 1.16.2;
fix compile warnings on the alpha.

Output the right file name in an error message.
Also a cosmetic change; pass a null pointer to gettimeofday() for the
time zone info.

Use S_IS*().
Use mode_t, uid_t, and gid_t as appropriate.
Don't use futimes(2) on a directory.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

Pr/4180: Erik Bertelsen: rdist does not produce intelligible error messages
and core dumps when the remote host is down:
- avoid core dumps by checking lfp before using it.
- use rcmd's err descriptor to grab and print the message.

call regfree() -- closes pr bin/2691.
Bug noticed and fixed by Charles Amos <amos@umiacs.umd.edu>
Submitted by Mike Grupenhoff

RCS id police.

From Christos: kill the last bits of sprintf(), and use regcomp/regexec
rather than re_comp/re_exec. (I committed my sprintf sweep-up before
I realized that Christos had already done it...)

Use snprintf() whenever feasible.

branches: 1.6.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

mixing setreuid and seteuid can really screw you, in terms of security

Use <dirent.h> instead of <sys/dir.h>.

merge in changes from netbsd-0-9-ALPHA2

Add RCS identifiers.

branches: 1.1.1;
Initial revision

avoid having addresses of local variable exist after a function returns.

found by GCC 12.

Delete unused static smatch() function.
Inspired by PR 41255 from Kurt Lidl (which used #if 0 instead of
deleting the function).

Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.16.42;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Remove #if __STDC__. De-__P() and ANSIfy.

de-ja-vous
This thing was still using <sys/dir.h> and struct direct.
Get rid of the time warp.

Add { and } to shut up egcs. Reformat the more questionable code.

Use S_IS*(), not S_IF*.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

NULL => 0 (Arne Juul; PR#3629)

RCS id police.

Use snprintf() whenever feasible.

branches: 1.5.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Use <dirent.h> instead of <sys/dir.h>.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.13.46;
Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.12.30;
Coverity CID 2341, 2342: Plug memory leak.

Don't compare a char to NULL.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #if __STDC__. De-__P() and ANSIfy.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

When iterating the host list, do not access memory that has just been
free()'d. From Matt Beal <beal@umiacs.umd.edu>, PR #2747.

RCS id police.

From Christos: kill the last bits of sprintf(), and use regcomp/regexec
rather than re_comp/re_exec. (I committed my sprintf sweep-up before
I realized that Christos had already done it...)

branches: 1.3.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.8.42;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove #if __STDC__. De-__P() and ANSIfy.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

RCS id police.

Use snprintf() whenever feasible.

branches: 1.3.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

fix various typos, mainly s/trasfering/transferring/ and s/theese/these/.

Use __dead and __printflike.

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.18.22;
Coverity CID 2341, 2342: Plug memory leak.

Sync usage with man page (add [login@], sort options, machine -> host);
print usage to stderr; use getprogname(3).
From Kouichirou Hiratsuka in PR 26225.

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

Remove #if __STDC__. De-__P() and ANSIfy.

Fix incorrect usage message. Problem noted by Brian Ginsbach in
PR bin/14411.

apply patches in PR bin/9249: rdist doesn't remove temporary file, from
<Michael.Eriksson@era-t.ericsson.se> to ensure we always remove the tempfile
(broken since mkstemp() was introduced).

branches: 1.10.6;
check some more syscall return values. use mkstemp.

ensure buffers for pathnames, etc., are PATH_MAX, etc., long.

Use S_IS*().
Use mode_t, uid_t, and gid_t as appropriate.
Don't use futimes(2) on a directory.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

RCS id police.

branches: 1.4.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

mixing setreuid and seteuid can really screw you, in terms of security

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

RCS id police.

branches: 1.3.8;
update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove workaround for ancient HTML generation code.

Fix whitespace nits. Suggested by Bug Hunting.

branches: 1.19.6;
Nesting displays is not valid groff syntax.

Sort options in SYNOPSIS. From Kouichirou Hiratsuka in PR 26225.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

New sentence, new line.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Edit -mdoc usage.

* There is no -indent option to .Bd or .Bl, although you would
never know that from its frequent use in this tree. There is a
"-offset indent" combination that makes sense, and you can certainly
say "-width indent".

* Also, you can't markup the -width option argument, tho you CAN
use a callable macro. So "-width Ar filename" doesn't make sense,
but either "-width Ar" or "-width filename" does, as might something
like "-width xxfilename" for a little extra space.

* There are a lot of needlessly complex hanging tag macros in man4 used
to create simple item lists. Those should be simplified one of these
days before someone copies and edits yet another man4 page.

Sort SEE ALSO, sort sections, punctuation nit.

Add missing description of option "-D".

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

RCS id police.

branches: 1.6.8;
re-fix spelling errors. going to kick them back to bostic...

update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Fix spelling errors.

Add RCS indentifiers.

Update file names.

branches: 1.1.1;
Initial revision

s/creat /create/ in few more comments and error log messages.

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.32.26;
remove unused

branches: 1.31.6; 1.31.12;
Fix WARNS=4 issues (-Wshadow -Wcast-qual -Wsign-compare)

branches: 1.30.20;
From Anon Ymous:
Convert "(void)&" constructs to "volatile".
Check gid against (gid_t)-1 rather than >= 0; gid_t is unsigned.
Flag some parameters __unused so this will compile with -Werror.

end the argument list to exec*(3) with a NULL instead of a bare '0', as
the latter isn't a pointer context in these varargs functions.

Patch from Olaf Siebert in PR 12688 to handle hard links correctly when
renaming.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use bounded string op

The Double-Semi-Colon Police.

Avoid confict with reserved identifier "log".

Remove #if __STDC__. De-__P() and ANSIfy.

branches: 1.22.2;
va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

heirarchy -> hierarchy

use %ll_ instead of the less standard %q_

More format string cleanup by sommerfeld.

branches: 1.18.8;
check some more syscall return values. use mkstemp.

branches: 1.17.2;
char -> unsigned char

de-ja-vous
This thing was still using <sys/dir.h> and struct direct.
Get rid of the time warp.

fix compile warnings on the alpha.

Use S_IS*().
Use mode_t, uid_t, and gid_t as appropriate.
Don't use futimes(2) on a directory.

WARNSify, fix .Nm usage, deprecate register, s/[br]*/[ms]*/

merge lite-2.

RCS id police.

From Christos: kill the last bits of sprintf(), and use regcomp/regexec
rather than re_comp/re_exec. (I committed my sprintf sweep-up before
I realized that Christos had already done it...)

Use snprintf() whenever feasible.

branches: 1.8.2;
in recvf() initialise the fd to -1 so that we can not close it later
if it was never used (for e.g., with symlinks). pr#1822.

kill some now-unnecessary casts.

cast so size/mtime doesn't get hosed

update to newest rdist from berkeley (via uunet). No security fixes, but
general cleanup.

Use <dirent.h> instead of <sys/dir.h>.

get rid of some (bad) setreuid() calls, which caused a security problem.
bug fix from Rick J Weldon <rick@badboy-jr.hq.af.mil>, and also confirmed
by looking at the latest rdist sources.

Add RCS identifiers.

branches: 1.1.1;
Initial revision