bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

Add ${LIBUTIL} to DPADD.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

convert HAVE_GCC == 7 to HAVE_GCC >= 7.

- use -Wno-error=format-truncation

branches: 1.40.14;
for 64 bit mips platforms where we built userland largely as n32 by
default, build a handful of tools as n64 so they work properly.

unfortunately, they're also static as dynamic n64 has a problem.

of these tools pstat is probably the lowest hanging fruit to convert
to sysctl. systat would be close were it not for the netstat screen,
which includes netstat itself.

the rest are difficult to perhaps foolish.


the upside is that netstat, pmap and fstat all work properly now.

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.38.2;
Define _KERNTYPES for things that need it.

kill ipsec support which hasn't been working for a long time
(neither for KAME nor for FAST_IPSEC)

branches: 1.36.6;
When using -lcurses, you also need -lterminfo.
This fixes the build for sun2, and also builds with LDSTATIC=-static,
since archive libraries don't record inter-library dependencies.

Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.34.20;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Include code to display per system call counts and times.

Update to use new kernel io statistics.

Add tape statistics.

WARNS=3

Add "df" display to give information about filesystems, available diskspace
and used disk capacity, similar to df(1):

Filesystem Avail Capacity
/0% /10% /20% /30% /40% /50% /60% /70% /80% /90% /100%
/ 359M |XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
/tmp 180M |
/home 146G |XXXXXXXXXXXXXXXX

Only compile in IPv6 support if ${USE_INET6} != "no"

MKINET6 is for providing IPv6 infrastructure.
USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6).

makefile delint. use NETBSDSRCDIR as appropriate

introduce puthumanint() which calls humanize_number(), and use to
display disk transfer values (Suggested by Simon Burge). Also clip
%busy to 100 and display as an int which has the useful side effect
of stopping it overflowing into the next column (100.0).

scan utmpx/utmp.

branches: 1.24.2;
Remove check for sparc64 which adds -msoft-quad-float as that is now the
default for the compiler on sparc64.

use -msoft-quad-float on the sparc64.

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

support IPv6. commands under "netstat" are IPv6 ready.
IPv6 is supported by filters (":ignore ssh") as well.
TODO: do something about line truncation?
TODO: inet6.icmp6? ":help" will not fit into single line...

Rototill global command matching -- switch from ad-hoc tomfoolery to a
table lookup. This will make prefix matching and so on easier.

Expect a similar change for mode-specific commands before too long.

While there, rename some structures with misleading names.

Watch this space for more changes soon.

- Add `bufcache' display which shows buffer cache usage per filesystem,
ala the monitor(1) command for Ultrix.
- Allow `h' or `?' to show the command list (same as `:help').
- Sort commands in cmdtab.c and systat.1

branches: 1.18.4;
the PMAP_NEW option is gone as the new interface is no longer optional.

Add 4 new modes: ip, icmp, tcp, tcpsyn. XXX still some work to be done
on aesthetics and update modes.

also install as `sysstat'.
rationale: `nfsstat' is not `nfstat', and
other systems have a `sysstat' but not a `systat'.

completely remove Mach VM support. all that is left is the all the
header files as UVM still uses (most of) these.

Add a new `ps' view to systat, which shows process information. This
view is identical to the output of `ps aux' except that a.) the RSS and VSZ
fields are one character wider and b.) it shows a zero value for the RSS
and %MEM columns of processes which report a negative RSS.

Simply include -lcurses instead of -lcurses -ltermcap

add -DPMAP_NEW if PMAP_NEW is on in mk.conf

add -DUVM to CPPFLAGS if defined(UVM)

use CPPFLAGS instead of CFLAGS

branches: 1.9.2;
fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

WARNS?=1

Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Update Makefiles for usr.bin/systat and usr.sbin/iostat to be
consistent with usr.bin/vmstat/Makefile wrt CLFAGS and -I, since
all three compile vmstat/names.c. (Now compiles on a pmax.)

Alphabetize.

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

increase slot slop space from 100 to 1000 before giving up.

from Paul Ripke on current-users. thanks!

Extend "systat vm" output to provide better insight about buffercache and
document it.

From Greg A. Woods in PR bin/36542

branches: 1.28.4; 1.28.6;
rearrange sys/mount.h so that all of the kernel-only parts are together
and not exposed to userland, except do expose struct mount if __EXPOSE_MOUNT
is defined. define __EXPOSE_MOUNT in the kmem grovellers that want
the definition. needed for ZFS.

sysctlbyname is convenient, but ain't cheap. Cache it.

branches: 1.26.8;
fix unused variable warnings

bufmem is unsigned.

Fix format string to resolve build break

use more sysctl

branches: 1.22.4; 1.22.26;
Remove clause 3 and 4 from TNF licenses

branches: 1.21.4;
specfs changes for PR kern/37717 (raidclose() is no longer called on
shutdown). There are still problems with device access and a PR will be
filed.

- Kill checkalias(). Allow multiple vnodes to reference a single device.

- Don't play dangerous tricks with block vnodes to ensure that only one
vnode can describe a block device. Instead, prohibit concurrent opens of
block devices. As a bonus remove the unreliable code that prevents
multiple file system mounts on the same device. It's no longer needed.

- Track opens by vnode and by device. Issue cdev_close() when the last open
goes away, instead of abusing vnode::v_usecount to tell if the device is
open.

branches: 1.20.8;
use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Show more information about page types in use, and free pages.

"bufmem" is unsigned long inside the kernel, so don't try to grovel it out
of kmem as a unsigned int.
Also avoid overrunning VCACHE_SIZE, thus scribling over unrelated memory.
Fixes PR port-sparc64/25537.

branches: 1.16.2;
Add PTRTOUINT64() and UINT64TOPTR() macros to sys/sysctl.h for use by
kern.proc, kern.proc2, kern.lwp, and kern.buf.

Define more MIB for kern.buf so that specific buffers can be selected
(only all/all is supported right now), and use a 32/64 bit agnostic
structure for communcating buffer information to userland.

Convert systat to the new kern.buf method.

Clean up the vm.buf* handling a little. There's no actual need to
record the dynamically assigned OIDs, since sysctl_data can tell us
what we're looking at.

Oh, and fix a typo in a comment.

Adapt to kernel buffer cache memort allocation changes.

Since the buffer headers do no longer exist as an array in the kernel anymore,
use the new CTL_KERN.KERN_BUF mib to fetch them from kernel space.

Also look at a vnode's specinfo field to properly associate an opened
block device special file with a mounted filesystem.

- avoid coredump by returning NULL when read fails and don't keep following
the list.
- avoid zerodivide.
XXX: still does not work, but at least it does not core-dump.

Create subwins that end one line from the bottom of the screen even
after the window is resized.

branches: 1.12.2;
replace "vnode" and "vtext" with "file" and "exec" in uvmexp field names.

Show pages used by executables.
Align the numbers in the summary lines.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

Show the vnode page cache memory usage on the "bufcache" display.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.7.4;
Fix arguments to *printw().

Prevent percentage overflows by keeping score in kilobytes.

branches: 1.5.2;
Fix error handling throughout. First off, it is not true as claimed in swap.c
that `systat doesn't handle errors'. Second off, errx should not be used directly, since
the terminal should be cleaned up before bailing. Third off, whatever we do we need
to be consistent.

There, I feel better now.

add some percentages in here.

Don't free "buf" in closebufcache() - initbufcache() only gets called
once per systat invocation, not each time we switch to the bufcache
display.

Fixes core dump noted by Andy Doran when switching back and forth to
bufcache display.

avoid using CLBYTES (which is based on NBPG).

- Add `bufcache' display which shows buffer cache usage per filesystem,
ala the monitor(1) command for Ultrix.
- Allow `h' or `?' to show the command list (same as `:help').
- Sort commands in cmdtab.c and systat.1

allow fractional intervals

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.28.74;
Add (unsigned char) cast to ctype functions
Although, IIRC, there is another PR on all commands being converted to
lower case.

Using timeout() to control refresh gets rid of a whole pile of signal-related
lossage.
Making ungetch() signal-safe, as ncurses seems to, would be better, though.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Ignore null commands, instead of inventing a bogus match. See PR 10596.
- In switch_mode(), display status line even if switching to the same mode.

Add "all" mode to systat to cycle between all modes,
sort of like VMS' "MONITOR ALL"-command.

Code was submitted by Jarkko Teppo <jate@uwasa.fi> in PR 10851,
cleaned up and added 'turns' handling by me.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.21.2;
Fix bogons in command parsing for >1 arg.

branches: 1.20.2;
Two UI changes:

a.) restore the capability to enter a substring of a mode or command
name. Pointed out by Soren Jorvang.

b.) (capital) Q now exits systat immediately

don't choke on non-INET6 kernel, or non-IPSEC kernel.
cleanup error handling on mode change failure.

TODO: non-IPv4 kernel support should be improved. "netstat" should be okay,
"inet.ip" and "inet.icmp" needs more trick.

NetBSD PR: 9157

Fix error handling throughout. First off, it is not true as claimed in swap.c
that `systat doesn't handle errors'. Second off, errx should not be used directly, since
the terminal should be cleaned up before bailing. Third off, whatever we do we need
to be consistent.

There, I feel better now.

Nuke assignment unneeded after last commit

More cleanup -- use strtok() rather than rolling our own not-quite-correct version.

G/C function used in old command parsing

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

End special-casing of `start' and `interval' global commands.
Vastly simplify handling of mode switches, and short-syntax interval
changes. Substring matching of mode names and commands will come
shortly, however the previous method of substring matching modes (it was
not available for commands) is currently not working.

TODO: implement table lookups for mode-specific commands.

Handle arguments to global commands. Note that the `interval' and
`start' global commands are still special cased, which will change

Rototill global command matching -- switch from ad-hoc tomfoolery to a
table lookup. This will make prefix matching and so on easier.

Expect a similar change for mode-specific commands before too long.

While there, rename some structures with misleading names.

Watch this space for more changes soon.

branches: 1.10.4;
Fix from PR7655: translation of keyboard command in systat is Wrong.
(breaks netstat's :ignore command for upper-case service names)

branches: 1.9.2;
char -> unsigned char

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

* revert broken handling of subcommands to the (working) 4.4Lite version.

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Sync with 4.4lite2

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Extend "systat vm" output to provide better insight about buffercache and
document it.

From Greg A. Woods in PR bin/36542

branches: 1.25.12; 1.25.14;
PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.24.22;
kill ipsec support which hasn't been working for a long time
(neither for KAME nor for FAST_IPSEC)

branches: 1.23.34;
Include code to display per system call counts and times.

use c99 initializers
consistently terminate nlist arrays with NULL not ""

Always treat ^h and ^? as erase chars (as well as stty erase).
Make the ':' erasable.
Fix typo in unviewable help message.
No point in having 'else' after 'return'...

Add "df" display to give information about filesystems, available diskspace
and used disk capacity, similar to df(1):

Filesystem Avail Capacity
/0% /10% /20% /30% /40% /50% /60% /70% /80% /90% /100%
/ 359M |XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
/tmp 180M |
/home 146G |XXXXXXXXXXXXXXXX

WRT disk commands, make the man page consistent with the program, and add the
feature I expected.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

iostat(8) and systat(8) support for separate read/write disk statistics.
"iostat -x" now shows these (ala linux/solaris), but this is only splitting
the read/write bytes/transactions, not adding any new metrics. "systat
iostat" now has two new commands to switch between combined/separate mode
for both it's numbers & bar modes.

branches: 1.16.2;
- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.15.4;
Reorder two commands so that substring matching doesn't make one shadow
the other.

Two UI changes:

a.) restore the capability to enter a substring of a mode or command
name. Pointed out by Soren Jorvang.

b.) (capital) Q now exits systat immediately

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

* Fix a display buglet: if the process list is exhausted before the window's
bottom is reached, clear the remaining lines, lest there be stale process
entries if the process list shrinks.
* Implement a top(1)-like `user' command in the ps display.

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

End special-casing of `start' and `interval' global commands.
Vastly simplify handling of mode switches, and short-syntax interval
changes. Substring matching of mode names and commands will come
shortly, however the previous method of substring matching modes (it was
not available for commands) is currently not working.

TODO: implement table lookups for mode-specific commands.

Rototill global command matching -- switch from ad-hoc tomfoolery to a
table lookup. This will make prefix matching and so on easier.

Expect a similar change for mode-specific commands before too long.

While there, rename some structures with misleading names.

Watch this space for more changes soon.

- Add `bufcache' display which shows buffer cache usage per filesystem,
ala the monitor(1) command for Ultrix.
- Allow `h' or `?' to show the command list (same as `:help').
- Sort commands in cmdtab.c and systat.1

branches: 1.7.4;
Add 'inet.' prefix to 'tcp', 'ip', 'tcpsyn' and 'icmp' displays.
Fixes PR: bin/8130 (Geoff C. Wing)

Add 4 new modes: ip, icmp, tcp, tcpsyn. XXX still some work to be done
on aesthetics and update modes.

Add a new `ps' view to systat, which shows process information. This
view is identical to the output of `ps aux' except that a.) the RSS and VSZ
fields are one character wider and b.) it shows a zero value for the RSS
and %MEM columns of processes which report a negative RSS.

- some KNF.
- use __RCSID().
- WARNS=1

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

branches: 1.2.2;
Add $NetBSD$ tag for new files

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.2.2;
Add $NetBSD$ tag for new files

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

Appease gcc 4.x

Don't show ptyfs in the display, it's useless.

WARNS=3

Add "df" display to give information about filesystems, available diskspace
and used disk capacity, similar to df(1):

Filesystem Avail Capacity
/0% /10% /20% /30% /40% /50% /60% /70% /80% /90% /100%
/ 359M |XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
/tmp 180M |
/home 146G |XXXXXXXXXXXXXXXX

Undo previous "restore lost break" and fix the issue that seems to
have been intending to correct properly (or at least, more rationally).

This makes adding/deleting drives for "vmstat" (and "iostat", though
the man page doesn't say that it also works there) using the :display
:ignore and :drive sub-commands work sensibly using fnmatch()
rather than what was there most of the time since it was added.

Previously ":ignore dk*" would ignore the first dk (wedge) found in
the system (whether or not it was ignored already) and that was it.
[":ignore dk* dk*" would just do that twice.]

Now the same command will ignore all dk* drives (all wedges), which
is what I would anticipate almost anyone would expect it to do.

Similarly for ":display" (to add drives) and ":drives" to explictly
list particular ones.

When the fnmatch() code was added, almost 9 and a half years ago now,
it was almost correct - except always resulted in an error occurring
(though that was little more than a minor inconvenience).

That was "fixed" 5 months later (9 years and almost a month ago now)
with the cvs log message "restore lost break" - which was absolutely
the wrong thing to do (the break was fine when no patterns were used,
and so a name could only ever match one drive - but wrong when the
whole point is to match many).

Somehow in the past 9+ years, no-one noticed that this functionality
had been rendered almost useless.

While here, fix a related problem ... just above I referred to the
error that occurred as a "minor inconvenience" - that's because while
an error would be shown on the screen, it would then immediately be
removed again, an observant user might notice the quick flash, but
that would be it.

Handle that by detecting whether any changes are actually made, and
don't go completely redrawing the screen (removing the error message
that was just placed there) if there is no point. This doesn't
entirely fix this problem, as if we do

:drives foo wd*

and there is no "foo" drive in the system, we'd get an error message
from that, but adding the wd* drives (assuming there are some, of course)
counts as a change, so that error message will still not last very long.
The order of that command line makes no difference, it isn't that wd drives
were found after foo wasn't, but that the whole line matched (at least one)
drive (and changed its state - for the "drives" command, that is equivalent
to matched) - but also contained an entry which did not match at all.
That's a harder problem to fix.

No pullups planned, as no-one seems to mind how it has been all this time.

Restore lost break.

Make :drives, :display, :ignore accept fnmatch(3) patterns to specify drives.
Bump man page date.

branches: 1.17.6; 1.17.12;
Fix -Wsign-compare issues

branches: 1.16.30;
Update to use new kernel io statistics.

Refresh labels and display after changing displayed disks

WRT disk commands, make the man page consistent with the program, and add the
feature I expected.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.10.2;
Fix bogons in command parsing for >1 arg.

branches: 1.9.2;
Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

branches: 1.8.6;
char -> unsigned char

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Removed a couple of #ifdef vax causing systat to malfunction.

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Adjust userland commands for struct inpcb integration

Only kvm users are affected.

PR/56331: Paul Goyette: Add -z option to display 0 instead of ' ' in vmstat.

PR/53906: Paul Ripke: systat(1) vmstat & syscall get
"alternate system clock has died" on terminal resize (SIGWINCH)

branches: 1.46.6; 1.46.12; 1.46.14;
allow fractional intervals

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.44.2;
if you change display types, the "Showing %s, refresh every %d seconds."
message is retained, and you can't get rid of it. since it's dispalyed
in inverse, it feels like there's always an error happening (which is
really what the code has -- the above string is displayed via the error()
function.) for several types of key press that largely are just "redraw"
operation (space, ^L, etc.), clear the error string as well.

Always use_sysctl in preparation of removing all kvm code.

branches: 1.42.6; 1.42.16;
kill ipsec support which hasn't been working for a long time
(neither for KAME nor for FAST_IPSEC)

branches: 1.41.2;
Consistently use __dead and __printflike.

Use sysctl to fetch network statistics unless a memory file is specified
on the command line.

Update for ICMP and UDP stats changes.

don't call curses from a signal handler!

branches: 1.37.4;
Include code to display per system call counts and times.

branches: 1.36.12; 1.36.14;
WARNS=3

Add "df" display to give information about filesystems, available diskspace
and used disk capacity, similar to df(1):

Filesystem Avail Capacity
/0% /10% /20% /30% /40% /50% /60% /70% /80% /90% /100%
/ 359M |XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
/tmp 180M |
/home 146G |XXXXXXXXXXXXXXXX

A __attribute__((__noreturn__)) function better be void - gcc correctly
complains at >= -O3 otherwise.

be more descriptive about what failed by printing the errno and the
variable we were trying to fetch.

WRT disk commands, make the man page consistent with the program, and add the
feature I expected.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

mark nlisterr() as 'noreturn'

Make kernel address arg of kvm_ckread() const void * so caller doesn't
need a cast.
(approved by christos)

iostat(8) and systat(8) support for separate read/write disk statistics.
"iostat -x" now shows these (ala linux/solaris), but this is only splitting
the read/write bytes/transactions, not adding any new metrics. "systat
iostat" now has two new commands to switch between combined/separate mode
for both it's numbers & bar modes.

branches: 1.27.2;
Fetch maxslp from the kernel. Only use USPACE if it's defined.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

More format string cleanup by sommerfeld.

Add "all" mode to systat to cycle between all modes,
sort of like VMS' "MONITOR ALL"-command.

Code was submitted by Jarkko Teppo <jate@uwasa.fi> in PR 10851,
cleaned up and added 'turns' handling by me.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.22.2;
Use kern.cp_time to fetch cp_time[]. Don't support fetching it from
crash dumps yet, as that requires determining which CPU we should fetch
it from, etc.

branches: 1.21.2;
- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

add command line -n flag, which is same as "netstat numbers".
without it, we can't disable name resolution before the resolution starts.

support IPv6. commands under "netstat" are IPv6 ready.
IPv6 is supported by filters (":ignore ssh") as well.
TODO: do something about line truncation?
TODO: inet6.icmp6? ":help" will not fit into single line...

GC now-spurious prototype

* Fix a display buglet: if the process list is exhausted before the window's
bottom is reached, clear the remaining lines, lest there be stale process
entries if the process list shrinks.
* Implement a top(1)-like `user' command in the ps display.

G/C function used in old command parsing

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

End special-casing of `start' and `interval' global commands.
Vastly simplify handling of mode switches, and short-syntax interval
changes. Substring matching of mode names and commands will come
shortly, however the previous method of substring matching modes (it was
not available for commands) is currently not working.

TODO: implement table lookups for mode-specific commands.

Handle arguments to global commands. Note that the `interval' and
`start' global commands are still special cased, which will change

Rototill global command matching -- switch from ad-hoc tomfoolery to a
table lookup. This will make prefix matching and so on easier.

Expect a similar change for mode-specific commands before too long.

While there, rename some structures with misleading names.

Watch this space for more changes soon.

- Add `bufcache' display which shows buffer cache usage per filesystem,
ala the monitor(1) command for Ultrix.
- Allow `h' or `?' to show the command list (same as `:help').
- Sort commands in cmdtab.c and systat.1

branches: 1.10.4;
Add 4 new modes: ip, icmp, tcp, tcpsyn. XXX still some work to be done
on aesthetics and update modes.

Kill incorrect const in previous.

Functional LP64 and type sanity fixes.

branches: 1.7.2;
Add a new `ps' view to systat, which shows process information. This
view is identical to the output of `ps aux' except that a.) the RSS and VSZ
fields are one character wider and b.) it shows a zero value for the RSS
and %MEM columns of processes which report a negative RSS.

Fix handling of privileges - the gid was given up before dkinit()
was called.
Pass the gid to use for KVM access explicitely to dkinit(), the caller
decides whether to call setgid(getgid()) or not.

- some KNF.
- use __RCSID().
- WARNS=1

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Fix -Wsign-compare issues

branches: 1.12.42;
be more descriptive about what failed by printing the errno and the
variable we were trying to fetch.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Make kernel address arg of kvm_ckread() const void * so caller doesn't
need a cast.
(approved by christos)

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

int vs. pointer format/argument confusion.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.6.2;
Use kern.cp_time to fetch cp_time[]. Don't support fetching it from
crash dumps yet, as that requires determining which CPU we should fetch
it from, etc.

branches: 1.5.6;
Functional LP64 and type sanity fixes.

branches: 1.4.2;
- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

- some KNF.
- use __RCSID().
- WARNS=1

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Correctly count number of chars output so that help isn't blank if the
terminal is too narrow.
Not ideal since the last command isn't shown on 80 column terminals.

Fix -Wsign-compare issues

branches: 1.13.30;
Rename 'cur' to 'name' to avoid aliasing a global - this code has some
horrid globals...

Always treat ^h and ^? as erase chars (as well as stty erase).
Make the ':' erasable.
Fix typo in unviewable help message.
No point in having 'else' after 'return'...

Using timeout() to control refresh gets rid of a whole pile of signal-related
lossage.
Making ungetch() signal-safe, as ncurses seems to, would be better, though.

error handling on strdup failure

branches: 1.9.2;
Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.7.4;
oops, avoid duplicate free().

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

branches: 1.5.2;
need <string.h> for strlen()

TNF copyright -- I will do the paperwork to give these over asap.

End special-casing of `start' and `interval' global commands.
Vastly simplify handling of mode switches, and short-syntax interval
changes. Substring matching of mode names and commands will come
shortly, however the previous method of substring matching modes (it was
not available for commands) is currently not working.

TODO: implement table lookups for mode-specific commands.

Handle arguments to global commands. Note that the `interval' and
`start' global commands are still special cased, which will change

Add a file missed in last commit

Always use_sysctl in preparation of removing all kvm code.

branches: 1.12.28; 1.12.40;
Don't even bother initializing the namelist if we're not going to use it.

Use sysctl to fetch network statistics unless a memory file is specified
on the command line.

Update for ICMP and UDP stats changes.

use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.4.2;
Use my proper name.

branches: 1.3.2;
Two tiny formatting nits in each file.

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

Add 4 new modes: ip, icmp, tcp, tcpsyn. XXX still some work to be done
on aesthetics and update modes.

branches: 1.2.2;
Add $NetBSD$ tag for new files

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

branches: 1.4.2;
Avoid string gymnastics in an olympic year.

Make this build with clang:
- Remove unused static const variables
- Adjust impossibleish comparision.

Add $NetBSD$ tag for new files

PR bin/51204

Add ifstat command to systat.

Imported from FreeBSD

PR/53906: Paul Ripke: systat(1) vmstat & syscall get
"alternate system clock has died" on terminal resize (SIGWINCH)

branches: 1.38.2; 1.38.4; 1.38.6;
Use I/O timestamps to compute disk statistics for better precisison.

branches: 1.37.38;
Fix -Wsign-compare issues

branches: 1.36.30;
Update to use new kernel io statistics.

Count both read bytes and write bytes when we are not showing separate read
and write statistics. Discovered by go.
Since I broke in in rev 1.31, I guess I'll fix it first!

Match changes to vmstat.c (splitting of dkreadstats).
Read tape stats if there are no disks found - is this possible?

Add tape statistics.

branches: 1.32.2;
Add an extra digit to the kBps column - now overflows at 100MB/s

Fix field widths for 'numbers' display, and allow it without 'secs'.

Uppercase CPU, plural is CPUs.

Correct boundary conditions for drive table for 'systat io num'.
Correct fix for bin/18823 (which was incomplete and wrong!)

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Create subwins that end one line from the bottom of the screen even
after the window is resized.

When disk activity exceeds 100kB/s divide length of bar by 10s and report
factor on RHS screen.
(approved by christos)

Prevent the "kBps" field from overflowing for values > 1M/s.

From Paul Shupak in PR 18822.

Remove extra args from a printf.

iostat(8) and systat(8) support for separate read/write disk statistics.
"iostat -x" now shows these (ala linux/solaris), but this is only splitting
the read/write bytes/transactions, not adding any new metrics. "systat
iostat" now has two new commands to switch between combined/separate mode
for both it's numbers & bar modes.

PR/18408: Chris Demetriou: Kilo is abbreviated using a small k not a CAPITAL K.

Since the KERN_CP_TIME sysctl reports total clock ticks across all
cpus and hz is measured in ticks per cpu, divide tick count by ncpu to
determine elapsed time since last sample.

Fixes I/O rate deflation observed on multiprocessors.

format fix in number mode. PR 16911

branches: 1.19.2; 1.19.4;
Make it compile (more vmstat fallout).

comment or delete text after CPP directives.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.15.2;
Use hline() and variants in a bunch of places.

Need to include <sys/sched.h> to get cp_time-related constants.

branches: 1.13.2;
Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

branches: 1.12.4;
Enlarge disk names in labels from 3 to 7 to cater for things like raid0.

Fix handling of privileges - the gid was given up before dkinit()
was called.
Pass the gid to use for KVM access explicitely to dkinit(), the caller
decides whether to call setgid(getgid()) or not.

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Use the new getmaxx and getmaxy macros instead of directly accessing
the private fields of WINDOW.

Be explicit about iostat transfer rate by displaying `KBps' instead of
`Kps'. As per (and noticed by) J.T.

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Removed a couple of #ifdef vax causing systat to malfunction.

Print out interrupt CPU time.

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Always use_sysctl in preparation of removing all kvm code.

branches: 1.17.28; 1.17.40;
Don't even bother initializing the namelist if we're not going to use it.

Use sysctl to fetch network statistics unless a memory file is specified
on the command line.

Change IP stats from a structure to an array of uint64_t's.

Note: This is ABI-compatible with the old ipstat structure; old netstat
binaries will continue to work properly.

Update for ICMP and UDP stats changes.

use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Create subwins that end one line from the bottom of the screen even
after the window is resized.

branches: 1.10.2;
receive, not recieve

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.7.2;
Use my proper name.

branches: 1.6.2;
u_quad_t must be cast to (long long) to be printed with %llu.

Two tiny formatting nits in each file.

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

fix printf format for inet.ip
(because the entries in struct ipstat is u_quad_t)

Formatting nits.

Add 4 new modes: ip, icmp, tcp, tcpsyn. XXX still some work to be done
on aesthetics and update modes.

Always use_sysctl in preparation of removing all kvm code.

branches: 1.15.28; 1.15.40;
Don't even bother initializing the namelist if we're not going to use it.

Use sysctl to fetch network statistics unless a memory file is specified
on the command line.

Change IPv6 stats from a structure to an array of uint64_t's.

Note: This is ABI-compatible with the old ip6stat structure; old netstat
binaries will continue to work properly.

use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Don't try to use CPP token pasting to somehow 'stick' structure member
names on to the -> or . before them. There's no need to, and it's not
actually the right thing!

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

repair inet6.ip6 stat (broken in 1.4 -> 1.5).

remove pulldown statistics

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.4.2;
Use my proper name.

branches: 1.3.2;
Two tiny formatting nits in each file.

don't choke on non-INET6 kernel, or non-IPSEC kernel.
cleanup error handling on mode change failure.

TODO: non-IPv4 kernel support should be improved. "netstat" should be okay,
"inet.ip" and "inet.icmp" needs more trick.

NetBSD PR: 9157

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

kill ipsec support which hasn't been working for a long time
(neither for KAME nor for FAST_IPSEC)

branches: 1.10.4;
Make IPSEC and FAST_IPSEC stats per-cpu. Use <net/net_stats.h> and
netstat_sysctl().

branches: 1.9.16;
use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.4.2;
Use my proper name.

branches: 1.3.2;
Two tiny formatting nits in each file.

don't choke on non-INET6 kernel, or non-IPSEC kernel.
cleanup error handling on mode change failure.

TODO: non-IPv4 kernel support should be improved. "netstat" should be okay,
"inet.ip" and "inet.icmp" needs more trick.

NetBSD PR: 9157

- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

if you change display types, the "Showing %s, refresh every %d seconds."
message is retained, and you can't get rid of it. since it's dispalyed
in inverse, it feels like there's always an error happening (which is
really what the code has -- the above string is displayed via the error()
function.) for several types of key press that largely are just "redraw"
operation (space, ^L, etc.), clear the error string as well.

No David, '\?' is not the del character. Broken in rev 1.21.
XXX pullup-5, pullup-6.

branches: 1.24.10; 1.24.26; 1.24.28; 1.24.32;
don't call curses from a signal handler!

branches: 1.23.6; 1.23.8; 1.23.12;
quell GCC 4.1 uninitialised variable warnings.

XXX: we should audit the tree for which old ones are no longer needed
after getting the older compilers out of the tree..

WARNS=3

Always treat ^h and ^? as erase chars (as well as stty erase).
Make the ':' erasable.
Fix typo in unviewable help message.
No point in having 'else' after 'return'...

Add (unsigned char) cast to ctype functions
Although, IIRC, there is another PR on all commands being converted to
lower case.

Whoops, make "all" work again.

Using timeout() to control refresh gets rid of a whole pile of signal-related
lossage.
Making ungetch() signal-safe, as ncurses seems to, would be better, though.

Use KEY_RESIZE. Might as well have something in our source tree that does.

A __attribute__((__noreturn__)) function better be void - gcc correctly
complains at >= -O3 otherwise.

Allow lower case 'q' to quit.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.11.4;
Two UI changes:

a.) restore the capability to enter a substring of a mode or command
name. Pointed out by Soren Jorvang.

b.) (capital) Q now exits systat immediately

Fix error handling throughout. First off, it is not true as claimed in swap.c
that `systat doesn't handle errors'. Second off, errx should not be used directly, since
the terminal should be cleaned up before bailing. Third off, whatever we do we need
to be consistent.

There, I feel better now.

Be consistent about whether to block SIGALRM before calling command() -- don't
ever do so, as the first thing command() does is block SIGALRM.

1.) Clean up keystroke processing
2.) Add the all-time most requested feature: hitting space or CR while
not in command mode now causes an instant refresh

- Add `bufcache' display which shows buffer cache usage per filesystem,
ala the monitor(1) command for Ultrix.
- Allow `h' or `?' to show the command list (same as `:help').
- Sort commands in cmdtab.c and systat.1

branches: 1.6.4;
Fix from PR7655: translation of keyboard command in systat is Wrong.
(breaks netstat's :ignore command for upper-case service names)

branches: 1.5.2;
- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

- some KNF.
- use __RCSID().
- WARNS=1

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Revert previous, and switch to using real arithmetic.

Ever since this code was first committed to the CSRG SCCS
tree, in Oct 1983, it has contained either
int dellave;
or more recently:
static int dellave;
(that change is irrelevant, as is the move of the declaration
from systat.h into main.c)

And then in main() initialised it as:
dellave = 0.0;

It seems clear to me that the variable really should have been a
double since day one. All its uses were in floating point contexts.

So, undo the change to use int constants, and instead just make
"dellave" (the load average delta) be a double.

This should make the load average bar which appears at the
top of most systat display screens more sensitive to showing
when the load average is increasing or decreasing (showing
it using '>' or '<' instead of '|' which is used when there
is not much change since last time).

systat: don't compare integer to floating point constants

No binary change.

PR/56331: Paul Goyette: Add -z option to display 0 instead of ' ' in vmstat.

PR/53906: Paul Ripke: systat(1) vmstat & syscall get
"alternate system clock has died" on terminal resize (SIGWINCH)

Extend "systat vm" output to provide better insight about buffercache and
document it.

From Greg A. Woods in PR bin/36542

branches: 1.53.2; 1.53.4;
add -b to usage.

add missing 'b' to the optstring. alpha-sort the option handling.

branches: 1.51.6;
add a basic "-b" option - that outputs one display and exits.
inspired by "top -b". still requires a curses-capable output
without some fairly significant internal restructuring.

allow fractional intervals

branches: 1.49.2;
if you change display types, the "Showing %s, refresh every %d seconds."
message is retained, and you can't get rid of it. since it's dispalyed
in inverse, it feels like there's always an error happening (which is
really what the code has -- the above string is displayed via the error()
function.) for several types of key press that largely are just "redraw"
operation (space, ^L, etc.), clear the error string as well.

branches: 1.48.2;
Always use_sysctl in preparation of removing all kvm code.

branches: 1.47.6;
use more sysctl

branches: 1.46.2; 1.46.8;
Consistently use __dead and __printflike.

Allow display intervals > 25 seconds.
Fixes PR/36999
I did contemplate chaging curses - but the code is replicated and warped.

Don't assume that two identical-looking string literals will have the
same address and will therefore be comparable with the == operator.
Instead, use a const variable.
Inspired by PR 41255 from Kurt Lidl.

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.42.4;
Use sysctl to fetch network statistics unless a memory file is specified
on the command line.

don't call curses from a signal handler!

branches: 1.40.2; 1.40.4; 1.40.8;
use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Add (unsigned char) cast to ctype functions
Although, IIRC, there is another PR on all commands being converted to
lower case.

Using timeout() to control refresh gets rid of a whole pile of signal-related
lossage.
Making ungetch() signal-safe, as ncurses seems to, would be better, though.

Use KEY_RESIZE. Might as well have something in our source tree that does.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

if kvm_nlist() fails, nlisterr() would be called before the screen
curses context would be initialized; just use errx() instead in this case
this fixes coredump for cases like 'systat -N /netbsd.gz', reported by Walt
on port-i386

in nlisterr(), wait a while (5 seconds currently) before exiting, so that
it would be actually possible to actually see the error

No need to resizeterm() if size not changed.
On 'fg' just restore old screen contents.

Reinstate our STOP handler before curses installs its one.
Ensures that both handlers are executed on subsequent stops.

Resize windows on SIGWINCH and restart from SIGTSTP
(approved by christos)

branches: 1.30.2;
Change deprecated curses function to new equivalent.

Fetch maxslp from the kernel. Only use USPACE if it's defined.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

Add "all" mode to systat to cycle between all modes,
sort of like VMS' "MONITOR ALL"-command.

Code was submitted by Jarkko Teppo <jate@uwasa.fi> in PR 10851,
cleaned up and added 'turns' handling by me.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.25.2;
Use hline() and variants in a bunch of places.

branches: 1.24.2;
Two UI changes:

a.) restore the capability to enter a substring of a mode or command
name. Pointed out by Soren Jorvang.

b.) (capital) Q now exits systat immediately

add command line -n flag, which is same as "netstat numbers".
without it, we can't disable name resolution before the resolution starts.

Block alarm signals while displaying -- there's no reason to allow recursive
display at all.

Knee-jerk snprintf()-ism.

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

Sigh... this is the missing part of last night's final commit -- perform
the same simplification on mode parsing for the command line as for user
commands.

My apologies to anyone who tried to build systat this morning.

Rototill global command matching -- switch from ad-hoc tomfoolery to a
table lookup. This will make prefix matching and so on easier.

Expect a similar change for mode-specific commands before too long.

While there, rename some structures with misleading names.

Watch this space for more changes soon.

Sync usage() with man page.

branches: 1.16.4;
Functional LP64 and type sanity fixes.

branches: 1.15.2;
Fix handling of privileges - the gid was given up before dkinit()
was called.
Pass the gid to use for KVM access explicitely to dkinit(), the caller
decides whether to call setgid(getgid()) or not.

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Message buffer passed to kvm_openfiles() should _POSIX2_LINE_MAX long; PR#3266

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

New userland code to read the statistics kept by the NetBSD generic
disk framework, from John M. Vinopal <banshee@gabriella.resort.com>

Be pedantic, main() returns int in C.

Print error message and exit if TERM is not set.
From PR #1015.

various includes, casts, and cleanups...

Use err*(3)/warn*(3).

Don't core dump on an illegal display type. Display a more specific error
message for an ambiguous type.

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

mbufs display was broken since the time we moved to percpu stats.

branches: 1.15.6; 1.15.12;
Fix -Wsign-compare issues

branches: 1.14.26;
use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.8.2;
Use hline() and variants in a bunch of places.

branches: 1.7.8;
Minor printf mod, for when we print a 3-digit value, and the next update prints only two (leaving the last stale digit showing)

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Use the new getmaxx and getmaxy macros instead of directly accessing
the private fields of WINDOW.

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Adjust userland commands for struct inpcb separation

Only kvm users are affected.

Adjust userland commands for struct inpcb integration

Only kvm users are affected.

netstat(1): use reallocarr instead of realloc(x * y)

WARNS=3

Add (unsigned char) cast to ctype functions
Although, IIRC, there is another PR on all commands being converted to
lower case.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

use strlcpy

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.15.4;
Fix arguments to *printw().

support IPv6. commands under "netstat" are IPv6 ready.
IPv6 is supported by filters (":ignore ssh") as well.
TODO: do something about line truncation?
TODO: inet6.icmp6? ":help" will not fit into single line...

avoid null pointer access on ":show".

bring in latter half of PR 9080 (host table allocation error check).

Add missing memory check in port table handling. Patch based on
PR bin/9080 by Jun-ichiro itojun Hagino

G/C function used in old command parsing

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

branches: 1.8.6;
- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

No need to include <sys/socketvar.h>.

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Use inet_aton(), not inet_addr().

various includes, casts, and cleanups...

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Adjust userland commands for struct inpcb separation

Only kvm users are affected.

Adjust userland commands for struct inpcb integration

Only kvm users are affected.

Remove now unused tcpip.h includes. Some were already unused before.

branches: 1.29.24;
Fix fallout from circleq->tailq transition.

branches: 1.28.40; 1.28.46;
use c99 initializers
consistently terminate nlist arrays with NULL not ""

WARNS=3

- remove left over debugging code.
- centralize pointer to the head of the list casts by introducing a new var.

synchronize w/ inpcb/in6pcb change

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Redraw addresses after screen refresh

use strlcat/strlcpy

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.18.4;
Fix arguments to *printw().

don't choke on non-INET6 kernel, or non-IPSEC kernel.
cleanup error handling on mode change failure.

TODO: non-IPv4 kernel support should be improved. "netstat" should be okay,
"inet.ip" and "inet.icmp" needs more trick.

NetBSD PR: 9157

add command line -n flag, which is same as "netstat numbers".
without it, we can't disable name resolution before the resolution starts.

support IPv6. commands under "netstat" are IPv6 ready.
IPv6 is supported by filters (":ignore ssh") as well.
TODO: do something about line truncation?
TODO: inet6.icmp6? ":help" will not fit into single line...

remove dupplicated prototype defs for file static funcs.

fix "netstat numbers".

Two things:

1.) fix a bug which caused coredumps when starting with no mode arguments
2.) move to table-lookup for mode-specific command parsing as well.
all command matching is now table-driven.

branches: 1.11.4;
Functional LP64 and type sanity fixes.

branches: 1.10.2;
Add { and } to shut up egcs. Reformat the more questionable code.

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Use the new getmaxx and getmaxy macros instead of directly accessing
the private fields of WINDOW.

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

clear the screen at the correct time to avoid leaving garbage on the screen.
This happens when switching from address to :numbers display.

From FreeBSD pr bin/1425.

update for new queue structures

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

systat(1): convert free(x); x = malloc(x * y) to reallocarr.

free on NULL is a guaranteed non-op.

fix wrong sysctl

use sysctl

branches: 1.31.6; 1.31.12;
Remove uarea swap-out functionality:

- Addresses the issue described in PR/38828.
- Some simplification in threading and sleepq subsystems.
- Eliminates pmap_collect() and, as a side note, allows pmap optimisations.
- Eliminates XS_CTL_DATA_ONSTACK in scsipi code.
- Avoids few scans on LWP list and thus potentially long holds of proc_lock.
- Cuts ~1.5k lines of code. Reduces amd64 kernel size by ~4k.
- Removes __SWAP_BROKEN cases.

Tested on x86, mips, acorn32 (thanks <mpumford>) and partly tested on
acorn26 (thanks to <bjh21>).

Discussed on <tech-kern>, reviewed by <ad>.

use c99 initializers
consistently terminate nlist arrays with NULL not ""

Appease gcc 4.x

WARNS=3

Uppercase CPU, plural is CPUs.

g/c SDEAD handling

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Create subwins that end one line from the bottom of the screen even
after the window is resized.

Merge the nathanw_sa branch.

branches: 1.22.2;
Use kinfo_proc2.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.19.2;
Use hline() and variants in a bunch of places.

Use kern.cp_time to fetch cp_time[]. Don't support fetching it from
crash dumps yet, as that requires determining which CPU we should fetch
it from, etc.

include sys/sched.h to get definition of CPUSTATES

branches: 1.16.2;
- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

Update for SDEAD.

Functional LP64 and type sanity fixes.

branches: 1.13.2;
Add a new `ps' view to systat, which shows process information. This
view is identical to the output of `ps aux' except that a.) the RSS and VSZ
fields are one character wider and b.) it shows a zero value for the RSS
and %MEM columns of processes which report a negative RSS.

Show pid as well as user name and command in pigs view. Makes hopping to
another window and killing the errant process (or even just distinguishing
it from like processes) rather easier.

const propagation.

- KNF
- use snprintf
- don't overwrite the keyboard buffer (and make this sized on
the window size).

Fix pasto.

Don't display %cpu for zombies. It never decays, and makes the results look
odd.

fix .Nm usage, deprecate register, getopt returns -1 not EOF, s/[br]*/[ms]*/

- some KNF.
- use __RCSID().
- WARNS=1

Use the new getmaxx and getmaxy macros instead of directly accessing
the private fields of WINDOW.

Freshen up a bit:

- Replace deprecated sigblock() with sigprocmask()
- Redraw the current display if SIGWINCH is caught
- Style police

various includes, casts, and cleanups...

Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Remove SCCS workarounds. No binary change.

Use the vm.uspace sysctl instead of using the USPACE kernel define.

- enlarge buffer to avoid snprintf() truncation

branches: 1.37.14;
need <sys/stat.h>

branches: 1.36.8;
Remove some pointless inclusions os sys/user.h

branches: 1.35.2; 1.35.8;
eliminate non-literal format strings.

Remove uarea swap-out functionality:

- Addresses the issue described in PR/38828.
- Some simplification in threading and sleepq subsystems.
- Eliminates pmap_collect() and, as a side note, allows pmap optimisations.
- Eliminates XS_CTL_DATA_ONSTACK in scsipi code.
- Avoids few scans on LWP list and thus potentially long holds of proc_lock.
- Cuts ~1.5k lines of code. Reduces amd64 kernel size by ~4k.
- Removes __SWAP_BROKEN cases.

Tested on x86, mips, acorn32 (thanks <mpumford>) and partly tested on
acorn26 (thanks to <bjh21>).

Discussed on <tech-kern>, reviewed by <ad>.

Fix -Wsign-compare issues

- add new RLIMIT_AS (aka RLIMIT_VMEM) resource that limits the total
address space available to processes. this limit exists in most other
modern unix variants, and like most of them, our defaults are unlimited.
remove the old mmap / rlimit.datasize hack.

- adds the VMCMD_STACK flag to all the stack-creation vmcmd callers.
it is currently unused, but was added a few years ago.

- add a pair of new process size values to kinfo_proc2{}. one is the
total size of the process memory map, and the other is the total size
adjusted for unused stack space (since most processes have a lot of
this...)

- patch sh, and csh to notice RLIMIT_AS. (in some cases, the alias
RLIMIT_VMEM was already present and used if availble.)

- patch ps, top and systat to notice the new k_vm_vsize member of
kinfo_proc2{}.

- update irix, svr4, svr4_32, linux and osf1 emulations to support
this information. (freebsd could be done, but that it's best left
as part of the full-update of compat/freebsd.)


this addresses PR 7897. it also gives correct memory usage values,
which have never been entirely correct (since mmap), and have been
very incorrect since jemalloc() was enabled.

tested on i386 and sparc64, build tested on several other platforms.

thanks to many folks for feedback and testing but most espcially
chuq and yamt for critical suggestions that lead to this patch not
having a special ugliness i wasn't happy with anyway :-)

branches: 1.31.2;
cast for tdev.

branches: 1.30.18;
Revert the changes done after newlock2 merge, except for the removal of
the now unused LSDEAD state. The current kernel headers are now
source-compatible with pre-newlock2 kernel headers again.

Approved by Andrew Doran.

Sync with kernel changes introduced by merging the newlock2 branch.

Print system processes' command names in square brackets, like ps(1) does.

Appease gcc 4.x

branches: 1.26.2;
WARNS=3

g/c SDEAD handling

use strlcat/strlcpy

use strlcpy

Merge the nathanw_sa branch.

interrupt with two rs.

branches: 1.20.2;
Use kinfo_proc2.

Fetch maxslp from the kernel. Only use USPACE if it's defined.

__CONCAT does token pasting, not string concatnation. if something like:
__CONCAT("foo","bar");
actually works to concantate strings, it's because the preprocessor expands
it into "foo""bar" as separate strings, and then ANSI string concatenation
is performed on that. It's more straightforward to just use ANSI string
concatenation directly, and newer GCCs complain (rightly) about misuse
of token pasting.

Remove extern variables and functions now declared in dkstats.h.
While here, remove 77 (!) unneed #includes.

- Add `boot', `run', `time' and `zero' commands to all IP displays. These work
as in the `vmstat' display mode. The default mode is now `time', not `boot'.
- ANSIfy.
- s@kre\(@vmstat\(@.
- __RCSID() police.
- Tweak inet.icmp display visual a little.

branches: 1.15.2;
include sys/sched.h to get definition of CPUSTATES

Handle SONPROC state.

branches: 1.13.2;
- implement layered help.
Suggested by: Andy Doran <ad@mr-magoo.sports.gov.uk>
- inet6.ip6 and ipsec menu
- u_quad_t printing fix
- #ifdefs to allow compilation on 1.4.x

* Fix a display buglet: if the process list is exhausted before the window's
bottom is reached, clear the remaining lines, lest there be stale process
entries if the process list shrinks.
* Implement a top(1)-like `user' command in the ps display.

TNF copyright -- I will do the paperwork to give these over asap.

Knee-jerk snprintf()-ism.

Backout unintended change

Add a file missed in last commit

More fallout from CL* purge.

recognise "dty" the same as we do "tty"

branches: 1.5.2;
According to the previous commit the new process state should be SDEAD and
not SDYING, so s/SDYING/SDEAD/.

Update for SDEAD.

Fix CPU percentage of "systat ps".
Yes, the name of the member "pt_pctcpu" is confusing :-).
Use double instead of float.

Add an __RCSID.