adapt to ${CC_WNO_IMPLICIT_FALLTHROUGH}

Use ${CC_WNO_IMPLICIT_FALLTHROUGH} instead of
the older style more complex expressions.

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

convert HAVE_GCC == 7 to HAVE_GCC >= 7.

apply -Wno-error=implicit-fallthrough on files that have fallthru
comments but are missed by the current checker.

Bump WARNS to 5, and remove unnecessary -Wno (tested with pkgsrc clang 7)

Remove advertising clause, permitted by the copyright author.

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.53.2; 1.53.4;
add LIBKRB5_LDADD/LIBKRB5_DPADD and their static counterparts
to bsd.prog.mk. use them instead of hard coding various lists
of libraries for krb5.

this fixes static builds.

Remove MKCRYPTO option.

Originally, MKCRYPTO was introduced because the United States
classified cryptography as a munition and restricted its export. The
export controls were substantially relaxed fifteen years ago, and are
essentially irrelevant for software with published source code.

In the intervening time, nobody bothered to remove the option after
its motivation -- the US export restriction -- was eliminated. I'm
not aware of any other operating system that has a similar option; I
expect it is mainly out of apathy for churn that we still have it.
Today, cryptography is an essential part of modern computing -- you
can't use the internet responsibly without cryptography.

The position of the TNF board of directors is that TNF makes no
representation that MKCRYPTO=no satisfies any country's cryptography
regulations.

My personal position is that the availability of cryptography is a
basic human right; that any local laws restricting it to a privileged
few are fundamentally immoral; and that it is wrong for developers to
spend effort crippling cryptography to work around such laws.

As proposed on tech-crypto, tech-security, and tech-userlevel to no
objections:

https://mail-index.netbsd.org/tech-crypto/2017/05/06/msg000719.html
https://mail-index.netbsd.org/tech-security/2017/05/06/msg000928.html
https://mail-index.netbsd.org/tech-userlevel/2017/05/06/msg010547.html

P.S. Reviewing all the uses of MKCRYPTO in src revealed a lot of
*bad* crypto that was conditional on it, e.g. DES in telnet... That
should probably be removed too, but on the grounds that it is bad,
not on the grounds that it is (nominally) crypto.

add sqlite3

branches: 1.50.10; 1.50.12; 1.50.14; 1.50.18; 1.50.20;
Remove many HAVE_GCC || HAVE_PCC conditionals as the options also apply
to Clang. Add a few cases of HAVE_LLVM for -fno-strict-aliasing.

branches: 1.49.2; 1.49.6; 1.49.8;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.48.2;
Use terminfo and the non-standard ttytype rather than termcap.

remove most of the remaining HAVE_GCC tests that are always true in
the modern world.

branches: 1.46.2;
Default to -Wno-sign-compare -Wno-pointer-sign for clang.
Push -Wno-array-bounds down to the cases that depend on it.
Selectively disable warnings for 3rd party software or non-trivial
issues to be reviewed later to get clang -Werror to build most of the
tree.

We no longer need -I/usr/include/krb5.

Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.42.6;
Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.

branches: 1.41.12;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4.

Goodbye KerberosIV

Add -lcrypt to link lines for applications using -lkrb5, so that they
link successfully when MKPIC=no, as is always the case for our ports
which do not support shared libraries.

Discussed with thorpej and christos.

Introduce PAM_STATIC_LDADD and PAM_STATIC_DPADD. When compiling
with MKPIC=no, possibly because the target does not support shared
libraries, these include libraries required to resolve all symbols
which end up referenced from PAM-using applications. The libraries
presently required are -lcrypt, -lrpcsvc and -lutil.

Add use of these variables which are currently set up to use PAM,
so that they compile when MKPIC=no.

Also, in the telnetd case, reorder the order of the libraries, so
that libtelnet.a comes before -ltermcap and -lutil, again to fix
link error when MKPIC=no.

Discussed with thorpej and christos.

Make this compile if pam is present. XXX: this sucks, because we don't
really use PAM here, but libtelnet needs it.

Only compile in IPv6 support if ${USE_INET6} != "no"

MKINET6 is for providing IPv6 infrastructure.
USE_INET6 is for compiling IPv6 support into the programs (needs MKINET6).

Move linking with libdes to the common kerberos section since
libtelnet depends on the old des functions.

From Jukka Salmi in NetBSD pr misc/28727

rearrange lib stuff so that these link on non-shared-lib platforms.

Fix the checkflist for builds without Kerberos 4 (MKKERBEROS4=no)
and without Kerberos 4 & 5 (MKKERBEROS=no). Previously checkflist
complained of missing files.

* move kerberos- and kerberos 4-only files into new flists,
distrib/sets/lists/*/krb.*

* make the flist generators grok MKKERBEROS{,4} variables

* fix Makefiles which treat MKKERBEROS=no as MKKERBEROS5=no.
9 out of 10 experts agree that it is ludicrous to build w/
KERBEROS4 and w/o KERBEROS5.

* fix header files, also, which treat MKKERBEROS=no as MKKERBEROS5=no.

* omit some Kerberos-only subdirectories from the build as
MKKERBEROS{,4} indicate

(I acknowledge the sentiment that flists are the wrong way to go,
and that the makefiles should produce the metalog directly. That
sounds to me like the right way to go, but I am not prepared to do
revamp all the makefiles. While my approach is expedient, it fits
painlessly within the current build architecture until we are
delivered from flist purgatory, and it does not postpone our
delivery. Fair enough?)

libkrb depend on libdes
libkrb5 depends on libasn1 and libcrypto

split MKKERBEROS4 from MKKERBEROS. based on work by lha at stacken.kth.se
(build confirmed with both MKKERBEROS4=yes and MKKERBEROS4=no)

stop installing install libtelnet. build under lib/libtelnet and reference
it from usr.bin/telnet and libexec/telnetd.
(reason for separate build: compiler flags)

remove unneeded #ifdef. (confirmed that same *.o is generated)

makefile delint. use NETBSDSRCDIR as appropriate

Split the notion of building Hesiod, Kerberos, S/key, and YP
infrastructure and using that infrastructure in programs.

* MKHESIOD, MKKERBEROS, MKSKEY, and MKYP control building
of the infratsructure (libraries, support programs, etc.)

* USE_HESIOD, USE_KERBEROS, USE_SKEY, and USE_YP control
building of support for using the corresponding API
in various libraries/programs that can use it.

As discussed on tech-toolchain.

forced: previous was really: remove libvers, it's not being used

link against the not-installed libvers

update build infrastructure for heimdal 0.3a

Add MK... variables to enable/disable various aspects of building
crypto support into the system. See share/mk/bsd.README for more
a full description.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.20.2;
Merge a bunch of things from crypto-us and crypto-intl into basesrc,
adding support for Heimdal/KTH Kerberos where easy to do so. Eliminate
bsd.crypto.mk.

There is still a bunch more work to do, but crypto is now more-or-less
fully merged into the base NetBSD distribution.

branches: 1.19.6;
optionally include CRYPTOPATH Makefile.frag files.

Use bsd.crypto.mk.

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

Treat crypto-us like domestic.

Descend on obj, as well as clean, etc.

distclean is a synonym for cleandir

Ack! I misunderstood a problem reported to me. We don't need to do
anything special to handle obj directories; bsd.man.mk does it for us
already. Back out that part of the previos commit.

Fix two problems with my previous change:

- We must include bsd.own.mk to get EXPORTABLE_SYSTEM from mk.conf.
Noted by Bernd Ernesti.
- If we're only generating man pages, we should deal with obj
directories as appropriate. Both Perry Metzger and I found this
independently.

This completes the tasks necessary to close PR 5519.

Unlike other domestic bits, telnet and telnetd are never built as a part
of the domestic build process. No domestic program actually builds its
own man pages but instead relies on those built in the exportable tree.
The result is missing telnet(1) and telnet(8) pages.

Fix this problem descending into the telnet and telnetd directories
regardless of whether we're doing an exportable build or not. Once there,
we generate only the man pages if we're building a non-exportable system.

WARNSify and fix problems passing int * -> long *

use CPPFLAGS instead of CFLAGS

branches: 1.8.2;
WARNS=0 for now (3rdparty product)

- Makefile cleanups

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

define 'unix'

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove README relevant to 1995 telnet.

branches: 1.5.98; 1.5.100;
Lots of typos.

seperate -> separate

Fix various misspellings of compatible/compatibility.

update to 95.10.23 version of telnet
also, RCS ID police

branches: 1.1.1;
Initial revision

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

branches: 1.13.38; 1.13.40;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.12.56;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

strlcpy

Ansify.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.8.4;
(net_write): rename to telnet_net_write

- synchronize with the domestic version
- setupterm -> setup_term
- char -> unsigned char

WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Prevent crashes as shown in PR 56918.

preserve errno because we are doing system calls between error printing
and error setting.

restore perror -> warn (reported by Havard Eidnes)

use memmove() instead of strncpy() for overlapping strings.
ensure nul termination.

Match the function prototype of encrypthandler instead of casting to it.
Make GCC 9 snapshot happier with the code

While here, remove unnecessary braces around return (KNF).

unifdef compatibility for old BSD servers. This has been
disabled, so no binary change. from openbsd.

Avoid unnecessary casts, from openbsd. No binary change.

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

G/C In3270 - always false

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.70.12; 1.70.14;
GC header left from earlier diagnostic test.

Remove source routing support.

branches: 1.68.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.67.34;
volatile fixes from Anon Ymous

end the argument list to exec*(3) with a NULL instead of a bare '0', as
the latter isn't a pointer context in these varargs functions.

Add support for RFC 3542 Adv. Socket API for IPv6 (which obsoletes 2292).
* RFC 3542 isn't binary compatible with RFC 2292.
* RFC 2292 support is on by default but can be disabled.
* update ping6, telnet and traceroute6 to the new API.

From the KAME project (www.kame.net).
Reviewed by core.

Turn if/then/elif into a switch

Rename debug to telnet_debug, to allow static linking with libssh.a.

fix compilation after changes to telopts. I will revisit this and constify
it later.

charaters -> characters

branches: 1.60.2;
NI_WITHSCOPEID was not picked up by IETF standardization process.

- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

use bounded copy ops

strlcpy

Ansify.

one <sys/cdefs.h> include is enough
fixes PR misc/21340 by Igor Sobrado

- Support -4 and -6. Approved by itojun.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Make telnet escape work in tn3270

PR: 1816

just to be sure, set telnetport to 0.
From: Pekka Savola <pekkas@netcore.fi>

comment or delete text after CPP directives.

Fix possible buffer overruns. From OpenBSD, but without breaking stuff.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.42.4;
add missing #ifdef INET6, to compile without -DINET6.
From: Mason Loring Bliss <mason@acheron.middleboro.ma.us>

Convert telnet and top to the new termcap interface. This stops some
buffer overflows in top from ever happening.

recover old error message on unknown service ("telnet localhost foo"
when foo is not valid). gai_strerror may be too generic.
fix suggested in openbsd camp.

sync comment for sourceroute() to reality

use getnameinfo for "Trying ::1..." message, to enable printing of
IPv6 scopeid.

sync with latest libipsec/kernel.

clarify reverse lookup and -N.
getaddrinfo(AI_CANONNAME) does not imply reverse lookup.

remove setuid(getuid()). they are unnecessary as noone is going to
setuid telnet(1).

i'm not sure why it is here (maybe someone reused this code from
other setuid'ed program, or someone cut-and-pasted the code from
somewhere else?), it was from revision 1.1 (= 4.4BSD).

briefly discussed in: tech-net?

clarify getaddrinfo() loop. try to contact all possible addresses
unless we experience fatal error.
XXX changed location of setuid(getuid()), may need someone's review.

clarify reverse address lookup (-N). AI_NUMERICHOST is for forward lookup.

XXX RFC2553 does not say that AI_CANONNAME means reverse lookup.
we need to check if getaddrinfo(3) implementation is correct.

Remove extraneous colons and newlines from perror(3) arguments.

branches: 1.31.2;
Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

fix handling of port number preceded by minus sign to restore documented behavior

clarify socket-connect trial loop. fix freeaddrinfo().
adjust indentation (commands.c uses sw=4 ts=8).

Whitespace cleanup.

bark if mismatched address families are found on source route.

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

- synchronize with the domestic version
- setupterm -> setup_term
- char -> unsigned char

const poisoning.

Declare ints, too, don't default them.

Fix pasto in previous.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

use static int instead of static

Avoid GCC warning on m68k.

Adjust for tn3270 cleanup.

Add a cast to make the compiler happy on the Alpha.

Fix compile error of tn3270/tn3270; getpgrp() takes no argument.

WARNSify and fix problems passing int * -> long *

sync up with domestic fixes

RCS id cosmetics.

restore last of the lost local changes.

replace another lost change: "help" is a valid hostname.

update to 95.10.23 version of telnet
also, RCS ID police

contrary to unpopular opinion, 'help' is a perfectly valid hostname.

Squish #581.

headers, and use INADDR_NONE appropriately.

020 -> IPTOS_LOWDELAY

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

fix sending simple commands, from Jonathan Stone <jonathan@CS.Stanford.EDU>

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.8.96; 1.8.98;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

remove unneeded #ifdef. (confirmed that same *.o is generated)

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

Inline the only use of NetNonblockingIO.
While here inline SetSockOpt. From openbsd.

G/C In3270 - always false

Remove unused code.

static-ify.

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.38.12; 1.38.14;
Remove source routing support.

branches: 1.37.22;
Use __dead

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

include <netipsec/ipsec.h> rather than <netinet6/ipsec.h> from userland
where possible, for consistency and compatibility to FreeBSD
(exception: KAME specific statistics gathering in netstat(1) and systat(1))

branches: 1.34.44;
Rename debug to telnet_debug, to allow static linking with libssh.a.

Change first arg of printsub() for 'char' to 'int' so that it builds again.
This matches the binary interface from before if was de-__Peed (or at least
that of K&R C).
In any case having arguments (and return values) of char and short isn't
especially sensible.

Fix build errors caused by de-__P()--ing "libtelnet".

- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

use bounded copy ops

Ansify.

- Support -4 and -6. Approved by itojun.

Change _putchar definition to match curses.h's expectations, and
remove some __ left over from de-P()'ing (mmm, inconsistency).
Noted by Juergen Hannken-Illjes.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

"wierd" is weird.

Symmetric has one s and two m's.

make usr.bin/tn3270 buildable. make sizeof(tline) usable.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.18.4;
(net_write): update prototype

sync with latest libipsec/kernel.

Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

branches: 1.13.2;
Make sure termio is defined to termios.

- synchronize with the domestic version
- setupterm -> setup_term
- char -> unsigned char

const poisoning.

Adjust for tn3270 cleanup.

WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

restore local change mistakenly overrun in import of 95.10.23
telnet--keep track of a client-side close and just turn off one
direction of the socket; keep running until server side closes down too.

update to 95.10.23 version of telnet
also, RCS ID police

If we get an EOF on stdin, close the write side of the TCP connection, but
wait for the remote host to close the connection before exiting.

headers, and use INADDR_NONE appropriately.

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

more unifdef

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sbin, usr.bin, usr.sbin: remove redundant getopt declarations

No binary change, except for assertion line numbers in tprof.

branches: 1.32.12;
minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.30.12; 1.30.14;
Drop main() prototype.

Use C89 function definitions

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.27.2;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.26.12;
volatile fixes from Anon Ymous

Goodbye KerberosIV

Rename debug to telnet_debug, to allow static linking with libssh.a.

Let the usage message fit in 80 columns to avoid wrapping.

Homogenize usage messages: make the 'usage' word all lowercase, as this seems
to be the most common practice in our tree.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

remove unneeded #ifdef. (confirmed that same *.o is generated)

strlcpy

Ansify.

- Support -4 and -6. Approved by itojun.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

fix spelling of cpp symbol (ENCRYPT vs ENCRYPTION).
enable encryption with autologin.
fixes PR 12226

Fix possible buffer overruns. From OpenBSD, but without breaking stuff.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.12.4;
sync with latest libipsec/kernel.

Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

Simply a construct in usage().

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

Include unistd.h to import declaration of getopt(3).

WARNSify and fix problems passing int * -> long *

getopt returns -1 not EOF

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

branches: 1.17.96; 1.17.98;
- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

Ansify.

null commit

poll.h, not sys/poll.h

Oops; fix array size. Nice compiler warning... not.

Duh, generate the pollfd arrays outside of loops, not that it really matters.

select() -> poll()

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.6.10;
WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

s/of of/of/ in comment.

remove always-true part of condition.

found by GCC 12.

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

Remove unused code.

branches: 1.13.96; 1.13.98;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

remove unneeded #ifdef. (confirmed that same *.o is generated)

Ansify.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.8.10;
WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

restore last of the lost local changes.

update to 95.10.23 version of telnet
also, RCS ID police

headers, and use INADDR_NONE appropriately.

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove unused code.

branches: 1.10.96; 1.10.98;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.7.10;
Adjust for tn3270 cleanup.

WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove unneeded casts

Remove some effectively if 0'd code.

Inline the only use of NetNonblockingIO.
While here inline SetSockOpt. From openbsd.

Expand SIG_FUNC_RET -from openbsd.

Remove unused code.

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.34.2; 1.34.4;
fixes for GCC 6.4:

mail's execute() needs a volatile for setjmp().

telnet has a missing {} issue.

isdnd's print_config() has a missing/wrong {} issue, and
its p_q931bc() has inconsistent indentation (but not any
actual problem.)

map-mbone's accept_neighbors2() compares a vs. a instead
of a vs. b.

sysinst's pm_cgd_check() has missing {} issue.

timed's main() has missing {} issue.

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.32.50;
Kill remnant function decl.

- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

occured -> occurred. From Peter Postma.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

need to pass flags as argument to TIOCFLUSH ioctl
fixes bin/22391 by SAITOH Masanobu

more unifdef

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

Ansify.

PR/18984: John Heasley: telnet spins on dead tty

null commit

poll.h, not sys/poll.h

select() -> poll()

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

s/infinate/infinite/

comment or delete text after CPP directives.

fix following sequence:
telnet localhost
cat (no argument)
control-C
(not returned to the shell prompt)
(push enter key)
(returned to prompt)

branches: 1.15.6;
Added an #undef. This, and previous revision fixes PR bin/5374

fixed call to select to keep track of the highest numbered file
descriptor. Also removed some redundant code that was #ifdef TN3270
(the code was the same on both sides of the #ifdef)

Declare ints, too, don't default them.

WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

put back in a change I accidentally dropped from telnet.95.10.23

restore local change mistakenly overrun in import of 95.10.23
telnet--keep track of a client-side close and just turn off one
direction of the socket; keep running until server side closes down too.

update to 95.10.23 version of telnet
also, RCS ID police

I seem to have forgotten to commit the patch in PR1608 when I closed it. Fix VLNEXT handling.

If we get an EOF on stdin, close the write side of the TCP connection, but
wait for the remote host to close the connection before exiting.

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Patch from Frank van der Linden <vdlinden@fwi.uva.nl> to handle 57600 and
115200 baud. Baud rate checking code disabled completely when using termios.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

telnet.1: update state of the art on Single DES encryption

Remove reference to krb_realmofhost(3) which does not exist.

Someone who speaks kerberos might want to check the -k description.

Remove some macros that do nothing and use \(em.

You can encrypt outside of north america now.

branches: 1.34.4; 1.34.6;
Remove workaround for ancient HTML generation code.

Remove unnecessary Bk/Ek pairs from SYNOPSIS.
No effective change except where I used the opportunity to sort options
and/or option descriptions.

Fix whitespace nits. Suggested by Bug Hunting.

branches: 1.31.6;
Don't workaround ancient macro argument limit with .Xo/.Xc.

branches: 1.30.42;
remove duplicate description of DEFAULT keyword (introduced by me).

Bump date for previous; fix a typo; use .Dq instead of \*( construct.

break the description of the "open" command into two paragraphs and improve
description of .telnetrc.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

New sentence, new line.

Fix typo.

- Support -4 and -6. Approved by itojun.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Punctuation nit, drop a .Pp.

s/If a port is specified on the command line/If a port is specified/
for the 'omits any automatic initialisation of TELNET' sentence

Whitespace cleanup.

Improve previous' markup usage a bit.

Document the .telnetrc DEFAULT machine entry.

Clarify when automatic initialisation of TELNET options occurs.
Reported by John Heasley.

Whitespace and punctuation fixes.

fix up various .Nm abuses:
- keep the case consistent between the actual name and what's referenced.
e.g, if it's `foo', don't use '.Nm Foo' at the start of a sentence.
- remove unnecessary `.Nm foo' after the first occurrence (except for
using `.Nm ""' if there's stuff following, or for the 2nd and so on
occurrences in a SYNOPSIS
- use Sx, Ic, Li, Em, Sq, and Xr as appropriate

Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

IPv6-ready telnet.
source route (telnet @localhost@localhost) works for IPv6 as well.

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Clean up SYNOPSIS formatting.

fix some minor macro usage and other bugs; some from Saitoh Masanobu
in PR misc/3656, others by myself.

fix typos noted by Masanobu Saitoh <msaitoh@spa.is.uec.ac.jp>.

fix a typo, noted by SAITOH Masanobu in PR misc/3599.
while I'm here, fix some other nits.

fix the the typos (and 1 other)

RCS id cosmetics.

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Fix spelling errors.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Obvious typo ':' -> ';'.

telnet(1): use reallocarr instead of malloc(x * y)

unifdef compatibility for old BSD servers. This has been
disabled, so no binary change. from openbsd.

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

G/C In3270 - always false

Remove unused code.

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

switch sprintf to snprintf in places.

Reported by hacker fantastic, thanks!

ok xtos.

branches: 1.36.18; 1.36.20; 1.36.28; 1.36.32; 1.36.38; 1.36.40;
fix signed/unsigned comparison.

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.34.2;
remove casts

Simplify

Use terminfo and the non-standard ttytype rather than termcap.

Rename debug to telnet_debug, to allow static linking with libssh.a.

plug buffer overflows, see
http://www.idefense.com/application/poi/display?id=220&type=vulnerabilities
http://www.idefense.com/application/poi/display?id=221&type=vulnerabilities
(CAN 2005-0468 and 2005-0469)

Patch taken from MIT/Kerberos (MITKRB5-SA-2005-001-telnet.txt)

branches: 1.29.2;
Add (unsigned char) cast to ctype functions

branches: 1.28.2; 1.28.4;
- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Various typo fixes from Jonathon Gray via jmc@openbsd.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

use bounded copy ops

Ansify.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

branches: 1.20.2;
s/infinate/infinite/

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

seperate -> separate

fix spelling of cpp symbol (ENCRYPT vs ENCRYPTION).
enable encryption with autologin.
fixes PR 12226

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.15.4;
Convert telnet and top to the new termcap interface. This stops some
buffer overflows in top from ever happening.

avoid memory leak on realloc() failure.

Add -N option (numeric host address) - idea taken from FreeBSD.
Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

branches: 1.12.2;
- synchronize with the domestic version
- setupterm -> setup_term
- char -> unsigned char

const poisoning.

- use an array MAXHOSTNAMELEN+1 size to hold hostnames
- ensure hostname from gethostname() is nul-terminated in all cases
- minor KNF
- use MAXHOSTNAMELEN over various other values/defines
- be safe will buffers that hold hostnames

WARNSify and fix problems passing int * -> long *

Don't interpret _POSIX_VDISABLE as a special character.

RCS id cosmetics.

restore local change mistakenly overrun in import of 95.10.23
telnet--keep track of a client-side close and just turn off one
direction of the socket; keep running until server side closes down too.

update to 95.10.23 version of telnet
also, RCS ID police

If we get an EOF on stdin, close the write side of the TCP connection, but
wait for the remote host to close the connection before exiting.

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

G/C In3270 - always false

branches: 1.15.90; 1.15.92;
Make this compile if pam is present. XXX: this sucks, because we don't
really use PAM here, but libtelnet needs it.

- deal with a dead tty in ttyflush() by cleaning-up and exiting instead of
returning a failure code and processing that all the way up the stack.
- deal with a dead peer similarly and do it without setjmp/longjmp() (at
christos' request).

These fix bin/20304 and my own observations when the remote abruptly closes
the connection.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

Ansify.

PR/18984: John Heasley: telnet spins on dead tty

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.6.10;
WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

branches: 1.22.80; 1.22.82;
PR/18906: roskens at elfin dot net: misc. select() to poll() updates.

Adapted to -current by myself, thanks for the patch!

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

remove #ifdef sun

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

use bounded copy ops

fix fallout from previous ansification (thanks to Juergen Hannken-Illjes)

Ansify.

null commit

poll.h, not sys/poll.h

Duh, generate the pollfd arrays outside of loops, not that it really matters.

select() -> poll()

Change _putchar definition to match curses.h's expectations, and
remove some __ left over from de-P()'ing (mmm, inconsistency).
Noted by Juergen Hannken-Illjes.

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Adjust for tn3270 cleanup.

WARNSify and fix problems passing int * -> long *

Include <sys/time.h>, which is the canonical location of the select()
prototype and assorted data type definitions.

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove unused code.

branches: 1.6.96; 1.6.98;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision

unifdef compatibility for old BSD servers. This has been
disabled, so no binary change. from openbsd.

minor cleanup:
- more const
- prevent overflow of the argument vector
- change a lot of unsigned to signed to eliminate casts

ExitString is used for error exit, do the minimum necessary here.
Avoid infinite loop:
telrcv->suboption->ExitString->SetForExit->telrcv

Reported by hacker fantastic, thanks!

static-ify.

unifdef TN3270 which is never defined (and wouldn't build if it was)
delete tn3270 file no longer needed.
SetIn3270(); expands to nothing now, so remove it.

No functional change.

switch sprintf to snprintf in places.

Reported by hacker fantastic, thanks!

ok xtos.

branches: 1.23.18; 1.23.20; 1.23.28; 1.23.32; 1.23.38; 1.23.40;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- Minimal diffs to separate MKCRYPTO from USE_KERBEROS

branches: 1.22.40;
PR/18906: roskens at elfin dot net: misc. select() to poll() updates.

Adapted to -current by myself, thanks for the patch!

Change first arg of printsub() for 'char' to 'int' so that it builds again.
This matches the binary interface from before if was de-__Peed (or at least
that of K&R C).
In any case having arguments (and return values) of char and short isn't
especially sensible.

Fix build errors caused by de-__P()--ing "libtelnet".

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

more unifdef

remove unneeded #ifdef. (confirmed that same *.o is generated)

use bounded copy ops

Ansify.

null commit

poll.h, not sys/poll.h

Duh, generate the pollfd arrays outside of loops, not that it really matters.

select() -> poll()

De-register, de-__P. Remove #ifndef __STDC__ parts.
defines.h: Be more careful with braces in macro definitions.

Fix unused variable warning in the non-ENCRYPTION case (e.g. when
built at tn3270(1)).

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.7.10;
Adjust for tn3270 cleanup.

WARNSify and fix problems passing int * -> long *

RCS id cosmetics.

update to 95.10.23 version of telnet
also, RCS ID police

new telnet from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Add RCS identifiers.

branches: 1.1.1;
Initial revision