bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

tftp: no longer need packed member warning

apply GCC_NO_ADDR_OF_PACKED_MEMBER

user.bin/tftp: Suppress -Werror=format-overflow error.

Add -Wno-error=format-overflow tftp.c to prevent build failure.

Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.

Reviewed by: kamil@

turn off various warnings for various things:

- file has looks bogus maybe-uninitialized
- llvm triggers an attribute violation:
ScheduleDAGInstrs.cpp:1430:14: error: declaration of
'llvm::raw_ostream& llvm::operator<<(llvm::raw_ostream&, const llvm::ILPValue&)'
with attribute 'noinline' follows inline declaration [-Werror=attributes]
- ntp and pkg_install have obvious restrict violations, should be
fixed but i'm avoiding patching upstream code in this pass
- tftp has an array bounds that doesn't seem real issue
- sysinst's partman.c has major problem with passing the same
string as source and dest in snprintf, as a way to strcat
with formatting which trip restrict violations. non trivial
to fix so for now the warning is elided.
- Xext's XEVI.c has similar issue as partman.c

everyone and GCC 8 gets these warnings turned off for now:

-Wno-format-truncation
-Wno-stringop-overflow
-Wno-stringop-truncation
-Wno-cast-function-type

as they trip a large amount of code. most of them should be
investigated, but the few i looked at were not finding actually
real bugs, vs instances of poor coding, so skipping for now.

branches: 1.11.28;
Work around "variable might be clobbered by longjmp" gcc warning when compiling with CPUFLAGS=-march=armv7. Should be fixed properly one day...

branches: 1.10.6; 1.10.12;
Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.9.20;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

__ss_{len,famiy} hack is no longer necessary

IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

remove WARNS=0

WARNS?=1

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ansify, const, knf

Add support for the multicast TFTP option. Reviewed by Rui Paulo.

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

Undo the non-sharing of the "toplevel" jmp_buf between main.c and tftp.c,
so that we don't get a core dump if a transfer time-out is experienced.
Also, get rid of an extranous newline printed in the case of time-out.

Use C89 function definitions

branches: 1.30.2;
PR/45842: Henning Petersen: compare fgets with NULL not 0

branches: 1.29.2;
ansify, const, knf

Add back a line accidentally deleted in the previous commit.

Use __dead

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.25.18;
use c99 initializer.

Add support for the multicast TFTP option. Reviewed by Rui Paulo.

Coverity CID 894: Avoid NULL dereference that cannot really happen.

Pass lint.

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

correct arg to setpeer() from main().

correct arg handling in setpeer().

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

strlcpy

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

fix argument validation mistake in setpeer().
From: Hiroyuki YAMAMORI <h-yamamo@db3.so-net.ne.jp>

make sure we do not overrun peeraddr.

branches: 1.12.8;
call freeaddrinfo() after getaddrinfo() to reclaim results.

IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

char -> unsigned char
<fcntl.h> instead of <sys/file.h>
compensate for different types in th_stuff

deprecate register, use err/warn, fix .Nm usage

WARNS?=1

Fix some potential buffer overflow problems.
From David Holland <dholland@hcs.harvard.edu>

Use inet_aton(), not inet_addr().

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

from: Christoph Robitschko <chmr@edvz.tu-graz.ac.at>
>fixed segmentation fault when connecting to nowhere.
>Also changed all gets() to fgets().

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

Remove workaround for ancient HTML generation code.

Nitpicks.

Mention multicast TFTP support.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Bump date for last.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

New sentence, new line.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace cleanup.

branches: 1.11.4;
[host]:filename syntax for IPv6 case.

branches: 1.10.4;
IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Implement a new manual page category ``SECURITY CONSIDERATIONS''
(suggested by mycroft)

Change occurrences of "UNIX" to .Ux or .At as appropriate.

deprecate register, use err/warn, fix .Nm usage

Replace `.LI' by `.Ql' (from Masanobu Saitoh; PR#1376).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Fix spelling errors.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

PR/57166: John Dundas: Correct error code byte order in error message

storage class first, *then* __dead

Remove K&R __P macros.
Remove main() function prototype if present.
Mark usage() as __dead if not already.
Binaries generated with & without these patches were compared with diff -r.

Undo the non-sharing of the "toplevel" jmp_buf between main.c and tftp.c,
so that we don't get a core dump if a transfer time-out is experienced.
Also, get rid of an extranous newline printed in the case of time-out.

Use C89 function definitions

branches: 1.32.2; 1.32.4;
ansify, const, knf

Use __dead

fix -Wsign-compare issues

- Malformed multicast option not being checked
for correctly. Could fault client.
- 'mc' (master client) field not being examined
properly. Actually looking at addr field so
proably always working out to non 0 (master).

sprinkle volatile.

Coverity CID 4119: Check negative returns (from Arnaud Lacombe)

Add support for the multicast TFTP option. Reviewed by Rui Paulo.

Pass lint.

Do not use %d for size_t!

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

appease gcc -Wuninitialized

Move declaration of local variables to start of function instead of
inside a block after code. Fixes build problem for vax, which still
uses gcc 2.95.3.

Make the extended options work on little endian machines.
Allow files smaller than 512 bytes to be received w/o a timeout.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

Fix sendto return value check (incomplete change in 1.14).
Noted by Brian Ginsbach in PR 19842.

branches: 1.15.2;
fix argument validation mistake in setpeer().
From: Hiroyuki YAMAMORI <h-yamamo@db3.so-net.ne.jp>

make sure we do not overrun tp->th_msg on ERROR packet.
correct ERROR length to include terminating \0 (RFC1350 page 8).

A too hasty checkin (and lack of -Wsign-compare) made send() never fail.
Newly added 'unsigned' removed from vars that shouldn't have had it.

defs had 'short block' for blocksize; changed defs to be unsigned.
added note to tftpd.8 that this bug hits multiple tftp clients.

branches: 1.11.4;
Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

branches: 1.9.2;
char -> unsigned char
<fcntl.h> instead of <sys/file.h>
compensate for different types in th_stuff

const poisoning.

deprecate register, use err/warn, fix .Nm usage

WARNS?=1

needs string.h

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

ansify, const, knf

fix -Wsign-compare issues

Pass lint.

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

branches: 1.6.8;
IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

deprecate register, use err/warn, fix .Nm usage

WARNS?=1

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

ansify, const, knf

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

branches: 1.2.16;
Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision