Enable WARNS=4 by default for usr.bin, except for:
awk bdes checknr compile_et error gss hxtool kgetcred kinit
klist ldd less lex locale login m4 man menuc mk_cmds
mklocale msgc openssl rpcgen rpcinfo sdiff spell ssh
string2key telnet tn3270 verify_krb5_conf xlint

branches: 1.27.28;
the intention of the whole tip-as-cu thing was to allow tip-as-cu and
have a cu command installed, even when the rest of uucp was removed
via MKUUCP=no. The old uucp-derived cu is no more, and is not
installed in either case.

make it so, by correcting some confusion that had made the non-uucp
tip-as-cu cu conditional on MKUUCP

branches: 1.26.2;
Include bsd.own.mk; from Jukka Salmi

Fix "MKUUCP" check so that "cu" installed if "MKUUCP" is not defined.

If MKUUCP=no, do not create links for cu and its manual page.

fix a typo in LINKS.

Clean up a bit.

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Now we use tip-as-cu, not Taylor UUCP cu.

These programs are no longer setuid, and now lock devices with flock,
not file locks in /var/spool/. They will no longer lock against UUCP
itself unless we modify UUCP to lock with flock, but this seems highly
unlikely to be an issue in the present day.

The ~C / ~+ command is no longer optional.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

Whoops. We don't *use* log.o, so don't *build* it.

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

Don't build any of the dialers except Hayes. If anyone is using any of
the others (maybe "Courier", but I doubt it) we can easily enough turn
them back on.

Saves 20-30K depending on platform. Not totally insignificant, since this
often goes on install media, or very small systems.

Default baud rate to 9600 (was 1200) to match Taylor cu.

warns=4

constify and warns = 3

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

use CPPFLAGS instead of CFLAGS

branches: 1.9.2;
disable WARNS here for now.

Make these executables world-readable.

Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

add -ansi -pedantic to CFLAGS, so that people won't try to use the behaviour
of the old zzhack-access macros, which with the current macro definitions
would cause a cast value to be used as an lvalue, which is a gcc extension,
but _not_ what we want.

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

We're have a real cu now, so break the link between cu and tip.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

branches: 1.1.1;
Initial revision

imported from 4.4lite

Add missing double p and d for stopped and overriden accordingly.
Fix few more typos along the way, mainly in copy-pasted comments.

compare pointers with NULL not '\0'.

branches: 1.16.42;
Use __dead. Make a bunch of local functions static.

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Added volatile keyword to variable that might be clobbered by longjmp

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

Rename an internal function who's name collides w/ pwrite(2).

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

don't enable IXANY.

branches: 1.36.4;
PR/47877: Michael van Elst: Disable and enable software flow control properly

branches: 1.35.2;
Add explicit continue to empty loop body.

while (...);
;
is really pointless, so remove the first semicolon.

branches: 1.33.2;
Use __dead. Make a bunch of local functions static.

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

sprinkle volatile.

end the argument list to exec*(3) with a NULL instead of a bare '0', as
the latter isn't a pointer context in these varargs functions.

Use closefrom, don't iterate over file descriptors from 3 to 20.

Replace abuse of SIGIOT, SIGEMT, SIGSYS for communication between the
TIPIN and TIPOUT processes with a third "attention" pipe. While we're
here, fix a few other minor nits like the hardcoded use of fd 3 in
consh().

Now ~+/~C appear to work. This must have been broken for years.

Redo the previous in the tip sanctioned way :-)

For the benefit of our 64-bit ports, we need to cast via intptr_t when
casting from pointer to unsigned int.

Pass a little lint.

delinting. more needed. (lint found some real bugs that I haven't fixed yet.)

The ~C / ~+ command is no longer optional.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

Oddly enough, smashing CRTSCTS into the terminal input flags doesn't do
much; it is a control flag.

Now toggling hardware flow control works.

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

constify and warns = 3

getfl() and cu_take() write a file locally. Open a file with O_RDWR.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

creat->open O_CREAT

Add { and } to shut up egcs. Reformat the more questionable code.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

Rename an internal function who's name collides w/ pwrite(2).

* fix a long-term annoyance with tip: if raisechar or force are set to
"", (usually in .tiprc with lines like `raisechar='), don't activate
feature if NUL (\0) is the received character
* on a related note, don't barf if the following variables are defined
to "": disconnect, log, parity, record

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Fix crash with null eofwrite capabilityand lseek/off_t bug; PR #1346

headers, casts, and use of time_t

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

use c99 initializer.

The ~C / ~+ command is no longer optional.

Add "~+" as a synonym for "~C" for Taylor cu compatibility.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

sbin, usr.bin, usr.sbin: remove redundant getopt declarations

No binary change, except for assertion line numbers in tprof.

branches: 1.24.10;
check speed argument conversion (Thierry Laronde)

branches: 1.23.16;
Put back -n

Remove broken snprintf usage (noted in PR 47976) and replace with
something simpler.

branches: 1.21.8; 1.21.18;
Use __dead. Make a bunch of local functions static.

pass lint; from Anon Ymous

Add Taylor cu compatibility: -f and "dir"

cuhelp: fix a typo in usage.

Pass a little lint.

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

If we're not given a phone number or system name to dial, use "direct
connect" mode -- in other words, set CLOCAL so the user can talk to the
device before CD.

ANSIfy decls, de-__P, clean trailing whitespace

Add another Taylor compat option, --nostop to disable software flow control
(a.k.a. "tandem" mode). While we're here, fix a buglet with --halfduplex,
and add --flow {hard, soft, none}. Note that you can't get *both* hard and
soft flow control using the command-line option; if you want that, you
have to set the variables in tiprc or with ~s once tip is running.

Move all setting of vars.c named variables to *after* the call to vinit().

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

New 'cu' command-line handling, derived from Todd Miller's in OpenBSD,
but with some long options added for Taylor 'cu' compatibility, and
with some bugs fixed (in particular, the handling of -# now works as
documented and does not overwrite argv).

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

warns=4

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead. Make a bunch of local functions static.

Properly use format string

pass lint; from Anon Ymous

Coverity CID 2972, 2973: Don't call close() with a negative fd.

Pass a little lint.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

DC is not a user-settable variable, but was being partially confused with one

Set O_NONBLOCK if dc flag is set. Don't set HUPCL if dc flag is set.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

headers, casts, and use of time_t

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Add { and } to shut up egcs. Reformat the more questionable code.

const poisoning.

* fix a long-term annoyance with tip: if raisechar or force are set to
"", (usually in .tiprc with lines like `raisechar='), don't activate
feature if NUL (\0) is the received character
* on a related note, don't barf if the following variables are defined
to "": disconnect, log, parity, record

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

headers, casts, and use of time_t

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

make evenpartab be of type 'unsigned char' to avoid -ansi -pedantic errors

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

unused file

headers, casts, and use of time_t

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

s/gleened/gleaned/ in comment.

branches: 1.20.28;
fix some error handling.

get rid of equal(), use {s,g}etprogname().

branches: 1.18.2; 1.18.24;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.17.12;
pass lint; from Anon Ymous

ANSIfy decls, de-__P, clean trailing whitespace

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

Remove extra \n from call to warn()

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

deal in a saner way with const strings.

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Add { and } to shut up egcs. Reformat the more questionable code.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

DC is not a user-settable variable, but was being partially confused with one

Add boolean for dc flag

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

tip.1: add missing markup

tip.1: amend -P argument parity details

tip.1: make some minor amendments

The paragraph about applying both -e and -o has never been correct for
NetBSD's implementation, from code and CVS history inspection. It looks
like it was a pasto from r. 1.26 when various parts of the OpenBSD man
page of the era were merged in.

Add an explanation of what cu(1)'s "dir" argument is for. (Really it's
optional and should be marked that way in the synopsis, but this seems
tricky to do while keeping the markup.)

While here, also borrow a historical note about cu(1) from OpenBSD.

branches: 1.34.2;
tip.1: s/Mail.1/mail.1/ ("Mail" was removed in 9)

Remove workaround for ancient HTML generation code.

Fix whitespace nits. Suggested by Bug Hunting.

branches: 1.31.6;
Use .Tn for XMODEM. Use .Bl -column for physically marked up table.

branches: 1.30.2;
Improve description in NAME section:
"serial terminal emulator"

From nick@openbsd via jmc@openbsd.

Punctuation nits.

Add missing cu synopsis and options.

Use Dq, punctuation vs whitespace nits.

Merge a few of the OpenBSD manual page changes. Not yet close to
finished but I have to break for now and Thor will probably pick up
from where I left off.

remove refs to uucp locking and aculog

ANSIfy decls, de-__P, clean trailing whitespace

Change manual page (as OpenBSD did) to reflect the actual arrangement of
file descriptors with ~C, instead of some weird ancient arrangement.

Document ~+ as a synonym for ~C.

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

English fix.

branches: 1.20.2;
Uppercase CPU.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

Comment out a line again.

New sentence, new line.

s/appeared command/command appeared/

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Sort SEE ALSO.

Add section to xref. Whitespace fixes.

branches: 1.11.2;
Fix missing space

branches: 1.10.8;
More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Fix minor formatting error.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Make lock directory match the code.

Fix spelling errors.

We're have a real cu now, so break the link between cu and tip.

Fix formatting bug.

Add RCS indentifiers.

branches: 1.1.1;
Initial revision

Avoid using common symbol definitions.

Make xgetchar() return an int like getchar() does, and remove needless cast.

Check getchar() result for EOF.

Call cleanup(SIGHUP) if we get local EOF, as if we've got SIGHUP.
While here, use EOF constant instead of literal -1 in an existing
check.

PR bin/53996

Make cu(1) and tip(1) recognize newline (^J) as end-of-line.
Now, tilde (~) after newline works as escape character as in ssh(1).
No objections when proposed on tech-userland.

branches: 1.59.14;
Drop main() prototype.

add missing quote, remove some braces.

fix some error handling.

Don't call exit() from a signal handler, as it's not async-signal-safe;
use _exit() instead.

Remove broken snprintf usage (noted in PR 47976) and replace with
something simpler.

don't enable IXANY.

branches: 1.53.2;
get rid of equal(), use {s,g}etprogname().

PR/47877: Michael van Elst: Disable and enable software flow control properly

branches: 1.51.2; 1.51.8;
Use __dead. Make a bunch of local functions static.

fix -Wsign-compare issues

Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.48.12;
Move #include <libgen.h> from tip.h to the place where it's really needed.
From: Slava Semushin <php-coder@altlinux.ru>

Moved ctype.h from header to source file in usr.bin/tip.
Also removed unused getopt header.

Patch contributed by Slava Semushin <slava.semushin@gmail.com>
in private mail.

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Use getopt() for arguments. Suggested by tls@.

Use closefrom, don't iterate over file descriptors from 3 to 20.

Replace abuse of SIGIOT, SIGEMT, SIGSYS for communication between the
TIPIN and TIPOUT processes with a third "attention" pipe. While we're
here, fix a few other minor nits like the hardcoded use of fd 3 in
consh().

Now ~+/~C appear to work. This must have been broken for years.

Move "cucommon" label (ugh) to above the O_NONBLOCK handling for direct
connections. This stops the tipout process from spinning.

actually set up baudrate after rev.1.33.

Pass a little lint.

delinting. more needed. (lint found some real bugs that I haven't fixed yet.)

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

New 'cu' command-line handling, derived from Todd Miller's in OpenBSD,
but with some long options added for Taylor 'cu' compatibility, and
with some bugs fixed (in particular, the handling of -# now works as
documented and does not overwrite argv).

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

Default to no parity instead of even parity. OpenBSD made this change
long ago, and I think it makes sense.

Add the rest of the speeds listed in termios.h. This is not, perhaps, as
sensible as the way OpenBSD supports arbitrary speeds; but we hardly add
new speeds often and this change is a lot less invasive.

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

Add (unsigned char) cast to ctype functions
islower() can be true for 0x80..0xff

Replaced strncpy with strlcpy. Thanks to Peter Postma who
pointed them our in PR #25762. Approved by christos@NetBSD.org.

deal in a saner way with const strings.

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

More format string cleanup by sommerfeld.

branches: 1.22.2; 1.22.10;
remove unused variable
char -> unsigned char

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

Rename an internal function who's name collides w/ pwrite(2).

Only turn off the O_NONBLOCK flag if DC flag is set.

Turn off the O_NONBLOCK flag after CLOCAL is set.

fix compile warnings on the alpha.

* fix a long-term annoyance with tip: if raisechar or force are set to
"", (usually in .tiprc with lines like `raisechar='), don't activate
feature if NUL (\0) is the received character
* on a related note, don't barf if the following variables are defined
to "": disconnect, log, parity, record

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

branches: 1.14.2;
DC is not a user-settable variable, but was being partially confused with one

Set CLOCAL if dc flag is set

getopt() returns:
- an int, not a char, and
- -1 upon completion, not EOF.

give buffers lengths; use strdup.

make evenpartab be of type 'unsigned char' to avoid -ansi -pedantic errors

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Fix parity calculation; PR #1325

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

setre[gu]id conversion.

Add RCS identifiers.

Flip euid to user immediately after opening log file, to allow .tiprc file
to be read without perms problems.

patch from David Greenman and Rod Grimes (davidg@implode.rain.com and
rgrimes@agora.rain.com) to support 57600 and 115200 baud

branches: 1.1.1;
Initial revision

fix various small typos, mainly in comments.

s/begining/beginning/ in comments and messages.

usr.bin: remove unnecessary lint comment CONSTCOND

Since 2021-01-31, lint no longer warns about 'do ... while (0)'.

No functional change.

Avoid using common symbol definitions.

get rid of equal(), use {s,g}etprogname().

branches: 1.32.2; 1.32.8;
Use __dead. Make a bunch of local functions static.

fix language

Move #include <libgen.h> from tip.h to the place where it's really needed.
From: Slava Semushin <php-coder@altlinux.ru>

Moved ctype.h from header to source file in usr.bin/tip.
Also removed unused getopt header.

Patch contributed by Slava Semushin <slava.semushin@gmail.com>
in private mail.

pass lint; from Anon Ymous

Use closefrom, don't iterate over file descriptors from 3 to 20.

Replace abuse of SIGIOT, SIGEMT, SIGSYS for communication between the
TIPIN and TIPOUT processes with a third "attention" pipe. While we're
here, fix a few other minor nits like the hardcoded use of fd 3 in
consh().

Now ~+/~C appear to work. This must have been broken for years.

Pass a little lint.

delinting. more needed. (lint found some real bugs that I haven't fixed yet.)

Wwwwwwww! Do not remove variables from the vtable in vars.c without
changing the indices in tip.h -- what a terrible design.

Okay, "design". Fine. Whatever. ;-) Now we don't dump core all the time.

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

Fix the conditional compilation on ACULOG so it actually works.
Turn it off by default -- it hardly saves any space, but it's
one of the reasons why the executable is installed setuid, and
other versions of tip/cu don't write a log file anyway. We can
add syslog support later if we ever really want this back, the
file-writing is all encapsulated in log.c.

New 'cu' command-line handling, derived from Todd Miller's in OpenBSD,
but with some long options added for Taylor 'cu' compatibility, and
with some bugs fixed (in particular, the handling of -# now works as
documented and does not overwrite argv).

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

synchron*, not sychron*

Spell "privilege" correctly (correct spelling from Jonathan Stone).

<sys/dir.h> -> <dirent.h>
<sys/file.h> -> <fcntl.h>

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

Rename an internal function who's name collides w/ pwrite(2).

Include <time.h>, needed for various definitions. Also, per KNF, don't include
both <sys/param.h> and <sys/types.h>; the former is sufficient.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Add boolean for dc flag

Change booleans from char to int so that comparisons against negative
values work as expected on systems with unsigned chars.

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead. Make a bunch of local functions static.

pass lint; from Anon Ymous

Use closefrom, don't iterate over file descriptors from 3 to 20.

Replace abuse of SIGIOT, SIGEMT, SIGSYS for communication between the
TIPIN and TIPOUT processes with a third "attention" pipe. While we're
here, fix a few other minor nits like the hardcoded use of fd 3 in
consh().

Now ~+/~C appear to work. This must have been broken for years.

Pass a little lint.

ANSIfy decls, de-__P, clean trailing whitespace

Treat EOF the same as EIO. Prevents spinning if an EOF condition is
encountered, such as a USB serial device being unplugged.

Instead of spinning, the process reading from the serial line will exit,
leaving the process reading from the local terminal to exit when it notices
that its child has gone away.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

If we might have two links, we'd better print our program name when we
emit an error -- and it would be nice if it were the *right* program name.
Since it's convenient, change most perror calls to warn, and a lot of
fprintf ... exit to errx. Fix at least one fprintf that could run off
the end of its arguments (%s but no argument, how did we never catch this?).

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Lseek(2) usage cleanup: the use of L_SET/L_INCR/L_XTND is deprecated,
use SEEK_SET/SEEK_CUR/SEEK_END instead.

give buffers lengths; use strdup.

Fix crash with null eofwrite capabilityand lseek/off_t bug; PR #1346

headers, casts, and use of time_t

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

Peter da Silva's <peter@taronga.com> for tip to obey the
taylor UUCP locking convention

branches: 1.1.1;
Initial revision

get rid of equal(), use {s,g}etprogname().

branches: 1.14.34; 1.14.40;
pass lint; from Anon Ymous

Pass a little lint.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

- KNF
- use snprintf
- be safe with buffers (change prompt() to take a size_t len arg for this)

fix compile warnings on the alpha.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

replace old zzhack structure (YUCK!) and number(), boolean(), character(),
and address() macros with new macros of the same names (to get values),
and macros with those names but with "set" prepended and which take a
second argument (to set values). The new macros use type casts to do
type conversion, which is much cleaner than using a union and making
endianness-related hacks to get the right 'short's and 'char's from
the right array indices. (YUCK! again, for good measure.)

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Pass a little lint.

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

At Luke Mewburn's suggestion, disable "force" by default, too. Those using
the tip frontend who really want ^P used for "send literal" can turn it on
in tiprc or remote.

Default the "raisechar" value (for the insane old case-mapping) to NULL.
As the same change in the OpenBSD tree says, "if you are crazy enough
to want it, then it can be turned on in /etc/remote."

pull the following change from OpenBSD
and bump date of the manpage.

date: 2003/09/20 18:15:32; author: millert; state: Exp; lines: +4 -2
Implement hardwareflow varable in tip(1) like Solaris and hf in /etc/remote.
Based on PR 3411 from Matthew Gream
Also document "tandem" variable (XON/XOFF) in tip man page.

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

NULL => 0 (Arne Juul; PR#3629)

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

Remove support for uucp style locking.

This means we can get rid of the suid/sgid parts of the code (which
have been removed). The program is now installed with normal permissions.

To prevent accidents, we now flock the tty line, attempting to get an
exclusive lock.

Reviewed by: tls

ANSIfy decls, de-__P, clean trailing whitespace

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

sigvec->sigaction
sigblock->sigprocmask
sigpause->sigsuspend
XXX: code could be shared here.

KNF. ensure buffers are not overrun.

use static int instead of static

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

fix from Bakul Shah <bvs@BitBlocks.com> to make tip not dump core
when courier acu routines are used with a non-USR Courier modem.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

ANSIfy decls, de-__P, clean trailing whitespace

Use O_WRONLY / O_RDWR instead of bare integers.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Use __dead. Make a bunch of local functions static.

fix -Wsign-compare issues

pass lint; from Anon Ymous

sprinkle volatile.

Pass a little lint.

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

translate '=' in phone number strings into ',' (to generate delays),
as is done for couriers and t3000s. Ahh, the wonders of being in
a hotel room with source.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

sigvec->sigaction
sigblock->sigprocmask
sigpause->sigsuspend
XXX: code could be shared here.

KNF. ensure buffers are not overrun.

use static int instead of static

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

branches: 1.1.1;
Initial revision

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

PR 51192 David Binderman: fix wrong logic (probably)

XXX: this file should probably just be deleted

pass lint; from Anon Ymous

ANSIfy decls, de-__P, clean trailing whitespace

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

char -> unsigned char

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

s/reseting/resetting/

pass lint; from Anon Ymous

kill the (void)&foo; from Anon Ymous

Remove vestiges of the ACULOG support. It depended on the suid support
(which is now gone) and it is woefully obsolete -- if something
analogous is ever needed in the future, syslog is the way to do it.

ANSIfy decls, de-__P, clean trailing whitespace

Add (unsigned char) cast to ctype functions
islower() can be true for 0x80..0xff

constify and warns = 3

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

char -> unsigned char

KNF. ensure buffers are not overrun.

WARNSify, KNFify, using ANSI string functions, cleanup .Nm usage

give buffers lengths; use strdup.

fix up -ansi -pedantic warnings produced because of static function
declarations nested in other functions. The solution: declare the
static functions at the top level.

Convert to termios (from Scott Reynolds; PR#1621).
8-bit patches (from Matthieu Herrb; PR#1384).

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

branches: 1.1.1;
Initial revision