lint: remove redundant LINTFLAGS for lint2

The -T flag is already provided by ../Makefile.inc, along with several
other flags.

lint: move xalloc to the only file where it is used

No functional change.

lint: only include code in the binaries that is actually used

No functional change.

lint: force strict bool mode

No functional change.

lint: remove WARNS=3, falling back to the default WARNS=5

It's strange that GCC does not warn about the nonliteral format strings
in lint1/err.c, lint2/msg.c and lint2/read.c, despite -Wformat=2, but
Clang does.

lint: use distinct struct tags for type_t in lint1 and lint2

Having two similar but still different definitions of 'struct type' is
unnecessarily confusing. Exchange this confusion for 8 lines of
straight-forward preprocessing code.

lint: fix LINTFLAGS for lint2

These have never worked since they report a syntax error in
<sys/cdefs.h> just because there is an __inline over there.

I wonder why it has been necessary at all to have custom LINTFLAGS for
lint itself. It's just an ordinary program.

WFORMAT is no more...

Factor out tyname() so that it can be used both by lint1 and lint2.
Since type_t is different between lint1.h and lint2.h include the
appropriate file depending on the pass. Make the argument mismatch
error print the type names of the types involved. Now that we have
a tyname() function we can fix the rest of the pass2 warnings to be
more explanatory, but not now.

Now that <bsd.prog.mk> DTRT if HOSTPROG is defined (i.e, it is a no-op),
there's no need to special-case .include-ing it.

makefile delint. use NETBSDSRCDIR as appropriate

Centralize the initialization/declaration of the ttab.

* Move stuff shared between lint1 and lint2 to the new common/ directory.
* Move the arch/ directory out of lint1/ into the top-level.

MKfoo=no -> NOfoo

Major overhaul of src/tools and host toolchain. Summary of changes:

* Rewrite src/tools Make logic to work like the rest of the tree wrt
"dependall" and "install". The old "make build" hack is gone.

* Remove the MKTOOLS logic. This was linked to the "make build" hack,
and was only needed because TOOLDIR originally had no writable default.

* Redo the GNU configure/make logic to make it fit reasonably in a
BSD make wrapper. Use new ${.ALLTARGETS} variable to scan for
targets in $(srcdir), and mark them with .MADE: to prevent rebuilding.

* Only build cross tools in src/tools; remove some messy logic in
src/usr.* and src/gnu/usr.* that would do target filename rewriting
(improves consistency and readability).

* Add the ability to build cross gdb at tool build time by setting
MKCROSSGDB (default no) to "yes" in mk.conf.

* Add src/tools/groff and set up paths to work with this cross groff.

Add support for putting prefixes on the name of lint(1)'s front
and back ends. This means that it can be built as a cross tool.
Part of the fix for bin/14280.

Add hooks to allow toolchain bits to be reachover-built at the top level.

More format string cleanup by sommerfeld.

branches: 1.6.2; 1.6.10;
convert from NOxxx= to MKxxx=no.
include <bsd.own.mk> if testing a MKxxx variable.

use CPPFLAGS instead of CFLAGS

branches: 1.4.2;
Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: reword lint2 warnings, reduce punctuation

The previous diagnostics used unusual punctuation, for example by placing
spaces inside parentheses, as well as using space-space-tab and
double-colon as separators. Convert these diagnostics into readily
readable prose, and mark them clearly as coming from lint2, so that they
can be related to the tests in /usr/tests/usr.bin/xlint/lint2/msg_???.ln.

This change means that usr.bin/error no longer recognizes these messages
as coming from lint2, but that can be fixed later if necessary.

branches: 1.2.4;
tests/lint: align message checker for lint2 to the one from lint1

No functional change.

lint2: add redundancy checker for comments in source code

Based on the redundancy checker for lint1.

No functional change.

lint: constify

lint: fix wording in a warning about a type conflict

An object does not have a return type, only functions do.

lint: remove now-unnecessary CONSTCOND comments

lint: normalize whitespace

lint: reword lint2 warnings, reduce punctuation

The previous diagnostics used unusual punctuation, for example by placing
spaces inside parentheses, as well as using space-space-tab and
double-colon as separators. Convert these diagnostics into readily
readable prose, and mark them clearly as coming from lint2, so that they
can be related to the tests in /usr/tests/usr.bin/xlint/lint2/msg_???.ln.

This change means that usr.bin/error no longer recognizes these messages
as coming from lint2, but that can be fixed later if necessary.

branches: 1.67.2;
lint: add wrapper for <ctype.h> functions, for strict bool mode

When using the Clang preprocessor (with MKLLVM=yes), the preprocessor
output does not indicate which tokens come from a system header and
which tokens come from the user code. Lint's strict bool mode relies on
this information to treat the character classification functions from
<ctype.h> as if their return type were bool instead of int.

These wrapper functions are only used when their argument is indeed a
'char', but not when the argument might be 'EOF or representable as an
unsigned char', such as when reading a byte from the input.

lint: remove custom wrappers around <ctype.h> functions

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: indent statement continuations consistently

No binary change.

lint: remove redundant empty lines

No functional change.

lint: make diagnostics about ANSI C more international

lint: indent copyright lines consistently

lint: push memory management one layer down

Just as with type_name in lint1, it is more convenient if the
application code does not have to deal with memory management.

lint: clean up lint2

lint: invert the -u, -v and -z flags

Now they behave the same as in the manual page.

No functional change.

lint: rename uppercase QUAD to LLONG

No binary change.

lint: indent local variables consistently

No binary change.

lint: rename constant NOTSPEC to NO_TSPEC

It was too easy to misread the old name as NOT_SPEC instead of the
intended NO_TSPEC.

lint: rename lint2 functions to be more expressive

lint: add hyphen to adjective 'old-style'

lint: clean up visual clutter

No functional change.

lint: rename functions to be clearer

No need anymore to keep external identifiers at the "6 significant
initial characters" mandated by C90.

lint: clean up comments

No binary change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: expand the last remaining __arraycount

For consistency with the other expressions for an array length, which
already use the expanded form.

No functional change.

lint: clean up lint2

No functional change.

lint: un-abbreviate members of sym_t

No functional change.

lint: constify lint2 checking functions

No functional change.

lint: force strict bool mode

No functional change.

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint2: align comments in the code with actual messages

lint: change spelling of initialisation to initialization

That's the wording from the ISO C99 standard.

lint: rename t_isenum and t_aincompl to be more expressive

No functional change.

lint: update data types in comments from int to bool

lint: clean up code (mostly comments)

lint: replace integer constant expressions with true and false

LINTFLAGS=-gST make lint, with manual review.

The error messages from lint are all correct, they are not complete
though. The return value of a function returning bool may still be
compared to the integer 0.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: rename type classification macros

The previous names tspec_is_int and tspec_is_uint were confusing because
there are actually tspec_t constants called INT and UINT, these
classification macros return true for other integer types as well,
though.

While here, remove the prefix "tspec_" from these macros. It wasn't as
helpful as intended, in many cases it was obviously redundant, when it
was called as tspec_is_integer(tn->tn_type->t_tspec).

No functional change.

lint: fix typos and other minor stylistic issues

lint: fix buffer truncation for type names

Previously, most type names had been cut off after 63 significant
characters. In some cases, 127 characters survived, or 255. And for
the debugging messages, sometimes even 1023. This inconsistency was
useless.

It was wrong in the first place to make the caller of the function
tyname responsible for handling the buffer. That's not something a
caller of such a simple function should do. These callers have better
things to do.

The API of the new function type_name is as simple as possible.

In the implementation, the name of the type is generated anew each time.
I just didn't know whether the type details could change, once the type
is initialized, and I didn't want to find out. To be on the safe side,
the resulting type name is cached, independently of the type it was
generated for. Using a trivial, unbalanced binary tree should be good
enough for now.

All this work is necessary to support adding new debug logging, without
being distracted by irrelevant implementation details such as these
buffer sizes. Adding new debug messages should be fun and easy; up to
now, it was overly bureaucratic.

lint: rename styp and utyp

lint: rename more _nxt members to _next

lint: rename s_nxt to s_next

lint: remove redundant parentheses around return value

lint: remove trailing whitespace

lint: sort includes

lint: rename tspec macros

Don't print duplicate definitions for inline symbols.

Fix typo in comment.

Add a list of functions where we usually don't care about their return
code. Can be bypassed by -hh

Fix -Wshadow issues

branches: 1.19.8;
print the types involved in the mismatch.

branches: 1.18.20;
Factor out tyname() so that it can be used both by lint1 and lint2.
Since type_t is different between lint1.h and lint2.h include the
appropriate file depending on the pass. Make the argument mismatch
error print the type names of the types involved. Now that we have
a tyname() function we can fix the rest of the pass2 warnings to be
more explanatory, but not now.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.16.4;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

Centralize the initialization/declaration of the ttab.

Initialize the type table with the correct type sizes for the target.

"than" instead of "then".

Various typos in comments (neccessary, sceme, choise, ...).

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.8.8;
If the return value is sometimes discarded, output `sometimes ignored' rather
than `always ignored'.

Fix a recurring typo: comparision -> comparison.

Fix uses of uninitialized memory, and incorrect types for initializers.
From ITOH Yasufumi, PR 5861.

WARNSify

in chkdnud(), don't warn if the defined-but-not-used object is a function.
chkdnud() is used (only) to implement the -x option, which is supposed to
warn for variables only.

branches: 1.3.2;
* Ignore the size of integer arguments when trying to automatically
convert them to pointers. If they're zero, they're converted (to
NULL pointers) regardless of size. If they're non-zero, they can't
be converted (without a cast). This matches the behavior of other
version of lint, e.g. the lints on Digital UNIX and HP-UX.

* recognize that pointers to identical unnamed and untyped structs,
unions, and enums are, in fact, identical. This is done by tagging
each of unnamed and untyped structure, union and enum with a unique
position of creation, which is used as a unique identifier that
when determine whether or not a pair of structures, unions, or enums
are identical.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: constify

lint: clean up

lint: support GCC's __auto_type

Fixes PR toolchain/58654.

branches: 1.39.2;
lint: add wrapper for <ctype.h> functions, for strict bool mode

When using the Clang preprocessor (with MKLLVM=yes), the preprocessor
output does not indicate which tokens come from a system header and
which tokens come from the user code. Lint's strict bool mode relies on
this information to treat the character classification functions from
<ctype.h> as if their return type were bool instead of int.

These wrapper functions are only used when their argument is indeed a
'char', but not when the argument might be 'EOF or representable as an
unsigned char', such as when reading a byte from the input.

lint: remove custom wrappers around <ctype.h> functions

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: clean up comments

There's no output buffer anymore.

lint: remove redundant comments

lint: for each record in the output file, write the newline immediately

There's no point delaying the '\n' until the next line is written.

lint: indent copyright lines consistently

lint: clean up initialization of type properties

No functional change.

lint: indent local variables consistently

No binary change.

lint: clean up

In symtab_search, most of the conditions were redundant, so remove them.

In read_byte, using CHAR_MASK was conceptually wrong, as that constant
is from the target platform while the lexical analysis happens on the
host platform. It was unnecessary as well, as a hypothetical host
platform with 36-bit chars might encode the characters from the basic
source character set as numbers higher than 0x0_0000_00ff. Since lint
assumes that both the source character set as well as the execution
character set are the same and based on 8-bit bytes, nothing changes.

No functional change.

lint: clean up messages for internal errors

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: clean up lint2

No functional change.

lint: inline local variables in outtype

No functional change.

lint: condense code for writing to a lint library

Same as in lint1.

No functional change.

lint: use 'char' as type for passing characters to functions

No functional change.

lint: un-abbreviate members of sym_t

No functional change.

lint: write the entries for the libraries in alphabetical order

This makes them easier to read by humans.

The checks are still performed in hashcode order since there are no
tests that would cover this change.

lint: remove unused parameter from forall

No functional change.

lint: allow libraries to use 128-bit integer types

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint: change spelling of initialisation to initialization

That's the wording from the ISO C99 standard.

lint: rename t_isenum and t_aincompl to be more expressive

No functional change.

lint: rename s_nxt to s_next

lint: remove redundant parentheses around return value

Teach lint about long double _Complex (C99)

same change: double is emitted as '\0'

handle lintlibrary output of _Complex types.

branches: 1.10.26;
recognize _Bool.

Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

Various typos in comments (neccessary, sceme, choise, ...).

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.4.8;
WARNSify

* recognize that pointers to identical unnamed and untyped structs,
unions, and enums are, in fact, identical. This is done by tagging
each of unnamed and untyped structure, union and enum with a unique
position of creation, which is used as a unique identifier that
when determine whether or not a pair of structures, unions, or enums
are identical.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: constify

lint: KNF

branches: 1.22.2;
lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: indent copyright lines consistently

lint: clean up lint2

lint: rename lint2 functions to be more expressive

lint: move xalloc to the only file where it is used

No functional change.

lint: remove custom memory allocator

Besides adding complexity, the custom memory allocator didn't invalidate
freed memory, which made it harder to find possible use-after-free bugs.

lint: clean up initialization of lint2 symbol table

No functional change.

lint: hide irrelevant type information from lint2

No functional change.

lint: write the entries for the libraries in alphabetical order

This makes them easier to read by humans.

The checks are still performed in hashcode order since there are no
tests that would cover this change.

lint: remove unused parameter from forall

No functional change.

lint: remove Tflag and pflag from common declarations

These flags are only needed by lint1 and lint2, but not by the driver
xlint.

No functional change.

lint: constify lint2 checking functions

No functional change.

lint: clean up comments

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

Centralize the initialization/declaration of the ttab.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.5.8;
WARNSify

implement (hack in) symbol (function and variable) renaming, so that
the function renaming tricks currently needed by libc can be tolerated
by lint. This needs some cleanup, but it appears to work.

branches: 1.3.2;
* recognize that pointers to identical unnamed and untyped structs,
unions, and enums are, in fact, identical. This is done by tagging
each of unnamed and untyped structure, union and enum with a unique
position of creation, which is used as a unique identifier that
when determine whether or not a pair of structures, unions, or enums
are identical.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: constify

branches: 1.29.2;
lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: indent copyright lines consistently

lint: clean up lint2

lint: clean up wchar_t and hash tables

lint: indent local variables consistently

No binary change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: clean up initialization of lint2 symbol table

No functional change.

lint: clean up hash functions

No functional change.

lint: fold constants in hash functions

All platforms supported by lint have sizeof(unsigned int) == 4 and
CHAR_BIT == 8. There is no need to encode these expressions in a hash
function, they only made the code harder to read.

No functional change.

lint: fix memory leak in symtab_forall_sorted (since today)

lint: write the entries for the libraries in alphabetical order

This makes them easier to read by humans.

The checks are still performed in hashcode order since there are no
tests that would cover this change.

lint: remove unused parameter from forall

No functional change.

lint: un-abbreviate unsigned integer types

No functional change.

lint: use unsigned integers for storing hash values

The computation of the hash values is unchanged, only the resulting
value (which is always less than 1009 anyway, see HSHSIZ2) is stored as
unsigned as well.

No functional change.

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: remove redundant parentheses around return value

Lukemify (WARNS=4)

Fix -Wcast-qual issue

branches: 1.9.36;
Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.8.4;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

Fix uses of uninitialized memory, and incorrect types for initializers.
From ITOH Yasufumi, PR 5861.

WARNSify

implement (hack in) symbol (function and variable) renaming, so that
the function renaming tricks currently needed by libc can be tolerated
by lint. This needs some cleanup, but it appears to work.

branches: 1.2.4;
RCS id cleanup

branches: 1.1.1;
Initial revision

lint: constify

lint: clean up

lint: normalize whitespace

branches: 1.27.2;
lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: move function body brace to the left

No functional change.

lint: indent copyright lines consistently

lint: clean up lint2

lint: drop compatibility with C90

Since tools/README 1.5 from 2022-02-03, the tools no longer need to be
compatible with C90, they may now use C99 features. Lint had used
<stdbool.h> and snprintf already.

No functional change.

lint: remove spaces around bit-field colon

As seen in /usr/share/misc/style.

No binary change.

lint: enter full C90 compatibility mode

The C99 comment in tree.c:3468 has been there since 2017-03-06, without
anyone complaining that their compiler would not handle it.

Strangely, running GCC 10.3.0 in '-std=c90' mode does not complain about
declarations after statements, '-Wdeclaration-after-statement' is needed
separately.

No functional change.

lint: un-abbreviate members of sym_t

No functional change.

lint: in debug mode, use proper type for sym_t.s_def

lint: un-abbreviate unsigned integer types

No functional change.

lint: save some memory

Before lint1.h 1.47 from 2021-01-02, adjacent bit-field struct members
shared storage. Restore that using smaller types.

No functional change.

lint: convert TP from macro to inline function

No functional change.

lint: use distinct struct tags for type_t in lint1 and lint2

Having two similar but still different definitions of 'struct type' is
unnecessarily confusing. Exchange this confusion for 8 lines of
straight-forward preprocessing code.

lint: rename t_isenum and t_aincompl to be more expressive

No functional change.

lint: use bool instead of u_int:1 in structures

Better late than never.

lint: rename more _nxt members to _next

lint: rename s_nxt to s_next

lint: fix typo in comments

Don't print duplicate definitions for inline symbols.

Factor out tyname() so that it can be used both by lint1 and lint2.
Since type_t is different between lint1.h and lint2.h include the
appropriate file depending on the pass. Make the argument mismatch
error print the type names of the types involved. Now that we have
a tyname() function we can fix the rest of the pass2 warnings to be
more explanatory, but not now.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.4.8;
implement (hack in) symbol (function and variable) renaming, so that
the function renaming tricks currently needed by libc can be tolerated
by lint. This needs some cleanup, but it appears to work.

branches: 1.3.2;
* recognize that pointers to identical unnamed and untyped structs,
unions, and enums are, in fact, identical. This is done by tagging
each of unnamed and untyped structure, union and enum with a unique
position of creation, which is used as a unique identifier that
when determine whether or not a pair of structures, unions, or enums
are identical.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: constify

branches: 1.35.2;
lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: indent copyright lines consistently

lint: replce sprintf with snprintf

Even though the sprintf calls were safe, they looked suspicious.

No functional change.

lint: clean up lint2

lint: sync usage messages with reality

lint: invert the -u, -v and -z flags

Now they behave the same as in the manual page.

No functional change.

lint: indent local variables consistently

No binary change.

lint: warn about extern declarations outside headers

https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

lint: return instead of calling exit from main

No functional change.

lint: rename lint2 functions to be more expressive

lint: remove custom memory allocator

Besides adding complexity, the custom memory allocator didn't invalidate
freed memory, which made it harder to find possible use-after-free bugs.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: clean up initialization of lint2 symbol table

No functional change.

lint: hide irrelevant type information from lint2

No functional change.

lint: sort the lint2 diagnostics by symbol name

lint: remove unused parameter from forall

No functional change.

lint: constify lint2 checking functions

No functional change.

lint: add reminder to sort the output of lint2

lint: remove WARNS=3, falling back to the default WARNS=5

It's strange that GCC does not warn about the nonliteral format strings
in lint1/err.c, lint2/msg.c and lint2/read.c, despite -Wformat=2, but
Clang does.

lint: clean up option parsing

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: update usage for lint1 and lint2

(Forgotten in the previous commit.)

lint: add new check for strict bool mode

In strict bool mode, bool is considered incompatible with all other
scalar types, just as in Java, C#, Pascal.

The controlling expressions in if statements, while loops, for loops and
the '?:' operator must be of type bool. The logical operators work on
bool instead of int, the bitwise operators accept both integer and bool.
The arithmetic operators don't accept bool.

Since <stdbool.h> implements bool using C preprocessor macros instead of
predefining the identifiers "true" and "false", the integer constants 0
and 1 may be used in all contexts that require a bool expression.
Except from these, no implicit conversion between bool and scalar types
is allowed.

See usr.bin/tests/xlint/lint1/d_c99_bool_strict.c for more details.

The command line option -T has been chosen because all obvious choices
(-b or -B for bool, -s or -S for strict) are already in use. The -T may
stand for "types are checked strictly".

The default behavior of lint doesn't change. The strict bool check is
purely optional.

An example program for strict bool mode is usr.bin/make, which has been
using explicit comparisons such as p != NULL, ch != '\0' or n > 0 in
most places for a long time now, even before the refactoring in 2020.

lint: fix typos and other minor stylistic issues

Drop main() prototype.

Add a list of functions where we usually don't care about their return
code. Can be bypassed by -hh

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.6.4;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

"than" instead of "then".

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

WARNSify

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: move xalloc to the only file where it is used

No functional change.

lint: remove custom memory allocator

Besides adding complexity, the custom memory allocator didn't invalidate
freed memory, which made it harder to find possible use-after-free bugs.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: fix memory allocation (since 2021-08-28)

In mem1.c 1.50 and mem2.c 1.13 from 2021-08-28, I accidentally changed
the initialization of mblklen from round_up to round_down, trying to
avoid a division instruction.

On NetBSD x86_64 this resulted in a few more malloc calls, but on Cygwin
with its 64k pagesize, mblklen became 0. Later, the function xalloc in
lint2 called xalloc(mblklen) and blindly assumed that the returned
memory would be large enough. This in turn led to out-of-bounds memory
access and crashes. Lint1 was not affected since it adjust mblklen
during runtime if it gets too small.

lint: use 'unsigned int' for bit-size of types

Lint does not need to support any types larger than 256 MB since they
don't occur in practice. Practically, such large types have never been
supported at all since the function type_size_in_bits used int for the
internal calculations, resulting in overflows.

lint: remove xmapalloc

Just trust the standard malloc to be smart enough.

No functional change.

lint: remove redundant parentheses around return value

lint: sort includes

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.8.2;
PR/23219: Dan McMahill: Make this compile on system that don't have MAP_ANON.
Centralize the mmap allocations in a new function, xmapalloc() that handles
this.

Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

WARNSify

support asm statements and asm modifiers in declarations

asm statements consist of an asm keyword, an optional qualifier, a
left paren, a list of tokens up to and including the matching right
paren, and a semicolon.

asm modifiers consist of an asm keyword, an left paren, a string and a
right paren.

asm statements and modifiers have no semantic for lint(1), they exist only
to avoid complaints about them.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: fix wording in a warning about a type conflict

An object does not have a return type, only functions do.

lint: reword lint2 warnings, reduce punctuation

The previous diagnostics used unusual punctuation, for example by placing
spaces inside parentheses, as well as using space-space-tab and
double-colon as separators. Convert these diagnostics into readily
readable prose, and mark them clearly as coming from lint2, so that they
can be related to the tests in /usr/tests/usr.bin/xlint/lint2/msg_???.ln.

This change means that usr.bin/error no longer recognizes these messages
as coming from lint2, but that can be fixed later if necessary.

branches: 1.25.2;
lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: indent copyright lines consistently

lint: push memory management one layer down

Just as with type_name in lint1, it is more convenient if the
application code does not have to deal with memory management.

lint: replce sprintf with snprintf

Even though the sprintf calls were safe, they looked suspicious.

No functional change.

lint: clean up lint2

lint: indent local variables consistently

No binary change.

lint: make basename simpler

There is no need to handle trailing slashes since lint only handles
regular files in diagnostics, not directories. Furthermore, only the
last '/' was ignored, but multiple trailing slashes would not.

lint: clean up

In symtab_search, most of the conditions were redundant, so remove them.

In read_byte, using CHAR_MASK was conceptually wrong, as that constant
is from the target platform while the lexical analysis happens on the
host platform. It was unnecessary as well, as a hypothetical host
platform with 36-bit chars might encode the characters from the basic
source character set as numbers higher than 0x0_0000_00ff. Since lint
assumes that both the source character set as well as the execution
character set are the same and based on 8-bit bytes, nothing changes.

No functional change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: un-abbreviate unsigned integer types

No functional change.

lint: remove space between 'sizeof ('

No functional change.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: remove redundant parentheses around return value

lint: sort includes

Fix format string usage

print the types involved in the mismatch.

branches: 1.9.20;
Factor out tyname() so that it can be used both by lint1 and lint2.
Since type_t is different between lint1.h and lint2.h include the
appropriate file depending on the pass. Make the argument mismatch
error print the type names of the types involved. Now that we have
a tyname() function we can fix the rest of the pass2 warnings to be
more explanatory, but not now.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.7.4;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

WARNSify

implement (hack in) symbol (function and variable) renaming, so that
the function renaming tricks currently needed by libc can be tolerated
by lint. This needs some cleanup, but it appears to work.

branches: 1.2.4;
RCS id cleanup

branches: 1.1.1;
Initial revision

lint: reword lint2 warnings, reduce punctuation

The previous diagnostics used unusual punctuation, for example by placing
spaces inside parentheses, as well as using space-space-tab and
double-colon as separators. Convert these diagnostics into readily
readable prose, and mark them clearly as coming from lint2, so that they
can be related to the tests in /usr/tests/usr.bin/xlint/lint2/msg_???.ln.

This change means that usr.bin/error no longer recognizes these messages
as coming from lint2, but that can be fixed later if necessary.

branches: 1.92.2;
lint: add wrapper for <ctype.h> functions, for strict bool mode

When using the Clang preprocessor (with MKLLVM=yes), the preprocessor
output does not indicate which tokens come from a system header and
which tokens come from the user code. Lint's strict bool mode relies on
this information to treat the character classification functions from
<ctype.h> as if their return type were bool instead of int.

These wrapper functions are only used when their argument is indeed a
'char', but not when the argument might be 'EOF or representable as an
unsigned char', such as when reading a byte from the input.

lint: remove custom wrappers around <ctype.h> functions

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: indent statement continuations consistently

No binary change.

lint: indent copyright lines consistently

lint: push memory management one layer down

Just as with type_name in lint1, it is more convenient if the
application code does not have to deal with memory management.

lint: clean up lint2

lint: clean up wchar_t and hash tables

lint: enable more lint warnings for its own source code

lint: rename uppercase QUAD to LLONG

No binary change.

lint: indent local variables consistently

No binary change.

lint: rename constant NOTSPEC to NO_TSPEC

It was too easy to misread the old name as NOT_SPEC instead of the
intended NO_TSPEC.

lint: use __printflike

lint: clean up messages for internal errors

lint: move xalloc to the only file where it is used

No functional change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: remove redundant braces

No binary change.

lint: reduce pointer usage when reading .ln lines

No binary change.

lint: remove unused parameter in read_ln_line

lint: improve error message for missing newline in .ln file

lint2: in case of parse errors, output the offending line

This provides more of a clue than a simple '(not alnum or _: )',
especially in the output of build.sh.

While here, change the format of the error message to the standard
'%s:%d'. Since these are internal errors, they are not supposed to occur
often, so no need to change error(1).

lint: move fgetln peculiarities out of read_ln_line

This allows the function parameter to be a pointer to const.

No functional change.

lint: clean up lint2

No functional change.

lint: clean up initialization of lint2 symbol table

No functional change.

lint: remove source code references from internal error message

The additional strings that are provided with the error message are
distinctive enough.

lint: extract function for reading a single line from a .ln file

No functional change.

lint: fix some more lint warnings

The only remaining warnings are in scan.c, which is a generated Flex
scanner.

No functional change.

lint: reduce complexity of reading a function call

No functional change.

lint: extract parse_function_attribute from decldef

No functional change.

lint: remove redundant call to strchr in decldef

This time, the branches for varargs, printflike and scanflike in the big
switch statement are covered by unit tests. These tests would have
caught the previous "cleanup" that broke parsing of these function
attributes. Furthermore, this second cleanup is closer to the original
code and conceptually simpler since it avoids having many 'continue'
statements in a 'switch' statement, which would have been unusual.

The branches for inline functions and used functions are still not
covered by the tests, but they are structurally equal to several other
branches.

No functional change.

lint: revert "remove redundant call to strchr" from yesterday

This "refactoring" broke the parsing code for varargs, printflike and
scanflike functions, and there were no tests for these. Revert for now,
maybe try again later, after adding the corresponding tests.

Move the character one back so that we don't increment twice

Skip the current character before parsing the number of arguments.

lint: remove redundant call to strchr

lint: un-abbreviate members of sym_t

No functional change.

lint: un-abbreviate unsigned integer types

No functional change.

lint: clean up error handling in lint2

These are edge cases that don't happen in practice, therefore reduce the
size of the binary.

lint: use unsigned integers for storing hash values

The computation of the hash values is unchanged, only the resulting
value (which is always less than 1009 anyway, see HSHSIZ2) is stored as
unsigned as well.

No functional change.

lint: simplify reading of type qualifiers in lint2

The only producer of .ln files is lint1, which always writes the type
qualifiers in the order 'c', 'v', therefore there is no need to expect
any other order or check for duplicates. There is no ambiguity since
the other type modifiers are neither 'c' nor 'v' and the main types are
all uppercase letters.

No functional change.

lint: clean up switch statements in gettlen

Since the switch statements are only about tagged and derived types,
there is no need to list all integer and floating types.

No functional change.

lint: convert TP from macro to inline function

No functional change.

lint: extract parse_tspec from inptype

Add error handling for unknown type character, which led to read of
uninitialized memory before. No practical change as far as lint2 only
ever reads output from lint1, since that is well-formed.

lint: force strict bool mode

No functional change.

lint: fix type of local variable in inpqstrg

Noted by Clang-Tidy.

lint: fix handling of __int128_t/__uint128_t in lint2

Previously, lint exited with "bad type: J u".

lint: improve support for __int128_t and __uint128_t

For the .ln files, I chose the letter 'J' to represent the 128-bit
integer types since it is close to 'I' for int. The naming of 'L' for
'long' is obvious, but 'Q' for 64-bit integers is a quad-16-bit word,
which is an unusual measurement unit nowadays. One benefit of choosing
'J' is that the next letter, 'K' can then be used for 256-bit integer
types.

Support for 128-bit integer types is still very basic. Plus, it is only
supported on LP64 platforms, which means that lint cannot be
cross-compiled to check for an LP64 platform while running on an ILP32
platform.

lint: remove WARNS=3, falling back to the default WARNS=5

It's strange that GCC does not warn about the nonliteral format strings
in lint1/err.c, lint2/msg.c and lint2/read.c, despite -Wformat=2, but
Clang does.

lint: reduce duplicate code for parsing .ln files

lint: fix error message in lint2 for missing record type in .ln file

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint2: align comments in the code with actual messages

lint: rename t_isenum and t_aincompl to be more expressive

No functional change.

lint: replace integer constant expressions with true and false

LINTFLAGS=-gST make lint, with manual review.

The error messages from lint are all correct, they are not complete
though. The return value of a function returning bool may still be
compared to the integer 0.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: fix typos and other minor stylistic issues

lint: remove NTSPEC from enum tspec_t

The number of elements in an enumeration is not a valid enum constant of
that enumeration itself.

lint: inline STRUCT_ASSIGN

This had only been necessary for some pre-C90 compilers.

lint: rename more _nxt members to _next

lint: rename s_nxt to s_next

lint: fix indentation and alignment that used space-tab

lint: remove redundant parentheses around return value

lint: sort includes

recognize int128

branches: 1.27.2; 1.27.4;
Don't print duplicate definitions for inline symbols.

src is too big these days to tolerate superfluous apostrophes. It's
"its", people!

Lukemify (WARNS=4)

Fix -Wshadow and -Wcast-qual issues

branches: 1.23.6;
Teach lint about long double _Complex (C99)

make the complex float/double annotated consistently with regular float/double.

- simplify logic in getting the filename index.
- fix an allocation botch.

preliminary _Complex support.
NB: Does not really understand type conversions between complex and doubles.

branches: 1.19.6;
tlst[inptype(...)] is bad C code because inptype() can realloc tlst
and there's no intermediate sequence point! We actually hit this on
sh3 with -O2 where gcc4 caches tlst in a register prior to recursive
call to inptype() and if you are unlucky the recursive call needs to
realloc tlst.

Introduce a temp variable to force a sequence point.

branches: 1.18.6; 1.18.8; 1.18.12;
gcc says case is missing, coverity says case not reached. Appease both.

Coverity CID 46: Remove dead code.

- make input errors print the lint source line number they are called from.
- simplify a conditional.

recognize _Bool.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.13.4;
Protect __RCSID and __COPYRIGHT from being invoked if not defined.

Add hooks for compiling on non-NetBSD hosts.

Add "case" statements for "NTSPEC" to fix "gcc" warnings.

Various typos in comments (neccessary, sceme, choise, ...).

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.7.8;
char -> unsigned char

Fix uses of uninitialized memory, and incorrect types for initializers.
From ITOH Yasufumi, PR 5861.

WARNSify

implement (hack in) symbol (function and variable) renaming, so that
the function renaming tricks currently needed by libc can be tolerated
by lint. This needs some cleanup, but it appears to work.

branches: 1.3.2;
* recognize that pointers to identical unnamed and untyped structs,
unions, and enums are, in fact, identical. This is done by tagging
each of unnamed and untyped structure, union and enum with a unique
position of creation, which is used as a unique identifier that
when determine whether or not a pair of structures, unions, or enums
are identical.

RCS id cleanup

branches: 1.1.1;
Initial revision