lint: replace space followed by tab with simply tab

No functional change.

lint: clean up CPPFLAGS for xlint

In 1995, the file mem.c was in ../lint1. In 2002, these files were
moved to ../common instead.

lint: only include code in the binaries that is actually used

No functional change.

lint: make xlint independent of lint1

The files from lint1 are not needed to build xlint, even worse, they get
mixed up wrongly.

$ (cd usr.bin/xlint && make cleandir)
$ (cd usr.bin/xlint/lint1 && make lint -k)
$ (cd usr.bin/xlint/xlint && make lint)

lint2: cannot open mem.ln: No such file or directory

The 'make -k' for lint1 is necessary because lint tries to validate
scan.c in strict bool mode, but the output from lex is not ready for
that. This only happens in my local builds but not in the official
builds on releng.NetBSD.org, I'm still researching that difference.

fix the build

lint: install custom stdbool.h, used for strict bool mode

lint: remove custom stdbool.h for strict bool mode again

Adding it broke the official builds.

lint: in strict bool mode, integer constants do not have type bool

Previously, lint1 allowed integer constants such as 0 and 1 to be used
as bool constants. This was only half-baked since after fixing all
error messages from that strict mode, there may still be integer
literals in the code that should be replaced with true or false. This
would stop a migration from int to bool in the middle, leaving
inconsistent code around.

To find the remaining type inconsistencies, treat integers and bool as
completely incompatible, even for compile time constants.

Don't bring in -lutil for tools.

Convert to using raise_default_signal(3).

branches: 1.14.24;
Now that <bsd.prog.mk> DTRT if HOSTPROG is defined (i.e, it is a no-op),
there's no need to special-case .include-ing it.

Use findcc() from ../mkdep so ${CC} can contain multiple tokens instead
of trying to exec the whole contents of ${CC}.

Major overhaul of src/tools and host toolchain. Summary of changes:

* Rewrite src/tools Make logic to work like the rest of the tree wrt
"dependall" and "install". The old "make build" hack is gone.

* Remove the MKTOOLS logic. This was linked to the "make build" hack,
and was only needed because TOOLDIR originally had no writable default.

* Redo the GNU configure/make logic to make it fit reasonably in a
BSD make wrapper. Use new ${.ALLTARGETS} variable to scan for
targets in $(srcdir), and mark them with .MADE: to prevent rebuilding.

* Only build cross tools in src/tools; remove some messy logic in
src/usr.* and src/gnu/usr.* that would do target filename rewriting
(improves consistency and readability).

* Add the ability to build cross gdb at tool build time by setting
MKCROSSGDB (default no) to "yes" in mk.conf.

* Add src/tools/groff and set up paths to work with this cross groff.

Give host tool builds better control over the HOST_CPPFLAGS.

Add support for putting prefixes on the name of lint(1)'s front
and back ends. This means that it can be built as a cross tool.
Part of the fix for bin/14280.

Add hooks to allow toolchain bits to be reachover-built at the top level.

use CPPFLAGS instead of CFLAGS

branches: 1.7.2;
add Makefile.inc to turn off WARNS, and use it

Back out the .PATH.c changes. The .depend problem (and others)
will be fixed using the new .NOPATH make feature instead.

Use .PATH.c: ...

- Makefile cleanups

Use ${INSTALL}.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: s/illegal/invalid/g

Lint does not provide legal advice.

lint: do not warn about constant operand of '!'

Like its related warning about a constant condition, the purpose of this
warning is unclear, and suppressing the warning requires special lint
comments, thus cluttering the code.

The message itself is still kept in err.c to keep the '-X 239' option
valid. These LINTFLAGS will be removed in a follow-up commit.

The lint comments /* CONSTCOND */, as well as its more verbose forms /*
CONSTANTCOND */ and /* CONSTANTCONDITION */ are no longer needed and can
be removed.

lint.1: modernize, brush up markup

The main purpose of lint is no longer to help migrate programs from
traditional C to C90, so don't mention those features prominently.

branches: 1.65.2;
lint: create .ln output file even when queries are enabled

This allows to configure lint flags in mk.conf globally for a whole
NetBSD build. Previously, this would have made the build fail due to
missing .ln files.

The previous use case of rerunning lint with or without queries is easy
enough to achieve by doing a 'make clean', in the same way as for lint
warnings.

lint: make diagnostics about ANSI C more international

lint: distinguish between arguments and parameters

lint: sync usage messages with reality

lint: remove redundant comments for command line flags

lint: add initial support for C23

Required by xsrc/external/mit/MesaLib.old, brw_eu_validate.c, which
initializes a struct using empty braces: 'return (struct string){};'.

lint: allow to keep the preprocessor output on success as well

lint.1: add a few examples

In default mode, lint runs in a mode that aids in migrating from
traditional C to C90, which is not widely useful nowadays. Instead,
suggest some examples of using lint in more practical ways.

lint.1: remove extra space from -q option

lint: repurpose the '-d' option to specify DESTDIR

Previously, passing '-nostdinc -isystem $dir' only searched the given
directory but not any compiler-specific directories.

Discovered by fontconfig, which includes <stdatomic.h> from C11, which
lives in /usr/include/gcc-10 instead of /usr/include.

Change the preprocessor options to '--sysroot' instead, to align them
with how the compiler is invoked using build.sh.

lint: add hyphen to adjective 'old-style'

lint: add additional queries that are not enabled by default

In the last 18 months, several lint warnings have been made adjusted to
allow common usage patterns. For example, lint no longer warns about a
constant condition in the statement 'do { ... } while (false)' (message
161), as this pattern is well-known in statement-like macros, making it
unlikely that the 'false' is a mistake. Another example is casts
between unequal pointer types (message 247) for a few well-known
patterns that are unlikely to be bugs.

Occasionally, it is useful to query the code for patterns or events that
would not justify a warning. These patterns are modeled as predefined
queries that can be selected individually, in addition to and
independently of the existing warnings and errors.

New queries can be added as needed, in the same way as new warnings.
Queries that are deemed no longer used can be deactivated in the same
way as warnings that are no longer used.

As long as none of the queries is enabled, they produce a minimal
overhead of querying a single global variable. Computations that are
more expensive than a few machine instructions should be guarded by
any_query_enabled.

https://mail-index.netbsd.org/source-changes-d/2022/06/28/msg013716.html

ok christos@

lint: clean up usage messages

The two synopsis forms differed in the spelling of 'file ...'.

The options string for getopt does not start with ':', which led to a
duplicate message 'unknown option -- ?' followed by 'Unknown flag ?'.

Be more specific when calling 'lint file.c -u'; the message 'Unknown
argument' was not helpful as it didn't pinpoint that there are two
different phases for parsing options. In the second phase, only the
options '-L' and '-l' are recognized.

In the manual page, mention the difference between the two synopsis
forms as early as possible. The two synopsis forms are very similar and
both have far to many options to see the difference at a glance.

lint: fix typography in manual page

lint: fix typography in manual page

lint: C99 has been released, so refer to it by its proper name

provide an expanded description for -W

Also accept -W to pass to cpp

Fix Dd argument.

lint: update and proofread manual page

lint: remove dead code for reading from stdin

Since xlint.c 1.27 from 2002-01-31, it has not been possible to read
from stdin anymore. Apparently nobody missed this feature in the last
19 years.

lint: on request, keep the preprocessor output

Previously, the simplest way of getting the preprocessed translation
unit was to run lint with the additional flag -V, which outputs the
command line of the C preprocessor, among other things. That command
line does not include the proper quoting though, so it cannot be used
verbatim as a shell command if the command line contains spaces such as
in -Du64="unsigned long long".

In the common situation where lint is run via a Makefile, the option -V
had to be added in the Makefile itself since there is no make variable
for additional user-settable lint flags. This is not straight-forward
enough.

Adding another command line option for this purpose would reduce the
remaining namespace for options. Most of the 52 letters are already
used up.

To make this situation as simple as possible, preserve the output of the
C preprocessor depending on an environment variable.

lint: add option to accept C11 features

The list of available letters for the command line options gets shorter
and shorter. Most of the interesting letters are already used for some
warning categories. Curiously, -A, -W and -E were all still available.

The option -A nicely matches the intention of the option, which is to
allow a certain set of language features. To keep the option available
for further extensions, define -Ac11 as the currently only valid option
of that kind. This allows straight-forward extension for C17 and future
language standards, as well as independent feature-sets. The options -W
and -E may someday complement the -A option, using the allow/warn/error
categories.

lint: add new check for strict bool mode

In strict bool mode, bool is considered incompatible with all other
scalar types, just as in Java, C#, Pascal.

The controlling expressions in if statements, while loops, for loops and
the '?:' operator must be of type bool. The logical operators work on
bool instead of int, the bitwise operators accept both integer and bool.
The arithmetic operators don't accept bool.

Since <stdbool.h> implements bool using C preprocessor macros instead of
predefining the identifiers "true" and "false", the integer constants 0
and 1 may be used in all contexts that require a bool expression.
Except from these, no implicit conversion between bool and scalar types
is allowed.

See usr.bin/tests/xlint/lint1/d_c99_bool_strict.c for more details.

The command line option -T has been chosen because all obvious choices
(-b or -B for bool, -s or -S for strict) are already in use. The -T may
stand for "types are checked strictly".

The default behavior of lint doesn't change. The strict bool check is
purely optional.

An example program for strict bool mode is usr.bin/make, which has been
using explicit comparisons such as p != NULL, ch != '\0' or n > 0 in
most places for a long time now, even before the refactoring in 2020.

Remove trailing whitespace, add missing word.

Use -Z to pass arguments to ccp(1) directly. Can be used as:
-Z-include -Zfile.h

Whitespace, sort, remove some superfluous macros/quoting.

Add -R (source filename remapping) for MKREPRO

branches: 1.37.10;
make NOSTRICT behave the same a LINTED; use the new format.

document LINTEDn

branches: 1.35.4; 1.35.10;
Sort options and option descriptions. Use more markup.

Remove use of .Xo/.Xc to workaround argument number limit.

branches: 1.33.6;
Lint predefines the following symbols: "__LINT__", "lint", "__lint", and
"__lint__"; not only "lint" as the man page previously claimed.

document P

branches: 1.31.12;
Drop trailing whitespace.

Xr lint 7; noticed by Anon Ymous

Bump date for previous.

Pass -MD through to cpp so that it can generate a depend file.
(Actually pass any -M <arg> through, but -MD is most useful.)

Fix part of last.

Homogenize paragraphs to begin with capital letter. Fixes my own PR misc/18773.

.Nm does not need a dummy argument ("") before punctuation or
for correct formatting of the SYNOPSIS any longer.

add -S flag for c99 support.

Ispell. Begin new sentences on a new line.

Remove some unnecessary Ns.

* Add header files (ilp32.h and lp64.h) that describe the two
models of type sizes that we currently support, and include
the appropriate one in each arch's targparam.h.
* Use the type size constants provided by targparam.h in the
type table, rather than using "sizeof(type) * CHAR_BIT" (which
would get the host's type size, not the target's). XXX Not
yet done for floating point types.
* Add a new BITFIELDTYPE lint comment that suppresses illegal
bitfield type errors if the type is an integer type (e.g.
long, long long), and also suppresses non-portable bitfield
type warnings.

Punctuation nits.

Nits.

support // comments if -g is given

allow trailing , in enum if -g

s/refferd/referred/

Spell occurred correctly.

No space is allowed before comma in optarg for -X option.

document new flags.

fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.11.2;
Add parsing of the CC env variable, and a -Bpath flag (for /usr/libexec)
so cross-building of lint libraries can be made possible. Tested
building a powerpc libc via make build on an alpha.

More and more .Os cleanups. .Os is defined in the tmac.doc-common file,
so we shouldn't override it with versions in the manpages. Many more to
come.

Missing .El.

Clean up SYNOPSIS formatting.

Add -d option, so lint can be used safely when we're not building "in
place" (e.g., when DESTDIR is set). This causes the lint driver to
pass -nostdinc -idirafter <dir> to cpp, causing it to ignore
/usr/include and look somewhere else instead..

xref exit(3) not exit(2)

alternate -> alternative, per PR 2643

* accept the file name '-' to indicate that standard input is to be
used as lint1 input. That involves having lint pass the '-' through
to the cpp which preprocesses the lint1 input, and having lint1's
scanner recognize a cpp filename "" as "{standard input}".

updated

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: indent copyright lines consistently

lint: remove unused pathname

lint: make path to lint data configurable

This is needed for strict bool mode, to make the custom header stdbool.h
available when lint is run as part of build.sh.

lint: in strict bool mode, integer constants do not have type bool

Previously, lint1 allowed integer constants such as 0 and 1 to be used
as bool constants. This was only half-baked since after fixing all
error messages from that strict mode, there may still be integer
literals in the code that should be replaced with true or false. This
would stop a migration from int to bool in the middle, leaving
inconsistent code around.

To find the remaining type inconsistencies, treat integers and bool as
completely incompatible, even for compile time constants.

Add hooks to allow toolchain bits to be reachover-built at the top level.

use "cc -E" not cpp directly. this allows lint(1) to be unaware of any
machine-dependant defines that cc(1) may normally define, and also
means that the mips ports work again.

RCS id cleanup

branches: 1.1.1;
Initial revision

lint: in C23 mode, support the keywords 'bool', 'false' and 'true'

lint: in strict bool mode, integer constants do not have type bool

Previously, lint1 allowed integer constants such as 0 and 1 to be used
as bool constants. This was only half-baked since after fixing all
error messages from that strict mode, there may still be integer
literals in the code that should be replaced with true or false. This
would stop a migration from int to bool in the middle, leaving
inconsistent code around.

To find the remaining type inconsistencies, treat integers and bool as
completely incompatible, even for compile time constants.

lint: warn about do-while macros that end with a semicolon

branches: 1.125.2;
lint: add wrapper for <ctype.h> functions, for strict bool mode

When using the Clang preprocessor (with MKLLVM=yes), the preprocessor
output does not indicate which tokens come from a system header and
which tokens come from the user code. Lint's strict bool mode relies on
this information to treat the character classification functions from
<ctype.h> as if their return type were bool instead of int.

These wrapper functions are only used when their argument is indeed a
'char', but not when the argument might be 'EOF or representable as an
unsigned char', such as when reading a byte from the input.

lint: remove unused flag '-u' from lint1

This flag is completely handled by lint2.

lint: remove custom wrappers around <ctype.h> functions

lint: clean up

lint: clean up comments

No functional change.

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: indent statement continuations consistently

No binary change.

lint: reduce number of negations, fix variable name

No functional change.

lint: merge redundant variables

No functional change.

lint: make variable names more expressive, remove redundant comments

No functional change.

lint: indent copyright lines consistently

lint: sync usage messages with reality

lint: allow to keep the preprocessor output on success as well

lint: sort functions in calling order

No functional change.

lint: indent local variables consistently

No binary change.

lint: make basename simpler

There is no need to handle trailing slashes since lint only handles
regular files in diagnostics, not directories. Furthermore, only the
last '/' was ignored, but multiple trailing slashes would not.

lint: repurpose the '-d' option to specify DESTDIR

Previously, passing '-nostdinc -isystem $dir' only searched the given
directory but not any compiler-specific directories.

Discovered by fontconfig, which includes <stdatomic.h> from C11, which
lives in /usr/include/gcc-10 instead of /usr/include.

Change the preprocessor options to '--sysroot' instead, to align them
with how the compiler is invoked using build.sh.

lint: catch more write errors when copying files

lint: remove unnecessary abstraction layer for passing arguments

The abstraction layer of the pass_to functions wasn't worth its weight.
After inlining the functions, the code is even clearer than before.

No functional change.

lint: keep output from cpp if cpp fails

Previously, lint only kept the cpp output if lint1 failed. Due to
subtle differences in the preprocessing, there can be cases where the
preprocessor already fails, for example when it takes a different
'#ifdef' branch and therefore tries to include nonexistent files. In
such a case, preserving the output of the preprocessor is helpful to
compare it with the regular output of cpp, so keep it.

xlint: fix null pointer dereference for lint -V (since today)

Building the argument lists further away from the vfork call in xlint.c
1.100 had the side effect that the trailing null pointer was added
outside run_child.

lint: clean up main function

No functional change.

lint: extract run_cpp and run_lint1 to separate functions

Move run_lint2 further to the top, to save a forward declaration.

No functional change.

lint: reduce number of local variables in lbasename

No functional change.

lint: move argument list modification further away from vfork

Just to be on the safe side.

While here, don't allocate argument strings needlessly.

No functional change.

lint: turn O(n^2) to O(n) for list of arguments to lint child processes

Previously, adding an argument to the lint child processes (cpp, lint1,
lint2) each time searched the list of arguments for the terminating
null pointer and then reallocated the memory for storing the strings.

Replace the above with a standard resizable array implementation and
give it a proper name, to avoid 'char ***' in the code.

The terminating null pointer in the lists is only required when passing
the list to execvp. In all other cases it's not needed, so drop it.

No functional change.

lint: rename local functions to be more readable

No functional change.

lint: explicitly ignore errors when printing status messages

No binary change.

lint: remove unnecessary MBLKSIZ, use stack buffer in xlint

No functional change.

lint: remove redundant cast

Since C90 prototypes, integer arguments are converted to the correct
parameter type.

No functional change.

lint: add additional queries that are not enabled by default

In the last 18 months, several lint warnings have been made adjusted to
allow common usage patterns. For example, lint no longer warns about a
constant condition in the statement 'do { ... } while (false)' (message
161), as this pattern is well-known in statement-like macros, making it
unlikely that the 'false' is a mistake. Another example is casts
between unequal pointer types (message 247) for a few well-known
patterns that are unlikely to be bugs.

Occasionally, it is useful to query the code for patterns or events that
would not justify a warning. These patterns are modeled as predefined
queries that can be selected individually, in addition to and
independently of the existing warnings and errors.

New queries can be added as needed, in the same way as new warnings.
Queries that are deemed no longer used can be deactivated in the same
way as warnings that are no longer used.

As long as none of the queries is enabled, they produce a minimal
overhead of querying a single global variable. Computations that are
more expensive than a few machine instructions should be guarded by
any_query_enabled.

https://mail-index.netbsd.org/source-changes-d/2022/06/28/msg013716.html

ok christos@

lint: clean up usage messages

The two synopsis forms differed in the spelling of 'file ...'.

The options string for getopt does not start with ':', which led to a
duplicate message 'unknown option -- ?' followed by 'Unknown flag ?'.

Be more specific when calling 'lint file.c -u'; the message 'Unknown
argument' was not helpful as it didn't pinpoint that there are two
different phases for parsing options. In the second phase, only the
options '-L' and '-l' are recognized.

In the manual page, mention the difference between the two synopsis
forms as early as possible. The two synopsis forms are very similar and
both have far to many options to see the difference at a glance.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: skip duplicate -llib and -Llibdir options

This removes many of the currently 26.000 'multiply defined' lines from
a typical NetBSD build. Duplicate libraries happen a lot due to
overlapping transitive dependencies. An example is usr.bin/telnet,
which links to -lcrypto and several other libraries twice.

lint: in verbose mode, quote shell commands in output

lint: fix typo in comment

No binary change.

lint: do not output "Lint pass2:"

A colon at the end of a line requires at least 1 follow-up line, but
xlint cannot know whether lint2 will find anything to complain about.
Having a colon followed by nothing creates unnecessary confusion.

Also accept -W to pass to cpp

remove extra line

Explain the usage errors.

lint: rename list_add to list_add_ref and list_add_copy to list_add

The function for copying the string is used more often, so use the
simpler name for it.

No functional change.

lint: remove redundant function prototypes

lint: hide irrelevant type information from lint2

No functional change.

lint: fix some more lint warnings

The only remaining warnings are in scan.c, which is a generated Flex
scanner.

No functional change.

lint: explicitly ignore the return value of close

mkdep: make argument of findcc const

Previously, findcc modified its argument string, even though it had been
declared as 'const char *'. This triggered a lint warning that "strchr
effectively discards 'const char *' from argument", in fact, this code
caused the lint check to be implemented in the first place.

The first attempt at fixing it by removing the 'const' from the
parameter type was a bad idea since it made the API of that function
more complicated.

Revert back to making the parameter a 'const char *' and duplicate that
string internally as necessary. Add a few more tests for absolute
pathnames since these had been missing before. There are no tests yet
for snprintf with too long strings, but the current change does not
modify that part of the code.

mkdep: fix prototype of findcc

A function that modifies a string argument must not declare that
argument as 'const char *', even if all callers (mkdep and lint) always
pass it a modifiable string.

No functional change.

lint: remove redundant variable Bflag

No functional change.

lint: remove unused static variable

lint: simplify code for adding '-l' and '-L' to libraries

No functional change.

lint: merge duplicate code for passing flags to subprocesses

No functional change.

lint: uniformly pass command line flags to subprocesses

No functional change.

lint: remove commented-out preprocessor options

These have been commented out since 2002.

lint: group global variables by the subprocess

No functional change.

lint: rename list_free to list_clear

The previous name suggested that the function would free the list
itself, which it doesn't.

lint: remove dead code for reading from stdin

Since xlint.c 1.27 from 2002-01-31, it has not been possible to read
from stdin anymore. Apparently nobody missed this feature in the last
19 years.

lint: inline list_add_defines

No functional change.

lint: rename functions for handling string lists

No functional change.

lint: make data flow in findlibs simpler

No functional change.

lint: make memory management in xlint simpler

No functional change.

lint: make xasprintf simpler

No functional change.

lint: on request, keep the preprocessor output

Previously, the simplest way of getting the preprocessed translation
unit was to run lint with the additional flag -V, which outputs the
command line of the C preprocessor, among other things. That command
line does not include the proper quoting though, so it cannot be used
verbatim as a shell command if the command line contains spaces such as
in -Du64="unsigned long long".

In the common situation where lint is run via a Makefile, the option -V
had to be added in the Makefile itself since there is no make variable
for additional user-settable lint flags. This is not straight-forward
enough.

Adding another command line option for this purpose would reduce the
remaining namespace for options. Most of the 52 letters are already
used up.

To make this situation as simple as possible, preserve the output of the
C preprocessor depending on an environment variable.

lint: remove WARNS=3, falling back to the default WARNS=5

It's strange that GCC does not warn about the nonliteral format strings
in lint1/err.c, lint2/msg.c and lint2/read.c, despite -Wformat=2, but
Clang does.

lint: un-abbreviate code for passing options to cpp, lint1 and lint2

No functional change.

lint: add option to accept C11 features

The list of available letters for the command line options gets shorter
and shorter. Most of the interesting letters are already used for some
warning categories. Curiously, -A, -W and -E were all still available.

The option -A nicely matches the intention of the option, which is to
allow a certain set of language features. To keep the option available
for further extensions, define -Ac11 as the currently only valid option
of that kind. This allows straight-forward extension for C17 and future
language standards, as well as independent feature-sets. The options -W
and -E may someday complement the -A option, using the allow/warn/error
categories.

lint: arrange options in the usage messages

* lowercase the word 'usage'
* group the preprocessor flags on a line of their own
* add missing closing ']' for '-X'
* properly indent the lines

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

lint: replace integer constant expressions with true and false

LINTFLAGS=-gST make lint, with manual review.

The error messages from lint are all correct, they are not complete
though. The return value of a function returning bool may still be
compared to the integer 0.

lint: in strict bool mode, integer constants do not have type bool

Previously, lint1 allowed integer constants such as 0 and 1 to be used
as bool constants. This was only half-baked since after fixing all
error messages from that strict mode, there may still be integer
literals in the code that should be replaced with true or false. This
would stop a migration from int to bool in the middle, leaving
inconsistent code around.

To find the remaining type inconsistencies, treat integers and bool as
completely incompatible, even for compile time constants.

lint: replace 0 and 1 with false and true, where appropriate

Change in behavior: Passing the option -h exactly 4294967296 times or
any multiple thereof is no longer equivalent to passing it never at all,
it is now equivalent to passing it once. See main2.c, hflag++ for the
actual change.

Other than that, no functional change intended.

A very large portion of the code already conformed to the requirements
of the strict bool mode. The only missing thing was using the constant
literals false and true instead of 0 and 1. For sure there are some
integer literals left that can be converted. For now, all literals that
appeared in the form " = 0" or " = 1" have been replaced.

lint: add new check for strict bool mode

In strict bool mode, bool is considered incompatible with all other
scalar types, just as in Java, C#, Pascal.

The controlling expressions in if statements, while loops, for loops and
the '?:' operator must be of type bool. The logical operators work on
bool instead of int, the bitwise operators accept both integer and bool.
The arithmetic operators don't accept bool.

Since <stdbool.h> implements bool using C preprocessor macros instead of
predefining the identifiers "true" and "false", the integer constants 0
and 1 may be used in all contexts that require a bool expression.
Except from these, no implicit conversion between bool and scalar types
is allowed.

See usr.bin/tests/xlint/lint1/d_c99_bool_strict.c for more details.

The command line option -T has been chosen because all obvious choices
(-b or -B for bool, -s or -S for strict) are already in use. The -T may
stand for "types are checked strictly".

The default behavior of lint doesn't change. The strict bool check is
purely optional.

An example program for strict bool mode is usr.bin/make, which has been
using explicit comparisons such as p != NULL, ch != '\0' or n > 0 in
most places for a long time now, even before the refactoring in 2020.

lint: fix typos and other minor stylistic issues

lint: remove redundant parentheses around return value

Use -Z to pass arguments to ccp(1) directly. Can be used as:
-Z-include -Zfile.h

use asprintf().

usr.bin/xlint: Fix -Werror=format-overflow= error.

Replace sprintf(3) with snprintf(3).

Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.

Reviewed by: kamil@

Undefine SSE stuff; we don't want portable code to depend on it and we
don't provide the necessary headers.

branches: 1.46.14;
Add -R (source filename remapping) for MKREPRO

Drop main() prototype.

branches: 1.44.24;
Fix lseek(2) swapped arguments.

convert -idirafter to -isystem, as recommended by cgd in PR 11843.
most of the list in that PR were already done.

Lukemify (WARNS=4)

fix -Wcast-qual issues

branches: 1.40.6;
Undefine __PCC__ the same as __GNUC__ inside lint.

enable -P

branches: 1.38.6;
Convert to using raise_default_signal(3).

branches: 1.37.12;
appease gcc -Wuninitialized

Only pass -Wtraditional to cpp for lint -t ...
Stops warnings about pre-processor constructs like #elif - which there is
no point detecting now that we've changed much of the code to require an
ANSI C compiler.

Completely rework how tools/compat is done. Purge all uses/references to
_NETBSD_SOURCE as this makes cross building from older/newer versions of
NetBSD harder, not easier (and also makes the resulting tools 'different')

Wrap all required code with the inclusion of nbtool_config.h, attempt to
only use POSIX code in all places (or when reasonable test w. configure and
provide definitions: ala u_int, etc).

Reviewed by lukem. Tested on FreeBSD 4.9, Redhat Linux ES3, NetBSD 1.6.2 x86
NetBSD current (x86 and amd64) and Solaris 9.

Fixes PR's: PR#17762 PR#25944

branches: 1.34.2;
Pass -MD through to cpp so that it can generate a depend file.
(Actually pass any -M <arg> through, but -MD is most useful.)

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

synchronous, not syncronous.

Skip passing -$ to the preprocessor, for now.

add -S flag for c99 support.

sweep of errx/warnx, remove unnecessary trailing \n

Use findcc() from ../mkdep so ${CC} can contain multiple tokens instead
of trying to exec the whole contents of ${CC}.

branches: 1.27.2;
* Use setprogname() in main().
* Don't grossly abuse getopt(); allow only -l and -L after filenames are
encountered, and do the parsing of these options manually.

Add a missing "break;" statement so that this actually works again.

Add hooks for compiling on non-NetBSD hosts.

Add support for putting prefixes on the name of lint(1)'s front
and back ends. This means that it can be built as a cross tool.
Part of the fix for bin/14280.

cleanup (prior to more adding more features):
- convert to ANSI KNF
- remove trailing whitespace
- translate some comments from german into english

code compiles and runs clean, and tested by running "make lint" against
xlint source using previous and this lint produces same results.

convert to use getprogname()

Handle arguments in a slightly more standard way (avoid resetting optind).

pass -X <id>[,<id>]... and -w to lint1

Use execvp() instead of execv(). Deals with the case where CC, the compiler,
is not a full path. For instance, "cc".

branches: 1.18.2;
fix up NetBSD RCS Ids to match the standard, and the leading comment as
to match as well. No functional changes.

branches: 1.17.2;
Add parsing of the CC env variable, and a -Bpath flag (for /usr/libexec)
so cross-building of lint libraries can be made possible. Tested
building a powerpc libc via make build on an alpha.

Define __LINT__, per XCU5.

Slight improvement to last fix: don't need to reset the cpp tempfile for
files which don't need to be run through cpp. Also, use vfork() instead of
fork().

Both from Anders Hjalmarsson (Anders.Hjalmarsson@economics.gu.se)

Apply fix from PR bin/8328 by Anders Hjalmarsson (Anders.Hjalmarsson@economics.gu.se):

work properly again when passwd multiple files on the command line.

More cosmetics in the usage message...

Now that we use cc -E, -U__GNUC__ to avoid gnu extensions. Nuke the
__attribute__ and __extension__ workarounds.
Our invariant is: No gcc extensions if __GNUC__ is not defined, so lint
should not be playing around trying to pretend it is gcc.

Deal with gcc __extension__({ }). We assume that it returns a value 0, and
we prepend a /*NOSTRICT*/ comment to avoid constant in conditional context
warning.

use "cc -E" not cpp directly. this allows lint(1) to be unaware of any
machine-dependant defines that cc(1) may normally define, and also
means that the mips ports work again.

branches: 1.9.2;
pass -CC instead of -C to cpp so that we preserve macro comments in place.

Eliminate memory leaks.
Use xrealloc() rather than xmalloc/memcpy/free trio.

Add -d option, so lint can be used safely when we're not building "in
place" (e.g., when DESTDIR is set). This causes the lint driver to
pass -nostdinc -idirafter <dir> to cpp, causing it to ignore
/usr/include and look somewhere else instead..

WARNSify

Use S_IS*(), not S_IF*.

* accept the file name '-' to indicate that standard input is to be
used as lint1 input. That involves having lint pass the '-' through
to the cpp which preprocesses the lint1 input, and having lint1's
scanner recognize a cpp filename "" as "{standard input}".

don't rely on macros predefined by cpp

RCS id cleanup

branches: 1.1.1;
Initial revision