License update from Stanford, via OpenBSD.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.1.18; 1.1.20;
Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

introduce new GCC 12 warning disables and use them in a few places

this introduces 4 new warning disable flags:

CC_WNO_MISSING_TEMPLATE_KEYWORD
CC_WNO_REGISTER
CC_WNO_STRINGOP_OVERREAD
CC_WNO_ARRAY_BOUNDS

and documents them in README.warnings. of these, the string op
and array bounds are both problematic (real bugs) and also spurious
(not real bugs), and the other 2 are mostly temporary for older
3rd party code.

add some new uses of CC_WNO_STRINGOP_OVERFLOW.

fix m68k build for gallium and GCC 12.

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

bsd.own.mk: rename to CC_WNO_ADDRESS_OF_PACKED_MEMBER

Provide a single variable
CC_WNO_ADDRESS_OF_PACKED_MEMBER
with options for both clang and gcc, to replace
CLANG_NO_ADDR_OF_PACKED_MEMBER
CC_NO_ADDR_OF_PACKED_MEMBER
GCC_NO_ADDR_OF_PACKED_MEMBER

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

add support for new GCC 9 warnings that may be too much to fix
right now. new address-of-packed-member and format-overflow
warnings have new GCC_NO_ADDR_OF_PACKED_MEMBER amd
GCC_NO_FORMAT_OVERFLOW variables to remove these warnings.

apply to a bunch of the tree. mostly, these are real bugs that
should be fixed, but in many cases, only by removing the 'packed'
attribute from some structure that doesn't really need it. (i
looked at many different ones, and while perhaps 60-80% were
already properly aligned, it wasn't clear to me that the uses
were always coming from sane data vs network alignment, so it
doesn't seem safe to remove packed without careful research for
each affect struct.) clang already warned (and was not erroring)
for many of these cases, but gcc picked up dozens more.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.15.44;
Default to -Wno-sign-compare -Wno-pointer-sign for clang.
Push -Wno-array-bounds down to the cases that depend on it.
Selectively disable warnings for 3rd party software or non-trivial
issues to be reviewed later to get clang -Werror to build most of the
tree.

Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

This seems to need a -I${.CURDIR} these days.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.10.2;
More #include <stdlib.h> string, etc. cleanup

branches: 1.9.8;
Use daemon(3) and pidfile(3).

.y.c <sys.mk> rule fixes. Don't create a y.tab.h file unless asked for,
and use smarter creation of the header file.

Update to mrouted 3.8.

Update to mrouted 3.8.

New-style RCS ids.

cfparse.c and y.tab.h should be in CLEANFILES

Update to multicast 3.5.

specify man pages the new way.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.4.12; 1.4.14;
WARNSify

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Fix WARNS=4 (-Wshadow -Wsign-compare -Wcast-qual)

branches: 1.15.40;
SIOCGIFCONF -> getifaddrs conversion

strdup is simpler

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Use vsnprintf instead of vsprintf. From OpenBSD.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.7.2;
copyright clarification. via openbsd

More format string cleanups by sommerfeld.

branches: 1.5.2; 1.5.10;
work around gcc warning.

Update to mrouted 3.8.

New-style RCS ids.

needs string.h

Update to multicast 3.5.

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

ifa->ifa_addr is already pointer, no need for "&". from love

use getifaddrs, not SIOCGIFCONF. should fix PR12578

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.6.14; 1.6.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Bring back original version from pre-4.4lite NetBSD

Get rid of source route for mrouting. This is no loger used in the MBONE and the 4.4-lite n/w code doesn't do it anyway.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

change cksum prototype to const void *, and check alignment via assertion.

Don't use bool as a variable name.

Remove a bunch of parameter names form function prototypes.

branches: 1.14.30;
Move ctype.h header from defs.h to main.c where it's really used
From: Slava Semushin <slava.semushin@gmail.com>

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.8.2;
More format string cleanups by sommerfeld.

branches: 1.7.4; 1.7.12;
WARNSify

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

header, for protos

Van's 2.2 mrouted changes

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.5.14; 1.5.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Van's 2.2 mrouted changes

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Fix WARNS=4 (-Wshadow -Wsign-compare -Wcast-qual)

branches: 1.13.28;
if we are going to cast the 3rd argument to accept_info_request(),
use the right type.

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

u_short cleansing (should be u_int16_t)

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.6.12; 1.6.14;
WARNSify

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Fill in ip_v and ip_hl since 4.4 rip_output won't

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

change cksum prototype to const void *, and check alignment via assertion.

A slightly better inet_parse(), tested in isolation.

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

avoid issues with typecast optimization (taking advantage of pointer aliasing),
which results in incorrect igmp checksum.
confirmed by taca@netbsd

u_short cleansing (should be u_int16_t)

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.4.14; 1.4.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

NULL does not need a cast

Don't use bool as a variable name.

Remove a bunch of parameter names form function prototypes.

branches: 1.10.38;
change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.4.14; 1.4.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.25.42;
NULL does not need a cast

Use __dead

Move ctype.h header from defs.h to main.c where it's really used
From: Slava Semushin <slava.semushin@gmail.com>

change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

Add (unsigned char) cast to ctype functions

use arc4random

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

die if fd_set overrun. (they're not setuid binary so it is not that critical)

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.14.2;
Negative exit code cleanup: Replace exit(-x) with exit(x).
As seen on tech-userlevel.

More format string cleanups by sommerfeld.

branches: 1.12.8;
Use daemon(3) and pidfile(3).

branches: 1.11.2;
Use strerror(3) instead of sys_errlist and sys_nerr.

use static int instead of static

WARNSify

fix a call to localtime() so that it works if time_t != long.
(Whoever decided that one should repeate all of the locals 2x to
save one more #ifdef in log() should be shot...)

Change a rogue RCS id to new-style.

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Use strerror(), not sys_errlist[].

Van's 2.2 mrouted changes

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Remove workaround for ancient HTML generation code.

Fix markup.

branches: 1.16.40;
Consistently use 'RFC 1234' instead of 'RFC1234' or 'RFC-1234'.
From jmc@openbsd.

Add RCS Id; new sentence, new line; at least one mdoc fix; sort sections.

mdocified man page from mpech@openbsd.org

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.11.2;
Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Whitespace nits.

branches: 1.9.12;
WARNSify

correct man page pathnames to reflect reality, per PR#4148

Mention correct PID file location.

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Bring back original version from pre-4.4lite NetBSD

Get rid of source route for mrouting. This is no loger used in the MBONE and the 4.4-lite n/w code doesn't do it anyway.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.5.8; 1.5.10;
Use pidfile(3).

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Fix WARNS=4 (-Wshadow -Wsign-compare -Wcast-qual)

branches: 1.17.28;
Coverity CID 1191, 1192: Don't check for NULL allocation, just to log it
and then die dereferencing. Return instead.

can't fit "256" in an 8bit value, don't have a switch case for it.

use arc4random

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

ANSIfy one more.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.8.2;
receive, not recieve

Make it compile again after format string changes (this change was obviously
never tested).

branches: 1.6.2; 1.6.10;
The ioctls have been issued on the wrong socket, so they failed with a
EINVAL. This has been confirmed by Bill Fenner. The wrong socket led to
masses of syslog entries on hosts connected to the mbone and cache entries
deleted to early.

XXX As the socket need to be the one that is ip_mrouter in netinet/ip_mroute.c,
XXX the kernel could be modified to always return the data for ip_mrouter.

XXX Bill Fenner suggests to upgrade to 3.9.beta-3 with -DIOCTL_OK_ON_RAW_SOCKET

Add {} pairs to shut up egcs.

WARNSify

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.4.10; 1.4.12;
Apply patches for mtrace in bin/5598 by yours truly.
This adds decoding of more error and result codes when tracing through
cisco routers running PIM and/or MBGP.

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Fix WARNS=4 (-Wshadow -Wsign-compare -Wcast-qual)

branches: 1.12.28;
Coverity CID 1188: Don't check for NULL just to log and then die
de-referencing; return instead.

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.6.4; 1.6.6;
Fix doubled 'the's.

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Van's 2.2 mrouted changes

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.4.14; 1.4.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

- Clean up warnings / errors.

branches: 1.9.32;
Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

branches: 1.4.10; 1.4.12;
use AF_LOCAL instead of AF_UNIX

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.2.16; 1.2.18;
New-style RCS ids.

Update to multicast 3.5.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.1.14; 1.1.16;
Update to mrouted 3.8.

avoid possible buffer overruns - strlcpy, snprintf

Add license (from Xerox), from OpenBSD.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

u_short cleansing (should be u_int16_t)

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

missing memset() for sockaddr. from deraadt

branches: 1.4.10; 1.4.12;
The ioctls have been issued on the wrong socket, so they failed with a
EINVAL. This has been confirmed by Bill Fenner. The wrong socket led to
masses of syslog entries on hosts connected to the mbone and cache entries
deleted to early.

XXX As the socket need to be the one that is ip_mrouter in netinet/ip_mroute.c,
XXX the kernel could be modified to always return the data for ip_mrouter.

XXX Bill Fenner suggests to upgrade to 3.9.beta-3 with -DIOCTL_OK_ON_RAW_SOCKET

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Add license (from Xerox), from OpenBSD.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

u_short cleansing (should be u_int16_t)

branches: 1.3.14; 1.3.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Fix bug in mrouted about aging neighbors.

mrouted will periodically age its neighbors and will remove a neighbor
if it hasn't heard from it for NEIGHBOR_EXPIRE_TIME. Unfortunately, the
neighbor pointers 'a' and 'prev_a' were never advanced when timer was
not expired. Therefore it would get stuck in a tight loop, advancing
'al_timer' until it would be greater than NEIGHBOR_EXPIRE_TIME. This
caused the neighbor to allways get timed out and dropped. Furthermore,
there was a second bug in this loop when deleting an item that was not
at the head of the list (i.e., prev_a should stay the same instead of
advancing).

This bug fix is the work of Konrad Lorincz. Bug found and fix made on
netbsd-6.

This material is based upon work supported by the Defense Advanced
Research Projects Agency and Space and Naval Warfare Systems Center,
Pacific, under Contract No. N66001-09-C-2073. Any opinions, findings
and conclusions or recommendations expressed in this material are
those of the author(s) and do not necessarily reflect the views of the
Defense Advanced Research Project Agency and Space and Naval Warfare
Systems Center, Pacific.
Approved for Public Release, Distribution Unlimited

Coverity CID 1189, 1190: Don't check for NULL just to log and then die
de-referencing; return instead.

Coverity CID 2718: Avoid using free'd memory.

change (mostly) int to socklen_t. GCC 4 doesn't like that int and
socklen_t are different signness.

remove obsolete comment

Revert previous change. Remove s parameter from teh function and rotate
the result through a fixed set of strings instead.
There never was a possibility of a buffer overrun in inet_fmt{s}().
Fix an actual buffer overrun in a scanf() call.

avoid possible buffer overruns - strlcpy, snprintf

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.

missing memset() for sockaddr. from deraadt

branches: 1.8.2;
Make it compile again after format string changes (this change was obviously
never tested).

branches: 1.7.2; 1.7.10;
The ioctls have been issued on the wrong socket, so they failed with a
EINVAL. This has been confirmed by Bill Fenner. The wrong socket led to
masses of syslog entries on hosts connected to the mbone and cache entries
deleted to early.

XXX As the socket need to be the one that is ip_mrouter in netinet/ip_mroute.c,
XXX the kernel could be modified to always return the data for ip_mrouter.

XXX Bill Fenner suggests to upgrade to 3.9.beta-3 with -DIOCTL_OK_ON_RAW_SOCKET

Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Bring back original version from pre-4.4lite NetBSD

Get rid of source route for mrouting. This is no loger used in the MBONE and the 4.4-lite n/w code doesn't do it anyway.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.

Move back from gnu/dist/mrouted, now that it's available under a BSD
license.

move mrouted out of basesrc, as it carries non-BSD license.
agreed w/ core.

branches: 1.6.14; 1.6.16;
Update to mrouted 3.8.

New-style RCS ids.

Update to multicast 3.5.

Bring back original version from pre-4.4lite NetBSD

Get rid of source route for mrouting. This is no loger used in the MBONE and the 4.4-lite n/w code doesn't do it anyway.

Mrouted ported by cmaeda@cs.washington.edu from BSD386 port.