ndp: add gmt2local() from external/bsd/tcpdump instead of reachover

It is no longer shipped with the tcpdump distribution.

use librumpres

Add getaddrinfo.c to RUMPSRCS for link-local addresses

Fix rump.ndp -I options by rump-ifying if_nametoindex(3)

From s-yamaguchi@IIJ

Introduce rump.ndp

ndp(8) uses RTM that requires that getpid(2) works correctly. Unfortunately
supporting getpid(2) in librumphijack will be tricky so that we rump-ify
ndp(8) as well as arp(8).

Don't check MKINET6 - parent makefile doesn't descend to ndp if it's "no".

branches: 1.8.6; 1.8.12;
use new tcpdump.

Enable WARNS=4 by default, except for:
cpuctl dumplfs hprop ipf iprop-log kadmin kcm kdc kdigest
kimpersonate kstash ktutil makefs ndbootd ntp pppd quot
racoon racoonctl rtadvd sntp sup tcpdchk tcpdmatch tcpdump
traceroute traceroute6 user veriexecgen wsmoused zic
(Mostly third-party applications)

branches: 1.6.20;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

Cleanup KNF, WARNS=4.
Phew, this started just to make set() static so that coverity does not get
confused.

use NETBSDSRCDIR as appropriate

change tcpdump dir to refer to. Daniel Carosone <dan@geek.com.au>

s/CFLAGS/CPPFLAGS/ for -D and -I.

ndp, "arp"-alike command for IPv6.

Remove this stub that hasn't been necessary in a decade or so.

branches: 1.2.64; 1.2.70;
add NetBSD RCS ID.

ndp, "arp"-alike command for IPv6.

fix few more typos in comments, messages and documentation.

ndp: Show U for Unreachable

ndp: Sync usage and SYNPOSIS with reality

Remove in-kernel handling of Router Advertisements

This is much better handled by a user-land tool.
Proposed on tech-net here:
https://mail-index.netbsd.org/tech-net/2020/04/22/msg007766.html

Note that the ioctl SIOCGIFINFO_IN6 no longer sets flags. That now
needs to be done using the pre-existing SIOCSIFINFO_FLAGS ioctl.

Compat is fully provided where it makes sense, but trying to turn on
RA handling will obviously throw an error as it no longer exists.

Note that if you use IPv6 temporary addresses, this now needs to be
turned on in dhcpcd.conf(5) rather than in sysctl.conf(5).

Sort some lists. Use EXIT STATUS instead of RETURN VALUES.

Use .Cm instead of .Li, same as arp.8.

Add IPV6CTL_AUTO_LINKLOCAL and ND6_IFF_AUTO_LINKLOCAL toggles which
control the automatic creation of IPv6 link-local addresses when an
interface is brought up.

Taken from FreeBSD.

branches: 1.26.2;
If IPv6 is disabled for an interface, mark all addresses as tentative.
If enabled, check for a duplicated link-local address and abort enabling
as per RFC 4862, section 5.4.5. If allowed to enable, perform DAD
on the tentative addresses.

Taken from FreeBSD.

branches: 1.25.6; 1.25.12;
Update date.

Teach ndp(8) about override_rtadv.

Simplify markup by not using .Xo/.Xc.

branches: 1.22.28;
NDP-related improvements:
RFC4191
- supports host-side router-preference

RFC3542
- if DAD fails on a interface, disables IPv6 operation on the
interface
- don't advertise MLD report before DAD finishes

Others
- fixes integer overflow for valid and preferred lifetimes
- improves timer granularity for MLD, using callout-timer.
- reflects rtadvd's IPv6 host variable information into kernel
(router only)
- adds a sysctl option to enable/disable pMTUd for multicast
packets
- performs NUD on PPP/GRE interface by default
- Redirect works regardless of ip6_accept_rtadv
- removes RFC1885-related code

From the KAME project via SUZUKI Shinsuke.
Reviewed by core.

change description of -I to meet the current implementation. bump date

with -i, flag on command line and flag displayed are different, and it does
nothing but confuse users. sync them.

for -nud and such, you need "-- -nud" due to posix arg parsing.

sync w/kame

comment out paragraph that does not fit to NetBSD

recover backward compatibility in -I behavior. sync w/kame

more KNF/nroff. from deraadt via kame

more posix-compliant arg parsing. sync with kame. help from deraadt

Drop a space, and two grammar fixes.

use new SIOCGIFINFO_IN6. random other cleanups.

Generate <>& symbolically. I'm avoiding .../dist/... directories for now.

Punctuation nits.

Xref tcpdump 8, not 1.

sync with latest kame tree. ndp -n -a is prettier with longer addresses.
-l is obsolete (igored).

For commands and utilities, use EXIT STATUS rather than RETURN VALUES or
DIAGNOSTICS as appropriate (and documented in mdoc(7)).

sync with more recent kame code.
accept scoped address notation.

branches: 1.7.4;
perform neighbor unreachability detection on p2p links (spec requires
it for bidir p2p links).
improve -i in ndp(8) to allow tweaking per-interface ND flag on.
fix ndp(8) infinite loop on certain routing table setup.

Typo.

remove net.inet6.ip6.nd6_proxyall sysctl.
support "ndp -s <ip6> <mac> proxy" for proxy NDP.

add -I and -l. cleanup on screen formatting.
(sync with latest KAME)

branches: 1.3.4;
fix routing socket alignment issue on alpha.
sync with more recent KAME code.

PR: 8305

add NetBSD RCS ID.

ndp, "arp"-alike command for IPv6.

ndp: add gmt2local() from external/bsd/tcpdump instead of reachover

It is no longer shipped with the tcpdump distribution.

usr.sbin: remove unnecessary CONSTCOND, lint no longer needs it

Since 2021-01-31, lint no longer requires a CONSTCOND comment in a
do-while-0 statement since this is a common code pattern, especially in
statement-like macros.

sed -i -E 's,} while \(/\* ?CONSTCOND ?\*/ ?0\),} while (0),' */*.[ch]

ndp: Show U for Unreachable

ndp: Sync usage and SYNPOSIS with reality

Remove in-kernel handling of Router Advertisements

This is much better handled by a user-land tool.
Proposed on tech-net here:
https://mail-index.netbsd.org/tech-net/2020/04/22/msg007766.html

Note that the ioctl SIOCGIFINFO_IN6 no longer sets flags. That now
needs to be done using the pre-existing SIOCSIFINFO_FLAGS ioctl.

Compat is fully provided where it makes sense, but trying to turn on
RA handling will obviously throw an error as it no longer exists.

Note that if you use IPv6 temporary addresses, this now needs to be
turned on in dhcpcd.conf(5) rather than in sysctl.conf(5).

ndp: SIOCSPFXFLUSH_IN6 and SIOCSRTRFLUSH_IN6 expect struct in6_ifreq

And not just a character string of the interface name.
This only worked before because the interface name is the first member
of the structure.

Use s6, not mysin.

ndp(8): host_buf should not be used in delete().

host_buf is passed to the argument host of delete() in do_foreach().

Remove duplicate rtrlist() function prototype.

branches: 1.51.2;
PR/53371: Thomas Barabosch: Potential memory leak in usr.sbin/ndp/ndp.c

branches: 1.50.4;
Enable to remove multiple ARP/NDP entries for one destination

The kernel can have multiple ARP/NDP entries which have an indentical
destination on different interfaces. This is normal and can be
reproduce easily by ping -I or ping6 -S. We should be able to remove
such entries.

arp -d <ip> and ndp -d <ip> are changed to fetch all ARP/NDP entries
and remove matched entries. So we can remove multiple entries
described above. This fetch all and selective removal behavior is
the same as arp <ip> and ndp <ip>; they also do fetch all entries
and show only matched entries.

Related to PR 51179

Fix usage of routing messages on arp -d and ndp -d

It didn't work as we expected; we should set RTA_GATEWAY not
RTA_IFP on RTM_GET to return an if_index and the kernel should
use it on RTM_DELETE.

branches: 1.48.6;
remove unused ancient code and widen v6 address so that columns are aligned.

branches: 1.47.2;
Separate nexthop caches from the routing table

By this change, nexthop caches (IP-MAC address pair) are not stored
in the routing table anymore. Instead nexthop caches are stored in
each network interface; we already have lltable/llentry data structure
for this purpose. This change also obsoletes the concept of cloning/cloned
routes. Cloned routes no longer exist while cloning routes still exist
with renamed to connected routes.

Noticeable changes are:
- Nexthop caches aren't listed in route show/netstat -r
- sysctl(NET_RT_DUMP) doesn't return them
- If RTF_LLDATA is specified, it returns nexthop caches
- Several definitions of routing flags and messages are removed
- RTF_CLONING, RTF_XRESOLVE, RTF_LLINFO, RTF_CLONED and RTM_RESOLVE
- RTF_CONNECTED is added
- It has the same value of RTF_CLONING for backward compatibility
- route's -xresolve, -[no]cloned and -llinfo options are removed
- -[no]cloning remains because it seems there are users
- -[no]connected is introduced and recommended
to be used instead of -[no]cloning
- route show/netstat -r drops some flags
- 'L' and 'c' are not seen anymore
- 'C' now indicates a connected route
- Gateway value of a route of an interface address is now not
a L2 address but "link#N" like a connected (cloning) route
- Proxy ARP: "arp -s ... pub" doesn't create a route

You can know details of behavior changes by seeing diffs under tests/.

Proposed on tech-net and tech-kern:
http://mail-index.netbsd.org/tech-net/2016/03/11/msg005701.html

Don't forget to set sin_scope. From Ryota Ozaki

Introduce rump.ndp

ndp(8) uses RTM that requires that getpid(2) works correctly. Unfortunately
supporting getpid(2) in librumphijack will be tricky so that we rump-ify
ndp(8) as well as arp(8).

improve error messages (remove \n, use __func__, etc)

branches: 1.43.2; 1.43.4;
Add IPV6CTL_AUTO_LINKLOCAL and ND6_IFF_AUTO_LINKLOCAL toggles which
control the automatic creation of IPv6 link-local addresses when an
interface is brought up.

Taken from FreeBSD.

branches: 1.42.2;
Simplify code to print the router/prefix list: use memcpy and local structs
properly aligned on the stack to decode the binary format passed by the
kernel - instead of (bogusly) assuming the format will obey all local
alignement requirements.

use new scopeid functions

branches: 1.40.2; 1.40.4; 1.40.8; 1.40.10; 1.40.16;
Use __dead

make this work again after routing socket alignment changes

branches: 1.38.4;
Teach ndp(8) about override_rtadv.

branches: 1.37.18; 1.37.26; 1.37.30;
* Don't include headers twice
* Remove a few trailing whitespaces
* Rearrange and join to one #if for some headers

Patch contributed by Slava Semushin <slava.semushin@gmail.com>
in private mail.

c99 initializer

Cleanup KNF, WARNS=4.
Phew, this started just to make set() static so that coverity does not get
confused.

NDP-related improvements:
RFC4191
- supports host-side router-preference

RFC3542
- if DAD fails on a interface, disables IPv6 operation on the
interface
- don't advertise MLD report before DAD finishes

Others
- fixes integer overflow for valid and preferred lifetimes
- improves timer granularity for MLD, using callout-timer.
- reflects rtadvd's IPv6 host variable information into kernel
(router only)
- adds a sysctl option to enable/disable pMTUd for multicast
packets
- performs NUD on PPP/GRE interface by default
- Redirect works regardless of ip6_accept_rtadv
- removes RFC1885-related code

From the KAME project via SUZUKI Shinsuke.
Reviewed by core.

Better support of IPv6 scoped addresses.

- most of the kernel code will not care about the actual encoding of
scope zone IDs and won't touch "s6_addr16[1]" directly.
- similarly, most of the kernel code will not care about link-local
scoped addresses as a special case.
- scope boundary check will be stricter. For example, the current
*BSD code allows a packet with src=::1 and dst=(some global IPv6
address) to be sent outside of the node, if the application do:
s = socket(AF_INET6);
bind(s, "::1");
sendto(s, some_global_IPv6_addr);
This is clearly wrong, since ::1 is only meaningful within a single
node, but the current implementation of the *BSD kernel cannot
reject this attempt.
- and, while there, don't try to remove the ff02::/32 interface route
entry in in6_ifdetach() as it's already gone.

This also includes some level of support for the standard source
address selection algorithm defined in RFC3484, which will be
completed on in the future.

From the KAME project via JINMEI Tatuya.
Approved by core@.

close(2) missing. Andrey Matveev

fflush(stdout) on -A. KAME-PR-584

typo (struct member name - has to be rtm_addrs). from fujitsu

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

err() cleanup, from openbsd-current via kame

sscanf overrun

with -i, flag on command line and flag displayed are different, and it does
nothing but confuse users. sync them.

for -nud and such, you need "-- -nud" due to posix arg parsing.

sync w/kame

recover backward compatibility in -I behavior. sync w/kame

more KNF/nroff. from deraadt via kame

typo

more posix-compliant arg parsing. sync with kame. help from deraadt

KNF, from openbsd via kame

more strlcpy. from openbsd via kame

use new SIOCGIFINFO_IN6. random other cleanups.

use strncpy() to set ifname arg to ioctl.

Use getnameinfo() to format link-layer addresses rather than doing it
ourselves.

sync with latest kame code. ndp -i won't print info for yet-to-be-initialized
interface.

getopt(3): EOF -> -1.

avoid dereferencing null pointer. from kame.

sync with latest kame tree. ndp -n -a is prettier with longer addresses.
-l is obsolete (igored).

avoid memory leak. sync with kame

nuke link-locals correctly on -c. sync with kame

More #include <stdlib.h> string, etc. cleanup

sync with more recent kame code.
accept scoped address notation.

branches: 1.8.4;
perform neighbor unreachability detection on p2p links (spec requires
it for bidir p2p links).
improve -i in ndp(8) to allow tweaking per-interface ND flag on.
fix ndp(8) infinite loop on certain routing table setup.

Don't declare 'extern opt*' getopt variables.
Don't declare 'extern int h_errno;' - it's in <netdb.h>.

remove net.inet6.ip6.nd6_proxyall sysctl.
support "ndp -s <ip6> <mac> proxy" for proxy NDP.

Remove bogus declaration of "errno".

add -I and -l. cleanup on screen formatting.
(sync with latest KAME)

branches: 1.3.4;
fix routing socket alignment issue on alpha.
sync with more recent KAME code.

PR: 8305

add NetBSD RCS ID.

ndp, "arp"-alike command for IPv6.

Introduce rump.ndp

ndp(8) uses RTM that requires that getpid(2) works correctly. Unfortunately
supporting getpid(2) in librumphijack will be tricky so that we rump-ify
ndp(8) as well as arp(8).

Introduce rump.ndp

ndp(8) uses RTM that requires that getpid(2) works correctly. Unfortunately
supporting getpid(2) in librumphijack will be tricky so that we rump-ify
ndp(8) as well as arp(8).

Introduce rump.ndp

ndp(8) uses RTM that requires that getpid(2) works correctly. Unfortunately
supporting getpid(2) in librumphijack will be tricky so that we rump-ify
ndp(8) as well as arp(8).