bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

introduce some common variables for use in GCC warning disables:

GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints. many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."

branches: 1.14.32;
Remove many HAVE_GCC || HAVE_PCC conditionals as the options also apply
to Clang. Add a few cases of HAVE_LLVM for -fno-strict-aliasing.

branches: 1.13.2;
remove most of the remaining HAVE_GCC tests that are always true in
the modern world.

branches: 1.12.18;
Wrap compiler-specific flags with HAVE_GCC and HAVE_PCC as necessary. Add a few flags for PCC.

branches: 1.11.12;
Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on the
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to
various string and memory copy and set functions (as well as a few system
calls and other miscellany) where known at function entry. RedHat has
evidently built all "core system packages" with this option for some time.

This option should be used at the top of Makefiles (or Makefile.inc where
this is used for subdirectories) but after any setting of LIB.

This is only useful for userland code, and cannot be used in libc or in
any code which includes the libc internals, because it overrides certain
libc functions with macros. Some effort has been made to make USE_FORT=yes
work correctly for a full-system build by having the bsd.sys.mk logic
disable the feature where it should not be used (libc, libssp iteself,
the kernel) but no attempt has been made to build the entire system with
USE_FORT and doing so will doubtless expose numerous bugs and misfeatures.

Adjust the system build so that all programs and libraries that are setuid,
directly handle network data (including serial comm data), perform
authentication, or appear likely to have (or have a history of having)
data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default,
with the exception of libc, which cannot use USE_FORT and thus uses
only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no
per-directory or in a system build will disable if desired.

sprinkle some -fno-strict-aliasing and -Wno-pointer-sign with GCC4.

use getifaddrs to avoid alignment constraints in SIOCGIFCONF.
(do you have PR # for this? >lukem)

Use pidfile(3).

If we answer a RARP request, also add the mapping to the local arp cache.
[This was broken when the 4.4BSD ARP table changes were done, and never
repaired.]
Inspired by Jarle Greipsland, PR 4531; code stolen from arp.a and cleaned
up (mostly removing global variables).
XXX As pointed out in the PR, this should be in some library (libutil?),
to be usable by other servers like bootpd and dhcpd.

use CPPFLAGS instead of CFLAGS

branches: 1.5.2;
remove unnecessary CFLAGS+=-I${.CURDIR} and SRCS=rarpd.c

New-style RCS id.

Make the "/tftpboot/<client-ip-address>" requirement conditional on
-DREQUIRE_TFTPBOOT and disable it by default.

specify man pages the new way.

original from LBL (part of the tcpdump distrib)
SIOCGIFCONF fixup by Roland McGrath <roland@frob.com>

Use RO_MSGFILTER.

branches: 1.11.2; 1.11.4;
Separate nexthop caches from the routing table

By this change, nexthop caches (IP-MAC address pair) are not stored
in the routing table anymore. Instead nexthop caches are stored in
each network interface; we already have lltable/llentry data structure
for this purpose. This change also obsoletes the concept of cloning/cloned
routes. Cloned routes no longer exist while cloning routes still exist
with renamed to connected routes.

Noticeable changes are:
- Nexthop caches aren't listed in route show/netstat -r
- sysctl(NET_RT_DUMP) doesn't return them
- If RTF_LLDATA is specified, it returns nexthop caches
- Several definitions of routing flags and messages are removed
- RTF_CLONING, RTF_XRESOLVE, RTF_LLINFO, RTF_CLONED and RTM_RESOLVE
- RTF_CONNECTED is added
- It has the same value of RTF_CLONING for backward compatibility
- route's -xresolve, -[no]cloned and -llinfo options are removed
- -[no]cloning remains because it seems there are users
- -[no]connected is introduced and recommended
to be used instead of -[no]cloning
- route show/netstat -r drops some flags
- 'L' and 'c' are not seen anymore
- 'C' now indicates a connected route
- Gateway value of a route of an interface address is now not
a L2 address but "link#N" like a connected (cloning) route
- Proxy ARP: "arp -s ... pub" doesn't create a route

You can know details of behavior changes by seeing diffs under tests/.

Proposed on tech-net and tech-kern:
http://mail-index.netbsd.org/tech-net/2016/03/11/msg005701.html

c99 initializers

static + __printflike + __dead

Fix WARNS=4 issues (-Wshadow -Wsign-compare -Wextra)

branches: 1.7.6;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

branches: 1.6.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22366, verified by myself.

Fix alignment for socket addresses in routing socket requests for
LP64 machines. Addresses port-alpha/11089. Reviewed by thorpej.

ANSIfy. Remove ifndef __STDC__. Remove __P(). Remove register.

We need to close and open the socket to prevent routing updates building
up such that when we send our message we never see our reply (and hang)
Fix taken (modified) from PR 7508

branches: 1.2.2;
PR/4835: Izumi Tsutsui: rarpd does not set the link level address length.
While there change "6" to "ETHER_ADDR_LEN"

branches: 1.1.2;
If we answer a RARP request, also add the mapping to the local arp cache.
[This was broken when the 4.4BSD ARP table changes were done, and never
repaired.]
Inspired by Jarle Greipsland, PR 4531; code stolen from arp.a and cleaned
up (mostly removing global variables).
XXX As pointed out in the PR, this should be in some library (libutil?),
to be usable by other servers like bootpd and dhcpd.

ANSIfy. Remove ifndef __STDC__. Remove __P(). Remove register.

branches: 1.1.2;
If we answer a RARP request, also add the mapping to the local arp cache.
[This was broken when the 4.4BSD ARP table changes were done, and never
repaired.]
Inspired by Jarle Greipsland, PR 4531; code stolen from arp.a and cleaned
up (mostly removing global variables).
XXX As pointed out in the PR, this should be in some library (libutil?),
to be usable by other servers like bootpd and dhcpd.

Use pidfile(3).

branches: 1.1.2;
support /var/run/rarpd.pid

Add xref for ethers(5) and hosts(5).
Remove extra white space in the middle of a sentence.
Use more markup for AUTHORS section.

ok wiz@

branches: 1.13.28;
Fix preamble

branches: 1.12.6;
UBC license does not require an advertizing clause any more - this files
where probably missed in the initial sweep due to strange formatting
(last clause not explicitly numbered).

FreeBSD converted them (rev. 1.21 pf rarpd.8 and rev 1.41 of rarpd.c
in their repository), nearly four years ago.

branches: 1.11.32;
Fix date typo, Oct 27 -> 17.

While it would be nice to be able to add features ahead of time,
it is not possible yet :)

Allow more than one interface to be specified on the command line.

branches: 1.9.2;
Drop a comma.

Whitespace nits.

add a -l (logging) switch.

branches: 1.6.2;
WARNSify

* use MAXHOSTNAMELEN+1 instead of 256
* don't use LOG_CONS - it's unnecessary and spams the console if syslogd
fails (a bad thing, really)

From [misc/873] by Giles Lean <giles@nemeton.com.au>:
* explain why the name lookup failed
* always send debug() via syslog(3) (unlike the PR, which added a -s flag)
* enhance the man page a bit (even in the commented out section which
is only relevant to the -DREQUIRE_TFTPBOOT case

New-style RCS id.

Make the "/tftpboot/<client-ip-address>" requirement conditional on
-DREQUIRE_TFTPBOOT and disable it by default.

Fix spelling errors

original from LBL (part of the tcpdump distrib)
SIOCGIFCONF fixup by Roland McGrath <roland@frob.com>

fix various typos in documentation, comments and sysctl device description.
mainly aion -> ation and inlude -> include.

Adapt to ar_tha() changes in if_arp.h rev1.31.

static + __printflike + __dead

Fix WARNS=4 issues (-Wshadow -Wsign-compare -Wextra)

branches: 1.57.6;
Remove the \n and tabs from the __COPYRIGHT() strings.
Tweak to use a consistent format.

UBC license does not require an advertizing clause any more - this files
where probably missed in the initial sweep due to strange formatting
(last clause not explicitly numbered).

FreeBSD converted them (rev. 1.21 pf rarpd.8 and rev 1.41 of rarpd.c
in their repository), nearly four years ago.

branches: 1.55.20;
since ar_tha() can return NULL, don't pass it directly to functions
that expect real addresses. explicitly KASSERT() that it is not
NULL in the kernel and just avoid using it userland.

(the kernel could be more defensive about this, but, until now it
would have just crashed anyway.)

remove backwards compatibility with non-cloning bpf.

Use /dev/bpf, if _PATH_BPF is defined.

Replaced strncpy with strlcpy. Thanks to Peter Postma who
pointed them our in PR #25762. Approved by christos@NetBSD.org.

Fix handling of interface aliases if "rarpd" is not invoked with "-a".

With recent changes to BPF, pushing the default buffer size to 1MB, running
a bunch of small daemons that seem small packet flows can easily chew up
significant kernel memory (each BPF device opened takes 2*buffersize of
wired memory.) In each of these applications, add code to set the buffer
size to 32k before setting the interface.

branches: 1.49.2;
use bounded string op

assume presense of getifaddrs(3).

tweak usage now that multiple interfaces are supported...

Allow more than one interface to be specified on the command line.

ANSIfy. Remove ifndef __STDC__. Remove __P(). Remove register.

branches: 1.44.2;
daemon(3) has to be called prior to file descriptor initialization.

va_{start,end} audit:
Make sure that each va_start has one and only one matching va_end,
especially in error cases.
If the va_list is used multiple times, do multiple va_starts/va_ends.
If a function gets va_list as argument, don't let it use va_end (since
it's the callers responsibility).

Improved by comments from enami and christos -- thanks!

Heimdal/krb4/KAME changes already fed back, rest to follow.

Inspired by, but not not based on, OpenBSD.

Kill no longer used variable decl.

use explicit name rather than __progname in openlog

With RARP, MAC asks, and IP answers. Fixes PR 11330 by Thilo Manske, who
also provided the fix (modulo formatting).

More format string cleanups by sommerfeld.

Include the fact we're making replies in the debug() output.

branches: 1.37.4;
use getifaddrs to avoid alignment constraints in SIOCGIFCONF.
(do you have PR # for this? >lukem)

Indicate on which interface a packet has been received when debugging

Copy struct ifreq returned by SIOGIFCONF to ensure correct alignment.

Need <sys/param.h> for MAXHOSTNAMELEN.

branches: 1.33.2;
Use pidfile(3).

branches: 1.32.2;
Fix a logic error which would have caused a NULL pointer dereference
if the client's IP address wasn't found on the interface's network.

In userland, pull in <errno.h> instead of <sys/errno.h> for the declaration
of errno.

Shut up gcc.

Teach rarpd about interface aliases.

use daemon(). remove spurious \n from rarperr() call

usage & comment string patch, per PR#5859

KNF. be safe with buffers. use setsid().

support /var/run/rarpd.pid

add a -l (logging) switch.

These changes from PR#3190 (second set of diffs) deal with rarpd
refusing to work in "-a" mode on a host with more than one Ethernet,
and at least one non-ethernet device. Frankly, the interface
initialization loop is badly structured and should be rewritten,
and these changes do nothing to fix that. However, they oughta do
the requested job, quick & dirty.

If we answer a RARP request, also add the mapping to the local arp cache.
[This was broken when the 4.4BSD ARP table changes were done, and never
repaired.]
Inspired by Jarle Greipsland, PR 4531; code stolen from arp.a and cleaned
up (mostly removing global variables).
XXX As pointed out in the PR, this should be in some library (libutil?),
to be usable by other servers like bootpd and dhcpd.

branches: 1.21.2;
use memcmp/memset/memmove instead of bcmp/bzero/bcopy

getopt returns -1 not EOF

WARNSify

* use MAXHOSTNAMELEN+1 instead of 256
* don't use LOG_CONS - it's unnecessary and spams the console if syslogd
fails (a bad thing, really)

From [misc/873] by Giles Lean <giles@nemeton.com.au>:
* explain why the name lookup failed
* always send debug() via syslog(3) (unlike the PR, which added a -s flag)
* enhance the man page a bit (even in the commented out section which
is only relevant to the -DREQUIRE_TFTPBOOT case

fix some u_long vs. u_int32_t bogons in uses of nameserver lookup results.

New ARP system, supports IPv4 over any hardware link.

Some of the stuff (e.g., rarpd, bootpd, dhcpd etc., libsa) still will
only support Ethernet. Tcpdump itself should be ok, but libpcap needs
lot of work.

For the detailed change history, look at the commit log entries for
the is-newarp branch.

branches: 1.15.2;
back out previoius commit---wasn't intended for The Trunk

adapt to new ARP code. still needs work for non-Ethernet.

cast ether_ntohost() argument to proper type;
from Klaus Klein <kleink@layla.inka.de>

Be pedantic, main() returns int in C.

If __FreeBSD__, don't swap the type field in the Ethernet II header.

interface aliases don't count as individual interfaces and hence don't
need a seperate bpf. Someone should decide whether to tell netstat
about this.

New-style RCS id.

branches: 1.8.2;
Make the "/tftpboot/<client-ip-address>" requirement conditional on
-DREQUIRE_TFTPBOOT and disable it by default.

Look up the ether addresses of interfaces *correctly*, and just ditch
SIOCSARP altogether.

rename constants

kill bad casts

put ar_hrd in network byte order. from
Christos Zoulas <christos@deshaw.com>

bpf writes for ethernet take a network byte order ether_type

remove the faster replacement for inet_ntoa because the stupid thing
is byte order dependent.

original from LBL (part of the tcpdump distrib)
SIOCGIFCONF fixup by Roland McGrath <roland@frob.com>